- 29 Nov, 2023 3 commits
-
-
Michael Goderbauer authored
Towards https://github.com/flutter/flutter/issues/134501. This change is based on https://github.com/flutter/engine/pull/48090. It changes the `RenderView` to be dynamically sized based on its content if the `FlutterView` it is configured with allows it (i.e. the `FlutterView` has loose `FlutterView.physicalConstraints`). For that, it uses those `physicalConstraints` as input to the layout algorithm by passing them on to its child (after translating them to logical constraints via the device pixel ratio). The resulting `Size` that the `RenderView` would like to be is then communicated back to the engine by passing it to the `FlutterView.render` call. Tests will fail until https://github.com/flutter/engine/pull/48090 has rolled into the framework.
-
Kate Lovett authored
This updates the implementation to use the stopwatch from the Clock object and pipes it through to the TestWidgetsFlutterBinding so it will be kept in sync with FakeAsync. Relands https://github.com/flutter/flutter/pull/138843 attempted to reland https://github.com/flutter/flutter/pull/137381 which attempted to reland #132291 Fixes https://github.com/flutter/flutter/issues/97761 1. The original change was reverted due to flakiness it introduced in tests that use fling gestures. * Using a mocked clock through the test binding fixes this now 2. It was reverted a second time because a change at tip of tree broke it, exposing memory leaks, but it was not rebased before landing. * These leaks are now fixed 3. It was reverted a third time, because we were so excellently quick to revert those other times, that we did not notice the broken benchmark that only runs in postsubmit. * The benchmark is now fixed
-
Kate Lovett authored
-
- 27 Nov, 2023 2 commits
-
-
Michael Goderbauer authored
Towards https://github.com/flutter/flutter/issues/134501. Required to roll https://github.com/flutter/engine/pull/48090 into the framework. Two new subclasses of FlutterView were added recently for testing (in https://github.com/flutter/flutter/pull/138849) that I missed in my previous PR (https://github.com/flutter/flutter/pull/138565).
-
Michael Goderbauer authored
Towards https://github.com/flutter/flutter/issues/134501. Required to roll https://github.com/flutter/engine/pull/48090 into the framework. **DO NOT SUBMIT until https://github.com/flutter/flutter/pull/138648 and https://github.com/flutter/engine/pull/48090 are ready.**
-
- 22 Nov, 2023 2 commits
-
-
Yegor authored
`FakeView` wraps the same underlying `FlutterView`. Sending semantics updates and Scene objects from multiple fake views into the same engine `FlutterView` violates contracts with the engine. This PR stubs out `render` and `updateSemantics` methods in `FakeView` classes to prevent that. This unblocks https://github.com/flutter/engine/pull/48251, which implements multi-view semantics for web.
-
Jackson Gardner authored
Reverts flutter/flutter#138843 This has broken the Mac_ios microbenchmarks_ios. Example failure: https://ci.chromium.org/ui/p/flutter/builders/prod/Mac_ios%20microbenchmarks_ios/9339/overview
-
- 21 Nov, 2023 1 commit
-
-
Kate Lovett authored
This updates the implementation to use the stopwatch from the Clock object and piping it through to the TestWidgetsFlutterBinding so it will be kept in sync with FakeAsync. Relands https://github.com/flutter/flutter/pull/137381 which attempted to reland #132291 Fixes https://github.com/flutter/flutter/issues/97761 The original change was reverted due to flakiness it introduced in tests that use fling gestures. * https://github.com/flutter/flutter/issues/135728 It was reverted again due to a change in the leak tracking tests that broke it.
-
- 15 Nov, 2023 3 commits
-
-
Srujan Gaddam authored
This version is needed so that dart:js_interop can move to extension types. Also adds some code to handle some breaking changes: - Body -> Response. Body was an IDL interface mixin type we exposed in dart:html. Going forward, users should either use Request or Response. - Casts to JSAny. These are temporary until we move package:web types to extension types. Currently, package:web types can't implement JSObject as JSObject will move to be an extension type itself. Co-authored-by: Kevin Moore <kevmoo@users.noreply.github.com>
-
auto-submit[bot] authored
Reverts flutter/flutter#137381 Initiated by: Piinks This change reverts the following previous change: Original Description: This updates the implementation to use the stopwatch from the Clock object and piping it through to the TestWidgetsFlutterBinding so it will be kept in sync with FakeAsync. Relands #132291 Fixes https://github.com/flutter/flutter/issues/97761 The change was reverted due to flakiness it introduced in tests that use fling gestures. * https://github.com/flutter/flutter/issues/135728
-
Kate Lovett authored
This updates the implementation to use the stopwatch from the Clock object and piping it through to the TestWidgetsFlutterBinding so it will be kept in sync with FakeAsync. Relands #132291 Fixes https://github.com/flutter/flutter/issues/97761 The change was reverted due to flakiness it introduced in tests that use fling gestures. * https://github.com/flutter/flutter/issues/135728
-
- 13 Nov, 2023 1 commit
-
-
Polina Cherkasova authored
-
- 08 Nov, 2023 1 commit
-
-
Michael Goderbauer authored
Looks like this was proactively added in https://github.com/flutter/engine/pull/20496, but never wired up to anything on any platform. It is also unused in framework and customer code; we never exposed this on e.g. MediaQuery. Related engine PR: https://github.com/flutter/engine/pull/47825
-
- 03 Nov, 2023 1 commit
-
-
Polina Cherkasova authored
-
- 01 Nov, 2023 2 commits
-
-
Dan Field authored
Fixes https://github.com/flutter/flutter/issues/137696 This will get the tree green again. The problem is that `CustomSemanticsAction` has static state in it, and todays test seed order makes things unhappy.
-
Polina Cherkasova authored
-
- 31 Oct, 2023 2 commits
-
-
Hrishikesh Kadam authored
-
Polina Cherkasova authored
Analyzer's dependency on autosnapshotting causes issues. Because every version of integration_test from sdk depends on leak_tracker from hosted and autosnapshotting depends on leak_tracker from path, integration_test from sdk is forbidden. So, because autosnapshotting depends on integration_test from sdk, version solving failed.
-
- 25 Oct, 2023 1 commit
-
-
Polina Cherkasova authored
Contributes to: https://github.com/flutter/flutter/issues/135856 This PR also adds transitive dependency on web_socket_channel, crypto, typed_data. `web_socket_channel` is needed to request retaining path for not GCed objects from VM Service. Two others are needed to serve web_socket_channel. The dependency on leak_tracker is pinned: https://github.com/flutter/flutter/blob/aea562114c4d8c220c9079e82d89a7da4164409f/packages/flutter_tools/lib/src/commands/update_packages.dart#L40
-
- 24 Oct, 2023 1 commit
-
-
Tirth authored
Fix Small Typos.
-
- 23 Oct, 2023 1 commit
-
-
Polina Cherkasova authored
-
- 20 Oct, 2023 2 commits
-
-
Harry Terkelsen authored
Relands https://github.com/flutter/flutter/pull/135249 A golden test was failing in post submit in the previous PR
-
flutter-pub-roller-bot authored
This PR was generated by `flutter update-packages --force-upgrade`.
-
- 19 Oct, 2023 2 commits
-
-
Elliott Brooks authored
Generated by running `flutter update-packages --force-upgrade` Updates vm_service to [12.0.0](https://pub.dev/packages/vm_service/versions/12.0.0) and dwds to [22.0.0](https://pub.dev/packages/dwds/versions/22.0.0) The changes to `packages/flutter_tools/lib/src/isolated/devfs_web.dart` are for the new interface of DWDS introduced in https://github.com/dart-lang/webdev/pull/2243 FYI @bkonyi
-
auto-submit[bot] authored
Reverts flutter/flutter#135249 Initiated by: zanderso This change reverts the following previous change: Original Description: Changes golden tests on CanvasKit to use Layer.toImage instead of browser APIs for screenshots. This brings it more in line with other platforms and should also fix some async timing bugs with tests.
-
- 18 Oct, 2023 2 commits
-
-
Harry Terkelsen authored
Changes golden tests on CanvasKit to use Layer.toImage instead of browser APIs for screenshots. This brings it more in line with other platforms and should also fix some async timing bugs with tests. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [Features we expect every widget to implement]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat
-
pdblasi-google authored
* Added `performAction` to `SemanticsController` as well as specific methods for specific actions * Added a `scrollable` finder to `find.semantics` as a convenience method for `findAny(<all scrollable actions>)` * Updated `containsSemantics` and `matchSemantics` matchers to also work on `FinderBase<Semantics>` Closes #112413
-
- 17 Oct, 2023 1 commit
-
-
Kostia Sokolovskyi authored
-
- 12 Oct, 2023 2 commits
-
-
Michael Goderbauer authored
-
pdblasi-google authored
Updates references to `finders.dart` in `controller.dart` to use a namespace. This enables us to make use of `finders.dart#find` in `SemanticsController` without anything being shadowed. Fixes #136421
-
- 11 Oct, 2023 1 commit
-
-
Kevin Moore authored
* Allow latest pkg:material_color_utilities * Bump other dependencies to their latest - including pkg:web
-
- 29 Sep, 2023 1 commit
-
-
Polina Cherkasova authored
Fixes: https://github.com/flutter/flutter/issues/135716 leak_tracker is left pinned because future updates are going to be breaking.
-
- 25 Sep, 2023 1 commit
-
-
chunhtai authored
fixes https://github.com/flutter/flutter/issues/135144
-
- 22 Sep, 2023 1 commit
-
-
Kostia Sokolovskyi authored
-
- 20 Sep, 2023 4 commits
-
-
David Iglesias authored
This PR is the result of running: ```console $ flutter upgrade-packages --force-upgrade ``` ### Issues * Fixes https://github.com/flutter/flutter/issues/135075 * Supersedes #135081
-
Michael Goderbauer authored
Avoids that dynamic accidentally sneaks in, see https://dart.dev/tools/analysis#enabling-additional-type-checks
-
Greg Spencer authored
## Description This removes all of the comments that are of the form "so-and-so (must not be null|can ?not be null|must be non-null)" from the cases where those values are defines as non-nullable values. This PR removes them from the animation, cupertino, foundation, gestures, semantics, and services libraries. Each of them only had a few, so I lumped them together. This was done by hand, since it really didn't lend itself to scripting, so it needs to be more than just spot-checked, I think. I was careful to leave any comment that referred to parameters that were nullable, but I may have missed some. In addition to being no longer relevant after null safety has been made the default, these comments were largely fragile, in that it was easy for them to get out of date, and not be accurate anymore anyhow. This did create a number of constructor comments which basically say "Creates a [Foo].", but I don't really know how to avoid that in a large scale change, since there's not much you can really say in a lot of cases. I think we might consider some leniency for constructors to the "Comment must be meaningful" style guidance (which we de facto have already, since there are a bunch of these). ## Related PRs - https://github.com/flutter/flutter/pull/134991 - https://github.com/flutter/flutter/pull/134992 - https://github.com/flutter/flutter/pull/134993 - https://github.com/flutter/flutter/pull/134994 ## Tests - Documentation only change.
-
Gray Mackall authored
More up to date version of https://github.com/flutter/flutter/pull/133786. Fixes https://github.com/flutter/flutter/issues/111304
-
- 19 Sep, 2023 1 commit
-
-
Greg Spencer authored
## Description This removes all of the comments that are of the form "so-and-so must not be null" or "so-and-so must be non-null" from the cases where those values are defines as non-nullable values. This PR removes them from the library in the repo that don't have anything to do with the framework. This was done by hand, since it really didn't lend itself to scripting, so it needs to be more than just spot-checked, I think. I was careful to leave any comment that referred to parameters that were nullable, but I may have missed some. In addition to being no longer relevant after null safety has been made the default, these comments were largely fragile, in that it was easy for them to get out of date, and not be accurate anymore anyhow. This did create a number of constructor comments which basically say "Creates a [Foo].", but I don't really know how to avoid that in a large scale change, since there's not much you can really say in a lot of cases. I think we might consider some leniency for constructors to the "Comment must be meaningful" style guidance (which we de facto have already, since there are a bunch of these). ## Related PRs - https://github.com/flutter/flutter/pull/134984 - https://github.com/flutter/flutter/pull/134991 - https://github.com/flutter/flutter/pull/134992 - https://github.com/flutter/flutter/pull/134993 ## Tests - Documentation only change.
-
- 16 Sep, 2023 1 commit
-
-
Polina Cherkasova authored
Contributes to https://github.com/flutter/flutter/issues/134575
-