- 30 Jun, 2023 1 commit
-
-
gmackall authored
Upgrades tests under `dev/integration_tests` to use the latest values [in the templates](https://github.com/flutter/flutter/blob/944d6c8fef76b2db7a2c33eeb1653de2b8571fd8/dev/tools/bin/generate_gradle_lockfiles.dart#L135). Most of this PR was auto-generated, by running `find dev/integration_tests/ -type d -name 'android' | dart dev/tools/bin/generate_gradle_lockfiles.dart` from the root of the flutter directory. The pieces that were not are: 1. Upgrading the Gradle versions used in integration tests to be >=7.4, in places where it was currently lower. 2. Upgrading the mac, windows, and linux build_tests .ci.yaml configuration to use jdk 17 on all shards. It currently was using a mix of 17 and 11. This isn't desirable, because some of the tests require 17, and the distribution is [random across shards](https://github.com/flutter/flutter/blob/cef9a8c54b766fa5f66e6fbdf7df341176f8e29f/dev/bots/test.dart#L553) (so they were only passing because they were getting randomly placed on shards using jdk 17). 3. Adding a dependency on jdk 11 for the tests based on the `firebaselab/firebaselab` recipe. Previously they had no java dependency, and were therefore defaulting to java 1.8. The newer AGP versions necessitated an upgrade to 11 to run. Note that it also ended up downgrading the AGP version in two places (in the [hybrid_android_views](https://github.com/flutter/flutter/pull/129642/files#diff-d7cfaa1c96d5c2383e7fc253ac8c9df062b544c24f7d80aa8a02290c01d17205L17) and [platform_interaction](https://github.com/flutter/flutter/pull/129642/files#diff-b2fba811efadd1cfb097bebd93be99fe4b6d6f17aefa863267290fc704290766L17) tests), because those had been manually edited to a newer version than the template. Related to: https://github.com/flutter/flutter/issues/123636, https://github.com/flutter/flutter/pull/123910
-
- 12 Apr, 2023 1 commit
-
-
Zachary Anderson authored
Reverts flutter/flutter#122437 This is causing several Android devicelab tests to fail on the first attempt, causing them to be marked flaky. The cause appears to be unexpected output on stderr. See: https://ci.chromium.org/ui/p/flutter/builders/prod/Mac_arm64_android%20run_release_test/5390/overview
-
- 11 Apr, 2023 1 commit
-
-
Micael Cid authored
[integration_test] upgrade androidx test to 1.4.0
-
- 05 Apr, 2023 1 commit
-
-
Reid Baker authored
https://github.com/flutter/flutter/issues/123917 Doc covering a broad set of issues related to android studio updating. https://docs.google.com/document/d/1hTXkjbUrBnXgu8NQsth1c3aEqo77rWoEj8CcsQ39wwQ/edit?pli=1# Specifically this pr: - Adds new functions to find a projects AGP, Gradle and java versions, and tests. - Adds new functions that take versions and parse if the versions are compatible with each other, and tests. - Adds validator for `flutter analyze --suggestions` that evaluates the java/gradle/agp versions and checks if they are compatible, and integration test. - Updates the version of gradle used by dev/integration_tests/flutter_gallery/ to the minimum supported by java 18 so that the integration tests pass (It is unknown why the java version is 18.9 instead of 11) - Moves `isWithinVersionRange` to version.dart, and tests. - Adds FakeAndroidStudio to fakes to be used in multiple tests but does not remove existing copies. Metrics will be included as part of the definition of done for this bug but not as part of this cl. It is already too big. Known work still left in this pr: * Understand why analyze integration tests are failing. Example output if Java and gradle are not compatible: ``` ┌───────────────────────────────────────────────────────────────────┐ │ General Info │ │ [✓] App Name: espresso_example │ │ [✓] Supported Platforms: android │ │ [✓] Is Flutter Package: yes │ │ [✓] Uses Material Design: yes │ │ [✓] Is Plugin: no │ │ [✗] Java/Gradle/Android Gradle Plugin: │ │ │ │ Incompatible Java/Gradle versions. │ │ │ │ Java Version: 17.0.6, Gradle Version: 7.0.2 │ │ │ │ See the link below for more information. │ │ https://docs.gradle.org/current/userguide/compatibility.html#java │ │ │ └───────────────────────────────────────────────────────────────────┘ ``` Example output if Gradle and AGP are not compatible ``` ┌─────────────────────────────────────────────────────────────────────────────┐ │ General Info │ │ [✓] App Name: espresso_example │ │ [✓] Supported Platforms: android │ │ [✓] Is Flutter Package: yes │ │ [✓] Uses Material Design: yes │ │ [✓] Is Plugin: no │ │ [✗] Java/Gradle/Android Gradle Plugin: Incompatible Gradle/AGP versions. │ │ │ │ Gradle Version: 7.0.2, AGP Version: 7.4.2 │ │ │ │ Update gradle to at least "7.5". │ │ See the link below for more information: │ │ https://developer.android.com/studio/releases/gradle-plugin#updating-gradle │ │ │ │ Incompatible Java/Gradle versions. │ │ │ │ Java Version: 17.0.6, Gradle Version: 7.0.2 │ │ │ │ See the link below for more information: │ │ https://docs.gradle.org/current/userguide/compatibility.html#java │ │ │ └─────────────────────────────────────────────────────────────────────────────┘ ``` Example output if Java/Gradle/Agp are not compatible. ``` ┌─────────────────────────────────────────────────────────────────────────────┐ │ General Info │ │ [✓] App Name: espresso_example │ │ [✓] Supported Platforms: android │ │ [✓] Is Flutter Package: yes │ │ [✓] Uses Material Design: yes │ │ [✓] Is Plugin: no │ │ [✗] Java/Gradle/Android Gradle Plugin: Incompatible Gradle/AGP versions. │ │ │ │ Gradle Version: 7.0.2, AGP Version: 7.4.2 │ │ │ │ Update gradle to at least "7.5". │ │ See the link below for more information: │ │ https://developer.android.com/studio/releases/gradle-plugin#updating-gradle │ │ │ │ Incompatible Java/Gradle versions. │ │ │ │ Java Version: 17.0.6, Gradle Version: 7.0.2 │ │ │ │ See the link below for more information: │ │ https://docs.gradle.org/current/userguide/compatibility.html#java │ │ │ └─────────────────────────────────────────────────────────────────────────────┘ ``` Commit messages - Add function to gradle_utils.dart that gets the gradle version from wrapper or system and add a test for each situation - Add method to get agp version, add method to validate agp against gradle version, update documentation, add tests for agp validation. - Update dart doc for validateGradleAndAgp to describe where the info came from and corner case behavior, create function to validate java and gradle and hardcode return to false - Fill out and test java gradle compatibility function in gradle_utils - Hook up java gradle evaluateion to hasValidJavaGradleAgpVersions with hardcoded java version - Add java --version output parsing and tests - Add getJavaBinary test - Update comment in android_sdk for mac behavior with java_home -v ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] All existing and new tests are passing.
-
- 29 Mar, 2023 1 commit
-
-
Bartek Pacia authored
Fix warning in `flutter create`d project ("package attribute is deprecated" in AndroidManifest) (#123426) Fix warning in `flutter create`d project ("package attribute is deprecated" in AndroidManifest)
-
- 21 Mar, 2023 1 commit
-
-
Bartek Pacia authored
Fix Gradle warning in a freshly `flutter create`ed Android project
-
- 07 Mar, 2023 2 commits
-
-
Zachary Anderson authored
Revert "[integration_test] upgrade androidx test to 1.4.0"
-
Micael Cid authored
[integration_test] upgrade androidx test to 1.4.0
-
- 05 Dec, 2022 1 commit
-
-
Gary Qian authored
-
- 26 Jul, 2022 1 commit
-
-
Zachary Anderson authored
This reverts commit ca6cecf0.
-
- 25 Jul, 2022 1 commit
-
-
Gary Qian authored
-
- 13 Jun, 2022 1 commit
-
-
Ahmed Ashour authored
-
- 13 Jan, 2022 1 commit
-
-
Emmanuel Garcia authored
* Bump video_player in flutter gallery * Update packages * Update dependencies * Bump device_info * Update dev/devicelab/bin/tasks/build_ios_framework_module_test.dart Co-authored-by:
Jenn Magder <magder@google.com> * Update dev/devicelab/bin/tasks/module_custom_host_app_name_test.dart Co-authored-by:
Jenn Magder <magder@google.com> * Update dev/devicelab/bin/tasks/module_test.dart Co-authored-by:
Jenn Magder <magder@google.com> * Remove deprecated device_info from ios-frameworks test Co-authored-by:
Jenn Magder <magder@google.com>
-
- 20 Nov, 2021 1 commit
-
-
Andrei Diaconu authored
-
- 07 Nov, 2021 2 commits
-
-
Jason Simmons authored
-
Zachary Anderson authored
This reverts commit 9038fac9.
-
- 05 Nov, 2021 3 commits
-
-
Andrei Diaconu authored
-
Zachary Anderson authored
This reverts commit 058dfd49.
-
Andrei Diaconu authored
-
- 01 Nov, 2021 1 commit
-
-
Emmanuel Garcia authored
-
- 25 Oct, 2021 1 commit
-
-
Emmanuel Garcia authored
-
- 15 Oct, 2021 1 commit
-
-
Emmanuel Garcia authored
-
- 08 Oct, 2021 1 commit
-
-
Zachary Anderson authored
* Revert "Mark last failing test after gradle update as flaky. (#91423)" This reverts commit 46a52d03. * Revert "fix android template for Gradle 7 (#91411)" This reverts commit 51d06d53. * Revert "Add explicit version for mac and windows openjdk. (#91408)" This reverts commit bf429f27. * Revert "Update the openjdk version used by linux android tests. (#91405)" This reverts commit 2144ab8b. * Revert "Migrate to Gradle 7.0.2 / AGP 7.0.1 (#90642)" This reverts commit b6459f9b.
-
- 07 Oct, 2021 1 commit
-
-
Taha Tesser authored
-
- 02 Oct, 2021 1 commit
-
-
Littlegnal authored
-
- 01 Jun, 2021 1 commit
-
-
Emmanuel Garcia authored
-
- 21 May, 2021 1 commit
-
-
Emmanuel Garcia authored
-
- 22 Apr, 2021 1 commit
-
-
Jonah Williams authored
-
- 20 Apr, 2021 1 commit
-
-
Emmanuel Garcia authored
-
- 23 Mar, 2021 1 commit
-
-
Jenn Magder authored
-
- 13 Mar, 2021 1 commit
-
-
Ahmed Saleh authored
-
- 11 Mar, 2021 1 commit
-
-
Abhishek Ghaskata authored
-
- 02 Dec, 2020 1 commit
-
-
Emmanuel Garcia authored
-
- 23 Nov, 2020 1 commit
-
-
Amir Hardon authored
This reverts commit 8e73bab9.
-
- 20 Nov, 2020 1 commit
-
-
Emmanuel Garcia authored
-
- 06 Oct, 2020 1 commit
-
-
keyonghan authored
-
- 12 Aug, 2020 1 commit
-
-
Ming Lyu (CareF) authored
-
- 11 Aug, 2020 1 commit
-
-
xster authored
-
- 04 Aug, 2020 2 commits
-
-
Jonah Williams authored
This reverts commit 5b3dc525.
-
xster authored
-