Commits · d113ee4c45a8a5d145688bebda2d09414ab70cb6 · abdullh.alsoleman / Front-End

15 Mar, 2024 9 commits

Roll Flutter Engine from 1e199ce6239d to 76f33eb0eced (3 revisions) (#145221) · d113ee4c

engine-flutter-autoroll authored Mar 15, 2024

https://github.com/flutter/engine/compare/1e199ce6239d...76f33eb0eced

2024-03-15 skia-flutter-autoroll@skia.org Roll Skia from 52bb1539c5cf to 54ecc23acf31 (11 revisions) (flutter/engine#51438)
2024-03-15 matanlurey@users.noreply.github.com Add `android_debug_unopt_arm64` to `local_engine.json`. (flutter/engine#51427)
2024-03-15 matanlurey@users.noreply.github.com Remove the Android-drawn surface rendering from scenario_app. (flutter/engine#51433)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

d113ee4c

Run gradle_plugin_*_apk_test on presubmit on flutter_tool changes. (#142090) · a97af209

Jackson Gardner authored Mar 15, 2024

These tests were failing in postsubmit after a change to `packages/flutter_tools`. We should run these in presubmit when `packages/flutter_tools` changes.

a97af209

Update a11y for SliverAppBar (#144437) · 58eb0e8a

hangyu authored Mar 15, 2024

1. Set cacheExtent for sliverAppBar so it's not dropped from the
semantics tree.
2. Update its toolbarOpacity in a11y mode to 1.0. When scrolling in a11y
mode and the focus is back to the sliverAppBar, the content should be
visible.
fixes: https://github.com/flutter/flutter/issues/143437


## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
[Data Driven Fixes]:
https://github.com/flutter/flutter/wiki/Data-driven-Fixes

58eb0e8a

Roll Packages from b21c5424783a to 756dcc11180b (6 revisions) (#145214) · eeff96d4

engine-flutter-autoroll authored Mar 15, 2024

https://github.com/flutter/packages/compare/b21c5424783a...756dcc11180b

2024-03-15 32538273+ValentinVignal@users.noreply.github.com [go_router] Use `leak_tracker_flutter_testing` (flutter/packages#6210)
2024-03-15 10687576+bparrishMines@users.noreply.github.com [camera_web][google_maps_flutter] Fix tests throwing errors after test completion with manual roll (flutter/packages#6318)
2024-03-14 10687576+bparrishMines@users.noreply.github.com [pigeon] Fixes double prefixes added to enum names for Objc HostApis and FlutterApis (flutter/packages#6263)
2024-03-14 10687576+bparrishMines@users.noreply.github.com [webview_flutter_android][webview_flutter_wkwebview] Adds platform implementations for onHttpError (flutter/packages#6149)
2024-03-14 34871572+gmackall@users.noreply.github.com [image_picker_android] Fix deprecation warnings by branching based on build version, and suppressing only when needed (flutter/packages#6233)
2024-03-14 30870216+gaaclarke@users.noreply.github.com [google_maps_flutter] Started dispatching platform messages from platform thread (flutter/packages#6069)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

eeff96d4

Roll pub packages manually (#145170) · 8d54abfc

Loïc Sharma authored Mar 15, 2024

The automated roll failed as a test needs to be updated: https://github.com/flutter/flutter/pull/145167

Fixes: https://github.com/flutter/flutter/issues/139861

8d54abfc

Roll Flutter Engine from 995d8903e074 to 1e199ce6239d (1 revision) (#145196) · 985576db

engine-flutter-autoroll authored Mar 15, 2024

https://github.com/flutter/engine/compare/995d8903e074...1e199ce6239d

2024-03-15 68449066+zijiehe-google-com@users.noreply.github.com [Fuchsia] Remove the use of //build/ in fuchsia (flutter/engine#51072)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

985576db

Roll Flutter Engine from 622b37282f20 to 995d8903e074 (8 revisions) (#145191) · 9b276be7

engine-flutter-autoroll authored Mar 15, 2024

https://github.com/flutter/engine/compare/622b37282f20...995d8903e074

2024-03-14 matanlurey@users.noreply.github.com Add some header-goodies for et. (flutter/engine#51434)
2024-03-14 jonahwilliams@google.com [Impeller] revert glyph atlas texture recycling. (flutter/engine#51428)
2024-03-14 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Add DisplayList Region and Transform benchmarks to CI (#51429)" (flutter/engine#51432)
2024-03-14 flar@google.com Add DisplayList Region and Transform benchmarks to CI (flutter/engine#51429)
2024-03-14 skia-flutter-autoroll@skia.org Roll Dart SDK from 2bc8b222d01f to 70ca2323a702 (1 revision) (flutter/engine#51430)
2024-03-14 matanlurey@users.noreply.github.com Reduce code-duplication a bit and add more error context across `SkiaGoldClient`. (flutter/engine#51426)
2024-03-14 zanderso@users.noreply.github.com [et] build and run commands disable RBE with a flag or when not available (flutter/engine#51404)
2024-03-14 matej.knopp@gmail.com Fix flakiness in FlutterVSyncWaiterTest.VSyncWorks and FlutterDisplayLinkTest.WorkaroundForFB13482573 (flutter/engine#51405)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

9b276be7

Roll Flutter Engine from 7b49dc9dd073 to 622b37282f20 (2 revisions) (#145179) · 60674fa3

engine-flutter-autoroll authored Mar 15, 2024

https://github.com/flutter/engine/compare/7b49dc9dd073...622b37282f20

2024-03-14 jonahwilliams@google.com [Impeller] revert round out. (flutter/engine#51395)
2024-03-14 kjlubick@users.noreply.github.com Remove always-true skia_enable_flutter_defines (flutter/engine#51423)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

60674fa3

Reverts "Platform view devicelab ad banner scroll list real ads (#144745)" (#145189) · 7f1c93d7

auto-submit[bot] authored Mar 15, 2024

Reverts: flutter/flutter#144745
Initiated by: gspencergoog
Reason for reverting: appears to have broken the build.

Original PR Author: hellohuanlin

Reviewed By: {jmagman, jonahwilliams}

This change reverts the following previous change:
This benchmark is to measure the platform view performance improvement. 

It is similar to https://github.com/lucalooz/flutter_ads_list_perf

There's still a pending issue https://github.com/flutter/flutter/issues/144339

*List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.*

Fixes https://github.com/flutter/flutter/issues/143534
Fixes https://github.com/flutter/flutter/issues/143257

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

7f1c93d7

14 Mar, 2024 22 commits

Platform view devicelab ad banner scroll list real ads (#144745) · be78542d

hellohuanlin authored Mar 14, 2024

This benchmark is to measure the platform view performance improvement. 

It is similar to https://github.com/lucalooz/flutter_ads_list_perf

There's still a pending issue https://github.com/flutter/flutter/issues/144339

*List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.*

Fixes https://github.com/flutter/flutter/issues/143534
Fixes https://github.com/flutter/flutter/issues/143257

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

be78542d

Implementing switch expressions in `flutter/test/` (#144580) · 17a27358
Nate authored Mar 14, 2024
```
Migrates test code to new `switch` syntax.
```
17a27358

Remove autofocus from the a11y_assessments app (#145117) · dff03432

Yegor authored Mar 14, 2024

As of https://github.com/flutter/engine/pull/47727 the web engine is able to find a default widget to focus on when a new route it pushed. The mobile engine already did that for some time. So `autofocus` is no longer necessary.

dff03432

Roll Flutter Engine from cc1e7d145067 to 7b49dc9dd073 (3 revisions) (#145176) · 5fb96272

engine-flutter-autoroll authored Mar 14, 2024

https://github.com/flutter/engine/compare/cc1e7d145067...7b49dc9dd073

2024-03-14 skia-flutter-autoroll@skia.org Roll Dart SDK from 749988e4d748 to 2bc8b222d01f (1 revision) (flutter/engine#51421)
2024-03-14 110993981+htoor3@users.noreply.github.com [web] - fix text editing IME composition interruption on geometry updates (flutter/engine#51323)
2024-03-14 flar@google.com Avoid unnecessary transform resets for pixel snapping (flutter/engine#51337)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

5fb96272

Roll Flutter Engine from 41fce3f010c9 to cc1e7d145067 (1 revision) (#145164) · 2c5d3b05

engine-flutter-autoroll authored Mar 14, 2024

https://github.com/flutter/engine/compare/41fce3f010c9...cc1e7d145067

2024-03-14 30870216+gaaclarke@users.noreply.github.com [Impeller] started asserting golden test runner has fatal impeller validations (flutter/engine#51357)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

2c5d3b05

Reverts "Fix TextField helper top padding on M3 (#145087)" (#145168) · bc611f56

auto-submit[bot] authored Mar 14, 2024

Reverts: flutter/flutter#145087
Initiated by: Jasguerrero
Reason for reverting: failing on accessibility checks b/329548765
Original PR Author: bleroux

Reviewed By: {justinmc}

This change reverts the following previous change:
## Description

`InputDecorator` adds a 8.0 gap beetween the container and the helper text.
From the Material 3 specification, this gap should be 4.0.
See https://m3.material.io/components/text-fields/specs#0c5c8d6d-2169-4d42-960c-51f6ee42eb57.

This PR sets the correct values for M3 without changing the value for M2.

| Before | After | M3 Spec |
|--------|--------|--------|
| ![image](https://github.com/flutter/flutter/assets/840911/9947f334-d98f-4f7e-9da7-ca6d5c0770ac) | ![image](https://github.com/flutter/flutter/assets/840911/081dec4b-eb9f-4eee-a7dc-2538e7110ff0)| ![image](https://github.com/flutter/flutter/assets/840911/c8c8f045-3b79-43a5-a1a3-cc6d5460644f) |

If this change is accepted, a future step will be to make this value configurable, probably by `InputDecorationTheme`.

## Related Issue

Fixes https://github.com/flutter/flutter/issues/144984

## Tests

Updates a value used by several existing tests.

bc611f56

Roll Flutter Engine from 46993c1bf5bb to 41fce3f010c9 (1 revision) (#145160) · 20889dd8

engine-flutter-autoroll authored Mar 14, 2024

https://github.com/flutter/engine/compare/46993c1bf5bb...41fce3f010c9

2024-03-14 matanlurey@users.noreply.github.com Remove or replaced unused or duplicate code in `SkiaGoldClient`. (flutter/engine#51399)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

20889dd8

[framework] fix incorrect chinese localizations for Search Web and Share in... · 9f5fd75e

LouiseHsu authored Mar 14, 2024

[framework] fix incorrect chinese localizations for Search Web and Share in selection controls (#144857)

Fixes https://github.com/flutter/flutter/issues/144825

Corresponding translation suggestions:

https://tc.corp.google.com/btviewer/edittranslation?project=Flutter&msgId=7417055026368500447&language=zh-TW
(I accidentally pressed submit 3 times :( )

https://tc.corp.google.com/btviewer/edittranslation?project=Flutter&msgId=7417055026368500447&language=zh-HK

https://tc.corp.google.com/btviewer/edittranslation?project=Flutter&msgId=7417055026368500447&language=zh-CN

https://tc.corp.google.com/btviewer/edittranslation?project=Flutter&msgId=8883913494819754382&language=zh-CN

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [relevant style guides] and ran the
auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages
repo does use `dart format`.)
- [x] I signed the [CLA].
- [x] The title of the PR starts with the name of the package surrounded
by square brackets, e.g. `[shared_preferences]`
- [x] I [linked to at least one issue that this PR fixes] in the
description above.
- [x] I updated `pubspec.yaml` with an appropriate new version according
to the [pub versioning philosophy], or this PR is [exempt from version
changes].
- [x] I updated `CHANGELOG.md` to add a description of the change,
[following repository CHANGELOG style].
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.

9f5fd75e

Asserts if a `TextPainter` gets disposed more than once (#145124) · a69567a3
LongCatIsLooong authored Mar 14, 2024
```
The overflow indicator was sharing the same `TextPainter`.
```
a69567a3

Roll Flutter Engine from 562d7a6e2861 to 46993c1bf5bb (2 revisions) (#145154) · 51d59a7d

engine-flutter-autoroll authored Mar 14, 2024

https://github.com/flutter/engine/compare/562d7a6e2861...46993c1bf5bb

2024-03-14 skia-flutter-autoroll@skia.org Roll Skia from f4ce9fc2ec45 to 52bb1539c5cf (1 revision) (flutter/engine#51415)
2024-03-14 skia-flutter-autoroll@skia.org Roll Dart SDK from d006b668dcb2 to 749988e4d748 (1 revision) (flutter/engine#51414)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

51d59a7d

Roll Packages from 38711aca66fa to b21c5424783a (5 revisions) (#145152) · 5b7d5cad

engine-flutter-autoroll authored Mar 14, 2024

https://github.com/flutter/packages/compare/38711aca66fa...b21c5424783a

2024-03-14 pageli328@gmail.com Support overriding `ErrorWidget.builder` (flutter/packages#6302)
2024-03-13 engine-flutter-autoroll@skia.org Manual roll Flutter from 61812ca3 to 394269f9 (6 revisions) (flutter/packages#6320)
2024-03-13 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 4.1.1 to 4.1.2 (flutter/packages#6309)
2024-03-13 magder@google.com Replace deprecated UIGraphicsBeginImageContextWithOptions with UIGraphicsImageRenderer (flutter/packages#6285)
2024-03-13 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.24.6 to 3.24.7 (flutter/packages#6310)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

5b7d5cad

Roll Flutter Engine from 8fcff7b44480 to 562d7a6e2861 (1 revision) (#145148) · 3d5f7864

engine-flutter-autoroll authored Mar 14, 2024

https://github.com/flutter/engine/compare/8fcff7b44480...562d7a6e2861

2024-03-14 skia-flutter-autoroll@skia.org Roll Skia from 21186e265c39 to f4ce9fc2ec45 (1 revision) (flutter/engine#51413)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

3d5f7864

Roll Flutter Engine from 5c147a9f8fa6 to 8fcff7b44480 (1 revision) (#145142) · 826e47e0

engine-flutter-autoroll authored Mar 14, 2024

https://github.com/flutter/engine/compare/5c147a9f8fa6...8fcff7b44480

2024-03-14 skia-flutter-autoroll@skia.org Roll Skia from 804d0ed22179 to 21186e265c39 (1 revision) (flutter/engine#51412)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

826e47e0

Roll Flutter Engine from 03d2af1d7a46 to 5c147a9f8fa6 (2 revisions) (#145135) · 4fa44339

engine-flutter-autoroll authored Mar 14, 2024

https://github.com/flutter/engine/compare/03d2af1d7a46...5c147a9f8fa6

2024-03-14 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from mYZPzdM3hCE1TA91s... to da-siZ7wPDA0Z0wXJ... (flutter/engine#51411)
2024-03-14 skia-flutter-autoroll@skia.org Roll Skia from e175e61d6259 to 804d0ed22179 (1 revision) (flutter/engine#51410)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from mYZPzdM3hCE1 to da-siZ7wPDA0

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

4fa44339

Roll Flutter Engine from f3bd39808a74 to 03d2af1d7a46 (1 revision) (#145133) · 7bf36ae7

engine-flutter-autoroll authored Mar 14, 2024

https://github.com/flutter/engine/compare/f3bd39808a74...03d2af1d7a46

2024-03-14 skia-flutter-autoroll@skia.org Roll Skia from cac09f152d9b to e175e61d6259 (2 revisions) (flutter/engine#51408)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

7bf36ae7

Roll Flutter Engine from 1da1597ec60d to f3bd39808a74 (1 revision) (#145131) · 822f55b3

engine-flutter-autoroll authored Mar 14, 2024

https://github.com/flutter/engine/compare/1da1597ec60d...f3bd39808a74

2024-03-14 skia-flutter-autoroll@skia.org Roll Dart SDK from b1e31a41fb17 to d006b668dcb2 (1 revision) (flutter/engine#51409)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

822f55b3

Roll Flutter Engine from bdf66af6ff0b to 1da1597ec60d (1 revision) (#145130) · fbf2692d

engine-flutter-autoroll authored Mar 14, 2024

https://github.com/flutter/engine/compare/bdf66af6ff0b...1da1597ec60d

2024-03-14 matanlurey@users.noreply.github.com Remove `--enable-impeller-{backend}` flags (always `True`). (flutter/engine#51402)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

fbf2692d

Roll Flutter Engine from 599dbd7382ec to bdf66af6ff0b (1 revision) (#145129) · d7dcd5ca

engine-flutter-autoroll authored Mar 14, 2024

https://github.com/flutter/engine/compare/599dbd7382ec...bdf66af6ff0b

2024-03-14 skia-flutter-autoroll@skia.org Roll Dart SDK from abc8988e9dac to b1e31a41fb17 (1 revision) (flutter/engine#51403)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

d7dcd5ca

Roll Flutter Engine from 6710d10ad703 to 599dbd7382ec (3 revisions) (#145123) · fa2f64ad

engine-flutter-autoroll authored Mar 14, 2024

https://github.com/flutter/engine/compare/6710d10ad703...599dbd7382ec

2024-03-14 737941+loic-sharma@users.noreply.github.com [Embedder API] Add multi-view present callback (flutter/engine#51267)
2024-03-14 skia-flutter-autoroll@skia.org Roll Skia from a315e4572f4e to cac09f152d9b (10 revisions) (flutter/engine#51398)
2024-03-14 dkwingsmt@users.noreply.github.com Multi-view View Metrics (flutter/engine#46174)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

fa2f64ad

Roll Flutter Engine from cb9dead25ef9 to 6710d10ad703 (1 revision) (#145121) · 5ab91882

engine-flutter-autoroll authored Mar 14, 2024

https://github.com/flutter/engine/compare/cb9dead25ef9...6710d10ad703

2024-03-13 yjbanov@google.com [web] make text more crawlable; fix a JAWS bug (flutter/engine#50794)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

5ab91882

Roll Flutter Engine from d29383cc8122 to cb9dead25ef9 (1 revision) (#145120) · a769ef48

engine-flutter-autoroll authored Mar 14, 2024

https://github.com/flutter/engine/compare/d29383cc8122...cb9dead25ef9

2024-03-13 john@johnmccutchan.com Disable cleaning up ImageReaders in memory pressure callback (flutter/engine#51391)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

a769ef48

Reduce Windows_arm64 plugin_test_windows test timeout (#145110) · 349cbb4a

Loïc Sharma authored Mar 14, 2024

Windows Defender sometimes kills the `Windows_arm64 plugin_test_windows` test process, causing the test to hang until it times out after 30 minutes. This reduces the test timeout to 900 seconds (15 minutes) to recover from this scenario faster.

Test timeout duration was chosen by looking at successful duration percentiles in the last 100 days:

duration_seconds_p90 | duration_seconds_p99 | duration_seconds_max
-- | -- | --
532 | 545 | 576

BigQuery SQL:

```sql
WITH
  successful_steps AS (
    SELECT
      b.id,
      TIMESTAMP_DIFF(s.end_time, s.start_time, SECOND) AS duration_seconds,
    FROM cr-buildbucket.flutter.builds AS b, UNNEST(steps) AS s
    WHERE
      create_time > TIMESTAMP_SUB(CURRENT_TIMESTAMP(), INTERVAL 100 DAY)
      AND regexp_substr(input.gitiles_commit.project, '[^\\/]+$') = 'flutter'
      AND builder.project || '/' || builder.bucket || '/' || builder.builder
        = 'flutter/prod/Windows_arm64 plugin_test_windows'
      AND name = 'run plugin_test_windows'
      AND s.status = 'SUCCESS'
  )
SELECT
  percentiles[offset(90)] AS duration_seconds_p90,
  percentiles[offset(99)] AS duration_seconds_p99,
  duration_seconds_max
FROM (
  SELECT
    APPROX_QUANTILES(duration_seconds, 100) AS percentiles,
    MAX(duration_minutes) AS duration_seconds_max
  FROM successful_steps
);
```

`test_timeout_secs` is documented here: https://github.com/flutter/cocoon/blob/main/CI_YAML.md

Part of https://github.com/flutter/flutter/issues/145072

349cbb4a

13 Mar, 2024 9 commits

Roll Flutter Engine from d65c7e41f89a to d29383cc8122 (1 revision) (#145116) · 0e126f3f

engine-flutter-autoroll authored Mar 13, 2024

https://github.com/flutter/engine/compare/d65c7e41f89a...d29383cc8122

2024-03-13 skia-flutter-autoroll@skia.org Roll Dart SDK from 18ec60df0774 to abc8988e9dac (1 revision) (flutter/engine#51388)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

0e126f3f

Roll Flutter Engine from c88934422419 to d65c7e41f89a (2 revisions) (#145113) · b246f587

engine-flutter-autoroll authored Mar 13, 2024

https://github.com/flutter/engine/compare/c88934422419...d65c7e41f89a

2024-03-13 john@johnmccutchan.com Small improvements to et lint command (flutter/engine#51372)
2024-03-13 jonahwilliams@google.com [Impeller] cleanup and test vk image usage flags. (flutter/engine#51301)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

b246f587

Update proxied devices to handle connection interface and diagnostics. (#145061) · 3dba3f2a
Lau Ching Jun authored Mar 13, 2024
```
Also improve the performance of daemon device discovery by parallelizing the calls.
```
3dba3f2a

RenderViewport max layout cycles should depend on number of slivers (#144104) · 19087442

Matej Knopp authored Mar 13, 2024

Fixes https://github.com/flutter/flutter/issues/144102

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
[Data Driven Fixes]:
https://github.com/flutter/flutter/wiki/Data-driven-Fixes

19087442

Roll Flutter Engine from 9551b49b3fa1 to c88934422419 (2 revisions) (#145108) · fd73a9a0

engine-flutter-autoroll authored Mar 13, 2024

https://github.com/flutter/engine/compare/9551b49b3fa1...c88934422419

2024-03-13 skia-flutter-autoroll@skia.org Roll Skia from 1ad0d0fabe7a to a315e4572f4e (7 revisions) (flutter/engine#51377)
2024-03-13 matej.knopp@gmail.com Reland "Reland: [macOS] Use CVDisplayLink to drive repaint" (flutter/engine#51210)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

fd73a9a0

Mark Mac_arm64_ios module_test_ios not flaky (#145044) · 6f175f1f

Jenn Magder authored Mar 13, 2024

Revert https://github.com/flutter/flutter/pull/144861

https://github.com/flutter/flutter/issues/144860 was resolved by https://github.com/openid/AppAuth-iOS/pull/825

I'm just going to mark this as unflaky instead of waiting for the bot.

6f175f1f

Revert "Add `FocusNode.focusabilityListenable` (#144280)" since the feature is... · 4f786841

LongCatIsLooong authored Mar 13, 2024

Revert "Add `FocusNode.focusabilityListenable` (#144280)" since the feature is no longer needed (#145102)

This reverts commit 726e5d28.

*Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.*

*List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.*

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

4f786841

Fix TextField helper top padding on M3 (#145087) · 33fbb75a

Bruno Leroux authored Mar 13, 2024

## Description

`InputDecorator` adds a 8.0 gap beetween the container and the helper text.
From the Material 3 specification, this gap should be 4.0.
See https://m3.material.io/components/text-fields/specs#0c5c8d6d-2169-4d42-960c-51f6ee42eb57.

This PR sets the correct values for M3 without changing the value for M2.

| Before | After | M3 Spec |
|--------|--------|--------|
| ![image](https://github.com/flutter/flutter/assets/840911/9947f334-d98f-4f7e-9da7-ca6d5c0770ac) | ![image](https://github.com/flutter/flutter/assets/840911/081dec4b-eb9f-4eee-a7dc-2538e7110ff0)| ![image](https://github.com/flutter/flutter/assets/840911/c8c8f045-3b79-43a5-a1a3-cc6d5460644f) |

If this change is accepted, a future step will be to make this value configurable, probably by `InputDecorationTheme`.

## Related Issue

Fixes https://github.com/flutter/flutter/issues/144984

## Tests

Updates a value used by several existing tests.

33fbb75a

Roll Flutter Engine from 6ceccf894c41 to 9551b49b3fa1 (9 revisions) (#145106) · 247580c7

engine-flutter-autoroll authored Mar 13, 2024

https://github.com/flutter/engine/compare/6ceccf894c41...9551b49b3fa1

2024-03-13 jonahwilliams@google.com [Impeller] fix heap selection process for YUV textures. (flutter/engine#51262)
2024-03-13 68449066+zijiehe-google-com@users.noreply.github.com [Fuchsia] Enable sound null safety everywhere (flutter/engine#51355)
2024-03-13 30870216+gaaclarke@users.noreply.github.com [Impeller] added missing golden test for DrawScaledTextWithPerspectiveSaveLayer (flutter/engine#51368)
2024-03-13 skia-flutter-autoroll@skia.org Roll Skia from dc7443fa4d88 to 1ad0d0fabe7a (1 revision) (flutter/engine#51373)
2024-03-13 tugorez@users.noreply.github.com Implement PlatformDispatcher.requestViewFocusChange on web. (flutter/engine#50535)
2024-03-13 jonahwilliams@google.com [Impeller] attempt to get validation errors from CI unittests. (flutter/engine#51341)
2024-03-13 skia-flutter-autoroll@skia.org Roll Dart SDK from b19e0995f317 to 18ec60df0774 (1 revision) (flutter/engine#51374)
2024-03-13 jonahwilliams@google.com [scenario app] make image matching fuzzier. (flutter/engine#51376)
2024-03-13 skia-flutter-autoroll@skia.org Roll Skia from bbe453e3525d to dc7443fa4d88 (1 revision) (flutter/engine#51371)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

247580c7