- 20 Sep, 2023 1 commit
-
-
Greg Spencer authored
## Description This removes all of the comments that are of the form "so-and-so (must not be null|can ?not be null|must be non-null)" from the cases where those values are defines as non-nullable values. This PR removes them from the animation, cupertino, foundation, gestures, semantics, and services libraries. Each of them only had a few, so I lumped them together. This was done by hand, since it really didn't lend itself to scripting, so it needs to be more than just spot-checked, I think. I was careful to leave any comment that referred to parameters that were nullable, but I may have missed some. In addition to being no longer relevant after null safety has been made the default, these comments were largely fragile, in that it was easy for them to get out of date, and not be accurate anymore anyhow. This did create a number of constructor comments which basically say "Creates a [Foo].", but I don't really know how to avoid that in a large scale change, since there's not much you can really say in a lot of cases. I think we might consider some leniency for constructors to the "Comment must be meaningful" style guidance (which we de facto have already, since there are a bunch of these). ## Related PRs - https://github.com/flutter/flutter/pull/134991 - https://github.com/flutter/flutter/pull/134992 - https://github.com/flutter/flutter/pull/134993 - https://github.com/flutter/flutter/pull/134994 ## Tests - Documentation only change.
-
- 22 Mar, 2023 1 commit
-
-
Michael Goderbauer authored
Remove 1745 decorative breaks
-
- 24 Jan, 2023 1 commit
-
-
Michael Goderbauer authored
-
- 08 Jun, 2022 1 commit
-
-
Taha Tesser authored
-
- 25 May, 2022 1 commit
-
-
Pierre-Louis authored
* Use `curly_braces_in_flow_control_structures` for `animation` * Use `curly_braces_in_flow_control_structures` for `cupertino` * fix comments
-
- 18 May, 2022 1 commit
-
-
gaaclarke authored
-
- 14 Apr, 2022 1 commit
-
-
Michael Goderbauer authored
-
- 14 Feb, 2022 1 commit
-
-
Taha Tesser authored
-
- 10 May, 2021 1 commit
-
-
Michael Goderbauer authored
-
- 26 Mar, 2021 1 commit
-
-
Alexandre Ardhuin authored
-
- 22 Dec, 2020 1 commit
-
-
Darren Austin authored
-
- 11 Dec, 2020 1 commit
-
-
Michael Goderbauer authored
-
- 03 Nov, 2020 1 commit
-
-
Greg Spencer authored
* Remove nullOk from cupertino color resolution * Add CupertinoDynamicColor.maybeResolveFrom * Remove CupertinoDynamicColor.maybeResolveFrom again
-
- 30 Oct, 2020 1 commit
-
-
Michael Goderbauer authored
-
- 19 Oct, 2020 1 commit
-
-
Xavier Chrétien authored
-
- 10 Oct, 2020 1 commit
-
-
Alexandre Ardhuin authored
-
- 23 Sep, 2020 1 commit
-
-
Alexandre Ardhuin authored
* migrate some cupertino files to nullsafety * address review comments * address review comments
-
- 17 Sep, 2020 1 commit
-
-
Matěj Žídek authored
-
- 11 Jun, 2020 1 commit
-
-
Alexandre Ardhuin authored
* add language version 2.8 in packages/flutter * enable non-nullable analyzer flag
-
- 08 Jan, 2020 1 commit
-
-
Greg Spencer authored
-
- 16 Dec, 2019 1 commit
-
-
Alexandre Ardhuin authored
-
- 27 Nov, 2019 1 commit
-
-
Ian Hickson authored
* Update project.pbxproj files to say Flutter rather than Chromium Also, the templates now have an empty organization so that we don't cause people to give their apps a Flutter copyright. * Update the copyright notice checker to require a standard notice on all files * Update copyrights on Dart files. (This was a mechanical commit.) * Fix weird license headers on Dart files that deviate from our conventions; relicense Shrine. Some were already marked "The Flutter Authors", not clear why. Their dates have been normalized. Some were missing the blank line after the license. Some were randomly different in trivial ways for no apparent reason (e.g. missing the trailing period). * Clean up the copyrights in non-Dart files. (Manual edits.) Also, make sure templates don't have copyrights. * Fix some more ORGANIZATIONNAMEs
-
- 15 Oct, 2019 1 commit
-
-
Luiz França authored
-
- 25 Sep, 2019 1 commit
-
-
LongCatIsLooong authored
-
- 24 Sep, 2019 2 commits
-
-
LongCatIsLooong authored
-
Alexandre Ardhuin authored
-
- 22 Aug, 2019 1 commit
-
-
LongCatIsLooong authored
-
- 19 Dec, 2018 1 commit
-
-
xster authored
-
- 08 Nov, 2018 1 commit
-
-
Greg Spencer authored
This converts existing ## Sample code samples to {@tool sample}...{@end-tool} form. Also: 1. Fixed a minor bug in analyze-sample-code.dart 2. Made the snippet tool only insert descriptions if the description is non-empty. 3. Moved the Card diagram to before the code sample.
-
- 05 Nov, 2018 1 commit
-
-
Greg Spencer authored
This rewrites the sample code analysis script to be a little less of a hack (but still not pretty), and to handle snippets as well. It also changes the semantics of how sample code is handled: the namespace for the sample code is now limited to the file that it appears in, so some additional "Examples can assume:" blocks were added. The upside of this is that there will be far fewer name collisions. I fixed the output too: no longer will you get 4000 lines of numbered output with the error at the top and have to grep for the actual problem. It gives the filename and line number of the original location of the code (in the comment in the tree), and prints out the source code on the line that caused the problem along with the error. For snippets, it prints out the location of the start of the snippet and the source code line that causes the problem. It can't print out the original line, because snippets get formatted when they are written, so the line might not be in the same place.
-
- 12 Sep, 2018 1 commit
-
-
Alexandre Ardhuin authored
* enable lint unnecessary_new * fix tests * fix tests * fix tests
-
- 07 Sep, 2018 1 commit
-
-
Alexandre Ardhuin authored
* lint unnecessary_new on samples * fix tests
-
- 14 Aug, 2018 1 commit
-
-
Jonah Williams authored
-
- 02 Aug, 2018 1 commit
-
-
Alexandre Ardhuin authored
-
- 27 Jul, 2018 1 commit
-
-
Todd Volkert authored
It was causing problems rolling Flutter into Fuchsia
-
- 23 Jul, 2018 1 commit
-
-
Alexandre Ardhuin authored
* re-enable lint unnecessary_const * remove trailling whitespaces * remove unnecessary const (after merge)
-
- 16 Jul, 2018 2 commits
-
-
Ian Hickson authored
This reverts commit cc1cf13e.
-
Alexandre Ardhuin authored
-
- 09 Jul, 2018 1 commit
-
-
xster authored
-
- 05 Jun, 2018 1 commit
-
-
Alexandre Ardhuin authored
-