- 23 Mar, 2015 4 commits
-
-
Adam Barth authored
This will let us form a wholistic picture of work done in the framework and in the engine. R=ojan@chromium.org, rafaelw@chromium.org Review URL: https://codereview.chromium.org/1028243003
-
Adam Barth authored
Build fix after recent Dart bindings refactoring. Now that these libraries are not included in the snapshot, we need to load them from the mojo package. R=zra@google.com TBR=zra@chromium.org Review URL: https://codereview.chromium.org/1029683002
-
Adam Barth authored
We were missing the ability to initialize one of the fields. TBR=rafaelw@chromium.org Review URL: https://codereview.chromium.org/1027293003
-
Adam Barth authored
Instead of hard-coding the stock data in the Dart file, this CL moves the data to a JSON file and loads that file over the network. This change improves load time for the Stocks app from 3 seconds to 2 seconds. Also, this CL removes shake-to-reload from the Stocks app because that also slows down load time (due to the two module systems fighting each other). R=rafaelw@chromium.org, ojan@chromium.org Review URL: https://codereview.chromium.org/1021723005
-
- 20 Mar, 2015 6 commits
-
-
Eric Seidel authored
Also bumped package:sky's version in prep for publishing. R=abarth@chromium.org BUG= Review URL: https://codereview.chromium.org/1024243002
-
Eric Seidel authored
I'm not sure this is the final long-term solution, but works for now. R=abarth@chromium.org Review URL: https://codereview.chromium.org/1022193002
-
Eric Seidel authored
TBR=abarth@chromium.org BUG= Review URL: https://codereview.chromium.org/1021933004
-
Rafael Weinstein authored
TBR=abarth BUG= Review URL: https://codereview.chromium.org/1024183002
-
Adam Barth authored
StockMenu was creating a container for the sole purpose of applying style to PopupMenu. Now we just use a StyleNode. Also, I've reverted the change to make box-sizing default to border-box. It turns out that CL wasn't effective because we didn't use the initialBoxSizing function to initialize box sizing. I've made us use initialBoxSizing but switch the default back to content-box because actually using border-box breaks a bunch of stuff. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/1024083003
-
Adam Barth authored
This CL extracts a Scaffold component from StockApp. The Scaffold component lets you create an "app-like" layout with an action bar, a drawer, etc. R=ojan@chromium.org, rafaelw@chromium.org Review URL: https://codereview.chromium.org/1027813002
-
- 16 Mar, 2015 1 commit
-
-
Rafael Weinstein authored
This patch adds a new (non-Render) StyleNode which takes two arguments: A (content) node, which it wraps and a Style object. This allows for styles to be applied to Nodes which are constructed elsewhere (e.g. passed in as arguments). R=abarth@chromium.org Review URL: https://codereview.chromium.org/1027653002
-
- 19 Mar, 2015 3 commits
-
-
Adam Barth authored
This CL adds just enough custom painting to Sky to make sky/examples/painting/circle.sky draw a circle. Over time, we should be able to elaborate this system into something interesting and to make it actually work in a reasonable way. R=ojan@chromium.org Review URL: https://codereview.chromium.org/1017593005
-
Adam Barth authored
1) Factors InkWell out of Material so that components can use an ink well without needing the shadow/level machinery. 2) Makes the ink effect move at a different velocity once the tap has actually occurred, converging with the spec. We don't have the right speeds yet, but at least we're approaching the right shape. 3) To support (2), added a primaryPointer attribute to GestureEvents to let authors coorelate gesturetapdown events with later gesturetap events. 4) To support (2), modernized SplashAnimation to used AnimatedValue and friends. 5) Added more constants to view-configuration.dart that match Android. I've also removed the cancelling of the ink effect on scroll. The proper way to do that is to notice that someone in the event chain is listening for scrollstart and delay the beginning of the ink effect for some period of time. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/1019023003
-
Viet-Trung Luu authored
(Using the query string from the URL.) R=erg@chromium.org Review URL: https://codereview.chromium.org/1019323002
-
- 15 Mar, 2015 1 commit
-
-
Rafael Weinstein authored
This patch removes the mutable API to event handling (Nodes no longer have a events object with which to add listeners). Instead, a new (non-Render) Node is introduced: EventTarget. This node represents a location in the Effen tree which can handle events as they bubble. Note that this also changes the implementation to use event delegation (one set of listeners at the sky.document level) rather than direct listeners on leaf nodes. R=abarth@chromium.org Review URL: https://codereview.chromium.org/1019633004
-
- 18 Mar, 2015 5 commits
-
-
Adam Barth authored
We're now doing all of the elements of the popup menu entrance animation from the material design spec, but our timing and curves might not be exactly right yet. I haven't started on the exit animation. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/1017193004
-
Eric Seidel authored
R=abarth@chromium.org Review URL: https://codereview.chromium.org/1022613002
-
Eric Seidel authored
Before this change Sky would hit 404s when trying to load examples from domokit.github.io. I also added a separate sky_home and updated the default url to point to sky_home instead of home. R=abarth@chromium.org Review URL: https://codereview.chromium.org/1016143002
-
Adam Barth authored
This CL also refactors how animations work, particularly for the Drawer. I've renamed DrawerAnimation to DrawerController and switched it from being an Animation to having an Animation. I've also renamed Animation to AnimatedValue to capture the idea that the class actually presents the value being animated. Finally, I've factored AnimatedValueListener out of Drawer so that it can be used by PopupMenuItem as well. Finally, I've added a scheduleBuild convienence function to Component instead of having to call setState(() {}), which has come up a couple times. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/1016093002
-
Adam Barth authored
We should probably move this menu into a view for an individual stock, but for now add it to the main stock screen. R=ojan@chromium.org, eseidel@chromium.org Review URL: https://codereview.chromium.org/1008003007
-
- 17 Mar, 2015 6 commits
-
-
Adam Barth authored
1) Add a pubspec.yaml. 2) Move all the code into a 'lib' directory. 3) Move the stock widgets out of the app's library. TBR=eseidel@chromium.org Review URL: https://codereview.chromium.org/1011023003
-
Viet-Trung Luu authored
Ditto for terminal_client.mojom, previously in examples/echo_terminal. Fix the sky terminal example. R=erg@chromium.org Review URL: https://codereview.chromium.org/1013313002
-
Adam Barth authored
Currently this widget is demoed in widgets-fn, but I'll move it into stocks-fn soon. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/1017873002
-
Eric Seidel authored
The packages produced from this CL were deployed as v0.0.1: https://pub.dartlang.org/packages/sky https://pub.dartlang.org/packages/mojo There is still no tool included with the sky package due to pub's inability to run anything other than Dart: https://code.google.com/p/dart/issues/detail?id=22877 I'm likely just going to write a dart version of my "sky" script. :( R=ojan@chromium.org, abarth@chromium.org Review URL: https://codereview.chromium.org/1015833002
-
Adam Barth authored
This CL is a warmup for using a more sophisticated gesture disambiguation. 1) Use gesturetap instead of click. We should probably remove click events because folks should use gesturetap to integrate with the gesture system. 2) Handle the case where you swipe the drawer during an animation. Previously we had an assert which triggered in some multitouch scenarios. We'll eventually move this over to gestureswipe. 3) Remove an extra container for ink splashes. There's no need to group all the ink splashes in a container. They can all just be children of the Material component itself. This structure is left over from when Material was a base class. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/1013713005
-
Adam Barth authored
This CL adds typography information to the Sky theme. The values are from the Material Design spec. I've also applied these values to the stocks app and the various components. We're not geting precisely the right typography in some cases because of https://github.com/domokit/mojo/issues/65. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/1006363004
-
- 16 Mar, 2015 2 commits
-
-
Adam Barth authored
The left edge of the title should be on the 72px vertical keyline according to the Material Design spec. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/1010443005
-
Adam Barth authored
This naming matches the naming in Material Design. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/1010913002
-
- 13 Mar, 2015 5 commits
-
-
Rafael Weinstein authored
R=abarth@chromium.org Review URL: https://codereview.chromium.org/1006053002
-
Adam Barth authored
This CL cleans up the sky/framework/animation as follows: 1) I've moved code that's used only by the custom elements framework into sky/framework/elements/animation. This code is based on AnimationDelegates rather than Streams. 2) Rename ScrollCurve to ScrollBehavior because it encapsulates more behavior than just a curve. 3) Make the Generator interface explicit and mark subclasses as actual subclasses. 4) Move Simulation into generators.dart because it implements the Generator interface. 5) Move Animation out of generators.dart because it does not implement the Generator interface. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/1001373002
-
Rafael Weinstein authored
-
Rafael Weinstein authored
-
Rafael Weinstein authored
-
- 12 Mar, 2015 3 commits
-
-
Adam Barth authored
When using OverscrollCurve, we continue to scroll beyond the top of the scrollable area but the scroll delta is reduced by 2x. A future CL will add an animation at gesturescrollend to relax back to scroll position 0.0. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/1002953003
-
Adam Barth authored
Intead of hard-coding the notion of bounded scrolling into Scrollable, this CL factors out a ScrollCurve class that applies the bounds. In the future, we'll refine this mechanism to implement overflow scrolling. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/1005633002
-
Adam Barth authored
R=eseidel@chromium.org Review URL: https://codereview.chromium.org/1000863002
-
- 11 Mar, 2015 4 commits
-
-
Viet-Trung Luu authored
Also: * Fix consecutive spaces (don't collapse them). * Add support for ^L. Still doesn't work: * Totally blank lines. (I know why, but I don't know why I can't seem to fix it.) R=erg@chromium.org Review URL: https://codereview.chromium.org/997873004
-
Viet-Trung Luu authored
D'oh. TBR=erg@chromium.org Review URL: https://codereview.chromium.org/998103002
-
Viet-Trung Luu authored
(Together with an app that echoes stuff from the terminal.) R=erg@chromium.org Review URL: https://codereview.chromium.org/999193002
-
Adam Barth authored
To accomplish this, I made the following changes: 1) Material is now in charge of drawing the material shadows. 2) In order to mix in the style for the shadow, Element now takes a list of Styles instead of a single style. 3) Update all clients of Element#style to understand that we now have a list. 4) Update components that drawer shadows to have Material do that work instead. a) One exception: FloatingActionButton draws its own shadow because of its crazy clip requirements. We'll probably want to find a better way for FloatingActionButton to clip in the future. I've also added a widgets-fn example to demo the fn material widgets. This CL introduces a bug into Drawer whereby you can get ink splashes everywhere in the drawer. In the future, we'll need to separate out the different material aspects to get non-splashable materials. R=rafaelw@chromium.org Review URL: https://codereview.chromium.org/1003553002
-