Commits · ceab0e005f8e34e329c4eaf2e50a5e20d37144fd · abdullh.alsoleman / Front-End

31 Jan, 2024 34 commits

Roll Flutter Engine from 9ccd81d7595b to 20e53614c16c (3 revisions) (#142628) · ceab0e00

engine-flutter-autoroll authored Jan 31, 2024

https://github.com/flutter/engine/compare/9ccd81d7595b...20e53614c16c

2024-01-31 skia-flutter-autoroll@skia.org Roll Dart SDK from fbf1d8ebceb4 to 1f136c7b962d (1 revision) (flutter/engine#50203)
2024-01-31 magder@google.com Log FlutterJSONMessageCodec decode errors before asserting (flutter/engine#50163)
2024-01-31 mdebbar@google.com [web] Final nail in FlutterViewEmbedder's coffin (flutter/engine#49769)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

ceab0e00

Show Mac Designed For iPad in 'flutter devices' (#141718) · 42317804

LouiseHsu authored Jan 31, 2024

Addresses https://github.com/flutter/flutter/issues/141290 by allow Mac Designed For IPad Devices to appear with 'flutter devices'.

<img width="573" alt="Screenshot 2024-01-29 at 12 23 24â¯AM" src="https://github.com/flutter/flutter/assets/36148254/35709a93-56fc-44c9-98d5-cf45afce967d">
<img width="725" alt="Screenshot 2024-01-29 at 12 26 01â¯AM" src="https://github.com/flutter/flutter/assets/36148254/b6cbcfce-44db-42c6-ac01-0ab716d30373">

42317804

Marks Mac_arm64_ios basic_material_app_ios__compile to be unflaky (#142594) · 07183066

Flutter GitHub Bot authored Jan 31, 2024

<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Mac_arm64_ios basic_material_app_ios__compile"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Mac_arm64_ios%20basic_material_app_ios__compile%22).
This test can be marked as unflaky.

07183066

Fix ParentDataWidget crash for multi view scenarios (#142486) · 3da5ff54

Michael Goderbauer authored Jan 31, 2024

Fixes https://github.com/flutter/flutter/issues/142480.

This fixes a crash occurring during hot reload when a `ViewAnchor` is used between a `ParentDataWidget` (like `Positioned`) and its closest `RenderObject` descendant. Prior to the fix, the `ParentDataWidget` was accidentally applying its parent data to the render object in the `ViewAnchor.view` slot, which crashed because that render object wasn't (and shouldn't be) setup to accept parent data (after all, it is in a different render tree). Instead, the parent data should only be applied to the render object in the `ViewAnchor.child` slot. Luckily, with `Element.renderObjectAttachingChild` we already have API in place to walk the widget tree such as that only `RenderObjectWidgets` from the same render tree are considered.

3da5ff54

Roll Flutter Engine from e0d8f472a1b6 to 9ccd81d7595b (1 revision) (#142625) · efca21c0

engine-flutter-autoroll authored Jan 31, 2024

https://github.com/flutter/engine/compare/e0d8f472a1b6...9ccd81d7595b

2024-01-31 skia-flutter-autoroll@skia.org Roll Skia from 439a6aae5036 to 053848101c10 (2 revisions) (flutter/engine#50202)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

efca21c0

Marks Mac_arm64 tool_tests_commands to be unflaky (#142593) · 9c107801

Flutter GitHub Bot authored Jan 31, 2024

<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Mac_arm64 tool_tests_commands"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Mac_arm64%20tool_tests_commands%22).
This test can be marked as unflaky.

9c107801

"System back gesture" explanation (#142254) · 9c2c487e
Justin McCandless authored Jan 31, 2024
```
Improve docs around PopScope and its interaction with back gestures on Android and iOS.
```
9c2c487e

Marks Mac_x64 tool_tests_commands to be unflaky (#142592) · 1d48b60d

Flutter GitHub Bot authored Jan 31, 2024

<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Mac_x64 tool_tests_commands"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Mac_x64%20tool_tests_commands%22).
This test can be marked as unflaky.

1d48b60d

Marks Mac_x64_ios integration_test_test_ios to be unflaky (#142595) · 0e274f5c

Flutter GitHub Bot authored Jan 31, 2024

<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Mac_x64_ios integration_test_test_ios"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Mac_x64_ios%20integration_test_test_ios%22).
This test can be marked as unflaky.

0e274f5c

Marks Mac_x64 native_ui_tests_macos to be unflaky (#142598) · 62fcc158

Flutter GitHub Bot authored Jan 31, 2024

<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Mac_x64 native_ui_tests_macos"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Mac_x64%20native_ui_tests_macos%22).
This test can be marked as unflaky.

62fcc158

Marks Mac_x64_ios hot_mode_dev_cycle_ios__benchmark to be unflaky (#142597) · 2dc7c922

Flutter GitHub Bot authored Jan 31, 2024

<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Mac_x64_ios hot_mode_dev_cycle_ios__benchmark"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Mac_x64_ios%20hot_mode_dev_cycle_ios__benchmark%22).
This test can be marked as unflaky.

2dc7c922

Marks Mac_arm64 native_ui_tests_macos to be unflaky (#142599) · 5efcfba6

Flutter GitHub Bot authored Jan 31, 2024

<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Mac_arm64 native_ui_tests_macos"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Mac_arm64%20native_ui_tests_macos%22).
This test can be marked as unflaky.

5efcfba6

Marks Windows_android hot_mode_dev_cycle_win__benchmark to be flaky (#142609) · 8629dfa2

Flutter GitHub Bot authored Jan 31, 2024

<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Windows_android hot_mode_dev_cycle_win__benchmark"
}
-->
Issue link: https://github.com/flutter/flutter/issues/142608

8629dfa2

Marks Mac_arm64_ios integration_test_test_ios to be unflaky (#142596) · 5f2961d2

Flutter GitHub Bot authored Jan 31, 2024

<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Mac_arm64_ios integration_test_test_ios"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Mac_arm64_ios%20integration_test_test_ios%22).
This test can be marked as unflaky.

5f2961d2

Mark test that leaks image. (#142539) · 6d8aa4af
Polina Cherkasova authored Jan 31, 2024

6d8aa4af

Roll Flutter Engine from b9bc256156b8 to e0d8f472a1b6 (1 revision) (#142623) · 50dbcc48

engine-flutter-autoroll authored Jan 31, 2024

https://github.com/flutter/engine/compare/b9bc256156b8...e0d8f472a1b6

2024-01-31 skia-flutter-autoroll@skia.org Roll Skia from f916aedaa69b to 439a6aae5036 (4 revisions) (flutter/engine#50201)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

50dbcc48

Fix unresponsive mouse tooltip (#142282) · 43aee92e

LongCatIsLooong authored Jan 31, 2024

Fixes https://github.com/flutter/flutter/issues/142045

The intent of using `??=` was that if the tooltip is already scheduled for showing, rescheduling another show does nothing. But if the tooltip is already scheduled for dismissing, the `??=` won't cancel the dismiss timer and as a result the tooltip won't show. So the `??=` is now replaced by `=` to keep it consistent with the `_scheduleDismissTooltip` implementation.

43aee92e

Marks Linux_android_emu android_defines_test to be unflaky (#142591) · 347403f2

Flutter GitHub Bot authored Jan 31, 2024

<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Linux_android_emu android_defines_test"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Linux_android_emu%20android_defines_test%22).
This test can be marked as unflaky.

347403f2

Roll Flutter Engine from 447dd212447e to b9bc256156b8 (6 revisions) (#142617) · 3652206c

engine-flutter-autoroll authored Jan 31, 2024

https://github.com/flutter/engine/compare/447dd212447e...b9bc256156b8

2024-01-31 skia-flutter-autoroll@skia.org Roll Dart SDK from cd834c2ade57 to fbf1d8ebceb4 (1 revision) (flutter/engine#50199)
2024-01-31 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from Z-xFM2ILZJw22eU8q... to nymRxHV9Shod7cyLe... (flutter/engine#50197)
2024-01-31 skia-flutter-autoroll@skia.org Roll Skia from ef48b123d2d1 to f916aedaa69b (1 revision) (flutter/engine#50196)
2024-01-31 skia-flutter-autoroll@skia.org Roll Dart SDK from 488e33cd39de to cd834c2ade57 (2 revisions) (flutter/engine#50195)
2024-01-31 skia-flutter-autoroll@skia.org Roll Skia from eb1d9b467596 to ef48b123d2d1 (1 revision) (flutter/engine#50194)
2024-01-31 skia-flutter-autoroll@skia.org Roll Skia from fec9deb3d8c6 to eb1d9b467596 (1 revision) (flutter/engine#50193)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from Z-xFM2ILZJw2 to nymRxHV9Shod

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

3652206c

Roll Packages from 25abb5d1e0de to 5b48c446976f (4 revisions) (#142616) · 9480e889

engine-flutter-autoroll authored Jan 31, 2024

https://github.com/flutter/packages/compare/25abb5d1e0de...5b48c446976f

2024-01-30 ian@hixie.ch [rfw] Enable subscribing to the root of a DynamicContent (flutter/packages#5848)
2024-01-30 10687576+bparrishMines@users.noreply.github.com [pigeon] Adds ProxyApi to AST generation (flutter/packages#5861)
2024-01-30 stuartmorgan@google.com [tool] Exempt federated impl examples from CHANGELOG (flutter/packages#6018)
2024-01-30 engine-flutter-autoroll@skia.org Manual roll Flutter from 2f6fdf26 to ace91811 (57 revisions) (flutter/packages#6013)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

9480e889

Fix null operator error when tapping on 'MenuItemButton' (#142230) · 4a6cbefe

Jude Selase Kwashie authored Jan 31, 2024

This PR fixes null operator error when you change focus node of a 'MenuItemButton' to null.

fixes: [issue142095](https://github.com/flutter/flutter/issues/142095)

4a6cbefe

Roll Flutter Engine from 8e7df85f7d11 to 447dd212447e (2 revisions) (#142587) · d93e7ae9

engine-flutter-autoroll authored Jan 31, 2024

https://github.com/flutter/engine/compare/8e7df85f7d11...447dd212447e

2024-01-31 skia-flutter-autoroll@skia.org Roll Skia from 1fbb575f968d to fec9deb3d8c6 (1 revision) (flutter/engine#50192)
2024-01-31 68449066+zijiehe-google-com@users.noreply.github.com [Fuchsia] Execute most of the testing/fuchsia/test_suites.yaml on debug and release builds (flutter/engine#50058)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

d93e7ae9

Split out AppBar/SliverAppBar material tests (#142560) · 42add0f8

Kate Lovett authored Jan 31, 2024

While looking into resolving https://github.com/flutter/flutter/issues/117903, I found the massive test file `app_bar_test.dart` and found it unwieldy to work with. So before proposing a solution to #117903, which would touch many of these tests, I figured a clean up would be best first.

This splits up `app_bar_test.dart` with a new file `app_bar_sliver_test.dart`, and adds `app_bar_utils.dart` for shared test methods.

It basically moves all SliverAppBar tests into their own file, leaving just AppBar tests in the original file.

42add0f8

Roll Flutter Engine from 2d2d88068a23 to 8e7df85f7d11 (2 revisions) (#142583) · c65ab4d5

engine-flutter-autoroll authored Jan 31, 2024

https://github.com/flutter/engine/compare/2d2d88068a23...8e7df85f7d11

2024-01-31 skia-flutter-autoroll@skia.org Roll Skia from bf27636582c7 to 1fbb575f968d (1 revision) (flutter/engine#50190)
2024-01-31 kustermann@google.com More correctly name methods regarding event loop that are currently named microtask (flutter/engine#50138)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

c65ab4d5

Add `DropdownMenu.focusNode` (#142516) · 16e014e8

Ian Hickson authored Jan 31, 2024

fixes [`DropdownMenu` doesn't have a focusNode](https://github.com/flutter/flutter/issues/142384)

### Code sample

<details>
<summary>expand to view the code sample</summary> 

```dart
import 'package:flutter/material.dart';

enum TShirtSize {
  s('S'),
  m('M'),
  l('L'),
  xl('XL'),
  xxl('XXL'),
  ;

  const TShirtSize(this.label);
  final String label;
}

void main() => runApp(const MyApp());

class MyApp extends StatefulWidget {
  const MyApp({super.key});

  @override
  State<MyApp> createState() => _MyAppState();
}

class _MyAppState extends State<MyApp> {
  final FocusNode _focusNode = FocusNode();

  @override
  void dispose() {
    _focusNode.dispose();
    super.dispose();
  }

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      debugShowCheckedModeBanner: false,
      home: Scaffold(
        appBar: AppBar(
          title: const Text('DropdownMenu Sample'),
        ),
        body: Center(
          child: DropdownMenu<TShirtSize>(
            focusNode: _focusNode,
            initialSelection: TShirtSize.m,
            label: const Text('T-Shirt Size'),
            dropdownMenuEntries: TShirtSize.values.map((e) {
              return DropdownMenuEntry<TShirtSize>(
                value: e,
                label: e.label,
              );
            }).toList(),
          ),
        ),
        floatingActionButton: FloatingActionButton.extended(
          onPressed: () {
            _focusNode.requestFocus();
          },
          label: const Text('Request Focus on DropdownMenu'),
        ),
      ),
    );
  }
}
```

</details>

16e014e8

Marks Windows_android native_assets_android to be unflaky (#140042) · 4af2051f

Flutter GitHub Bot authored Jan 31, 2024

<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Windows_android native_assets_android"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Windows_android%20native_assets_android%22).
This test can be marked as unflaky.

4af2051f

Marks Linux_pixel_7pro... · 3a442ab4

Flutter GitHub Bot authored Jan 31, 2024

Marks Linux_pixel_7pro complex_layout_scroll_perf_impeller_gles__timeline_summary to be unflaky (#140039)

<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Linux_pixel_7pro complex_layout_scroll_perf_impeller_gles__timeline_summary"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Linux_pixel_7pro%20complex_layout_scroll_perf_impeller_gles__timeline_summary%22).
This test can be marked as unflaky.

3a442ab4

Marks Linux_android native_assets_android to be unflaky (#140040) · 19aa1ed9

Flutter GitHub Bot authored Jan 31, 2024

<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Linux_android native_assets_android"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Linux_android%20native_assets_android%22).
This test can be marked as unflaky.

19aa1ed9

Marks Mac_android native_assets_android to be unflaky (#140041) · ae49afa4

Flutter GitHub Bot authored Jan 31, 2024

<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Mac_android native_assets_android"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Mac_android%20native_assets_android%22).
This test can be marked as unflaky.

ae49afa4

Marks Mac flavors_test_macos to be unflaky (#140647) · 6379378c

Flutter GitHub Bot authored Jan 31, 2024

<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Mac flavors_test_macos"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Mac%20flavors_test_macos%22).
This test can be marked as unflaky.

6379378c

Roll Flutter Engine from 588f06b02664 to 2d2d88068a23 (1 revision) (#142569) · daf8d5fe

engine-flutter-autoroll authored Jan 31, 2024

https://github.com/flutter/engine/compare/588f06b02664...2d2d88068a23

2024-01-31 skia-flutter-autoroll@skia.org Roll Skia from 76da7ec3e106 to bf27636582c7 (1 revision) (flutter/engine#50187)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

daf8d5fe

Roll Flutter Engine from e6e1d6b3d035 to 588f06b02664 (1 revision) (#142566) · 1e8c7519

engine-flutter-autoroll authored Jan 31, 2024

https://github.com/flutter/engine/compare/e6e1d6b3d035...588f06b02664

2024-01-30 skia-flutter-autoroll@skia.org Roll Skia from 62cab132c9ad to 76da7ec3e106 (1 revision) (flutter/engine#50186)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

1e8c7519

M3 - Fix Chip icon and label colors (#140573) · 20dc5cbc
David Martos authored Jan 31, 2024

20dc5cbc

Roll Flutter Engine from d20ed240ace9 to e6e1d6b3d035 (3 revisions) (#142564) · 1f573e02

engine-flutter-autoroll authored Jan 31, 2024

https://github.com/flutter/engine/compare/d20ed240ace9...e6e1d6b3d035

2024-01-30 skia-flutter-autoroll@skia.org Roll Dart SDK from 734aae9604e8 to 488e33cd39de (1 revision) (flutter/engine#50185)
2024-01-30 jonahwilliams@google.com [Impeller] Reland: add interface for submitting multiple command buffers at once. (flutter/engine#50180)
2024-01-30 iinozemtsev@google.com Support running sound null safe kernels from flutter_jit_runner (flutter/engine#50002)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

1f573e02

30 Jan, 2024 6 commits

Be less verbose in CI for customer_testing, and revert old timeout hack (#139611) · cd444534

Ian Hickson authored Jan 30, 2024

This PR does two things. First, it reduces the verbosity in the customer_testing shard. We want to be less verbose because it's nigh on impossible to find anything when there's a failure in the verbose logs. Also, some additional comments are added to make following the breadcrumbs easier for the next person.

Second, it reverts a timeout that had been set to 90 minutes a while ago. It's no longer needed.

Fixes https://github.com/flutter/flutter/issues/120901.

cd444534

use PDI to end the isolated scope for RLI (#141345) · 9ed650ae

Kohei Seino authored Jan 30, 2024

will fix https://github.com/flutter/flutter/issues/141344

https://unicode.org/reports/tr9/#Explicit_Directional_Isolates
https://api.flutter.dev/flutter/foundation/Unicode/RLI-constant.html

9ed650ae

Style correctness improvements for toStrings and related fixes (#142485) · abebd340

Ian Hickson authored Jan 30, 2024

Children should be omitted from debugFillProperties (if they really need to be included they should be in debugDescribeChildren, but in general for widgets we don't bother including them since they are eventually included anyway).

toStrings should not contain newlines (or, ideally, should use Diagnosticable).

Also some minor tweaks to match grammar and style guide conventions.

abebd340

Roll Flutter Engine from 500ae6c4d947 to d20ed240ace9 (1 revision) (#142554) · 176b439d

engine-flutter-autoroll authored Jan 30, 2024

https://github.com/flutter/engine/compare/500ae6c4d947...d20ed240ace9

2024-01-30 skia-flutter-autoroll@skia.org Roll Skia from 739b66191c66 to 62cab132c9ad (2 revisions) (flutter/engine#50181)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

176b439d

Bump codecov/codecov-action from 3.1.5 to 3.1.6 (#142553) · c40acdad

dependabot[bot] authored Jan 30, 2024

Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 3.1.5 to 3.1.6.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/codecov/codecov-action/releases">codecov/codecov-action's releases</a>.</em></p>
<blockquote>
<h2>v3.1.6</h2>
<p><strong>Full Changelog</strong>: <a href="https://github.com/codecov/codecov-action/compare/v3.1.5...v3.1.6">https://github.com/codecov/codecov-action/compare/v3.1.5...v3.1.6</a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/codecov/codecov-action/commit/ab904c41d6ece82784817410c45d8b8c02684457"><code>ab904c4</code></a> chore(release): bump to 3.1.6</li>
<li><a href="https://github.com/codecov/codecov-action/commit/a8c374ae465f56cbb2da206950e903ad74b01bff"><code>a8c374a</code></a> Revert &quot;action.yml: Update to Node.js 20 (<a href="https://redirect.github.com/codecov/codecov-action/issues/1228">#1228</a>)&quot;</li>
<li>See full diff in <a href="https://github.com/codecov/codecov-action/compare/4fe8c5f003fae66aa5ebb77cfd3e7bfbbda0b6b0...ab904c41d6ece82784817410c45d8b8c02684457">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=codecov/codecov-action&package-manager=github_actions&previous-version=3.1.5&new-version=3.1.6)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

c40acdad

Roll Flutter Engine from cd12316a0883 to 500ae6c4d947 (1 revision) (#142551) · d35c08e9

engine-flutter-autoroll authored Jan 30, 2024

https://github.com/flutter/engine/compare/cd12316a0883...500ae6c4d947

2024-01-30 35989475+MeandNi@users.noreply.github.com Revert "Close connection on keyboard close (#41500)" (flutter/engine#49366)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

d35c08e9