- 11 Feb, 2021 2 commits
-
-
Jenn Magder authored
-
Jenn Magder authored
-
- 27 Jan, 2021 1 commit
-
-
Jonah Williams authored
* opt out the flutter tool * oops EOF * fix import * Update tool_backend.dart * Update daemon_client.dart * fix more
-
- 22 Jan, 2021 2 commits
-
-
Jonah Williams authored
-
Jonah Williams authored
-
- 20 Nov, 2020 1 commit
-
-
Jonah Williams authored
-
- 29 Oct, 2020 1 commit
-
-
Angjie Li authored
Support --web-renderer options which would allow user to specify which rendering backend to use. (#68848)
-
- 09 Oct, 2020 1 commit
-
-
James D. Lin authored
[flutter tools] Add a DelegatingLogger class Move most of `DelegateLogger` `from test/src/testbed.dart` to `lib/src/base/logger.dart` to better formalize the common practice of chaining `Logger`s together. I renamed the class since it isn't itself the delegate and to better match the `Delegating...` classes from `package:collection`. Additionally, add a freestanding `asLogger<T>` function to "cast" a `Logger` into a matching delegate if possible. This will allow `Logger` chains to be ordered a *bit* more freely (e.g. `NotifyingLogger` and `AppRunLogger` will no longer required to be at the end of the chain, an unwritten rule that has led to breakage in google3). Chain order still matters since lack of virtual dispatch means that parent `Logger`s can never invoke child methods, however. I made `asLogger<T>` a freestanding function because I didn't want to make it part of the `Logger` interface (and I thought that making it an extension method might be weird). Bonus cleanup: There no longer appears to be a way to construct an `AppRunLogger` with a null parent, so remove all of code paths for that case and make the `parent` construction parameter required.
-
- 30 Sep, 2020 1 commit
-
-
Jonah Williams authored
Re-arrange the implementation of the devtools launcher so that google3 is not required to depend on any devtools packages. Also renames the build_runner folders to isolated to better clarify their intention.
-
- 21 Sep, 2020 1 commit
-
-
Jonah Williams authored
The k toggle allows switching between canvaskit and html backend at runtime. unfortunately this causes hot restart to break, since the dart_sdk modules stores state at runtime. The recommendation will be to use cavaskit via dart-defines.
-
- 17 Sep, 2020 1 commit
-
-
Jonah Williams authored
[flutter_tools] use flutter tool handler for dwds resources and precache tool pub dependencies (#65814) If the tool is downloaded from a precompiled snapshot, or if the backing source files in the pub cache are deleted, the dwds debugging functionality will break as the client.js file cannot be located. Instead use the PackageConfig to verify that package location, downloading if it is missing. Override the dwds middleware to avoid Isolate.resolvePackageUri Fixes #53644 Fixes #65475
-
- 20 Jul, 2020 1 commit
-
-
Jonah Williams authored
To support #61407 , the tool needs to check if a single widget reload is feasible, and then conditionally perform a fast reassemble. To accomplish this, the FlutterDevice class will have a WidgetCache injected. This will eventually contain the logic for parsing the invalidated dart script. Concurrent with the devFS update, the widget cache will be updated/checked if a single widget reload is feasible. If so, an expression evaluation with the target type is performed and the success is communicated through the devFS result. An integration test which demonstrates that this works is already present in https://github.com/flutter/flutter/blob/master/packages/flutter_tools/test/integration.shard/hot_reload_test.dart#L86 Finally, when actually performing the reassemble the tool simply checks if this flag has been set and calls the alternative reassemble method. Cleanups: Remove modules, as this is unused now.
-
- 15 Jul, 2020 1 commit
-
-
Jonah Williams authored
Allow configuring the flutter_manifest to support a synthetic package, this is done through flutter: generate: true. When running pub get, insert a flutter_gen entry into the packages if it does not already exist. This points to .dart_tool/flutter_gen, which can be updated to contain the generated intl sources (But doesn't currently) Adds an integration test that verifies this code can be run and imported when enabled. Part of #60914
-
- 13 Jul, 2020 1 commit
-
-
Dan Field authored
* Optionally invert oversized images
-
- 10 Jul, 2020 1 commit
-
-
Jenn Magder authored
-
- 30 Jun, 2020 2 commits
-
-
Jonah Williams authored
In web debug mode, infer sound null safety by default. When sound null safety is enabled, provide a separate dill and precompiled Dart SDK. Release builds do not need this setting since we run dart2js from source. Fixes #59873
-
Jonah Williams authored
The flutter daemon unconditionally waits for the appFinished signal, even if startup failed. Ensure this future is correctly completed if there is a failure in ResidentRunner.run and not just ResidentRunner.attach. Adds regression tests for run release, debug, debug web, and release web. Adds missing try catch in cold runner startup. Manually tested with release/debug on Android and release/debug on web. Fixes #60613
-
- 26 Jun, 2020 1 commit
-
-
Jonah Williams authored
Last batch of test fixes for general shard.
-
- 25 Jun, 2020 1 commit
-
-
Jonah Williams authored
The global packages path could cause tests to fail when it would be overriden to unexpected (in test setup) values. Remove most usage and make it a configuration on buildInfo, along with most other build information. Cleanup the asset builder to require the .packages path and the resident runners to no longer require it, since they already have the information in build_info. It needs to stick around for the fuchsia deps we do not control. Filled #60232 for remaining work.
-
- 24 Jun, 2020 1 commit
-
-
Jonah Williams authored
Fix tests broken under tester
-
- 18 Jun, 2020 1 commit
-
-
Jonah Williams authored
A frequent request from the last Flutter developer survey was for an easier method of testing light/dark mode changes. Currently, a user needs to manually change the theme settings or adjust phone settings to see the difference. Instead we should add a toggle from the CLI, and eventually devtools/Intellij/Vscode that allows developers to override the current setting. Fixes #59495 Adds flutter.ext.brightnessOverride service protocol which either queries the current platform brightness, or overrides it to a new value. This accepts either Brightness.light or Brightness.dark as a value. Adds a CLI toggle b which allows the setting to be toggled manually. Requires an update to the MediaQuery, to conditionally use a debug override when not in release mode
-
- 09 Jun, 2020 1 commit
-
-
Helin Shiah authored
-
- 08 Jun, 2020 3 commits
-
-
Jonah Williams authored
This reverts commit f0174b17.
-
Jenn Magder authored
-
Helin Shiah authored
* Revert "Revert "Send text error in JSON and print in tools (#58284)" (#58872)" This reverts commit c2d5e18c. * Put streamListen in try/catch if extension events already listened for
-
- 06 Jun, 2020 2 commits
-
-
Jonah Williams authored
This reverts commit cce6b3c5.
-
Helin Shiah authored
* Send text error in JSON and print in tools * Add test for error text * Fix analysis issues * Move streamListen to try/catch and use global.printStatus * Extract print error fn and listen for events in web runner * Add extension listen request to test * Update packages/flutter_tools/lib/src/resident_runner.dart Co-authored-by: Jonah Williams <jonahwilliams@google.com> * Rename error parsing method * Allow crash if listen for extension stream fails * Add test for error and non-error extension events * Fix formatting for TextTreeRenderer * Use shorter message for second exceptions * Specify types for map * Add empty JSON for resident_web_runner test * Move stream listen to vmservice and add vmservice test * Fix stream type * Move structured error log definition to vmservice * Use correct test matcher isNot Co-authored-by: Jonah Williams <jonahwilliams@google.com>
-
- 04 Jun, 2020 1 commit
-
-
Jonah Williams authored
* [flutter_tools] only copy cached dill after startup * shared code * cleanup artifact directory * do not copy if dillOutputPath is given
-
- 02 Jun, 2020 1 commit
-
-
Jonah Williams authored
This reverts commit 39d1e4b7.
-
- 01 Jun, 2020 1 commit
-
-
Jonah Williams authored
Remove copying from the shutdown stage since that seems risky. If the tool copies the first compilation there will still be a decent dill for initialization.
-
- 08 May, 2020 1 commit
-
-
Bogdan Lukin authored
Workaround for cached web builds with --[no-]track-widget-creation flags. Similar PR: #23299
-
- 06 May, 2020 1 commit
-
-
Zachary Anderson authored
-
- 05 May, 2020 3 commits
-
-
Jonah Williams authored
Fixes #56194 Remove caching of FlutterView and poll forever if the list of flutter views is empty. Added test for missing release mode logic.
-
Jonah Williams authored
This reverts commit 209bdcb6.
-
Jonah Williams authored
Remove caching of FlutterView. Perhaps the FlutterView RPC might return an empty list if the VM is not quite up yet? We had some old logic to poll the flutter views RPC for up to 200ms. That doesn't seem like a great approach, so instead we could forgo it entirely and trust that either the views come up before the developer tries to interact, or we crash.
-
- 01 May, 2020 1 commit
-
-
Jonah Williams authored
-
- 24 Apr, 2020 1 commit
-
-
Jonah Williams authored
[flutter_tools] set test directory base as additional root, allow running without index.html (#55531)
-
- 22 Apr, 2020 1 commit
-
-
Jonah Williams authored
-
- 20 Apr, 2020 2 commits
-
-
Jonah Williams authored
-
Jonah Williams authored
-