Commits · ce1231d682e5608af0d688ae900d2c5e03cae357 · abdullh.alsoleman / Front-End

22 Nov, 2023 14 commits

Manual roll Flutter Engine from 342fb003b11f to f331e0afaf2e (9 revisions) (#138918) · ce1231d6

engine-flutter-autoroll authored Nov 22, 2023

Manual roll requested by jacksongardner@google.com

https://github.com/flutter/engine/compare/342fb003b11f...f331e0afaf2e

2023-11-22 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] pass const ref to binding helpers." (flutter/engine#48330)
2023-11-22 jacksongardner@google.com Revert "Manual roll Dart SDK from f1fd14505782 to df958dc1ca7b (6 revisions)" (flutter/engine#48325)
2023-11-22 jonahwilliams@google.com [Impeller] cache render target properties on Render Pass. (flutter/engine#48323)
2023-11-22 jonahwilliams@google.com [Impeller] pass const ref to binding helpers. (flutter/engine#48318)
2023-11-22 skia-flutter-autoroll@skia.org Roll Skia from 994558cd1fae to 30ecaac60b47 (1 revision) (flutter/engine#48324)
2023-11-22 skia-flutter-autoroll@skia.org Roll Skia from 9086788fc341 to 994558cd1fae (1 revision) (flutter/engine#48322)
2023-11-22 31859944+LongCatIsLooong@users.noreply.github.com Expose a few more glyph apis from `ui.Paragraph` (flutter/engine#47698)
2023-11-22 skia-flutter-autoroll@skia.org Roll Skia from efdec1f459ce to 9086788fc341 (2 revisions) (flutter/engine#48317)
2023-11-22 skia-flutter-autoroll@skia.org Manual roll Dart SDK from f1fd14505782 to df958dc1ca7b (6 revisions) (flutter/engine#48316)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

ce1231d6

Fix team-infra label in dependabot (#138917) · 094f529b

Michael Goderbauer authored Nov 22, 2023

As part of the new triage process (https://flutter.dev/go/triage-2023-rfc) the "team: infra" label was replaced by "team-infra"

094f529b

make FakeView not send Scene and semantics to the engine (#138849) · 14549b38

Yegor authored Nov 22, 2023

`FakeView` wraps the same underlying `FlutterView`. Sending semantics updates and Scene objects from multiple fake views into the same engine `FlutterView` violates contracts with the engine. This PR stubs out `render` and `updateSemantics` methods in `FakeView` classes to prevent that.

This unblocks https://github.com/flutter/engine/pull/48251, which implements multi-view semantics for web.

14549b38

Update the default outline color for `OutlinedButton` (#138768) · c7d4b32f

Qun Cheng authored Nov 22, 2023

Fix b/311343182

This is to update the default outline for `OutlinedButton`. When the button is focused, the outline color should be primary color.

c7d4b32f

Roll Flutter Engine from c954a64c509b to 342fb003b11f (1 revision) (#138903) · 843074c5

engine-flutter-autoroll authored Nov 22, 2023

https://github.com/flutter/engine/compare/c954a64c509b...342fb003b11f

2023-11-22 skia-flutter-autoroll@skia.org Roll Skia from 2c68a803f497 to efdec1f459ce (2 revisions) (flutter/engine#48315)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

843074c5

Roll Packages from c9933fc09a0b to 2102327ab9f2 (3 revisions) (#138895) · 721ee574

engine-flutter-autoroll authored Nov 22, 2023

https://github.com/flutter/packages/compare/c9933fc09a0b...2102327ab9f2

2023-11-22 mikemcguiness@protonmail.com [cross_file] adopt code excerpts in README (flutter/packages#5347)
2023-11-21 engine-flutter-autoroll@skia.org Manual roll Flutter from 9c9e0617 to ab721f93 (16 revisions) (flutter/packages#5461)
2023-11-21 kevmoo@users.noreply.github.com [url_launcher_web] migrate to pkg:web (flutter/packages#5451)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

721ee574

Marks Mac_build_test flutter_gallery__transition_perf_e2e_ios to be unflaky (#138886) · 29c95cda

Flutter GitHub Bot authored Nov 22, 2023

<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Mac_build_test flutter_gallery__transition_perf_e2e_ios"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Mac_build_test%20flutter_gallery__transition_perf_e2e_ios%22).
This test can be marked as unflaky.

29c95cda

Roll Flutter Engine from d55b673f895c to c954a64c509b (1 revision) (#138894) · 35a53b0b

engine-flutter-autoroll authored Nov 22, 2023

https://github.com/flutter/engine/compare/d55b673f895c...c954a64c509b

2023-11-22 skia-flutter-autoroll@skia.org Roll Skia from af2bd26a3a5e to 2c68a803f497 (1 revision) (flutter/engine#48311)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

35a53b0b

Add `commandHasTerminal` parameter + apple usage event + `sendException`... · 48187028

Elias Yishak authored Nov 22, 2023

Add `commandHasTerminal` parameter + apple usage event + `sendException` events for `package:unified_analytics` (#138806)

Relates to tracker issue:
- https://github.com/flutter/flutter/issues/128251

This PR includes 3 major updates:
- Adding the `commandHasTerminal` parameter for `Event.flutterCommandResult`
  - In `packages/flutter_tools/lib/src/runner/flutter_command.dart`
- Adding the new event for `sendException` from package:usage to be `Event.exception` (this event can be used by all dash tools)
  - In `packages/flutter_tools/lib/runner.dart`
- Migrating the generic `UsageEvent` which was only used for Apple related workflows for iOS and macOS. I did an initial analysis in this [sheet](https://docs.google.com/spreadsheets/d/11KJLkHXFpECMX7tw-trNkYSr5MHDG15XNGv6TgLjfQs/edit?resourcekey=0-j4qdvsOEEg3wQW79YlY1-g#gid=0) to identify all the call sites
  - Found in several files, highlighted in the sheet above

48187028

Roll Flutter Engine from 6c8f7b566a22 to d55b673f895c (1 revision) (#138890) · 67a602d7

engine-flutter-autoroll authored Nov 22, 2023

https://github.com/flutter/engine/compare/6c8f7b566a22...d55b673f895c

2023-11-22 skia-flutter-autoroll@skia.org Roll Skia from cc9006085362 to af2bd26a3a5e (1 revision) (flutter/engine#48307)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

67a602d7

Roll Flutter Engine from dda2499df48a to 6c8f7b566a22 (1 revision) (#138875) · b3f71ff3

engine-flutter-autoroll authored Nov 22, 2023

https://github.com/flutter/engine/compare/dda2499df48a...6c8f7b566a22

2023-11-22 skia-flutter-autoroll@skia.org Roll Skia from 143b6b5b91a5 to cc9006085362 (1 revision) (flutter/engine#48306)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

b3f71ff3

Roll Flutter Engine from 1ae1d5318257 to dda2499df48a (4 revisions) (#138872) · 9a9ee236

engine-flutter-autoroll authored Nov 22, 2023

https://github.com/flutter/engine/compare/1ae1d5318257...dda2499df48a

2023-11-22 skia-flutter-autoroll@skia.org Roll Skia from cebd44423589 to 143b6b5b91a5 (1 revision) (flutter/engine#48305)
2023-11-22 skia-flutter-autoroll@skia.org Roll Skia from 23b9316efd20 to cebd44423589 (1 revision) (flutter/engine#48304)
2023-11-22 jonahwilliams@google.com [Impeller] make host buffer state internally ref counted. (flutter/engine#48303)
2023-11-22 skia-flutter-autoroll@skia.org Roll Skia from b6f33389cefa to 23b9316efd20 (2 revisions) (flutter/engine#48302)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

9a9ee236

Roll Flutter Engine from 7cf9d90d59e1 to 1ae1d5318257 (8 revisions) (#138861) · 615481de

engine-flutter-autoroll authored Nov 22, 2023

https://github.com/flutter/engine/compare/7cf9d90d59e1...1ae1d5318257

2023-11-22 skia-flutter-autoroll@skia.org Roll Skia from cac28f3634a3 to b6f33389cefa (1 revision) (flutter/engine#48299)
2023-11-22 jonahwilliams@google.com [Impeller] Dont copy the paint until we're sure that the RRect blur optimization will apply. (flutter/engine#48298)
2023-11-21 matanlurey@users.noreply.github.com Finish making `shell/platform/linux/...` compatible with `.clang-tidy`. (flutter/engine#48297)
2023-11-21 matanlurey@users.noreply.github.com Finish making `shell/platform/android/...` compatible with `.clang-tidy`. (flutter/engine#48296)
2023-11-21 matanlurey@users.noreply.github.com Finish making `shell/common/...` compatible with `.clang-tidy`. (flutter/engine#48295)
2023-11-21 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from Q3HcTitDF90ZOPWDa... to IK4xyRtZkDwqT6pXA... (flutter/engine#48294)
2023-11-21 skia-flutter-autoroll@skia.org Roll Skia from c6d971f87d12 to cac28f3634a3 (12 revisions) (flutter/engine#48293)
2023-11-21 30870216+gaaclarke@users.noreply.github.com [Impeller] Switched to static linked libc++ in vulkan validation layers. (flutter/engine#48290)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from Q3HcTitDF90Z to IK4xyRtZkDwq

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

615481de

Revert "Reland VelocityTracker update (again)" (#138863) · b186c696

Jackson Gardner authored Nov 22, 2023

Reverts flutter/flutter#138843

This has broken the Mac_ios microbenchmarks_ios. Example failure:
https://ci.chromium.org/ui/p/flutter/builders/prod/Mac_ios%20microbenchmarks_ios/9339/overview

b186c696

21 Nov, 2023 18 commits

In `flutter doctor -v`, when JRE is too out-of-date to run `sdkmanager`, print... · cf09a8a2

Andrew Kolos authored Nov 21, 2023

In `flutter doctor -v`, when JRE is too out-of-date to run `sdkmanager`, print a helpful error message (#138762)

Closes https://github.com/flutter/flutter/issues/138132. See this issue for more information.

cf09a8a2

Roll Flutter Engine from a8e9b8dd562b to 7cf9d90d59e1 (1 revision) (#138847) · 9d9dbb78

engine-flutter-autoroll authored Nov 21, 2023

https://github.com/flutter/engine/compare/a8e9b8dd562b...7cf9d90d59e1

2023-11-21 matanlurey@users.noreply.github.com Yet more compliance with `.clang_tidy`, stragglers edition. (flutter/engine#48291)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

9d9dbb78

Roll Flutter Engine from 90d1ff04ae02 to a8e9b8dd562b (1 revision) (#138846) · ba433ebb

engine-flutter-autoroll authored Nov 21, 2023

https://github.com/flutter/engine/compare/90d1ff04ae02...a8e9b8dd562b

2023-11-21 jacksongardner@google.com Update skia build file to account for new skcms changes. (flutter/engine#48286)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

ba433ebb

Reland VelocityTracker update (again) (#138843) · 3e4e2809

Kate Lovett authored Nov 21, 2023

This updates the implementation to use the stopwatch from the Clock object and piping it through to the TestWidgetsFlutterBinding so it will be kept in sync with FakeAsync.

Relands https://github.com/flutter/flutter/pull/137381 which attempted to reland #132291
Fixes https://github.com/flutter/flutter/issues/97761

The original change was reverted due to flakiness it introduced in tests that use fling gestures.
* https://github.com/flutter/flutter/issues/135728

It was reverted again due to a change in the leak tracking tests that broke it.

3e4e2809

Roll Flutter Engine from 31799868224d to 90d1ff04ae02 (2 revisions) (#138844) · 50c9a377

engine-flutter-autoroll authored Nov 21, 2023

https://github.com/flutter/engine/compare/31799868224d...90d1ff04ae02

2023-11-21 matanlurey@users.noreply.github.com Make `{shell|lib/ui}/...` compatible with `.clang_tidy`. (flutter/engine#48242)
2023-11-21 jonahwilliams@google.com [Impeller] Ensure that overlay surfaces are constructed with wide gamut settings. (flutter/engine#48190)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

50c9a377

Fix M3 Tabs Specs links (#138808) · ccc3622e

Taha Tesser authored Nov 21, 2023

fixes [Material 3 Tab Specs links are broken/outdated ](https://github.com/flutter/flutter/issues/138805)

ccc3622e

Roll Flutter Engine from 0c2de1e8849c to 31799868224d (1 revision) (#138840) · e791c434

engine-flutter-autoroll authored Nov 21, 2023

https://github.com/flutter/engine/compare/0c2de1e8849c...31799868224d

2023-11-21 matanlurey@users.noreply.github.com Make `{flow|fml|impeller}/...` compatible with `.clang_tidy`. (flutter/engine#48241)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

e791c434

Roll Flutter Engine from 746697c27569 to 0c2de1e8849c (1 revision) (#138834) · 85e509d0

engine-flutter-autoroll authored Nov 21, 2023

https://github.com/flutter/engine/compare/746697c27569...0c2de1e8849c

2023-11-21 jonahwilliams@google.com [Impeller] preallocate command buffer to next power of two of entity list. (flutter/engine#48185)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

85e509d0

Roll Flutter Engine from 6da31e1bff67 to 746697c27569 (1 revision) (#138826) · ab721f93

engine-flutter-autoroll authored Nov 21, 2023

https://github.com/flutter/engine/compare/6da31e1bff67...746697c27569

2023-11-21 30870216+gaaclarke@users.noreply.github.com [Impeller] implements gaussian "blur halo" (flutter/engine#48149)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

ab721f93

Add mhbdev to AUTHORS (#138311) · 5ae1baeb

Mahdi Bagheri authored Nov 21, 2023

Reference: [author:mhbdev](https://github.com/flutter/flutter/issues?q=author%3Amhbdev)

5ae1baeb

Manual roll Flutter Engine from 70b1c7341255 to 6da31e1bff67 (10 revisions) (#138817) · 3cd723b4

engine-flutter-autoroll authored Nov 21, 2023

Manual roll requested by zra@google.com

https://github.com/flutter/engine/compare/70b1c7341255...6da31e1bff67

2023-11-21 zanderso@users.noreply.github.com Revert Dart SDK to 3.3.0-152.0.dev (flutter/engine#48272)
2023-11-21 ditman@gmail.com [web] Add add/removeView JS methods. (flutter/engine#48106)
2023-11-21 skia-flutter-autoroll@skia.org Roll Skia from c244996e79d6 to c6d971f87d12 (1 revision) (flutter/engine#48268)
2023-11-21 skia-flutter-autoroll@skia.org Roll Skia from 516357c42907 to c244996e79d6 (1 revision) (flutter/engine#48266)
2023-11-21 skia-flutter-autoroll@skia.org Roll Dart SDK from 99d9cf9bd05a to 5e7b22caba8a (1 revision) (flutter/engine#48264)
2023-11-21 skia-flutter-autoroll@skia.org Roll Dart SDK from 64cbfa6c51e6 to 99d9cf9bd05a (1 revision) (flutter/engine#48261)
2023-11-21 skia-flutter-autoroll@skia.org Roll Skia from 88a9e6328f93 to 516357c42907 (1 revision) (flutter/engine#48260)
2023-11-21 skia-flutter-autoroll@skia.org Roll Skia from a26e5a5771c8 to 88a9e6328f93 (1 revision) (flutter/engine#48259)
2023-11-21 skia-flutter-autoroll@skia.org Roll Skia from f8daeeb7f092 to a26e5a5771c8 (2 revisions) (flutter/engine#48258)
2023-11-21 skia-flutter-autoroll@skia.org Roll Dart SDK from f1fd14505782 to 64cbfa6c51e6 (1 revision) (flutter/engine#48257)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

3cd723b4

Fix Chips with Tooltip throw an assertion when enabling or disabling (#138799) · e6d43ac6

Taha Tesser authored Nov 21, 2023

fixes [Enabling or disabling a `Chip`/`RawChip` with a tooltip throws an exception](https://github.com/flutter/flutter/issues/138287) 

### Code sample

<details>
<summary>expand to view the code sample</summary> 

```dart
import 'package:flutter/material.dart';

void main() => runApp(const MyApp());

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    bool isEnabled = true;

    return MaterialApp(
      home: Material(
        child: Center(
          child: StatefulBuilder(
              builder: (BuildContext context, StateSetter setState) {
            return Column(
              mainAxisSize: MainAxisSize.min,
              children: [
                RawChip(
                  tooltip: 'This is a tooltip',
                  isEnabled: isEnabled,
                  label: const Text('RawChip'),
                  onPressed: isEnabled ? () {} : null,
                ),
                const SizedBox(height: 20),
                ElevatedButton(
                  onPressed: () {
                    setState(() {
                      isEnabled = !isEnabled;
                    });
                  },
                  child: Text('${isEnabled ? 'Disable' : 'Enable'} Chip'),
                )
              ],
            );
          }),
        ),
      ),
    );
  }
}
```

</details>

e6d43ac6

Roll Packages from c5443ad7e7e0 to c9933fc09a0b (2 revisions) (#138809) · 2a8eedf0

engine-flutter-autoroll authored Nov 21, 2023

https://github.com/flutter/packages/compare/c5443ad7e7e0...c9933fc09a0b

2023-11-20 engine-flutter-autoroll@skia.org Manual roll Flutter from 6cf9ab02 to 9c9e0617 (15 revisions) (flutter/packages#5453)
2023-11-20 41930132+hellohuanlin@users.noreply.github.com Update CODEOWNERS (flutter/packages#5452)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

2a8eedf0

Roll Flutter Engine from 3348fb0ca302 to 70b1c7341255 (1 revision) (#138774) · b6ef78e9

engine-flutter-autoroll authored Nov 21, 2023

https://github.com/flutter/engine/compare/3348fb0ca302...70b1c7341255

2023-11-21 33898039+designDo@users.noreply.github.com [PlatformView][Android]VirtualDisplay resize on Android31 and above (flutter/engine#47946)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

b6ef78e9

Roll Flutter Engine from f3e9b38a2588 to 3348fb0ca302 (1 revision) (#138772) · 2a216e33

engine-flutter-autoroll authored Nov 21, 2023

https://github.com/flutter/engine/compare/f3e9b38a2588...3348fb0ca302

2023-11-21 matanlurey@users.noreply.github.com [Impeller] Try replacing `*desc` with value/is_valid checks. (flutter/engine#48194)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

2a216e33

Roll Flutter Engine from 39fb4581cff2 to f3e9b38a2588 (3 revisions) (#138770) · 889c0836

engine-flutter-autoroll authored Nov 21, 2023

https://github.com/flutter/engine/compare/39fb4581cff2...f3e9b38a2588

2023-11-21 skia-flutter-autoroll@skia.org Roll Dart SDK from ee7aaca9adcc to f1fd14505782 (1 revision) (flutter/engine#48250)
2023-11-21 skia-flutter-autoroll@skia.org Roll Skia from 3876e576a38e to f8daeeb7f092 (1 revision) (flutter/engine#48249)
2023-11-20 skia-flutter-autoroll@skia.org Roll Skia from c9943f14039f to 3876e576a38e (3 revisions) (flutter/engine#48246)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

889c0836

Add dartdoc warnings (#138766) · 24b99e5d
Michael Goderbauer authored Nov 21, 2023
```
Follow-up to https://github.com/flutter/flutter/pull/138760.
```
24b99e5d

Roll Flutter Engine from 6e8e55ef1a7f to 39fb4581cff2 (2 revisions) (#138765) · 2e78cbce

engine-flutter-autoroll authored Nov 21, 2023

https://github.com/flutter/engine/compare/6e8e55ef1a7f...39fb4581cff2

2023-11-20 matanlurey@users.noreply.github.com Make `runtime/...` and `shell/common/...` compatible with `.clang-tidy`. (flutter/engine#48158)
2023-11-20 63278936+hongeSunCoder@users.noreply.github.com Fix embedder glfw examples cmake subdirectory path error (flutter/engine#48013)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

2e78cbce

20 Nov, 2023 8 commits

Added Features requested in #137530 (#137532) · 1dafa400

Mahdi Bagheri authored Nov 20, 2023

This PR will add new parameters to `ExpansionTile` widget to manage `dense`, `visualDensity` and `enableFeedback` of the main ListTile.

Solves #137530 

It is not a breaking change.

1dafa400

Bump dartdoc to 7.0.2 (#138760) · 5350da67
Sam Rawlins authored Nov 20, 2023

5350da67

Roll Flutter Engine from 7a31543b4630 to 6e8e55ef1a7f (4 revisions) (#138761) · e002b2da

engine-flutter-autoroll authored Nov 20, 2023

https://github.com/flutter/engine/compare/7a31543b4630...6e8e55ef1a7f

2023-11-20 matanlurey@users.noreply.github.com Silence a lint in `common/settings.h` in order to turn on `clang_tidy`. (flutter/engine#48239)
2023-11-20 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from LnToEykA8o68jv58K... to Q3HcTitDF90ZOPWDa... (flutter/engine#48244)
2023-11-20 skia-flutter-autoroll@skia.org Roll Skia from 2bcc2e8682a6 to c9943f14039f (1 revision) (flutter/engine#48243)
2023-11-20 matanlurey@users.noreply.github.com Make `vulkan/...` compatible with `.clang_tidy`. (flutter/engine#48240)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from LnToEykA8o68 to Q3HcTitDF90Z

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

e002b2da

[Reland] Introduce `AnimationStyle` (#138721) · fc917c71

Taha Tesser authored Nov 20, 2023

This PR introduces `AnimationStyle`, it is used to override default
animation curves and durations in several widgets.

fixes [Add the ability to customize MaterialApp theme animation
duration](https://github.com/flutter/flutter/issues/78372)
fixes [Allow customization of showMenu transition animation curves and
duration](https://github.com/flutter/flutter/issues/135638)
fixes [`AnimationStyle.noAnimation` needs to replace `AnimatedTheme`
with just `Theme` in the
`MaterialApp`](https://github.com/flutter/flutter/issues/138618)

Here is an example where popup menu curve and transition duration is
overridden:

```dart
          popUpAnimationStyle: AnimationStyle(
            curve: Easing.emphasizedAccelerate,
            duration: Durations.medium4,
          ),
```

Set `AnimationStyle.noAnimation` to disable animation.
```dart
    return MaterialApp(
      themeAnimationStyle: AnimationStyle.noAnimation,
```

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat

fc917c71

Roll Flutter Engine from 337ab58e81f7 to 7a31543b4630 (2 revisions) (#138759) · 2c9d9665

engine-flutter-autoroll authored Nov 20, 2023

https://github.com/flutter/engine/compare/337ab58e81f7...7a31543b4630

2023-11-20 matanlurey@users.noreply.github.com [Impeller] Write a text-decoration test at the `dart:ui` layer (flutter/engine#48101)
2023-11-20 skia-flutter-autoroll@skia.org Roll Skia from 69213ba6f68a to 2bcc2e8682a6 (1 revision) (flutter/engine#48238)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

2c9d9665

Reland update bottom navigation bar test for m3 (#137998) · 1a9e866f

Bruno Leroux authored Nov 20, 2023

This is a reland of https://github.com/flutter/flutter/pull/136624 which was reverted because one new M3 golden test failed. The failure was related to the ink sparkle animation.

Ink sparkle is the M3 default animation, it does not play well with golden because it introduces an element of randomness.
One way to avoid this randomness is to use the `InkSparkle.constantTurbulenceSeedSplashFactory`.

This PR has two commits:
- the first one is the original PR (https://github.com/flutter/flutter/pull/136624).
- the second one updates the failing test using `InkSparkle.constantTurbulenceSeedSplashFactory`.

1a9e866f

Roll Flutter Engine from 215853171cdc to 337ab58e81f7 (3 revisions) (#138751) · 9c9e0617

engine-flutter-autoroll authored Nov 20, 2023

https://github.com/flutter/engine/compare/215853171cdc...337ab58e81f7

2023-11-20 reidbaker@google.com Protect sdk upload script from missing ndk, add documentation for checking write access, improve comments to add context (flutter/engine#47989)
2023-11-20 skia-flutter-autoroll@skia.org Roll Dart SDK from 09bd5d71062d to ee7aaca9adcc (1 revision) (flutter/engine#48237)
2023-11-20 skia-flutter-autoroll@skia.org Roll Skia from 151d297efcf5 to 69213ba6f68a (2 revisions) (flutter/engine#48236)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

9c9e0617

Roll Flutter Engine from 255f967a3938 to 215853171cdc (2 revisions) (#138746) · 5dbf7f30

engine-flutter-autoroll authored Nov 20, 2023

https://github.com/flutter/engine/compare/255f967a3938...215853171cdc

2023-11-20 skia-flutter-autoroll@skia.org Roll Skia from e9206d29ef07 to 151d297efcf5 (1 revision) (flutter/engine#48235)
2023-11-20 skia-flutter-autoroll@skia.org Roll Skia from 795a259c2f56 to e9206d29ef07 (3 revisions) (flutter/engine#48231)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

5dbf7f30