- 21 Jun, 2016 2 commits
-
-
Adam Barth authored
This required switching from the Future-based bindings to the callback-based bindings.
-
Ian Hickson authored
Anywhere that accepted IconData now accepts either an Icon or an ImageIcon. Places that used to take an IconData in an `icon` argument, notably IconButton and DrawerItem, now take a Widget in that slot. You can wrap the value that used to be passed in in an Icon constructor to get the same result. Icon itself now takes the icon as a positional argument, for brevity. ThemeData now has an iconTheme as well as a primaryIconTheme, the same way it has had a textTheme and primaryTextTheme for a while. IconTheme.of() always returns a value now (though that value itself may have nulls in it). It defaults to the ThemeData.iconTheme. IconThemeData.fallback() is a new method that returns an icon theme data structure with all fields filled in. IconTheme.merge() is a new constructor that takes a context and creates a widget that mixes in the new values with the inherited values. Most places that introduced an IconTheme widget now use IconTheme.merge. IconThemeData.merge and IconThemeData.copyWith act in a way analogous to the similarly-named members of TextStyle. ImageIcon is introduced. It acts like Icon but takes an ImageProvider instead of an IconData. Also: Fix the analyzer to actually check the stocks app.
-
- 18 Jun, 2016 1 commit
-
-
Adam Barth authored
Fixes #4553
-
- 16 Jun, 2016 1 commit
-
-
Ian Hickson authored
Overview ======== This patch refactors images to achieve the following goals: * it allows references to unresolved assets to be passed around (previously, almost every layer of the system had to know about whether an image came from an asset bundle or the network or elsewhere, and had to manually interact with the image cache). * it allows decorations to use the same API for declaring images as the widget tree. It requires some minor changes to call sites that use images, as discussed below. Widgets ------- Change this: ```dart child: new AssetImage( name: 'my_asset.png', ... ) ``` ...to this: ```dart child: new Image( image: new AssetImage('my_asset.png'), ... ) ``` Decorations ----------- Change this: ```dart child: new DecoratedBox( decoration: new BoxDecoration( backgroundImage: new BackgroundImage( image: DefaultAssetBundle.of(context).loadImage('my_asset.png'), ... ), ... ), child: ... ) ``` ...to this: ```dart child: new DecoratedBox( decoration: new BoxDecoration( backgroundImage: new BackgroundImage( image: new AssetImage('my_asset.png'), ... ), ... ), child: ... ) ``` DETAILED CHANGE LOG =================== The following APIs have been replaced in this patch: * The `AssetImage` and `NetworkImage` widgets have been split in two, with identically-named `ImageProvider` subclasses providing the image-loading logic, and a single `Image` widget providing all the widget tree logic. * `ImageResource` is now `ImageStream`. Rather than configuring it with a `Future<ImageInfo>`, you complete it with an `ImageStreamCompleter`. * `ImageCache.load` and `ImageCache.loadProvider` are replaced by `ImageCache.putIfAbsent`. The following APIs have changed in this patch: * `ImageCache` works in terms of arbitrary keys and caches `ImageStreamCompleter` objects using those keys. With the new model, you should never need to interact with the cache directly. * `Decoration` can now be `const`. The state has moved to the `BoxPainter` class. Instead of a list of listeners, there's now just a single callback and a `dispose()` method on the painter. The callback is passed in to the `createBoxPainter()` method. When invoked, you should repaint the painter. The following new APIs are introduced: * `AssetBundle.loadStructuredData`. * `SynchronousFuture`, a variant of `Future` that calls the `then` callback synchronously. This enables the asynchronous and synchronous (in-the-cache) code paths to look identical yet for the latter to avoid returning to the event loop mid-paint. * `ExactAssetImage`, a variant of `AssetImage` that doesn't do anything clever. * `ImageConfiguration`, a class that describes parameters that configure the `AssetImage` resolver. The following APIs are entirely removed by this patch: * `AssetBundle.loadImage` is gone. Use an `AssetImage` instead. * `AssetVendor` is gone. `AssetImage` handles everything `AssetVendor` used to handle. * `RawImageResource` and `AsyncImage` are gone. The following code-level changes are performed: * `Image`, which replaces `AsyncImage`, `NetworkImage`, `AssetImage`, and `RawResourceImage`, lives in `image.dart`. * `DecoratedBox` and `Container` live in their own file now, `container.dart` (they reference `image.dart`). DIRECTIONS FOR FUTURE RESEARCH ============================== * The `ImageConfiguration` fields are mostly aspirational. Right now only `devicePixelRatio` and `bundle` are implemented. `locale` isn't even plumbed through, it will require work on the localisation logic. * We should go through and make `BoxDecoration`, `AssetImage`, and `NetworkImage` objects `const` where possible. * This patch makes supporting animated GIFs much easier. * This patch makes it possible to create an abstract concept of an "Icon" that could be either an image or a font-based glyph (using `IconData` or similar). (see https://github.com/flutter/flutter/issues/4494) RELATED ISSUES ============== Fixes https://github.com/flutter/flutter/issues/4500 Fixes https://github.com/flutter/flutter/issues/4495 Obsoletes https://github.com/flutter/flutter/issues/4496
-
- 12 Jun, 2016 1 commit
-
-
Adam Barth authored
We now use the `@required` annotation to encourage developers to explicitly set onPressed and onChanged callbacks to null when that would disable the widget. Fixes #287
-
- 08 Jun, 2016 1 commit
-
-
Ian Hickson authored
Also, make sure that the parent is notified when they change. Fixes #2298
-
- 31 May, 2016 1 commit
-
-
Ian Hickson authored
-
- 29 May, 2016 1 commit
-
-
Adam Barth authored
The new mojom.dart code makes mocking services a bit tricky. I've filed https://github.com/domokit/mojo/issues/786 about improving that.
-
- 12 May, 2016 1 commit
-
-
pq authored
It's safe to remove the unneeded `void`s from setters since the blocking issues in the `always_declare_return_types` lint have been fixed (https://github.com/dart-lang/linter/). We can also safely flip the bit on `avoid_return_types_on_setters`.
-
- 09 May, 2016 1 commit
-
-
Jason Simmons authored
-
- 04 May, 2016 1 commit
-
-
pq authored
Last fixes to get the repo running clean checking for annotations on list and map literals.
-
- 29 Apr, 2016 1 commit
-
-
Adam Barth authored
Turns out there were more clients of the old paragraph API than I expected. This patch migrates them to the new API.
-
- 28 Apr, 2016 1 commit
-
-
Adam Barth authored
Cassowary doesn't have any additional dependencies and this simplifies things. Fixes #2442
-
- 27 Apr, 2016 1 commit
-
-
Adam Barth authored
These uses cases are now address by http.dart via http.readDataPipe.
-
- 22 Apr, 2016 1 commit
-
-
Ian Hickson authored
The old names were getting silly and started stepping on valuable namespace. The new names are consistent and clear.
-
- 21 Apr, 2016 1 commit
-
-
Ian Hickson authored
Previously the widgets layer only provided a concrete binding, which makes it awkward to extend it compared to other bindings. This moves widgets to the same style as the other layers. In a subsequent patch I'll use this to make the tests layer saner.
-
- 20 Apr, 2016 1 commit
-
-
Ian Hickson authored
The 'routes' table is a point of confusion with new developers. By providing a 'home' argument that sets the '/' route, we can delay the point at which we teach developers about 'routes' until the point where they want to have a second route.
-
- 15 Apr, 2016 1 commit
-
-
krisgiesing authored
-
- 13 Apr, 2016 1 commit
-
-
Ian Hickson authored
...by adding tests to our examples that don't import flutter_test, which pins the relevant dependencies. Also, provide more information when complaining about leaked transient callbacks in tests. Also, make tests display full information when they have an exception, by bypassing the throttling we have for Android logging in tests. Also, make the word wrapping not wrap stack traces if they happen to be included in exception output. Also, fix a leaked transient callback in the checkbox code.
-
- 12 Apr, 2016 1 commit
-
-
Ian Hickson authored
This also shrinks the width of the error messages a bit because now that we use 'package:' URLs the stacks are a bit narrower.
-
- 11 Apr, 2016 1 commit
-
-
Ian Hickson authored
I ran into a case where I was setting minHeight=∞ and then calling layout() with that constraint, which is all kinds of bad. To try to catch this earlier, this patch now provides a way to catch constraints that are requiring infinite values. We don't _always_ check this because there are valid uses for BoxConstraints.biggest, e.g. as an additionalConstraint.
-
- 31 Mar, 2016 2 commits
-
-
Kris Giesing authored
-
Kris Giesing authored
Adds BuildOwner to manage the dirty list and build processing for widgets/elements, and adds a widget unit test to make sure separation is enforced. Fixes #2723
-
- 29 Mar, 2016 1 commit
-
-
Adam Barth authored
Adds some names for common FractionalOffset values.
-
- 24 Mar, 2016 1 commit
-
-
Hixie authored
Previously, border with '0' was ambiguous. Sometimes we treated it as hairline borders, sometimes as "don't show the border", though even in the latter case we did some graphics work sometimes. Now we have an explicit BorderStyle.none flag to not draw the border efficiently.
-
- 21 Mar, 2016 1 commit
-
-
Ian Hickson authored
Also misc cleanup: - reorder members to be more consistent and fit the style guide - remove use of _Pair - made Variable.applyUpdate and Variable.owner public - added docs to Priority, tweaked the code a bit - added some docs to Result - removed the internal-error Result (replaced with asserts) - removed unused Results - made Result const - merged some files together since they had used privates a lot I'm sorry this is completely unreviewable. I did the move from `lib/*` to `lib/src/*` first, then did the `part`-to-`import` change, and then found out how many of the files involved privates, which I wasn't expecting. I can redo this as multiple commits if that would make it easier to review.
-
- 17 Mar, 2016 1 commit
-
-
Adam Barth authored
We'll eventually remove Paragraph#paint. Fixes #2694
-
- 14 Mar, 2016 2 commits
-
-
Hixie authored
-
Adam Barth authored
Instead, require an AndroidManifest.xml and always build an APK. Fixes #2517
-
- 13 Mar, 2016 3 commits
-
-
Adam Barth authored
* justifyContent -> mainAxisAlignment * alignItems -> crossAxisAlignment * FlexJustifyContent -> MainAxisAlignment * FlexAlignItems -> CrossAxisAlignment Fixes #231
-
Adam Barth authored
* left -> leading (Removes an LTR bias) * center -> title (Widget was actually centered) * right -> actions (Removes an LTR bias, asymmetric with leading) Fixes #2348
-
Adam Barth authored
Fixes #2353
-
- 12 Mar, 2016 6 commits
-
-
Adam Barth authored
This patch renames StatelessComponent to StatelessWidget and StatefulComponent to StatefulWidget. Fixes #2308
-
Adam Barth authored
Fixes #1482
-
Adam Barth authored
Fixes #1382
-
Hixie authored
And fix the zillion issues that uncovered.
-
Ian Hickson authored
This reverts commit f41b3411, reversing changes made to e33d8d96. This was a bad check-in due to my mangling uploading a new version of the branch from a different machine. This reverts https://github.com/flutter/flutter/pull/2639 and will be replaced by https://github.com/flutter/flutter/pull/2640
-
Hixie authored
And fix the zillion issues that uncovered.
-
- 11 Mar, 2016 1 commit
-
-
Adam Barth authored
We'll need this for RTL support because the RTL state will live in the widget tree. Also, remove the `oldWidget` argument to updateRenderObject because there aren't any clients for it.
-
- 10 Mar, 2016 1 commit
-
-
Hixie authored
And fix a zillion omissions this uncovered.
-