- 07 Mar, 2019 1 commit
-
-
Dan Field authored
-
- 01 Mar, 2019 1 commit
-
-
Alexandre Ardhuin authored
* add trailing commas on list/map/parameters * add trailing commas on Invocation with nb of arg>1 * add commas for widget containing widgets * add trailing commas if instantiation contains trailing comma * revert bad change
-
- 23 Feb, 2019 1 commit
-
-
Dan Field authored
* Allow for gradle downloading missing SDK assets if SDK licenses are present. * Improvements for windows testing
-
- 22 Feb, 2019 1 commit
-
- 21 Feb, 2019 2 commits
-
-
Dan Field authored
* Allow for gradle downloading missing SDK assets if SDK licenses are present. * Fix license path for missing sdkmanager * Cirrus re-run... * Fix condition check * rename props, add docs, rename method * fix tests after param changes * Fix weird path for flutter run and add tests * remove print, fix tests
-
Alexandre Ardhuin authored
-
- 26 Jan, 2019 1 commit
-
-
Jonah Williams authored
-
- 16 Jan, 2019 1 commit
-
-
Vyacheslav Egorov authored
Newer NDKs switched to clang which by default uses system linker, instead we need to force it to use appropriate toolchain linker by passing -fuse-ld= command line flag. Fixes #23458
-
- 17 Dec, 2018 1 commit
-
-
Danny Tuppeny authored
* Fall back to ANDROID_SDK_ROOT if ANDROID_HOME is not set And update descriptions to use the non-deprecated ANDROID_SDK_ROOT. Fixes #15114. * Remove trailing whitespace * Update dev/devicelab/lib/framework/adb.dart Co-Authored-By:
DanTup <danny@tuppeny.com> * Reformat long line
-
- 06 Nov, 2018 1 commit
-
-
jslavitz authored
* Improves error message and adds test.
-
- 01 Oct, 2018 1 commit
-
-
Alexandre Ardhuin authored
-
- 12 Sep, 2018 1 commit
-
-
Alexandre Ardhuin authored
* enable lint unnecessary_new * fix tests * fix tests * fix tests
-
- 18 Aug, 2018 1 commit
-
-
Ian Hickson authored
* Fixes resulting from audit of issues links I looked at every link to GitHub in our repo. For cases where we had a TODO that was waiting for a bug to be fixed, and the bug has now been fixed, I applied the pending change. For cases where the link was out of date, I updated the link. * Update run_test.dart skip this test again since it failed on linux and macos bots
-
- 20 Jul, 2018 1 commit
-
-
Greg Spencer authored
-
- 28 Jun, 2018 2 commits
-
-
-
Danny Tuppeny authored
* Add --create option to flutter emulators * Tweaks to error message * Simplify emulator search logic * Make name optional * Add a note about this option being used with --create * Tweaks to help information * Switch to processManager for easier testing * Don't crash on missing files or missing properties in Android Emulator * Move name suffixing into emulator manager This allows it to be tested in the EmulatorManager tests and also used by daemon later if desired. * Pass the context's android SDK through so it can be mocked by tests * Misc fixes * Add tests around emulator creation Process calls are mocked to avoid needing a real SDK (and to be fast). Full integration tests may be useful, but may require ensuring all build environments etc. are set up correctly. * Simplify avdManagerPath Previous changes were to emulatorPath! * Fix lint errors * Fix incorrect file exgtension for Windows * Fix an issue where no system images would crash reduce throws on an empty collection. * Fix "null" appearing in error messages The name we attempted to use will now always be returned, even in the case of failure. * Add additional info to missing-system-image failure message On Windows after installing Andriod Studio I didn't have any of these and got this message. Installing with sdkmanager fixed the issue. * Fix thrown errors runResult had a toString() but we moved to ProcessResult when switching to ProcessManager to this ended up throwing "Instance of ProcessResult". * Fix package import * Fix more package imports * Move mock implementation into Mock class There seemed to be issues using Lists in args with Mockito that I couldn't figure out (docs say to use typed() but I couldn't make this compile with these lists still).. * Rename method that's ambigious now we have create * Handle where there's no avd path * Add another toList() :( * Remove comment that was rewritten * Fix forbidden import * Make optional arg more obviously optional * Reformat doc * Note that we create a pixel device in help text * Make this a named arg
-
- 18 May, 2018 1 commit
-
-
Greg Spencer authored
Our style guide says the k's are not necessary, and it seems like a good idea to make all the code be consistent on this. Only naming changes to private vars: no logic changes.
-
- 14 May, 2018 1 commit
-
-
Vyacheslav Egorov authored
* Search for a suitable ARM sysroot instead of hardcoding it; * Add facility to explain why NDK was not found;
-
- 09 May, 2018 5 commits
-
-
Danny Tuppeny authored
Added an exists check to ensure we don't try to run if emulator is missing, but that requires the file extension for Windows.
-
Danny Tuppeny authored
-
Danny Tuppeny authored
Windows sets HOMEDRIVE/HOMEPATH.
-
Danny Tuppeny authored
-
Danny Tuppeny authored
Very basic support for "flutter emulators" which just lists the available Android AVDs. Relates to: https://github.com/flutter/flutter/issues/14822 https://github.com/Dart-Code/Dart-Code/issues/490 https://github.com/flutter/flutter/issues/13379
-
- 04 Apr, 2018 1 commit
-
-
Todd Volkert authored
This reverts https://github.com/flutter/flutter/pull/16035
-
- 03 Apr, 2018 1 commit
-
-
Luke authored
Adds Java EE module to SDK manager environment to stop missing xml library exception when checking for licenses. (#16035)
-
- 01 Mar, 2018 1 commit
-
-
jcollins-g authored
-
- 28 Feb, 2018 1 commit
-
-
jcollins-g authored
* Revert "Revert "Add android license verification to doctor and some refactoring" (#14727)" This reverts commit d2602947. * Add tests, fix sdkManagerEnv and use it consistently, and rearrange Status object model * AnsiSpinner needs to leave the cursor where it found it. * fix tests * Const constructor warning only shows up on windows...? * Avoid crash if we can't find the home directory * Make pathVarSeparator return a string in the mock * Implement review comments * Fix out-of-order problem on stop
-
- 15 Feb, 2018 1 commit
-
-
Todd Volkert authored
Reports from that commit included: * Doctor hanging * Doctor prompting to install JDK * AnsiStatus.cancel() printing elapsed time and extra newline * Printing extra spinner character at the end of each line
-
- 14 Feb, 2018 1 commit
-
-
jcollins-g authored
* Initial version, seems to work * Unit test for android license checker * Cleanups * Windows analyzer wants const. * Refinements to timeout * review comments * Forgot a nit
-
- 02 Feb, 2018 1 commit
-
-
Alexandre Ardhuin authored
-
- 24 Jan, 2018 1 commit
-
-
Chris Bracken authored
Convenience getters for the the path to the Android SDK manager and the currently installed version of the tool. Pre-factoring to support better checks around the --android-licenses command, which uses a feature of the SDK manager that is unsupported in older versions of the tool.
-
- 21 Nov, 2017 1 commit
-
-
Martin Kustermann authored
* Add support for NDK discovery and add --prefer-shared-library option We would like to be able to use native tools (e.g. simpleperf, gdb) with precompiled flutter apps. The native tools work much better with *.so files instead of the custom formats the Dart VM uses by default. The reason for using blobs / instruction snapshots is that we do not want to force flutter users to install the Android NDK. This CL adds a `--prefer-shared-library` flag to e.g. `flutter build apk` which will use the NDK compiler (if available) to turn the precompiled app assembly file to an `*.so` file. If the NDK compiler is not available it will default to the default behavior. * Rebase, add test for NDK detection, augment flutter.gradle with @Input for flag * Use InMemoryFileSystem for test * Remove unused import * Address some analyzer warnings
-
- 17 Nov, 2017 1 commit
-
-
Todd Volkert authored
Previously, we were mapping certain named platforms (e.g. `android-stable`) to their corresponding version. this had two problems: 1. The version could become out of date. For instance, we had mapped `android-stable` to version 24, but the stable version is now 27. 2. The list of possible named versions wasn't comprehensive. Some Android SDKs just list the platform as `stable`, or `experimental`, etc. This change updates the platform version detection to use the `build.prop` file that exists in the platform directory (only for cases where the version number is not encoded into the directory name).
-
- 19 Jul, 2017 1 commit
-
-
Devon Carew authored
* pass the value of the android sdk * swap flag * allow the user to set the android-sdk location
-
- 22 Mar, 2017 1 commit
-
-
Jakob Andersen authored
* Remove unnecessary Android SDK checks. * Remove unused accessors, skip replay test.
-
- 13 Mar, 2017 1 commit
-
-
John McCutchan authored
Fixes #8618
-
- 07 Mar, 2017 1 commit
-
-
John McCutchan authored
* Request the user upgrade if the Android SDK version is 24 * Update android_sdk_test.dart * Update android_sdk.dart
-
- 04 Mar, 2017 1 commit
-
-
Chris Bracken authored
-
- 22 Feb, 2017 2 commits
-
-
Jakob Andersen authored
* Fix bug parsing Gradle version. Version from pub_semver requires versions of the format X.Y.Z. Gradle doesn't follow semantic versioning, though, so version parsing would fail on versions like '3.2'. Fixed by writing a custom Version class. Also removed a check for apksigner when building Gradle-based projects. Fixes #8298
-
Michael Goderbauer authored
This reverts commit 70d7fe3a. The Java version missmatch on the bots has been resolved.
-