- 23 Jan, 2024 1 commit
-
-
auto-submit[bot] authored
Reverts flutter/flutter#141541 Initiated by: yusuf-goog This change reverts the following previous change: Original Description: This PR introduces the first app in this repo that fully uses Gradle Kotlin DSL. It also fixes a bug I found in the process – fields of `FlutterExtensions` must be `public`.
-
- 22 Jan, 2024 1 commit
-
-
Bartek Pacia authored
This PR introduces the first app in this repo that fully uses Gradle Kotlin DSL. It also fixes a bug I found in the process â fields of `FlutterExtensions` must be `public`.
-
- 12 Jan, 2024 2 commits
-
-
Bartek Pacia authored
This PR has no issue. I got this cool idea and decided to quickly try it out, and it works. ### Summary This will allow Flutter Developers to have less code in their Android Gradle buildscripts. ```diff plugins { id "com.android.application" id "dev.flutter.flutter-gradle-plugin" id "kotlin-android" } -def localProperties = new Properties() -def localPropertiesFile = rootProject.file("local.properties") -if (localPropertiesFile.exists()) { - localPropertiesFile.withReader("UTF-8") { reader -> - localProperties.load(reader) - } -} - -def flutterVersionCode = localProperties.getProperty("flutter.versionCode") -if (flutterVersionCode == null) { - flutterVersionCode = "1" -} - -def flutterVersionName = localProperties.getProperty("flutter.versionName") -if (flutterVersionName == null) { - flutterVersionName = "1.0" -} - -def keystorePropertiesFile = rootProject.file("keystore.properties") -def keystoreProperties = new Properties() - keystoreProperties.load(new FileInputStream(keystorePropertiesFile)) android { applicationId "pl.baftek.discoverrudy" minSdk 21 targetSdk 34 - versionCode flutterVersionCode.toInteger() - versionName flutterVersionName + versionCode flutter.versionCode() + versionName flutter.versionName() } ``` The boilerplate that loads 'local.properties' can live in Flutter Gradle Plugin. ### Concerns I was worried about lifecycle/ordering issues, so I tested it. To Flutter Gradle Plugin, I added: ```diff class FlutterPlugin implements Plugin<Project> { //... @Override void apply(Project project) { + project.logger.quiet("Start applying FGP") // ... } } ``` and to my `android/app/build.gradle` I added: ```diff android { + logger.quiet("Start evaluating android block") namespace "pl.bartekpacia.awesomeapp" compileSdk 34 defaultConfig { applicationId "pl.baftek.discoverrudy" minSdk 21 targetSdk 34 versionCode flutter.versionCode() versionName flutter.versionName() } ``` Gradle first applies the plugins (which sets versionCode and versionName on FlutterExtension), and then it executes the `android {}` extension block: ``` $ ./gradlew :app:assembleDebug > Configure project :app Start applying FGP Start evaluating android block BUILD SUCCESSFUL in 2s 383 actionable tasks: 10 executed, 373 up-to-date ``` So ordering is fine.
-
Bartek Pacia authored
This PR resolves #140548. It's based on my work in #118067.
-
- 16 Nov, 2023 1 commit
-
-
Bruno Leroux authored
## Description This PR adds a new section to the Android manifest file. This section is required for https://github.com/flutter/engine/pull/44579 (because it uses `PackageManager.queryIntentActivities` API ), see: 1. https://developer.android.com/training/package-visibility?hl=en 2. https://developer.android.com/reference/android/content/Intent#ACTION_PROCESS_TEXT 3. https://developer.android.com/reference/android/content/pm/PackageManager?hl=en#queryIntentActivities(android.content.Intent,%20android.content.pm.PackageManager.ResolveInfoFlags) ## Related Issue Android manifest update for https://github.com/flutter/flutter/issues/107603 ## Tests This PR updates the integration tests and examples Android manifest files, this will help catch error or warning related to this change.
-
- 09 Nov, 2023 1 commit
-
-
Camille Simon authored
Re-lands https://github.com/flutter/flutter/pull/137191. The fix for the issue causing that PR to be reverted was tested in this PR but ultimately landed separately in https://github.com/flutter/flutter/pull/138093.
-
- 03 Nov, 2023 1 commit
-
-
auto-submit[bot] authored
Reverts flutter/flutter#137191 Initiated by: camsim99 This change reverts the following previous change: Original Description: Adds support for Android 34 in the following ways: - Bumps integration tests compile SDK versions 33 --> 34 - Bumps template compile SDK version 33 --> 34 - Also changes deprecated `compileSdkVersion` to `compileSdk` Part of https://github.com/flutter/flutter/issues/134220
-
- 02 Nov, 2023 2 commits
-
-
Camille Simon authored
Adds support for Android 34 in the following ways: - Bumps integration tests compile SDK versions 33 --> 34 - Bumps template compile SDK version 33 --> 34 - Also changes deprecated `compileSdkVersion` to `compileSdk` Part of https://github.com/flutter/flutter/issues/134220
-
Bartek Pacia authored
I'm removing an unneded block of configuration from the `settings.gradle` template. It was introduced by me in #123511. At that time, I did not know that it's unnecessary, and did not test removing it â sorry about that. I learned that it's unnecessary recently, when [I asked a question on StackOverflow](https://stackoverflow.com/questions/77073596/whats-the-difference-between-plugins-and-pluginmanagement-plugins-in). More context there.
-
- 25 Oct, 2023 1 commit
-
-
Qun Cheng authored
Reverts flutter/flutter#137190
-
- 24 Oct, 2023 1 commit
-
-
Polina Cherkasova authored
-
- 22 Sep, 2023 1 commit
-
-
Bartek Pacia authored
Refactor "app plugin loader" Gradle Plugin so it can be applied using the declarative `plugins {}` block (#127897) This PR fixes #125009.
-
- 13 Sep, 2023 1 commit
-
-
Zachary Anderson authored
I'm seeing these in the bot reports every week. Hopefully this is all of them, and hopefully 4GB is enough.
-
- 19 Apr, 2023 1 commit
-
-
Bartek Pacia authored
Refactor Flutter Gradle Plugin so it can be applied using the declarative `plugins {}` block (#123511) This PR aims to resolve #121552. Resources used: - [Developing Plugins](https://docs.gradle.org/current/userguide/custom_plugins.html) - [Using Gradle Plugins](https://docs.gradle.org/current/userguide/plugins.html#sec:plugins_block) - [Composite Builds Plugin Development Sample](https://docs.gradle.org/current/samples/sample_composite_builds_plugin_development.html) This PR also paves way for #121541, because apps will no longer have: ```groovy apply from: "$flutterRoot/packages/flutter_tools/gradle/flutter.gradle" ``` hardcoded. Instead, they'll use: ```groovy plugins { // ... id "dev.flutter.flutter-gradle-plugin" // the exact name is tentative } ```
-
- 29 Mar, 2023 1 commit
-
-
Bartek Pacia authored
Fix warning in `flutter create`d project ("package attribute is deprecated" in AndroidManifest) (#123426) Fix warning in `flutter create`d project ("package attribute is deprecated" in AndroidManifest)
-
- 21 Mar, 2023 1 commit
-
-
Bartek Pacia authored
Fix Gradle warning in a freshly `flutter create`ed Android project
-
- 29 Jul, 2022 1 commit
-
-
Gary Qian authored
Reland "Upgrade Gradle and AGP versions to 7.5/7.2 and migrate benchmarks+examples" #108472 (#108510)
-
- 27 Jul, 2022 3 commits
-
-
Kate Lovett authored
Revert "Reland "Upgrade Gradle and AGP versions to 7.5/7.2 and migrate benchmarks+examples" #108355 (#108472)" (#108488) This reverts commit 1f8c490c.
-
Gary Qian authored
Reland "Upgrade Gradle and AGP versions to 7.5/7.2 and migrate benchmarks+examples" #108355 (#108472)
-
Zachary Anderson authored
Revert "Reland "Upgrade Gradle and AGP versions to 7.5/7.2 and migrate benchmarks+examples" (#108355)" (#108407) This reverts commit c4b3625d.
-
- 26 Jul, 2022 2 commits
-
-
Gary Qian authored
-
Zachary Anderson authored
This reverts commit ca6cecf0.
-
- 25 Jul, 2022 1 commit
-
-
Gary Qian authored
-
- 13 Jun, 2022 1 commit
-
-
Ahmed Ashour authored
-
- 19 Apr, 2022 1 commit
-
-
Wyte Krongapiradee authored
-
- 28 Feb, 2022 1 commit
-
-
Emmanuel Garcia authored
-
- 24 Feb, 2022 1 commit
-
-
Tacca authored
-
- 20 Nov, 2021 1 commit
-
-
Andrei Diaconu authored
-
- 07 Nov, 2021 1 commit
-
-
Zachary Anderson authored
This reverts commit 9038fac9.
-
- 05 Nov, 2021 3 commits
-
-
Andrei Diaconu authored
-
Zachary Anderson authored
This reverts commit 058dfd49.
-
Andrei Diaconu authored
-
- 01 Nov, 2021 1 commit
-
-
Emmanuel Garcia authored
-
- 25 Oct, 2021 1 commit
-
-
Emmanuel Garcia authored
-
- 15 Oct, 2021 1 commit
-
-
Emmanuel Garcia authored
-
- 08 Oct, 2021 1 commit
-
-
Zachary Anderson authored
* Revert "Mark last failing test after gradle update as flaky. (#91423)" This reverts commit 46a52d03. * Revert "fix android template for Gradle 7 (#91411)" This reverts commit 51d06d53. * Revert "Add explicit version for mac and windows openjdk. (#91408)" This reverts commit bf429f27. * Revert "Update the openjdk version used by linux android tests. (#91405)" This reverts commit 2144ab8b. * Revert "Migrate to Gradle 7.0.2 / AGP 7.0.1 (#90642)" This reverts commit b6459f9b.
-
- 07 Oct, 2021 1 commit
-
-
Taha Tesser authored
-
- 02 Oct, 2021 1 commit
-
-
Littlegnal authored
-
- 01 Jun, 2021 1 commit
-
-
Emmanuel Garcia authored
-
- 21 May, 2021 1 commit
-
-
Emmanuel Garcia authored
-