- 05 Oct, 2017 1 commit
-
-
Yegor authored
* optimize ThemeData: make it monomorphic, memoize result * address comments * RLU cache; fix text theme merging * use FIFO cache for ThemeData; use HashMap to store inherited widgets * address comments
-
- 03 Oct, 2017 2 commits
-
-
Hans Muller authored
-
Adam Barth authored
Previously, we used `Alignment`, which was difficult to understand. Now, we just use an `Offset` scaled to the child's size, which is much easier to understand.
-
- 02 Oct, 2017 1 commit
-
-
Adam Barth authored
Unlike FractionalOffset, Alignment uses the center as the zero of the coordinate system, which makes the RTL math work out much cleaner. Also, make FractionalOffset into a subclass of Alignment so that clients can continue to use FractionalOffset.
-
- 29 Sep, 2017 4 commits
-
-
Ian Hickson authored
-
Todd Volkert authored
Temporary workaround to the fact that the Analyzer API doesn't have a way to turn on asserts in initializers, coupled with the fact that this file is being parsed by package:intl using the Analyzer API.
-
Chris Bracken authored
This patch fixes a collection of issues with widgets involved in text editing: * Fire widget.onChanged on EditableText value change: The value of an EditableText is composed of the text value as well as other editing-related data such as selection-related information. Previously, widget.onChanged() was only called for updates via updateEditingValue(). For pastes via a TextSelectionOverlay, updates are signalled via _handleSelectionOverlayChanged(), which only ever triggered widget.onSelectionChanged(), but not widget.onChanged(). Both updateEditingValue() and _handleSelectionOverlayChanged() perform the value update via _formatAndSetValue(), which is where this patch moves the widget.onChanged() call. * Correctly update TextFormField value on edits via controller: The textual value of a TextFormField exists in two locations: 1. FormField.value, as with all FormFields and subclasses. 2. TextEditingController.value associated with the TextField underlying the TextFormField. Previously, edits to the TextEditingController associated with a TextFormField resulted in updates to the rendered TextField widget, but did not update TextFormField.value. FormField.value is updated via FormField's onChanged function, which is called from the EditableText underlying the TextField underlying the TextFormField. EditableText only fires onChanged when it receives changes from the engine. It does not fire onChanged for changes made to the underlying TextController, since the owner of the TextController is the one making these changes and thus, already aware of them. FormField, however, *does* need to listen to these changes to update its value. * Adds an initialValue parameter to the TextFormField constructor: FormField's constructor already takes an initialValue parameter, which specifies the initial value in the field, which is also the value to which reset() returns the field. Previously, TextFormField took its initial value from the controller value (if a controller was passed in) or the empty string (if not). This had the undesirable effect that calling reset() always resets the value to the current value of the controller... i.e., does nothing. We now take an initial value explicitly.
-
Ian Hickson authored
* SafeArea * AnimatedSafeArea * AppBar test * Apply feedback
-
- 28 Sep, 2017 2 commits
-
-
Ian Hickson authored
-
Stefano Rodriguez authored
* Update AUTHORS * Add background and value colors to LinearProgressIndicator * Add tests for LinearProgressIndicator with colors
-
- 27 Sep, 2017 2 commits
-
-
Ian Hickson authored
-
gspencergoog authored
Add multiline keyboard support to editable text widget. Fixes #8028.
-
- 26 Sep, 2017 3 commits
-
-
Chris Bracken authored
-
jiamingc authored
* Make switch widget accept 3 other colors: inactiveThumbColor, inactiveTrackColor, activeTrackColor. * Make switch widget accept 3 other colors. * Make switch widget accept 3 other colors.
-
Kyle Bradshaw authored
* _SaltedKey solution to `ExpansionPanelList` _SaltedKey implementation courtesy of @Hixie Tested and confirmed working. Fixes #11166 * Added a simple test * Style correction to test
-
- 24 Sep, 2017 3 commits
-
-
Todd Volkert authored
It was incorrectly added in #11858
-
Adam Barth authored
Just some very minor tweaks to remove subtle LTR bias. We use the same arrow rotation animation in RTL and LTR, but I think that's correct. Usually, rotations are either clockwise or anitclockwise, which are the same in RTL and LTR. We might need to check with someone who reads an RTL language to confirm. Fixes #11845
-
Adam Barth authored
This widget makes it easier to animated Positioned widgets with awareness of the ambient Directionality. Fixes #11998
-
- 23 Sep, 2017 1 commit
-
-
Adam Barth authored
Also, fix asserts in TableBorder#paint to match documentation. Fixes #12009
-
- 22 Sep, 2017 5 commits
-
-
Yegor authored
* internationalize time numerals * tests * use foundation.dart instead of meta.dart * address comments
-
Yegor authored
* introduce localized text geometry in MaterialLocalizations * remove geometry from color text themes * fix merge conflict * optional Localizations * fix fallback; test; docs
-
Yegor authored
* misc .arb fixes; localizations validator * regenerate localizations * address comments * do not treat plural variations as invalid keys
-
Hans Muller authored
-
Yegor authored
* Fix inherited widget notifications in Localizations * address comments
-
- 21 Sep, 2017 2 commits
-
-
Alexandre Ardhuin authored
-
xster authored
* Refactor CupertinoScaffold * Rename rootTabPageBuilder to tabBuilder * fix tab transparency padding * add a CupertinoTab * Add default background color * Add a bunch of examples * A bunch of tests * Refactor CupertinoScaffold * Rename rootTabPageBuilder to tabBuilder * fix tab transparency padding * Add default background color * review notes * fix test * review * Rename CupertinoTab to CupertinoTabView * remove final ; in sample code for analyzer
-
- 20 Sep, 2017 2 commits
-
-
Chris Bracken authored
Correctly handle the case where the TextEditingController associated with a TextField is set to null. Due to a typo (= vs ==), previously this was a no-op and the existing TextEditingController was retained, rather than copied.
-
Zev Youra authored
* Add IconThemeData adjustment to ListTile trailing element (makes consistent with leading element) * Add test for ListTile theme changes * Pull out and share IconThemeData variable between leading and trailing * remove extra comma * fix style nit
-
- 15 Sep, 2017 7 commits
-
-
Collin Jackson authored
Fix dropdown buttons menus being clipped by the edge of the screen
-
Yegor authored
* upper case * fix Russian material translations * regenerate localizations.dart
-
Hans Muller authored
-
Ian Hickson authored
* Allow FloatingActionButton to not have a heroTag. * Allow FloatingActionButton to not have a child. * Allow Tooltip to not have a child. * Improve the debug output of the default FloatingActionButton hero tag. * Improve the error message in the Hero clashing-tag case. * Improve the debug output of the Hero widget. * Improve the debug output of gesture-related widgets. * Minor improvements to documentation. * Fix some typos in comments. * Fix some style nits.
-
Hans Muller authored
-
Hans Muller authored
-
Ian Hickson authored
-
- 14 Sep, 2017 4 commits
-
-
Mehmet Fidanboylu authored
* Allow apps to change the title margin in app bar. * Fix documentation links and the shouldLayout function in the _ToolbarLayout * Rename margin to spacing * review comments * Test fixes. Now we also test the width to make sure enough space is left for trailing widget * Expose the middle spacing default and use it in app bar. * Fix analyzer break * Doc fixes due to review
-
Yegor authored
* Internationalize the time picker - header layout and formatting - 12-hour vs 24-hour dial - RTL * make TimeOfDayFormat an enum * address comments
-
Kyle Bradshaw authored
* Trailing widget override for ExpansionTile Fixes #11890 * Add a test * Replaced missing comma
-
Ian Hickson authored
-
- 13 Sep, 2017 1 commit
-
-
Ian Hickson authored
This reverts commit da0602fe.
-