1. 29 Nov, 2015 1 commit
    • Adam Barth's avatar
      Clean up code organization in flutter_tools · 9662d49e
      Adam Barth authored
      1) Moved basic utility code into base/ directory to make it clear which code
         doesn't depend on Flutter-specific knowldge.
      2) Move the CommandRunner subclasses into a runner/ directory because these
         aren't commands themselves.
      9662d49e
  2. 25 Nov, 2015 1 commit
  3. 20 Nov, 2015 1 commit
  4. 18 Nov, 2015 2 commits
  5. 17 Nov, 2015 1 commit
    • Adam Barth's avatar
      Add all the icon sizes to the FLX · a8ab3d69
      Adam Barth authored
      Adding all the sizes of all the icons adds about 50 KB to the stocks FLX.
      That's probably the right trade-off until we get better at pruning the set of
      assets.
      
      Fixes #235
      a8ab3d69
  6. 12 Nov, 2015 1 commit
    • Hixie's avatar
      flutter analyze command · a0227cab
      Hixie authored
      Other changes in this patch:
      - Make the 'flutter' tool say "Updating flutter tool..." when it calls
        pub get, to avoid confusion about what the pub get output is about.
      - Make the bash flutter tool call pub get when the revision has
        changed. (This was already happening on Windows.)
      - Fix a raft of bugs found by the analyzer.
      - Fix some style nits in various bits of code that happened to be near
        things the analyzer noticed.
      - Remove the logic in "flutter test" that would run "pub get", since
        upon further reflexion it was determined it didn't work anyway.
        We'll probably have to add better diagnostics here and say to run the
        updater script.
      - Remove the native velocity tracker script, since it was testing code
        that has since been removed.
      
      Notes on ignored warnings:
      - We ignore warnings in any packages that are not in the Flutter repo or
        in the author's current directory.
      - We ignore various irrelevant Strong Mode warnings. We still enable
        strong mode because even though it's not really relevant to our needs,
        it does (more or less accidentally) catch a few things that are
        helpful to us.
      - We allow CONSTANTS_LIKE_THIS, since we get some of those from other
        platforms that we are copying for sanity and consistency.
      - We allow one-member abstract classes since we have a number of them
        where it's perfectly reasonable.
      - We unfortunately still ignore warnings in mojom.dart autogenerated
        files. We should really fix those but that's a separate patch.
      - We verify the actual source file when we see the 'Name non-constant
        identifiers using lowerCamelCase.' lint, to allow one-letter variables
        that use capital letters (e.g. for physics expressions) and to allow
        multiple-underscore variable names.
      - We ignore all errors on lines that contain the following magic
        incantation and a "#" character:
          // analyzer doesn't like constructor tear-offs
      - For all remaining errors, if the line contains a comment of the form
          // analyzer says "..."
        ...then we ignore any errors that have that "..." string in them.
      a0227cab
  7. 07 Nov, 2015 1 commit
  8. 04 Nov, 2015 1 commit
  9. 03 Nov, 2015 1 commit
  10. 02 Nov, 2015 2 commits
  11. 29 Oct, 2015 1 commit
  12. 26 Oct, 2015 1 commit
  13. 21 Oct, 2015 1 commit
  14. 19 Oct, 2015 1 commit
    • Matt Perry's avatar
      Support signing flx packages with ECDSA key pair · b458935b
      Matt Perry authored
      Adds a --private-key option to the build command, which specifies an ECDSA
      private key. When this is provided along with a manifest, the manifest is
      prepended to the .flx package and signed with the private key. The manifest
      also includes a SHA-256 hash of the zipped content portion of the .flx package.
      
      This is used by the Flutter updater package, to verify that updates are
      from the right publisher.
      b458935b
  15. 17 Oct, 2015 1 commit
  16. 13 Oct, 2015 1 commit
  17. 12 Oct, 2015 1 commit
    • Adam Barth's avatar
      Teach sky_tools about prebuilt artifacts · bdd20661
      Adam Barth authored
      This patch makes `flutter start` work without a clone of the engine git
      repository. Making this work pulled a relatively large refactor of how the
      commands interact with application packages and devices. Now commands that want
      to interact with application packages or devices inherit from a common base
      class that holds stores of those objects as members.
      
      In production, the commands download and connect to devices based on the build
      configuration stored on the FlutterCommandRunner. In testing, these fields are
      used to mock out the real application package and devices.
      bdd20661
  18. 10 Oct, 2015 1 commit
  19. 25 Sep, 2015 2 commits
  20. 24 Sep, 2015 1 commit
  21. 23 Sep, 2015 1 commit
    • James Robinson's avatar
      Instantiate ArtifactStore explicit with packageRoot · 0758c592
      James Robinson authored
      This teaches commands that need binary artifacts to explicitly instantiate an
      instance of the ArtifactStore with the appropriate packageRoot string. The
      ArtifactStore can then remember the package root and compute the engine
      revision when created and remember those for subsequence calls.
      0758c592
  22. 22 Sep, 2015 1 commit
  23. 18 Sep, 2015 2 commits
    • James Robinson's avatar
      Download sky_snapshot from the cloud · cbc35dfa
      James Robinson authored
      This adds logic to download and use the sky_snapshot binary from
      Google cloud storage when running the 'sky_tools build' command.
      The downloaded binary is put into lib/cache/... The binary is
      chosen to match the REVISION in the sky_engine package in the
      packages directory of whichever package the user wishes to
      build a flx from.
      
      Known issues:
      *) Assumes linux-x64 host
      *) Assumes download will always produce valid executable
      *) No clearing of stale cache entries
      cbc35dfa
    • Ian Fischer's avatar
      Add missing semicolon · 670f14e0
      Ian Fischer authored
      670f14e0
  24. 17 Sep, 2015 4 commits