Skip to content

F
Front-End
Switch branch/tag
  1. 08 Feb, 2023 2 commits
    • Greg Price's avatar
      Add test for RenderProxyBoxMixin; clarify doc, resolve TODO (#117664) · cd125e1f
      Greg Price authored 
      * Add test for RenderProxyBoxMixin; clarify doc, resolve TODO

The TODO comment suggested this mixin would no longer be needed once
a Dart issue on inherited constructors was fixed:
  https://github.com/dart-lang/sdk/issues/31543
That issue is now long since fixed, so I went to go carry out the TODO.

But in doing so, I realized that the mixin's documentation was more
right than the TODO comment: even with that issue fixed, there is a
legitimate use case for this mixin, namely to reuse the implementation
of RenderProxyBox in a class that also inherits from some other base
class.  Moreover, searching GitHub I found an example of a library
that makes real use of that capability.

So I think the right resolution is to accept that this separation
is useful and delete the TODO.

Then, add a test with an extremely simplified sketch of that
real-world example.  In case someone in the future attempts to
simplify this mixin away, the test will point us at the use case
that would be broken by such a change.

Also remove the only in-tree use of the mixin, which was redundant;
and expand the mixin's documentation to advise about that case.

* Tweak formatting
Co-authored-by: 's avatarMichael Goderbauer <goderbauer@google.com>

* Cut comments

---------
Co-authored-by: 's avatarMichael Goderbauer <goderbauer@google.com>
      cd125e1f
    • Greg Price's avatar
      Fix hang on successful dev/bots/analyze.dart (#117660) · 98b3e48e
      Greg Price authored 
      Fixes #117659

It turns out this was due to the output-suppression timer introduced
recently as part of cleaning up the output (#109206); on success, the
script would wait 10 minutes for the timeout to expire.  This didn't
affect CI because this feature doesn't apply in CI (as detected by
lack of color on stdout.)

Fix the issue by cleaning up the timer on success in the same way
as on failure.

While here, clean up the final summary messages slightly,
and also cut the trailing space that printProgress was leaving
on each line.
      98b3e48e
  3. 07 Feb, 2023 20 commits
  5. 06 Feb, 2023 9 commits
  7. 05 Feb, 2023 3 commits
  9. 04 Feb, 2023 6 commits
    • Brandon DeRosier's avatar
      De-flake adapter integration test (#120016) · f10e625e
      Brandon DeRosier authored
      f10e625e
    • engine-flutter-autoroll's avatar
      Roll Flutter Engine from 1b132e44194d to c7a4bbab0e75 (6 revisions) (#119990) · 61f6a0bc
      engine-flutter-autoroll authored 
      * 49f2d98d2 Roll Skia from f083b79aa388 to 5d8a7ed8acfe (3 revisions) (flutter/engine#39381)

* 88fda68f4 Roll Skia from 5d8a7ed8acfe to 8de8c6287254 (1 revision) (flutter/engine#39382)

* 23f53e5ef [fuchsia] Add output_path property to customize output path of .so files (flutter/engine#39007)

* 87ed27470 Roll Fuchsia Mac SDK from _6bmpi47oMZC-msOI... to hcZFTTKMN0k4lXjfs... (flutter/engine#39384)

* d3edcc985 Roll Dart SDK from de912d108ebb to a507a9057730 (2 revisions) (flutter/engine#39385)

* c7a4bbab0 [Impeller] Make text appear less emboldened (flutter/engine#39383)
      61f6a0bc
    • engine-flutter-autoroll's avatar
      Roll Flutter Engine from e1b265bb52aa to 1b132e44194d (8 revisions) (#119980) · 5241d38f
      engine-flutter-autoroll authored 
      * 2ddbff9b6 [Impeller] Append to existing atlas if room exists, reuse texture (flutter/engine#38253)

* 9dd2e9c98 [fuchsia] fdio_service_connect no longer provides rights which we need (flutter/engine#39374)

* 9dde1563c [impeller] drawVertices blend mode (flutter/engine#38985)

* 18750d245 [ios] Lock refresh rate to 80fps when threads are merged (flutter/engine#39172)

* fe259c2ba Roll Skia from 83a3d8b16c94 to f083b79aa388 (5 revisions) (flutter/engine#39376)

* 4fdbb0a36 [Impeller] Retain embolden/skew font properties when rendering text glyphs (flutter/engine#39378)

* 868234df1 Roll Dart SDK from b7a0c75d4470 to de912d108ebb (1 revision) (flutter/engine#39379)

* 1b132e441 [iOS] Ensure FlutterView's background color is not nil to avoid CAMetalLayer nextDrawable being time-consuming (flutter/engine#39359)
      5241d38f
    • godofredoc's avatar
      Do not run customer testing on release candidate branches. (#119979) · c8e75a8d
      godofredoc authored 
      These tests try to use a commit contemporary to the framework commit in
customer repositories. This won't work because a CP to the framework
release candidate branch may be recent even though the release candidate
branch can be months old.
      c8e75a8d
    • godofredoc's avatar
      Revert "Fix unable to find bundled Java version (#119244)" (#119981) · f7c2bd05
      godofredoc authored 
      This reverts commit 57fd50f8.
      f7c2bd05
    • crasowas's avatar
      Fix unable to find bundled Java version (#119244) · 57fd50f8
      crasowas authored
      57fd50f8

HIAST - GitLab