Commits · cd06ba7ab6215616e994745f445b7c3edc9c2dbd · abdullh.alsoleman / Front-End

18 Jan, 2024 15 commits

Fix: TextField can inherit `errorStyle` from `InputDecorationTheme`. (#141227) · cd06ba7a

Renzo Olivares authored Jan 18, 2024

Previously `TextField`s error `cursorColor` was being derived without taking into account any `InputDecorationTheme` defaults. This change respects `InputDecorationTheme` defaults when deriving the error `cursorColor`.

Fixes #140607

cd06ba7a

Add check for Bank of Brazil security module to Windows Flutter Doctor validators (#141135) · 3123d981

yaakovschectman authored Jan 18, 2024

Add a warning to Flutter Doctor if Topaz OFD is found as a process on
the system.
The protection module used by the Bank of Brazil has been identified as
causing build failures when using VS with CMake for Windows (see
https://github.com/flutter/flutter/issues/121366#issuecomment-1845703728).
Disabling the software allows the build to succeed again.

If a running process is found by `flutter doctor` whose path contains
`Topaz OFD\Warsaw\core.exe`, a warning message is generated to convey
this.

Addresses https://github.com/flutter/flutter/issues/121366

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat

---------
Co-authored-by: Elias Yishak <42216813+eliasyishak@users.noreply.github.com>
Co-authored-by: Loïc Sharma <737941+loic-sharma@users.noreply.github.com>

3123d981

Fix gradle lints No semantic change should be present. (#141692) · c479109e

Reid Baker authored Jan 18, 2024

Move static methods together.
Fix property uses of duplicate strings.
Add types wherever obvious
Fix format depth
Add whitespace to top and bottom of classes
Ignore line length for file
Ignore prefer single quote for file
Ignore correction for getFoo used instead of foo

Loosely related to flutter/flutter/issues/123934

c479109e

Roll Packages from 1a2b780c9108 to 83c2c4da97c5 (5 revisions) (#141778) · 6065c426

engine-flutter-autoroll authored Jan 18, 2024

https://github.com/flutter/packages/compare/1a2b780c9108...83c2c4da97c5

2024-01-18 stuartmorgan@google.com [google_maps_flutter] Restore the arm64 workaround (flutter/packages#5915)
2024-01-17 10687576+bparrishMines@users.noreply.github.com [pigeon] Separates message call code generation into separate methods in the KotlinGenerator (flutter/packages#5891)
2024-01-17 10687576+bparrishMines@users.noreply.github.com [webview_flutter_wkebview] Verify JavaScriptChannels have a unique name (flutter/packages#5904)
2024-01-17 10687576+bparrishMines@users.noreply.github.com [pigeon] Separates message call code generation into separate methods in the `DartGenerator` (flutter/packages#5859)
2024-01-17 engine-flutter-autoroll@skia.org Roll Flutter from 8e94423e to def6af0b (23 revisions) (flutter/packages#5911)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

6065c426

Roll Flutter Engine from 49fa2cb9024f to b75d6d80d813 (1 revision) (#141771) · f77f8243

engine-flutter-autoroll authored Jan 18, 2024

https://github.com/flutter/engine/compare/49fa2cb9024f...b75d6d80d813

2024-01-18 skia-flutter-autoroll@skia.org Roll Skia from 1b2909f1eac7 to 7b3d788ba978 (1 revision) (flutter/engine#49861)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

f77f8243

Roll Flutter Engine from 49c6ca211aa4 to 49fa2cb9024f (1 revision) (#141762) · 91aceaa0

engine-flutter-autoroll authored Jan 18, 2024

https://github.com/flutter/engine/compare/49c6ca211aa4...49fa2cb9024f

2024-01-18 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from GuU0e5WxJCi92Scz8... to dTy8CK4YxnUsW305O... (flutter/engine#49859)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from GuU0e5WxJCi9 to dTy8CK4YxnUs

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

91aceaa0

Roll Flutter Engine from 873449c27d5a to 49c6ca211aa4 (1 revision) (#141760) · a5da3a22

engine-flutter-autoroll authored Jan 18, 2024

https://github.com/flutter/engine/compare/873449c27d5a...49c6ca211aa4

2024-01-18 skia-flutter-autoroll@skia.org Roll Skia from ea70dd235e9f to 1b2909f1eac7 (1 revision) (flutter/engine#49858)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

a5da3a22

Roll Flutter Engine from bfdc0c5b2826 to 873449c27d5a (1 revision) (#141759) · 0ee36adc

engine-flutter-autoroll authored Jan 18, 2024

https://github.com/flutter/engine/compare/bfdc0c5b2826...873449c27d5a

2024-01-18 leroux_bruno@yahoo.fr [Android] Reset IME state in TextInputPlugin.clearTextInputClient (flutter/engine#49829)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

0ee36adc

Catch UnsupportedError thrown when user provides an asset directory path... · 0833929c

Andrew Kolos authored Jan 18, 2024

Catch UnsupportedError thrown when user provides an asset directory path containing invalid characters (#141214)

Fixes https://github.com/flutter/flutter/issues/140092

0833929c

Roll Flutter Engine from 48f89ac064ac to bfdc0c5b2826 (1 revision) (#141752) · e1e470d4

engine-flutter-autoroll authored Jan 18, 2024

https://github.com/flutter/engine/compare/48f89ac064ac...bfdc0c5b2826

2024-01-18 skia-flutter-autoroll@skia.org Roll Skia from 31f275e8fcc7 to ea70dd235e9f (2 revisions) (flutter/engine#49856)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

e1e470d4

Roll Flutter Engine from 924c17245a78 to 48f89ac064ac (2 revisions) (#141751) · ebc20163

engine-flutter-autoroll authored Jan 18, 2024

https://github.com/flutter/engine/compare/924c17245a78...48f89ac064ac

2024-01-18 dnfield@google.com Delete trace event from DeviceBufferVK (flutter/engine#49854)
2024-01-18 jonahwilliams@google.com [Impeller] remove shared_ptr copies during text contents rendering. (flutter/engine#49837)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

ebc20163

Roll Flutter Engine from 98c16b430e6b to 924c17245a78 (1 revision) (#141749) · 2ff9802c

engine-flutter-autoroll authored Jan 18, 2024

https://github.com/flutter/engine/compare/98c16b430e6b...924c17245a78

2024-01-18 yjbanov@google.com [web] fix ==/hashCode/toString for several classes across renderers (flutter/engine#49786)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

2ff9802c

Roll Flutter Engine from 73a2de5da53f to 98c16b430e6b (16 revisions) (#141744) · 5dc69250

engine-flutter-autoroll authored Jan 18, 2024

https://github.com/flutter/engine/compare/73a2de5da53f...98c16b430e6b

2024-01-18 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Manual roll Dart SDK from d6c08fa9bb54 to 6ff69d6b7f59 (15 revisions)" (flutter/engine#49852)
2024-01-18 skia-flutter-autoroll@skia.org Roll Skia from 5abf9717ea92 to 31f275e8fcc7 (8 revisions) (flutter/engine#49850)
2024-01-18 30870216+gaaclarke@users.noreply.github.com Reland: [Impeller] Turned on new blur. (#48472) (flutter/engine#49642)
2024-01-17 737941+loic-sharma@users.noreply.github.com [Windows] Reduce Visual Studio build errors caused by keyboard unit tests (flutter/engine#49814)
2024-01-17 30870216+gaaclarke@users.noreply.github.com [Impeller] disabled misleading vulkan golden image tests (flutter/engine#49836)
2024-01-17 737941+loic-sharma@users.noreply.github.com [Windows] Remove unnecessary statics in keyboard (flutter/engine#49834)
2024-01-17 skia-flutter-autoroll@skia.org Roll Skia from 5c9e3474cf13 to 5abf9717ea92 (1 revision) (flutter/engine#49831)
2024-01-17 godofredoc@google.com Move mac cache builder to bringup. (flutter/engine#49843)
2024-01-17 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] Switch from transient stencil-only to depth+stencil buffer." (flutter/engine#49832)
2024-01-17 skia-flutter-autoroll@skia.org Roll Skia from d8da1ee69767 to 5c9e3474cf13 (2 revisions) (flutter/engine#49827)
2024-01-17 skia-flutter-autoroll@skia.org Manual roll Dart SDK from d6c08fa9bb54 to 6ff69d6b7f59 (15 revisions) (flutter/engine#49825)
2024-01-17 skia-flutter-autoroll@skia.org Roll Skia from 02e94b3b4d29 to d8da1ee69767 (1 revision) (flutter/engine#49824)
2024-01-17 bdero@google.com Flutter GPU: Add GpuContext.createHostBuffer (flutter/engine#49822)
2024-01-17 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from Klxww53tA4-TG5pA9... to GuU0e5WxJCi92Scz8... (flutter/engine#49823)
2024-01-17 bdero@google.com [Impeller] Switch from transient stencil-only to depth+stencil buffer. (flutter/engine#47987)
2024-01-17 skia-flutter-autoroll@skia.org Roll Skia from 31309ff09537 to 02e94b3b4d29 (43 revisions) (flutter/engine#49819)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from Klxww53tA4-T to GuU0e5WxJCi9

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

5dc69250

Move mac pixel 7 pro test to presubmit: false (#141747) · a9d94be0
Zachary Anderson authored Jan 18, 2024
```
The only bot with this configuration in the try pool just died.
```
a9d94be0

[web] prepare layers_test.dart for https://github.com/flutter/engine/pull/49786 (#141731) · 00032569

Yegor authored Jan 18, 2024

This disables the expectation for `TileMode` stringification because
https://github.com/flutter/engine/pull/49786 is about to fix it (as in,
the test would fail when the engine fix lands).

00032569

17 Jan, 2024 21 commits

Remove non-needed bot and increase time out for leak_tracking. (#141712) · b90a3e47
Polina Cherkasova authored Jan 17, 2024

b90a3e47

Add `headerHeight` for `SearchAnchor` (#141223) · ef794e2a

Qun Cheng authored Jan 17, 2024

Fixes #140046

This PR is to add a `headerHeight` property to `SearchAnchor` and `SearchViewThemeData` so the header height on the search view can be customized.

ef794e2a

Bump github/codeql-action from 3.23.0 to 3.23.1 (#141715) · a3c11cdc

dependabot[bot] authored Jan 17, 2024

Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.23.0 to 3.23.1.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/github/codeql-action/blob/main/CHANGELOG.md">github/codeql-action's changelog</a>.</em></p>
<blockquote>
<h1>CodeQL Action Changelog</h1>
<p>See the <a href="https://github.com/github/codeql-action/releases">releases page</a> for the relevant changes to the CodeQL CLI and language packs.</p>
<p>Note that the only difference between <code>v2</code> and <code>v3</code> of the CodeQL Action is the node version they support, with <code>v3</code> running on node 20 while we continue to release <code>v2</code> to support running on node 16. For example <code>3.22.11</code> was the first <code>v3</code> release and is functionally identical to <code>2.22.11</code>. This approach ensures an easy way to track exactly which features are included in different versions, indicated by the minor and patch version numbers.</p>
<h2>[UNRELEASED]</h2>
<p>No user facing changes.</p>
<h2>3.23.1 - 17 Jan 2024</h2>
<ul>
<li>Update default CodeQL bundle version to 2.16.0. <a href="https://redirect.github.com/github/codeql-action/pull/2073">#2073</a></li>
<li>Change the retention period for uploaded debug artifacts to 7 days. Previously, this was whatever the repository default was. <a href="https://redirect.github.com/github/codeql-action/pull/2079">#2079</a></li>
</ul>
<h2>3.23.0 - 08 Jan 2024</h2>
<ul>
<li>We are rolling out a feature in January 2024 that will disable Python dependency installation by default for all users. This improves the speed of analysis while having only a very minor impact on results. You can override this behavior by setting <code>CODEQL_ACTION_DISABLE_PYTHON_DEPENDENCY_INSTALLATION=false</code> in your workflow, however we plan to remove this ability in future versions of the CodeQL Action. <a href="https://redirect.github.com/github/codeql-action/pull/2031">#2031</a></li>
<li>The CodeQL Action now requires CodeQL version 2.11.6 or later. For more information, see <a href="https://github.com/github/codeql-action/blob/main/#2227---16-nov-2023">the corresponding changelog entry for CodeQL Action version 2.22.7</a>. <a href="https://redirect.github.com/github/codeql-action/pull/2009">#2009</a></li>
</ul>
<h2>3.22.12 - 22 Dec 2023</h2>
<ul>
<li>Update default CodeQL bundle version to 2.15.5. <a href="https://redirect.github.com/github/codeql-action/pull/2047">#2047</a></li>
</ul>
<h2>3.22.11 - 13 Dec 2023</h2>
<ul>
<li>[v3+ only] The CodeQL Action now runs on Node.js v20. <a href="https://redirect.github.com/github/codeql-action/pull/2006">#2006</a></li>
</ul>
<h2>2.22.10 - 12 Dec 2023</h2>
<ul>
<li>Update default CodeQL bundle version to 2.15.4. <a href="https://redirect.github.com/github/codeql-action/pull/2016">#2016</a></li>
</ul>
<h2>2.22.9 - 07 Dec 2023</h2>
<p>No user facing changes.</p>
<h2>2.22.8 - 23 Nov 2023</h2>
<ul>
<li>Update default CodeQL bundle version to 2.15.3. <a href="https://redirect.github.com/github/codeql-action/pull/2001">#2001</a></li>
</ul>
<h2>2.22.7 - 16 Nov 2023</h2>
<ul>
<li>Add a deprecation warning for customers using CodeQL version 2.11.5 and earlier. These versions of CodeQL were discontinued on 8 November 2023 alongside GitHub Enterprise Server 3.7, and will be unsupported by CodeQL Action v2.23.0 and later. <a href="https://redirect.github.com/github/codeql-action/pull/1993">#1993</a>
<ul>
<li>If you are using one of these versions, please update to CodeQL CLI version 2.11.6 or later. For instance, if you have specified a custom version of the CLI using the 'tools' input to the 'init' Action, you can remove this input to use the default version.</li>
<li>Alternatively, if you want to continue using a version of the CodeQL CLI between 2.10.5 and 2.11.5, you can replace <code>github/codeql-action/*@v2</code> by <code>github/codeql-action/*@v2.22.7</code> in your code scanning workflow to ensure you continue using this version of the CodeQL Action.</li>
</ul>
</li>
</ul>
<h2>2.22.6 - 14 Nov 2023</h2>
<ul>
<li>Customers running Python analysis on macOS using version 2.14.6 or earlier of the CodeQL CLI should upgrade to CodeQL CLI version 2.15.0 or later. If you do not wish to upgrade the CodeQL CLI, ensure that you are using Python version 3.11 or earlier, as CodeQL version 2.14.6 and earlier do not support Python 3.12. You can achieve this by adding a <a href="https://github.com/actions/setup-python"><code>setup-python</code></a> step to your code scanning workflow before the step that invokes <code>github/codeql-action/init</code>.</li>
<li>Update default CodeQL bundle version to 2.15.2. <a href="https://redirect.github.com/github/codeql-action/pull/1978">#1978</a></li>
</ul>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/github/codeql-action/commit/0b21cf2492b6b02c465a3e5d7c473717ad7721ba"><code>0b21cf2</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2089">#2089</a> from github/update-v3.23.1-f65ecd09c</li>
<li><a href="https://github.com/github/codeql-action/commit/ae616145ed5a0d64a670cddaf1306bd35b978202"><code>ae61614</code></a> Update changelog for v3.23.1</li>
<li><a href="https://github.com/github/codeql-action/commit/f65ecd09c7594dc5bfccb15a694c4d15971c9b73"><code>f65ecd0</code></a> Only delete SARIF in PR check if not running on a fork  (<a href="https://redirect.github.com/github/codeql-action/issues/2084">#2084</a>)</li>
<li><a href="https://github.com/github/codeql-action/commit/4d75a10efaeb4b135a886e21e438f08fd32a87ab"><code>4d75a10</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2073">#2073</a> from github/update-bundle/codeql-bundle-v2.16.0</li>
<li><a href="https://github.com/github/codeql-action/commit/e65c5d92f7c1e067aaca8aa8a9a714db5322e074"><code>e65c5d9</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2086">#2086</a> from github/dependabot/npm_and_yarn/npm-c0441c84d9</li>
<li><a href="https://github.com/github/codeql-action/commit/6b12e3d9d9976c9372b35297046ba0adddb4fb10"><code>6b12e3d</code></a> Update checked-in dependencies</li>
<li><a href="https://github.com/github/codeql-action/commit/e292db6207ceb5de549d18b4cd713c4c84d06b45"><code>e292db6</code></a> Bump the npm group with 4 updates</li>
<li><a href="https://github.com/github/codeql-action/commit/1fea7a57e709f40b2c9f20431ca0c7c325a8ba63"><code>1fea7a5</code></a> Merge branch 'main' into update-bundle/codeql-bundle-v2.16.0</li>
<li><a href="https://github.com/github/codeql-action/commit/96531062ba46eb11dee25758db76518ad30ee4cf"><code>9653106</code></a> Stop setting <code>CODEQL_RUNNER</code> environment variable if CLI already sets it (<a href="https://redirect.github.com/github/codeql-action/issues/2081">#2081</a>)</li>
<li><a href="https://github.com/github/codeql-action/commit/eb14aeb61d80eb999887486ac17a507b970d02f0"><code>eb14aeb</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2080">#2080</a> from github/henrymercer/fix-unconditional-warning</li>
<li>Additional commits viewable in <a href="https://github.com/github/codeql-action/compare/e5f05b81d5b6ff8cfa111c80c22c5fd02a384118...0b21cf2492b6b02c465a3e5d7c473717ad7721ba">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=github/codeql-action&package-manager=github_actions&previous-version=3.23.0&new-version=3.23.1)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

a3c11cdc

Make test file systems/platforms used in asset_bundle_test.dart less dependent... · 57575009

Andrew Kolos authored Jan 17, 2024

Make test file systems/platforms used in asset_bundle_test.dart less dependent on the host platform (#141657)

Part of work on https://github.com/flutter/flutter/pull/141214. See [this discussion](https://github.com/flutter/flutter/pull/141214#discussion_r1446727495) for the inspiration for this PR.

## Issue
Many tests in [packages/flutter_tools/test/general.shard/asset_bundle_test.dart](https://github.com/flutter/flutter/blob/4cd0a3252d2b45e243714b3ce93c5b2313bce671/packages/flutter_tools/test/general.shard/asset_bundle_test.dart) aren't hermetic. When setting up fake `FileSystem` and `Platform` objects, the host OS is referenced:

https://github.com/flutter/flutter/blob/f2745e97d53c6a29c7d40003dfaa4fc4c688cdd2/packages/flutter_tools/test/general.shard/asset_bundle_test.dart#L35-L40

https://github.com/flutter/flutter/blob/f2745e97d53c6a29c7d40003dfaa4fc4c688cdd2/packages/flutter_tools/test/general.shard/asset_bundle_test.dart#L43

To improve hermeticity here, we could instead run each once _per_ valid combination of file system style and platform. However, it is unclear if these tests even depend on the file system style (integration tests should catch most cases where this might matter). As a result, I think it's sufficient to improve hermeticity by always assuming a Linux environment, which is generally our default (as `MemoryFileSystem` does, and most of our fakes of `Platform` do by default).

In general, if a test needs to run other kinds of environments, it should make this clear, ideally through the test name.

57575009

Native assets: roll deps (#141684) · f5442bf9

Daco Harkes authored Jan 17, 2024

Rolls the packages from https://github.com/dart-lang/native in the native assets implementation.

Most notable we're refactoring `package:native_assets_cli` for `build.dart` use.
Therefore, all imports to that package for Flutter/Dart should be to the implementation internals that are no longer visible for `build.dart` writers. Hence all the import updates.

No behavior in Flutter apps should change.

This PR also updates the template to use the latests version of `package:native_assets_cli` which no longer exposes all the implementation details.

f5442bf9

Run build tests on both x64 and arm64. (#141206) · 66f5e88e

godofredoc authored Jan 17, 2024

Most of the builds for mac_x64 can actually run on any available architecture. This is required to use capacity more efficiently.

66f5e88e

Update tests to Xcode 15 (#141706) · 8de818dd
Victoria Ashworth authored Jan 17, 2024
```
Framework part of https://github.com/flutter/flutter/issues/132237.
```
8de818dd

[web] prepare for https://github.com/flutter/engine/pull/49786 (#141700) · bac4d839

Yegor authored Jan 17, 2024

Skip incorrect expectations in preparation for https://github.com/flutter/engine/pull/49786.

Bonus: improved error message when text style test fails

bac4d839

Marks Windows framework_tests_misc_leak_tracking to be unflaky (#141676) · 8286f499

Flutter GitHub Bot authored Jan 17, 2024

<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Windows framework_tests_misc_leak_tracking"
}
-->
The issue https://github.com/flutter/flutter/issues/140414 has been closed, and the test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Windows%20framework_tests_misc_leak_tracking%22).
This test can be marked as unflaky.

8286f499

Label "flutter_localizations" PRs with "framework" (#141654) · c0a4c34f

Michael Goderbauer authored Jan 17, 2024

Make sure that these PRs don't slip through the cracks and only get caught during the stale PR review in critical triage.

c0a4c34f

Fix Tooltip show delay when mouse moves to one Tooltip from another (#141656) · da20edf0
LongCatIsLooong authored Jan 17, 2024
```
Fixes https://github.com/flutter/flutter/issues/141644
```
da20edf0

Roll Packages from 7dd0fcbcfa79 to 1a2b780c9108 (6 revisions) (#141683) · a10712e8

engine-flutter-autoroll authored Jan 17, 2024

https://github.com/flutter/packages/compare/7dd0fcbcfa79...1a2b780c9108

2024-01-17 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[ci] Run check_podspecs on arm Mac bots" (flutter/packages#5909)
2024-01-17 stuartmorgan@google.com [various] Update minimum iOS versions to 12.0 (flutter/packages#5902)
2024-01-16 magder@google.com [ci] Run check_podspecs on arm Mac bots (flutter/packages#5885)
2024-01-16 alzollin@microsoft.com [pigeon] Fix pigeon test generation missing wrapResponse method. (flutter/packages#5903)
2024-01-16 engine-flutter-autoroll@skia.org Roll Flutter from 1a2c3151 to 8e94423e (2 revisions) (flutter/packages#5897)
2024-01-16 49699333+dependabot[bot]@users.noreply.github.com Bump actions/upload-artifact from 3.1.3 to 4.1.0 (flutter/packages#5896)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

a10712e8

Fix the --empty flag to not try working with non-app templates (#141632) · 4e3be0bf

Greg Spencer authored Jan 17, 2024

## Description

This adds a check to make sure that the `--empty` flag isn't applied to non-app templates.

## Related Issues
 - Fixes https://github.com/flutter/flutter/issues/141592

## Tests
 - Added a test.

4e3be0bf

Revert "Roll Flutter Engine from 73a2de5da53f to c7e328518bc0 (5 revisions)" (#141691) · 9bbff1bb
Jonah Williams authored Jan 17, 2024
```
Reverts flutter/flutter#141673
```
9bbff1bb

Roll Flutter Engine from 73a2de5da53f to c7e328518bc0 (5 revisions) (#141673) · def6af0b

engine-flutter-autoroll authored Jan 17, 2024

https://github.com/flutter/engine/compare/73a2de5da53f...c7e328518bc0

2024-01-17 skia-flutter-autoroll@skia.org Roll Skia from 02e94b3b4d29 to d8da1ee69767 (1 revision) (flutter/engine#49824)
2024-01-17 bdero@google.com Flutter GPU: Add GpuContext.createHostBuffer (flutter/engine#49822)
2024-01-17 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from Klxww53tA4-TG5pA9... to GuU0e5WxJCi92Scz8... (flutter/engine#49823)
2024-01-17 bdero@google.com [Impeller] Switch from transient stencil-only to depth+stencil buffer. (flutter/engine#47987)
2024-01-17 skia-flutter-autoroll@skia.org Roll Skia from 31309ff09537 to 02e94b3b4d29 (43 revisions) (flutter/engine#49819)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from Klxww53tA4-T to GuU0e5WxJCi9

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

def6af0b

Manual roll Flutter Engine from 1382ff79dd6d to 73a2de5da53f (2 revisions) (#141667) · 65acd072

engine-flutter-autoroll authored Jan 17, 2024

Manual roll requested by zra@google.com

Cannot build log URL because revision "73a2de5da53f" is invalid: Luci
builds of "Mac builder_cache" for
73a2de5da53f8ab133e88b43d05189879c370cb3 was INFRA_FAILURE

2024-01-17 98614782+auto-submit[bot]@users.noreply.github.com Reverts
"[Impeller] Encode directly to command buffer for Vulkan."
(flutter/engine#49818)
2024-01-17 zanderso@users.noreply.github.com Revert "Add
gclient_variables back for linux_license and fix the excluded files"
(flutter/engine#49817)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on
the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

65acd072

Roll Flutter Engine from d4b6b7ec8e48 to 1382ff79dd6d (7 revisions) (#141664) · 2d93b446

engine-flutter-autoroll authored Jan 17, 2024

https://github.com/flutter/engine/compare/d4b6b7ec8e48...1382ff79dd6d

2024-01-16 magder@google.com Remove iOS 12 availability checks (flutter/engine#49771)
2024-01-16 30870216+gaaclarke@users.noreply.github.com [Impeller] generate mipmaps for imagefilters (flutter/engine#49794)
2024-01-16 ditman@gmail.com [web] Leave blob URLs untouched in TT policy. (flutter/engine#49782)
2024-01-16 jason-simmons@users.noreply.github.com [Impeller] Fix a race between SwapchainImplVK::Present and WaitForFence (flutter/engine#49777)
2024-01-16 737941+loic-sharma@users.noreply.github.com Reland "[Windows] Move to FlutterCompositor for rendering" (flutter/engine#49726)
2024-01-16 jason-simmons@users.noreply.github.com [Impeller] Add an API for sampling strictly within the bounds of the source rect in DrawImageRect (flutter/engine#49696)
2024-01-16 jonahwilliams@google.com [Impeller] Encode directly to command buffer for Vulkan. (flutter/engine#49780)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

2d93b446

TrainHoppingAnimation should dispatch creation and disposal events. (#141635) · e36a868b
Kostia Sokolovskyi authored Jan 17, 2024

e36a868b

Reverts "Roll Flutter Engine from d4b6b7ec8e48 to 021a5ff5eae6 (5 revisions)" (#141659) · 0503c447

auto-submit[bot] authored Jan 17, 2024

Reverts flutter/flutter#141651
Initiated by: jonahwilliams
This change reverts the following previous change:
Original Description:

https://github.com/flutter/engine/compare/d4b6b7ec8e48...021a5ff5eae6

2024-01-16 ditman@gmail.com [web] Leave blob URLs untouched in TT policy. (flutter/engine#49782)
2024-01-16 jason-simmons@users.noreply.github.com [Impeller] Fix a race between SwapchainImplVK::Present and WaitForFence (flutter/engine#49777)
2024-01-16 737941+loic-sharma@users.noreply.github.com Reland "[Windows] Move to FlutterCompositor for rendering" (flutter/engine#49726)
2024-01-16 jason-simmons@users.noreply.github.com [Impeller] Add an API for sampling strictly within the bounds of the source rect in DrawImageRect (flutter/engine#49696)
2024-01-16 jonahwilliams@google.com [Impeller] Encode directly to command buffer for Vulkan. (flutter/engine#49780)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

0503c447

[flutter_tools] Fix analyze size on arm64 (#141317) · 4cd0a325
Christopher Fujino authored Jan 17, 2024
```
Fixes https://github.com/flutter/flutter/issues/140659
```
4cd0a325

Roll Flutter Engine from d4b6b7ec8e48 to 021a5ff5eae6 (5 revisions) (#141651) · 0c66636a

engine-flutter-autoroll authored Jan 17, 2024

https://github.com/flutter/engine/compare/d4b6b7ec8e48...021a5ff5eae6

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

0c66636a

16 Jan, 2024 4 commits

Update TESTOWNERS iskakaushik -> dnfield (#141649) · a38af622
Dan Field authored Jan 16, 2024

a38af622

Allow selection in composing region (#140516) · 212d0a64

LongCatIsLooong authored Jan 16, 2024

Fixes https://github.com/flutter/flutter/issues/68547 for macOS. Needs https://github.com/flutter/engine/pull/49314

212d0a64

Roll Flutter Engine from eab7bd3b0999 to d4b6b7ec8e48 (1 revision) (#141643) · 9775877d

engine-flutter-autoroll authored Jan 16, 2024

https://github.com/flutter/engine/compare/eab7bd3b0999...d4b6b7ec8e48

2024-01-16 jonahwilliams@google.com [Impeller] remove shared_ptr copy/release in main rendering loop. (flutter/engine#49801)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

9775877d

Roll Flutter Engine from f20657354d8b to eab7bd3b0999 (12 revisions) (#141638) · 0526ca4a

engine-flutter-autoroll authored Jan 16, 2024

https://github.com/flutter/engine/compare/f20657354d8b...eab7bd3b0999

2024-01-16 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Manually bump Dart to 3.4.0-34.0.dev" (flutter/engine#49802)
2024-01-16 bdero@google.com Use the correct impeller-cmake-example mirror (flutter/engine#49791)
2024-01-16 bdero@google.com [Flutter GPU] Run unittests on CI and fix HostBuffer. (flutter/engine#49789)
2024-01-16 bdero@google.com [Flutter GPU] Fix playground shader paths. (flutter/engine#49790)
2024-01-16 737941+loic-sharma@users.noreply.github.com [Windows] Add README (flutter/engine#49779)
2024-01-16 dnfield@google.com Fix typo (flutter/engine#49725)
2024-01-16 jason-simmons@users.noreply.github.com Truncate thread names on Linux to the maximum allowed length (flutter/engine#49781)
2024-01-16 dnfield@google.com [Impeller] Fix hot reload for shaders on Impeller (flutter/engine#49739)
2024-01-16 jiahaog@users.noreply.github.com Add `flutter` prefix to import (flutter/engine#49793)
2024-01-16 ivan.inozemtsev@gmail.com Support running sound null safe kernels from dart_runner (flutter/engine#49598)
2024-01-16 bdero@google.com Manually bump Dart to 3.4.0-34.0.dev (flutter/engine#49792)
2024-01-16 49699333+dependabot[bot]@users.noreply.github.com Bump actions/upload-artifact from 3.1.3 to 4.1.0 (flutter/engine#49788)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

0526ca4a