1. 01 Feb, 2016 1 commit
  2. 29 Jan, 2016 1 commit
  3. 18 Jan, 2016 1 commit
    • Ian Hickson's avatar
      Fix some intrinsic constraints contract violations. · 60d9ab7e
      Ian Hickson authored
      RenderBlock wasn't constraining the results.
      RenderPadding wasn't constraining the results (which matters
      especially when the constraints can't fit the padding in the first
      place).
      RenderViewport wasn't constraining the results.
      
      Add a test for the block case.
      
      To catch this kind of thing in the future, add some asserts to
      debugDoesMeetConstraints() that all four intrinsic functions return
      values that are within the constraints.
      
      RenderBlockViewport doesn't support returning intrinsics, so turn off
      the "no intrinsic support" asserts (and return zero) when we're doing
      this new assert.
      
      This new assert screwed up the custom layout classes' tests, so adjust
      those tests to ignore the callbacks invoked from these asserts.
      
      Add to the _debugReportException() method a short summary of the
      descendants of this node. It's important to have this information when
      debugging errors like these intrinsic constraints contract violations
      because often nodes just pass the values through to their child so you
      have to go several steps down to find the actual problem.
      
      Fixes https://github.com/flutter/flutter/issues/1210
      60d9ab7e
  4. 16 Jan, 2016 1 commit
  5. 11 Jan, 2016 1 commit
    • Ian Hickson's avatar
      tightenWidth(), tightenHeight() => tighten(width:, height:) · c21b565f
      Ian Hickson authored
      This makes it more consistent with tightFor(), and also makes it
      easier to tighten both directions at once when you're not sure you
      will always do so (e.g. if you have a height and width that might be
      null, and want to tighten whichever ones aren't null).
      c21b565f
  6. 02 Jan, 2016 3 commits
    • Adam Barth's avatar
      Generalize grid layout · 46a178dc
      Adam Barth authored
      This patch make grid layout much more flexible. The behavior is factored
      out into a GridDelegate that's modeled after the custom layout
      delegates. The patch includes a MaxTileWidthGridDelegate that implements
      the old behavior and a FixedColumnCountGridDelegate that implements a
      grid layout with a fixed number of columns.
      
      Fixes #1048
      46a178dc
    • Adam Barth's avatar
      RenderBox should use Offset for child offset · e9ac6d30
      Adam Barth authored
      Previously we used Position, which makes it harder to accumulate offsets
      when walking the render tree.
      e9ac6d30
    • Adam Barth's avatar
      ScrollbarPainter exception when scrolling MaterialList · 94843700
      Adam Barth authored
      When assigning a new overlayPainter, we were detaching the old overlay
      painter even if the render object itself wasn't attached. Now we only
      twiddle the attach/detach state of the overlay painter when we're
      attached ourselves.
      
      Fixes #1047
      94843700
  7. 17 Dec, 2015 1 commit
    • Hixie's avatar
      Less tree walking for compositing bits updates. · ab01c7bf
      Hixie authored
      Use the same technique for updating compositing bits as layout and
      painting. This avoids walking the entire rendering tree when all you
      need to update is a small subtree.
      ab01c7bf
  8. 16 Dec, 2015 1 commit