Commits · cb50d4a804f6a85fd8c2feec3c5f33c15091e390 · abdullh.alsoleman / Front-End

21 Dec, 2023 7 commits

Reverts "[web] Re-enable test now that source of flakiness is fixed" (#140515) · cb50d4a8

auto-submit[bot] authored Dec 21, 2023

Reverts flutter/flutter#140462
Initiated by: cbracken
This change reverts the following previous change:
Original Description:
The test was flaky before due to overflowing GPU memory during the test. The memory leak was fixed here https://github.com/flutter/engine/pull/49214

Fixes https://github.com/flutter/flutter/issues/137669

As a side effect of the fix, this test also runs much faster, from about 3 minutes on my Macbook down to about 25 seconds.

cb50d4a8

Reland: "Fix how Gradle resolves Android plugin" (#137115) · f5ac225c

Gustl22 authored Dec 21, 2023

Relands #97823

When the tool migrated to `.flutter-plugins-dependencies`, the Gradle plugin was never changed.
Until now, the plugin had the heuristic that a plugin with a `android/build.gradle` file supported the Android platform.

Also applies schema of `getPluginDependencies` to `getPluginList` which uses a `List` of Object instead of `Properties`.

Fixes #97729
Cause of the error: https://github.com/flutter/flutter/blob/5f105a6ca7a5ac7b8bc9b241f4c2d86f4188cf5c/packages/flutter_tools/gradle/flutter.gradle#L421C25-L421C25

Fixes #98048
The deprecated line `include ":$name"` in `settings.gradle` (pluginEach) in old projects causes the `project.rootProject.findProject` to also find the plugin "project", so it is not failing on the `afterEvaluate` method. But the plugin shouldn't be included in the first place as it fails with `Could not find method implementation() for arguments` error in special cases.

Related to #48918, see [_writeFlutterPluginsListLegacy](https://github.com/flutter/flutter/blob/27bc1cf61a5b54bf655062be63050123abb617e4/packages/flutter_tools/lib/src/flutter_plugins.dart#L248).
Co-authored-by: Emmanuel Garcia <egarciad@google.com>

f5ac225c

Roll Packages from dc5b267f3cd1 to 4c3bc496bed2 (1 revision) (#140511) · 430254e1

engine-flutter-autoroll authored Dec 21, 2023

https://github.com/flutter/packages/compare/dc5b267f3cd1...4c3bc496bed2

2023-12-20 15619084+vashworth@users.noreply.github.com Remove workarounds for `check_podspecs` needed for older version of Cocoapods (flutter/packages#5724)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

430254e1

Update README.md (#140382) · 11def8ef

Michael Thomsen authored Dec 21, 2023

Update the "fast results" subsection of readme with recent developments.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat

---------
Co-authored-by: Parker Lougheed <parlough@gmail.com>

11def8ef

Revert "Integrate testWidgets with leak tracking. (#138057)" (#140502) · 8407dd2d
Jim Graham authored Dec 21, 2023
```
The PR is breaking the `flutter_test_performance` test and making the
tree red.
```
8407dd2d
Integrate testWidgets with leak tracking. (#138057) · d746007f
Polina Cherkasova authored Dec 21, 2023
```
Contributes to: https://github.com/flutter/flutter/issues/135856

TODO:
```
d746007f
Fix import pattern (#140425) · c0acd8c4
Qun Cheng authored Dec 21, 2023
```
This PR is just to fix the import pattern to follow the convention.
```
c0acd8c4

20 Dec, 2023 19 commits

Update job permissions (#140476) · cf3760bc

godofredoc authored Dec 20, 2023

Updates to use contents: write and pull-requests: write.

## Pre-launch Checklist

- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [X] I signed the [CLA].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [X] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [X] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat

cf3760bc

Roll pub packages (#140472) · 2d75f76b
flutter-pub-roller-bot authored Dec 20, 2023
```
This PR was generated by `flutter update-packages --force-upgrade`.
```
2d75f76b
Remove outdated ignores from tool (#140467) · 68e346e4
Michael Goderbauer authored Dec 20, 2023
```
These were not ignoring anything (anymore).
```
68e346e4
Remove outdated ignores from framework (#140465) · c4fda233
Michael Goderbauer authored Dec 20, 2023
```
These were not ignoring anything (anymore).
```
c4fda233

Reland `find.textRange.ofSubstring` changes (#140469) · e2e8bcb1

LongCatIsLooong authored Dec 20, 2023

Extracted from https://github.com/flutter/flutter/pull/139717 as-is. Landing this change first so we can avoid doing a g3fix.

e2e8bcb1

Part 1/n migration steps for kotlin migration (#140452) · d6e435a7

Reid Baker authored Dec 20, 2023

Following https://developer.android.com/build/migrate-to-kotlin-dsl
1/n Add parentheses to method calls 

Should be a no-op change. If you see a behavioral change please flag it.

d6e435a7

Reverts "Make `TextSpan` hit testing precise." (#140468) · 9003f138

auto-submit[bot] authored Dec 20, 2023

Reverts flutter/flutter#139717
Initiated by: LongCatIsLooong
This change reverts the following previous change:
Original Description:
Fixes https://github.com/flutter/flutter/issues/131435, #104594, #43400
Needs https://github.com/flutter/engine/pull/48774 (to fix the web test failure).

Currently the method we use for text span hit testing `TextPainter.getPositionForOffset` always returns the closest `TextPosition`, even when the given offset is far away from the text.

The new TextPaintes method tells you the layout bounds (`width = letterspacing / 2 + x_advance + letterspacing / 2`, `height = font ascent + font descent`) of a character, the PR changes the hit testing implementation such that a TextSpan is only considered hit if the point-down event landed in one of it's character's layout bounds.

Potential issues:

1. In theory since the text is baseline aligned, we should use the max ascent and max descent of each character to calculate the height of the text span's hit-test region, in case some characters in the span have to fall back to a different font, but that will be slower and it typically doesn't make a huge difference.

This is a breaking change. It also introduces a new finder and a new method `WidgetTester.tapOnText`: `await tester.tapOnText('string to match')` for ease of migration.

9003f138

[web] Re-enable test now that source of flakiness is fixed (#140462) · 11bfb3c4

Harry Terkelsen authored Dec 20, 2023

The test was flaky before due to overflowing GPU memory during the test.
The memory leak was fixed here
https://github.com/flutter/engine/pull/49214

Fixes https://github.com/flutter/flutter/issues/137669

As a side effect of the fix, this test also runs much faster, from about
3 minutes on my Macbook down to about 25 seconds.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat

11bfb3c4

Eliminate Cirrus build status badge (#140461) · 7b0bfa8c

Chris Bracken authored Dec 20, 2023

We have no tasks running on Cirrus any more. This eliminates the "Build
Status - Cirrus" badge/link as well as the "Build status" link
reference, which was unused.

@CaseyHillers has filed a bug to add a Cocoon endpoint to replace it:
https://github.com/flutter/flutter/issues/140460

## Pre-launch Checklist

- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [X] I signed the [CLA].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [X] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat

7b0bfa8c

Move tests shifted to Pixel 7 from staging to prod (#140438) · 76c8e738
Zachary Anderson authored Dec 20, 2023

76c8e738

Roll Packages from be52ac86bb4f to dc5b267f3cd1 (5 revisions) (#140450) · 0dc3b072

engine-flutter-autoroll authored Dec 20, 2023

https://github.com/flutter/packages/compare/be52ac86bb4f...dc5b267f3cd1

2023-12-20 engine-flutter-autoroll@skia.org Roll Flutter from 0eb78813 to da0cd696 (15 revisions) (flutter/packages#5729)
2023-12-20 49699333+dependabot[bot]@users.noreply.github.com [webview]: Bump androidx.annotation:annotation from 1.7.0 to 1.7.1 in /packages/webview_flutter/webview_flutter_android/android (flutter/packages#5702)
2023-12-19 jsharp83@gmail.com [webview_flutter] Implement platform interface for JavaScript dialog (flutter/packages#5670)
2023-12-19 JeroenWeener@users.noreply.github.com [webview_flutter] Support for handling basic authentication requests (iOS) (flutter/packages#5455)
2023-12-19 engine-flutter-autoroll@skia.org Roll Flutter from cdc83e5e to 0eb78813 (17 revisions) (flutter/packages#5722)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

0dc3b072

_TabBarViewState should not recreate page controller (#135500) · 0d90014b

Bruno Leroux authored Dec 20, 2023

## Description

This PR replaces the unconditional instantiation of `PageController` in `_TabBarViewState.didChangeDependencies` as suggested in https://github.com/flutter/flutter/pull/134091#discussion_r1319177744.

## Related Issue

Fixes https://github.com/flutter/flutter/issues/134253.

## Tests

Adds 1 test.

0d90014b

Revert automated changes made to deprecated settings.gradle (plugins.each) (#140037) · da0cd696

Gustl22 authored Dec 20, 2023

Restore testing deprecated settings.gradle (plugins.each).

Updated presumably by accident in #83067

Split from #137115
See also https://github.com/flutter/flutter/pull/137115#issuecomment-1781909865

da0cd696

[github actions] change minimal example workflow to be manually dispatched (#140435) · 62d69996
Xilai Zhang authored Dec 20, 2023
```
This would allow easier testing of the minimal example.

Might need Github Admin power to trigger the manual dispatches.
```
62d69996

Make `TextSpan` hit testing precise. (#139717) · ea5b9728

LongCatIsLooong authored Dec 20, 2023

Fixes https://github.com/flutter/flutter/issues/131435, #104594, #43400
Needs https://github.com/flutter/engine/pull/48774 (to fix the web test failure).

Currently the method we use for text span hit testing `TextPainter.getPositionForOffset` always returns the closest `TextPosition`, even when the given offset is far away from the text.

Potential issues:

This is a breaking change. It also introduces a new finder and a new method `WidgetTester.tapOnText`: `await tester.tapOnText('string to match')` for ease of migration.

ea5b9728

[github actions] add minimal workflow to test token (#140363) · e86b8258

Xilai Zhang authored Dec 20, 2023

Add a workflow that simply:
1. checkout repo
2. write a file
3. create a PR

This is used to verify the permissions and validity of the github token we use to create PR.
context: https://chat.google.com/room/AAAAc_4rqiI/Ck593Sg7mvs

If we think the triggering condition is complicated, I can also change this workflow to be manual dispatch, to make it truly minimal.

e86b8258

Roll Flutter Engine from 5279873a8635 to c70f0a495ace (2 revisions) (#140431) · 18db55b4

engine-flutter-autoroll authored Dec 20, 2023

https://github.com/flutter/engine/compare/5279873a8635...c70f0a495ace

2023-12-19 skia-flutter-autoroll@skia.org Roll Skia from 48f959a857da to d0f09ad481f7 (3 revisions) (flutter/engine#49264)
2023-12-19 dkwingsmt@users.noreply.github.com Revert "Reland 2: Multiview Pipeline (#47239)" (flutter/engine#49238)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

18db55b4

Roll Flutter Engine from df1593e96a6b to 5279873a8635 (2 revisions) (#140428) · 0ae92601

engine-flutter-autoroll authored Dec 20, 2023

https://github.com/flutter/engine/compare/df1593e96a6b...5279873a8635

2023-12-19 skia-flutter-autoroll@skia.org Roll Dart SDK from e8cdc554c598 to 4c59838945d9 (2 revisions) (flutter/engine#49261)
2023-12-19 flar@google.com Make sure run_tests.py runs dart tests on Skia (flutter/engine#49260)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

0ae92601

[flutter_tools] handle FileSystemException trying to delete temp directory... · ef1227f0

Christopher Fujino authored Dec 20, 2023

[flutter_tools] handle FileSystemException trying to delete temp directory from core_devices.dart (#140415)

Fixes https://github.com/flutter/flutter/issues/140416, the top crasher on stable/3.16.4

ef1227f0

19 Dec, 2023 14 commits

Move hybrid_android_views_integration_test back to Moto G4 (#140421) · ea6017de
Zachary Anderson authored Dec 19, 2023
```
Related https://github.com/flutter/flutter/issues/140420
```
ea6017de

Roll Flutter Engine from 3b156c8ce9bd to df1593e96a6b (2 revisions) (#140422) · 8316e851

engine-flutter-autoroll authored Dec 19, 2023

https://github.com/flutter/engine/compare/3b156c8ce9bd...df1593e96a6b

2023-12-19 zanderso@users.noreply.github.com Rolls clang to 725656bdd885483c39f482a01ea25d67acf39c46 (flutter/engine#49248)
2023-12-19 aam@google.com Roll dart to 3.3.0-242.0.dev (flutter/engine#49239)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

8316e851

Added onEnd callback into AnimatedSize (#139859) · 2bb19a95
Fedor Blagodyr authored Dec 19, 2023
```
close #106439
```
2bb19a95

Roll Flutter Engine from 3f45f9db4471 to 3b156c8ce9bd (1 revision) (#140413) · 5a5683dd

engine-flutter-autoroll authored Dec 19, 2023

https://github.com/flutter/engine/compare/3f45f9db4471...3b156c8ce9bd

2023-12-19 skia-flutter-autoroll@skia.org Roll Skia from df1a7ccbdc97 to 48f959a857da (1 revision) (flutter/engine#49255)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

5a5683dd

Roll Flutter Engine from 187334c39b44 to 3f45f9db4471 (3 revisions) (#140412) · 1fd5d87e

engine-flutter-autoroll authored Dec 19, 2023

https://github.com/flutter/engine/compare/187334c39b44...3f45f9db4471

2023-12-19 skia-flutter-autoroll@skia.org Roll Skia from 541f16af8b3e to df1a7ccbdc97 (3 revisions) (flutter/engine#49250)
2023-12-19 skia-flutter-autoroll@skia.org Roll Skia from 0d39fb28b32d to 541f16af8b3e (1 revision) (flutter/engine#49246)
2023-12-19 john@johnmccutchan.com Use new SurfaceProducer external texture class for rendering platform views (flutter/engine#49201)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

1fd5d87e

Remove workarounds for `plugin_lint_mac` needed for older version of Cocoapods (#140395) · 6981fe6f

Victoria Ashworth authored Dec 19, 2023

CI has been updated to Cocoapods 1.13, which fixes previous issues with the `plugin_lint_mac` test. Remove workarounds added previously.

Fixes https://github.com/flutter/flutter/issues/125812.

See also https://github.com/flutter/flutter/issues/133584.

6981fe6f

Roll Flutter Engine from b87a782ce3a3 to 187334c39b44 (2 revisions) (#140398) · b14d7452

engine-flutter-autoroll authored Dec 19, 2023

https://github.com/flutter/engine/compare/b87a782ce3a3...187334c39b44

2023-12-19 skia-flutter-autoroll@skia.org Roll Skia from 22dad95c218f to 0d39fb28b32d (2 revisions) (flutter/engine#49241)
2023-12-19 skia-flutter-autoroll@skia.org Roll Skia from 6496c9c5866a to 22dad95c218f (4 revisions) (flutter/engine#49237)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

b14d7452

Roll Flutter Engine from 1d5a141917fa to b87a782ce3a3 (1 revision) (#140390) · 837ba409

engine-flutter-autoroll authored Dec 19, 2023

https://github.com/flutter/engine/compare/1d5a141917fa...b87a782ce3a3

2023-12-19 skia-flutter-autoroll@skia.org Roll Skia from ed0148ab400d to 6496c9c5866a (6 revisions) (flutter/engine#49234)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

837ba409

Shift some Linux-hosted tests on moto g4 to pixel 7 (#140389) · 0eb78813
Zachary Anderson authored Dec 19, 2023

0eb78813

Reland "Warn when Gradle plugins are applied using the legacy apply script method (#140103) · a1e1dc3f

Bartek Pacia authored Dec 19, 2023

> This PR relands #139690 which was reverted in #140102

This PR adds a deprecation message when Android build is using the legacy "apply script method" way of applying Flutter's Gradle plugins (that is: [`flutter.gradle`](https://github.com/flutter/flutter/blob/3.16.0/packages/flutter_tools/gradle/flutter.gradle) and [`app_plugin_loader.gradle`](https://github.com/flutter/flutter/blob/3.16.0/packages/flutter_tools/gradle/app_plugin_loader.gradle)).

See also:
- #121541
  - in particular https://github.com/flutter/flutter/issues/121541#issuecomment-1836947311
- #135392
  - and PR that add the migration guide: [#9857](https://github.com/flutter/website/pull/9857)

- I think either `logger.error` or `logger.quiet` must be used, because all other error levels are not shown during `flutter build apk` (and that's what most people use).

a1e1dc3f

Roll Packages from d7dee796f3c8 to be52ac86bb4f (1 revision) (#140386) · df678135

engine-flutter-autoroll authored Dec 19, 2023

https://github.com/flutter/packages/compare/d7dee796f3c8...be52ac86bb4f

2023-12-18 engine-flutter-autoroll@skia.org Roll Flutter from 2407f699 to cdc83e5e (28 revisions) (flutter/packages#5715)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

df678135

Roll Flutter Engine from bde7c612f6ba to 1d5a141917fa (3 revisions) (#140371) · bbfe177d

engine-flutter-autoroll authored Dec 19, 2023

https://github.com/flutter/engine/compare/bde7c612f6ba...1d5a141917fa

2023-12-19 skia-flutter-autoroll@skia.org Roll Skia from c12c2a174327 to ed0148ab400d (1 revision) (flutter/engine#49222)
2023-12-19 49699333+dependabot[bot]@users.noreply.github.com Bump actions/upload-artifact from 3.1.3 to 4.0.0 (flutter/engine#49220)
2023-12-19 skia-flutter-autoroll@skia.org Roll Skia from 27ab8a8d2a0d to c12c2a174327 (1 revision) (flutter/engine#49218)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

bbfe177d

Roll Flutter Engine from 42af8f106206 to bde7c612f6ba (2 revisions) (#140367) · 51633fe9

engine-flutter-autoroll authored Dec 19, 2023

https://github.com/flutter/engine/compare/42af8f106206...bde7c612f6ba

2023-12-19 academy3746@gmail.com Makes PlatformViewsController view to use tracked event's action & pointer count (flutter/engine#47424)
2023-12-19 skia-flutter-autoroll@skia.org Roll Skia from 37a60129e019 to 27ab8a8d2a0d (1 revision) (flutter/engine#49213)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

51633fe9

Roll Flutter Engine from bbfee6f59b42 to 42af8f106206 (1 revision) (#140362) · 2ed0df84

engine-flutter-autoroll authored Dec 19, 2023

https://github.com/flutter/engine/compare/bbfee6f59b42...42af8f106206

2023-12-19 skia-flutter-autoroll@skia.org Roll Skia from e5b0cdc11992 to 37a60129e019 (1 revision) (flutter/engine#49212)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

2ed0df84