Commits · cb4b4d4ac93981d9f22aa17ce5e10b22346b4700 · abdullh.alsoleman / Front-End

25 Sep, 2023 15 commits

[macOS,iOS] Improve CocoaPods upgrade instructions (#135453) · cb4b4d4a

Chris Bracken authored Sep 25, 2023

In our CocoaPods doctor check, if the version of CocoaPods is found to
be too low, rather than emitting a link to the install instructions,
emit a link to the upgrade instructions.

Since this check operates on CocoaPodsStatus, an enum, swtich to using a
case statement and cover all cases.


## Pre-launch Checklist

- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [X] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [X] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [X] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat

cb4b4d4a

Fix and Test Conditional Validator Behavior in FormField (#132714) · 79caa837

Edgar Jan authored Sep 25, 2023

In the FormField widget, if a validator is initially set (and validation fails), then subsequently the validator is set to null, the form incorrectly retains its error state. This is not expected behavior as removing the validator should clear any validation errors.

79caa837

[Velocity Tracker] Fix: Issue 97761: Flutter Scrolling does not match iOS;... · fffbbf27

Chip Weinberger authored Sep 25, 2023

[Velocity Tracker] Fix: Issue 97761: Flutter Scrolling does not match iOS; inadvertent scrolling when user lifts up finger (#132291)

## Issue

**Issue:** https://github.com/flutter/flutter/issues/97761

https://github.com/flutter/flutter/assets/1863934/53c5e0df-b85a-483c-a17d-bddd18db3aa9

## The Cause:

The bug is very simple to understand - `velocity_tracker.dart` **only adds new samples while your finger is moving**.

**Therefore**, if you move your finger quickly & (important) stop suddenly with no extra movement, the last 3 samples will all be > 0 dy. Regardless of how long you wait, you will get movement when you lift up your finger.

**Logs from velocity_tracker.dart:**
Notice: all 3 `_previousVelocityAt` are `dy > 0` despite a 2 second delay since the last scroll
```
// start moving finger
flutter: addPosition dy:-464.0
flutter: addPosition dy:-465.0
flutter: addPosition dy:-466.0
flutter: addPosition dy:-467.0
flutter: addPosition dy:-468.0
flutter: addPosition dy:-469.0
flutter: addPosition dy:-470.0
// stop moving finger here, keep it still for 2 seconds & lift it up
flutter: _previousVelocityAt(-2) samples(-467.0, -468.0)) dy:-176.772140710624
flutter: _previousVelocityAt(-1) samples(-468.0, -469.0)) dy:-375.0937734433609
flutter: _previousVelocityAt(0) samples(-469.0, -470.0)) dy:-175.71604287471447
flutter: primaryVelocity DragEndDetails(Velocity(0.0, -305.5)).primaryVelocity
flutter: createBallisticSimulation pixels 464.16666666666663 velocity 305.4699824197211
```

## The Fix

**There are 3 options to fix it:**
A. sample uniformly *per unit time* (a larger more risky change, hurts battery life)
B. consider elapsed time since the last sample. If greater than X, assume no more velocity. (easy & just as valid)
C. similar to B, but instead add "ghost samples" of velocity zero, and run calculations as normal (a bit tricker, of dubious benefit imo)

**For Option B I considered two approaches:**
1. _get the current timestamp and compare to event timestamp._ This is tricky because events are documented to use an arbitrary timescale & I wasn't able to find the code that generates the timestamps. This approach could be considered more.
2. _get a new timestamp using Stopwatch and compare now vs when the last sample was added._ This is the solution implemented here. There is a limitation in that we don't know when addSamples is called relative to the event. But, this estimation is already on a very low latency path & still it gives us a *minimum* time bound which is sufficient for comparison.

**This PR chooses the simplest of the all solutions. Please try it our yourself, it completely solves the problem ð** Option _B.1_ would be a nice alternative as well, if we can define and access the same timesource as the pointer tracker in a maintainable simple way.

## After Fix

https://github.com/flutter/flutter/assets/1863934/be50d8e7-d5da-495a-a4af-c71bc541cbe3

fffbbf27

simulatedAccessibilityTraversal account for force merging (#135178) · 52914c76
chunhtai authored Sep 25, 2023
```
fixes https://github.com/flutter/flutter/issues/135144
```
52914c76

Roll Flutter Engine from 2c4c1108aa87 to 1ae3d20332f0 (4 revisions) (#135438) · def17532

engine-flutter-autoroll authored Sep 25, 2023

https://github.com/flutter/engine/compare/2c4c1108aa87...1ae3d20332f0

2023-09-25 54558023+keyonghan@users.noreply.github.com Switch goma to reclient for Linux host engine targets (flutter/engine#45884)
2023-09-25 skia-flutter-autoroll@skia.org Roll Skia from 7a49397a02b4 to e16a9b5b2c48 (1 revision) (flutter/engine#46258)
2023-09-25 skia-flutter-autoroll@skia.org Roll Skia from 569a30fbdbdf to 7a49397a02b4 (2 revisions) (flutter/engine#46257)
2023-09-25 skia-flutter-autoroll@skia.org Roll Skia from 31ceb1669d1c to 569a30fbdbdf (1 revision) (flutter/engine#46256)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

def17532

Roll Packages from 98ebcd3d9c05 to e548ae1d2045 (5 revisions) (#135431) · 4ae2e91c

engine-flutter-autoroll authored Sep 25, 2023

https://github.com/flutter/packages/compare/98ebcd3d9c05...e548ae1d2045

2023-09-23 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.21.7 to 2.21.8 (flutter/packages#4952)
2023-09-23 engine-flutter-autoroll@skia.org Manual roll Flutter from 89365041 to f92884c7 (48 revisions) (flutter/packages#4985)
2023-09-22 geral.sbi2@gmail.com [image_picker_android] check if data from result is empty when picking a single img or video (flutter/packages#4836)
2023-09-22 me@nils.re [camera_android] Removes usage of `_ambiguate` method in tests (flutter/packages#4948)
2023-09-22 49699333+dependabot[bot]@users.noreply.github.com [sign_in]: Bump com.google.android.gms:play-services-auth from 20.6.0 to 20.7.0 in /packages/google_sign_in/google_sign_in_android/android (flutter/packages#4841)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

4ae2e91c

Roll Flutter Engine from e6d3bac5c723 to 2c4c1108aa87 (1 revision) (#135424) · 9c7ab901

engine-flutter-autoroll authored Sep 25, 2023

https://github.com/flutter/engine/compare/e6d3bac5c723...2c4c1108aa87

2023-09-25 49699333+dependabot[bot]@users.noreply.github.com Bump archive from 3.3.9 to 3.4.2 in /lib/web_ui (flutter/engine#46253)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

9c7ab901

Revert "Marks Linux_pixel_7pro hello_world_impeller to be unflaky" (#135388) · 16ae8c01
Zachary Anderson authored Sep 25, 2023
```
Reverts flutter/flutter#135372
```
16ae8c01

Roll Flutter Engine from e1c1022c2d6d to e6d3bac5c723 (2 revisions) (#135410) · 3c4b81da

engine-flutter-autoroll authored Sep 25, 2023

https://github.com/flutter/engine/compare/e1c1022c2d6d...e6d3bac5c723

2023-09-25 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from VKAiabs4VzJ1Py-oA... to uY9WEf2tJxa1Hpp4v... (flutter/engine#46252)
2023-09-25 skia-flutter-autoroll@skia.org Roll Skia from b8bc0c080aa8 to 31ceb1669d1c (1 revision) (flutter/engine#46249)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from VKAiabs4VzJ1 to uY9WEf2tJxa1

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

3c4b81da

Roll Flutter Engine from 3ea1174ecfaa to e1c1022c2d6d (2 revisions) (#135403) · d5a8cd38

engine-flutter-autoroll authored Sep 25, 2023

https://github.com/flutter/engine/compare/3ea1174ecfaa...e1c1022c2d6d

2023-09-25 skia-flutter-autoroll@skia.org Roll Skia from 983f42f4c76b to b8bc0c080aa8 (1 revision) (flutter/engine#46247)
2023-09-25 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from 0Jl20zAW45rRsTNEu... to SNqQGAfjWL3PbUABh... (flutter/engine#46246)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from 0Jl20zAW45rR to SNqQGAfjWL3P

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

d5a8cd38

Roll Flutter Engine from 2daf5e7bb249 to 3ea1174ecfaa (4 revisions) (#135396) · be085a92

engine-flutter-autoroll authored Sep 25, 2023

https://github.com/flutter/engine/compare/2daf5e7bb249...3ea1174ecfaa

2023-09-25 zanderso@users.noreply.github.com In run_tests.py, separate Dart package unit tests from other tests (flutter/engine#46232)
2023-09-24 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from SqWjDvrDsMfiisUoA... to VKAiabs4VzJ1Py-oA... (flutter/engine#46241)
2023-09-24 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from W1uZC0_FbXyoCmwJ1... to 0Jl20zAW45rRsTNEu... (flutter/engine#46240)
2023-09-24 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from M-fNM9YP2Lpc8Y_Dj... to SqWjDvrDsMfiisUoA... (flutter/engine#46239)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from M-fNM9YP2Lpc to VKAiabs4VzJ1
fuchsia/sdk/core/mac-amd64 from W1uZC0_FbXyo to 0Jl20zAW45rR

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

be085a92

Add a basic golden test for `CupertinoTextSelectionToolbar` (#135267) · 6a9df55d

LongCatIsLooong authored Sep 25, 2023

Goden tests are easier to understand than `paints..` since the toolbar has a relatively complex path, and this should make PRs that make visual changes easier to review. 

The current goldens don't look correct since I messed up the y offset of the tip of the arrow when the arrow is pointing up. Should be fixed in https://github.com/flutter/flutter/pull/133386

6a9df55d

Revert "Marks Linux_samsung_a02 new_gallery__transition_perf to be unflaky" (#135399) · 07ce6a76
godofredoc authored Sep 25, 2023
```
Reverts flutter/flutter#135373
```
07ce6a76

Marks Linux_samsung_a02 new_gallery__transition_perf to be unflaky (#135373) · 2f56288a

Flutter GitHub Bot authored Sep 25, 2023

<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Linux_samsung_a02 new_gallery__transition_perf"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Linux_samsung_a02%20new_gallery__transition_perf%22).
This test can be marked as unflaky.

2f56288a

Fix failing test at master. (#135394) · 49f1a6bb
Polina Cherkasova authored Sep 25, 2023

49f1a6bb

24 Sep, 2023 12 commits

Marks Linux_pixel_7pro hello_world_impeller to be unflaky (#135372) · 797d34e5

Flutter GitHub Bot authored Sep 24, 2023

<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Linux_pixel_7pro hello_world_impeller"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Linux_pixel_7pro%20hello_world_impeller%22).
This test can be marked as unflaky.

797d34e5

Marks Windows_android channels_integration_test_win to be unflaky (#135374) · a6e98d30

Flutter GitHub Bot authored Sep 24, 2023

<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Windows_android channels_integration_test_win"
}
-->
The issue https://github.com/flutter/flutter/issues/134636 has been closed, and the test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Windows_android%20channels_integration_test_win%22).
This test can be marked as unflaky.

a6e98d30

Marks Mac_ios draw_atlas_perf_ios__timeline_summary to be unflaky (#134626) · 8bc223e3

Flutter GitHub Bot authored Sep 24, 2023

<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Mac_ios draw_atlas_perf_ios__timeline_summary"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Mac_ios%20draw_atlas_perf_ios__timeline_summary%22).
This test can be marked as unflaky.

8bc223e3

Marks Mac_ios draw_vertices_perf_ios__timeline_summary to be unflaky (#134625) · 2c1f517d

Flutter GitHub Bot authored Sep 24, 2023

<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Mac_ios draw_vertices_perf_ios__timeline_summary"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Mac_ios%20draw_vertices_perf_ios__timeline_summary%22).
This test can be marked as unflaky.

2c1f517d

Marks Windows module_test to be unflaky (#134121) · 417aaf5b

Flutter GitHub Bot authored Sep 24, 2023

<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Windows module_test"
}
-->
The issue https://github.com/flutter/flutter/issues/133639 has been closed, and the test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Windows%20module_test%22).
This test can be marked as unflaky.

417aaf5b

Marks Mac_ios dynamic_path_tessellation_perf_ios__timeline_summary to be unflaky (#133128) · c0bde99e

Flutter GitHub Bot authored Sep 24, 2023

<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Mac_ios dynamic_path_tessellation_perf_ios__timeline_summary"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Mac_ios%20dynamic_path_tessellation_perf_ios__timeline_summary%22).
This test can be marked as unflaky.

c0bde99e

Marks Mac_ios draw_points_perf_ios__timeline_summary to be unflaky (#127933) · 6240c899

Flutter GitHub Bot authored Sep 24, 2023

<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Mac_ios draw_points_perf_ios__timeline_summary"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Mac_ios%20draw_points_perf_ios__timeline_summary%22).
This test can be marked as unflaky.

6240c899

Marks Linux_pixel_7pro picture_cache_perf__timeline_summary to be unflaky (#134118) · 260c16cf

Flutter GitHub Bot authored Sep 24, 2023

<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Linux_pixel_7pro picture_cache_perf__timeline_summary"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Linux_pixel_7pro%20picture_cache_perf__timeline_summary%22).
This test can be marked as unflaky.

260c16cf

Roll Flutter Engine from ee27600dfbe2 to 2daf5e7bb249 (1 revision) (#135371) · 713272eb

engine-flutter-autoroll authored Sep 24, 2023

https://github.com/flutter/engine/compare/ee27600dfbe2...2daf5e7bb249

2023-09-24 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from de4D1aoqF6LBk18Rd... to W1uZC0_FbXyoCmwJ1... (flutter/engine#46238)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from de4D1aoqF6LB to W1uZC0_FbXyo

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

713272eb

Marks Mac_ios very_long_picture_scrolling_perf_ios__e2e_summary to be unflaky (#134629) · 82a972bf

Flutter GitHub Bot authored Sep 24, 2023

<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Mac_ios very_long_picture_scrolling_perf_ios__e2e_summary"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Mac_ios%20very_long_picture_scrolling_perf_ios__e2e_summary%22).
This test can be marked as unflaky.

82a972bf

Marks Mac_ios animated_advanced_blend_perf_ios__timeline_summary to be unflaky (#132630) · 389d482a

Flutter GitHub Bot authored Sep 24, 2023

<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Mac_ios animated_advanced_blend_perf_ios__timeline_summary"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Mac_ios%20animated_advanced_blend_perf_ios__timeline_summary%22).
This test can be marked as unflaky.

389d482a

Marks Mac_ios static_path_tessellation_perf_ios__timeline_summary to be unflaky (#133127) · 3ba8472a

Flutter GitHub Bot authored Sep 24, 2023

<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Mac_ios static_path_tessellation_perf_ios__timeline_summary"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Mac_ios%20static_path_tessellation_perf_ios__timeline_summary%22).
This test can be marked as unflaky.

3ba8472a

23 Sep, 2023 9 commits

Marks Linux_android platform_channels_benchmarks to be flaky (#135106) · 4f5c8155

Flutter GitHub Bot authored Sep 23, 2023

<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Linux_android platform_channels_benchmarks"
}
-->
Issue link: https://github.com/flutter/flutter/issues/135105

4f5c8155

Marks Linux_android flutter_gallery__start_up_delayed to be flaky (#134632) · 6d4a5e3d

Flutter GitHub Bot authored Sep 23, 2023

<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Linux_android flutter_gallery__start_up_delayed"
}
-->
Issue link: https://github.com/flutter/flutter/issues/134631

6d4a5e3d

Marks Linux_android... · 6d88ade7

Flutter GitHub Bot authored Sep 23, 2023

Marks Linux_android opacity_peephole_grid_of_alpha_savelayers_perf__e2e_summary to be flaky (#135119)

<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Linux_android opacity_peephole_grid_of_alpha_savelayers_perf__e2e_summary"
}
-->
Issue link: https://github.com/flutter/flutter/issues/135118

6d88ade7

Roll Flutter Engine from 614859053262 to ee27600dfbe2 (1 revision) (#135364) · 69004a89

engine-flutter-autoroll authored Sep 23, 2023

https://github.com/flutter/engine/compare/614859053262...ee27600dfbe2

2023-09-23 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from PCEkaltiQ-iEKlmEj... to M-fNM9YP2Lpc8Y_Dj... (flutter/engine#46231)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from PCEkaltiQ-iE to M-fNM9YP2Lpc

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

69004a89

Roll Flutter Engine from 564480337eae to 614859053262 (7 revisions) (#135362) · 76716272

engine-flutter-autoroll authored Sep 23, 2023

https://github.com/flutter/engine/compare/564480337eae...614859053262

2023-09-23 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from M9rDyhmn7VY4iTxzQ... to de4D1aoqF6LBk18Rd... (flutter/engine#46229)
2023-09-23 ychris@google.com [ios] Fix default assets url (flutter/engine#46214)
2023-09-23 skia-flutter-autoroll@skia.org Roll Skia from 15ccdeaba011 to 983f42f4c76b (1 revision) (flutter/engine#46223)
2023-09-23 chillers@google.com Revert "[Impeller] fail if software backend is chosen and Impeller is enabled on iOS" (flutter/engine#46217)
2023-09-23 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from QcxgV9KlY7j3o3b4j... to PCEkaltiQ-iEKlmEj... (flutter/engine#46221)
2023-09-22 jonahwilliams@google.com [Impeller] dont treat non-rects as rects. (flutter/engine#46218)
2023-09-22 skia-flutter-autoroll@skia.org Roll Skia from e9358f92110c to 15ccdeaba011 (1 revision) (flutter/engine#46216)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from QcxgV9KlY7j3 to PCEkaltiQ-iE
fuchsia/sdk/core/mac-amd64 from M9rDyhmn7VY4 to de4D1aoqF6LB

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

76716272

Roll Flutter Engine from e4bfdc1a67de to 564480337eae (4 revisions) (#135341) · f5d91854

engine-flutter-autoroll authored Sep 23, 2023

https://github.com/flutter/engine/compare/e4bfdc1a67de...564480337eae

2023-09-22 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from ZyajVWocCHVIuJkzM... to M9rDyhmn7VY4iTxzQ... (flutter/engine#46215)
2023-09-22 skia-flutter-autoroll@skia.org Roll Dart SDK from 4ddff752a6b0 to 692273b46610 (1 revision) (flutter/engine#46212)
2023-09-22 skia-flutter-autoroll@skia.org Roll Skia from 78fced84372d to e9358f92110c (4 revisions) (flutter/engine#46211)
2023-09-22 bdero@google.com [Impeller] Incorporate backdrop filters in subpass coverage. (flutter/engine#46130)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from ZyajVWocCHVI to M9rDyhmn7VY4

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

f5d91854

[iOS,macOS] Clean up obsolete PlatformView warning (#135040) · 6379648b

Chris Bracken authored Sep 23, 2023

PlatformViews have been supported without a custom engine build on iOS
for quite some time now, and are nearing support for macOS. Adds a link
to the website documentation covering creation of PlatformViews for iOS
and adds a TODO to do the same once the macOS PlatformView documentation
is ready.

Related: https://github.com/flutter/website/issues/9424

6379648b

Move some tests from staging to prod (#135333) · 70fd3350
Zachary Anderson authored Sep 23, 2023
```
This PR moves tests running on Pixel 7 Pro that use Skia from staging to prod.
```
70fd3350
Convert relative to absolute import. (#135337) · 1d769955
Polina Cherkasova authored Sep 23, 2023
```
Requested here: https://github.com/flutter/flutter/pull/133952#discussion_r1334860858
```
1d769955

22 Sep, 2023 4 commits

Roll Flutter Engine from 954ea95be336 to e4bfdc1a67de (1 revision) (#135332) · 57ccf3a5

engine-flutter-autoroll authored Sep 22, 2023

https://github.com/flutter/engine/compare/954ea95be336...e4bfdc1a67de

2023-09-22 skia-flutter-autoroll@skia.org Roll Skia from 8a1e6e5844d7 to 78fced84372d (4 revisions) (flutter/engine#46207)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

57ccf3a5

TabController should dispatch creation in constructor. (#133952) · 49e16867
Polina Cherkasova authored Sep 22, 2023

49e16867
Fix _paintAvatar in chip.dart to dispose layer. (#135228) · c00e9798
Polina Cherkasova authored Sep 22, 2023

c00e9798
Fix memory leak in _MatchesReferenceImage (#135150) · a4e3f933
Kostia Sokolovskyi authored Sep 22, 2023

a4e3f933