Commits · cb29b406931692e2309342910c49d0691c3d5923 · abdullh.alsoleman / Front-End

12 Mar, 2024 3 commits

Roll Packages from d489d84c359b to d1aeb26e1b43 (3 revisions) (#144994) · cb29b406

engine-flutter-autoroll authored Mar 12, 2024

https://github.com/flutter/packages/compare/d489d84c359b...d1aeb26e1b43

2024-03-12 engine-flutter-autoroll@skia.org Manual roll Flutter from 3bb2e594 to 1ca88730 (11 revisions) (flutter/packages#6304)
2024-03-11 engine-flutter-autoroll@skia.org Roll Flutter from 7c89ec8b to 3bb2e594 (31 revisions) (flutter/packages#6300)
2024-03-11 engine-flutter-autoroll@skia.org Manual roll Flutter from 7c89ec8b to 3bb2e594 (31 revisions) (flutter/packages#6299)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

cb29b406

Add platform check to `FocusManager` app lifecycle listener (#144718) · 61812ca3

Nate authored Mar 12, 2024

This PR implements a temporary fix for the mobile device keyboard bug reported in [this comment](https://github.com/flutter/flutter/pull/142930#issuecomment-1981750069).

CC @gspencergoog

61812ca3

Update integration tests regexes. (#144847) · 1ca88730

godofredoc authored Mar 12, 2024

Some tests are assuming the flutter sdk code is being checked out to flutter and checking the code to a different repository makes them fail.

Bug: https://github.com/flutter/flutter/issues/144487

1ca88730

11 Mar, 2024 13 commits

Reverts "Fail tests on exceptions raised after test completed (#144706)" (#144970) · 49f45d20

auto-submit[bot] authored Mar 11, 2024

Reverts: flutter/flutter#144706
Initiated by: gspencergoog
Reason for reverting: This has broken the tree because some tests are still failing post completion. This particular one looks like it might have to do with a gold image not existing.
Original PR Author: goderbauer

Reviewed By: {Piinks}

This change reverts the following previous change:
A test was failing silently because of this (see https://github.com/flutter/flutter/issues/144353 and fixed in https://github.com/flutter/flutter/pull/144709). The failure went undetected for months. Ideally, this should have been a regular non-silent failure. This change makes that so. `package:test` can properly handle reported exceptions outside of test cases. With this change, the test fails as follows:

```
00:03 +82: Smoke test material/color_scheme/dynamic_content_color.0.dart
══╡ EXCEPTION CAUGHT BY FLUTTER TEST FRAMEWORK ╞════════════════════════════════════════════════════
The following assertion was thrown running a test (but after the test had completed):
setState() called after dispose(): _DynamicColorExampleState#1cd37(lifecycle state: defunct, not
mounted)
This error happens if you call setState() on a State object for a widget that no longer appears in
the widget tree (e.g., whose parent widget no longer includes the widget in its build). This error
can occur when code calls setState() from a timer or an animation callback.
The preferred solution is to cancel the timer or stop listening to the animation in the dispose()
callback. Another solution is to check the "mounted" property of this object before calling
setState() to ensure the object is still in the tree.
This error might indicate a memory leak if setState() is being called because another object is
retaining a reference to this State object after it has been removed from the tree. To avoid memory
leaks, consider breaking the reference to this object during dispose().

When the exception was thrown, this was the stack:
#0 State.setState.<anonymous closure> (package:flutter/src/widgets/framework.dart:1167:9)
#1 State.setState (package:flutter/src/widgets/framework.dart:1202:6)
#2 _DynamicColorExampleState._updateImage (package:flutter_api_samples/material/color_scheme/dynamic_content_color.0.dart:191:5)
<asynchronous suspension>
════════════════════════════════════════════════════════════════════════════════════════════════════
00:03 +81 -1: Smoke test material/context_menu/context_menu_controller.0.dart
00:03 +81 -1: Smoke test material/color_scheme/dynamic_content_color.0.dart [E]
Test failed. See exception logs above.
The test description was: Smoke test material/color_scheme/dynamic_content_color.0.dart

This test failed after it had already completed.
Make sure to use a matching library which informs the test runner
of pending async work.
```

49f45d20

Make TabController communicating creation in constructor. (#144912) · e66811ae
Polina Cherkasova authored Mar 11, 2024
```
Contributes to https://github.com/flutter/flutter/issues/144910
```
e66811ae

Fail tests on exceptions raised after test completed (#144706) · 91cccc8e

Michael Goderbauer authored Mar 11, 2024

A test was failing silently because of this (see
https://github.com/flutter/flutter/issues/144353 and fixed in
https://github.com/flutter/flutter/pull/144709). The failure went
undetected for months. Ideally, this should have been a regular
non-silent failure. This change makes that so. `package:test` can
properly handle reported exceptions outside of test cases. With this
change, the test fails as follows:

This test failed after it had already completed.
Make sure to use a matching library which informs the test runner
of pending async work.
```

91cccc8e

Refactoring `if` chains into `switch` statements (#144905) · 26e379e0

Nate authored Mar 11, 2024

Based on issue #144903, this PR aims to bring the codebase more in line with the [Flutter repo style guide](https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#avoid-using-if-chains-or--or--with-enum-values):

> #### Avoid using `if` chains or `?:` or `==` with enum values

<br>

This change unfortunately increases the total line length, but it also improves readability.

26e379e0

Reverts "Expose build mode in environment of asset transformer processes (#144752)" (#144957) · 187ec75e

auto-submit[bot] authored Mar 11, 2024

Reverts: flutter/flutter#144752
Initiated by: andrewkolos
Reason for reverting: compilation issue has turned the tree red
Original PR Author: andrewkolos

Reviewed By: {christopherfujino}

This change reverts the following previous change:
In service of https://github.com/flutter/flutter/issues/143348

When invoking a package to transform an asset, we set `FLUTTER_BUILD_MODE` to the CLI name of the build mode being used. Inspired by https://github.com/flutter/flutter/issues/101077#issuecomment-1890379501:

> Do transformers know whether they get executed in debug or release mode? I kinda imagine that being useful. Ex: There's a transformer that optimizes the file size of images. Depending on the amount and size of the images, that could take a significant amount of time. Therefore, I might want to only execute it in release builds.

Note for the reviewer: the interesting part of this change can be found in the commit [set environment variable to build mode when running asset transformer…](https://github.com/flutter/flutter/pull/144752/commits/579912d470b6f6eb036fd6b23a128fa3942f6282). The rest of the change is updating call sites with a new argument.

187ec75e

Expose build mode in environment of asset transformer processes (#144752) · 83fad745

Andrew Kolos authored Mar 11, 2024

In service of https://github.com/flutter/flutter/issues/143348

When invoking a package to transform an asset, we set `FLUTTER_BUILD_MODE` to the CLI name of the build mode being used. Inspired by https://github.com/flutter/flutter/issues/101077#issuecomment-1890379501:

> Do transformers know whether they get executed in debug or release mode? I kinda imagine that being useful. Ex: There's a transformer that optimizes the file size of images. Depending on the amount and size of the images, that could take a significant amount of time. Therefore, I might want to only execute it in release builds.

Note for the reviewer: the interesting part of this change can be found in the commit [set environment variable to build mode when running asset transformerâ¦](https://github.com/flutter/flutter/pull/144752/commits/579912d470b6f6eb036fd6b23a128fa3942f6282). The rest of the change is updating call sites with a new argument.

83fad745

Roll Flutter Engine from 9196947bc687 to 6745955bb49e (2 revisions) (#144946) · d98d842d

engine-flutter-autoroll authored Mar 11, 2024

https://github.com/flutter/engine/compare/9196947bc687...6745955bb49e

2024-03-11 zanderso@users.noreply.github.com Remove flaky check from observatory/tracing_test.dart (flutter/engine#51320)
2024-03-11 skia-flutter-autoroll@skia.org Roll Skia from cb30f40eea75 to f8d5ecc7841d (4 revisions) (flutter/engine#51321)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

d98d842d

Skip test temporarily until headingLevel is added in engine (issue 41… (#135077) · b9afa60f

victorgalo authored Mar 11, 2024

The purpose of this PR is to temporarily skip one integration test that is blocking the changes indicated below:

(This change adds a new property in Semantics widget that would take an integer corresponding to the heading levels defined by the ARIA heading role. This is necessary in order to get proper accessibility and usability in a website for users who rely on screen readers and other assistive technologies.)

Issue fixed by this PR:
https://github.com/flutter/flutter/issues/97894

Engine part:
https://github.com/flutter/engine/pull/41435 

Framework part:
https://github.com/flutter/flutter/pull/125771

b9afa60f

Roll Flutter Engine from 3b0b59bb224d to 9196947bc687 (1 revision) (#144934) · 505a5153

engine-flutter-autoroll authored Mar 11, 2024

https://github.com/flutter/engine/compare/3b0b59bb224d...9196947bc687

2024-03-11 skia-flutter-autoroll@skia.org Roll Skia from e6b884229d2d to cb30f40eea75 (1 revision) (flutter/engine#51318)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

505a5153

Roll Packages from 0badb4356021 to d489d84c359b (3 revisions) (#144931) · b8d01ce6

engine-flutter-autoroll authored Mar 11, 2024

https://github.com/flutter/packages/compare/0badb4356021...d489d84c359b

2024-03-08 reidbaker@google.com [in_app_purchase_android] Add UserChoiceBilling mode. (flutter/packages#6162)
2024-03-08 engine-flutter-autoroll@skia.org Roll Flutter from 471a8285 to 7c89ec8b (15 revisions) (flutter/packages#6288)
2024-03-08 engine-flutter-autoroll@skia.org Roll Flutter (stable) from 7482962148e8 to ba3931984302 (2 revisions) (flutter/packages#6287)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

b8d01ce6

Roll Flutter Engine from 210f84eb818b to 3b0b59bb224d (1 revision) (#144923) · 3bb2e594

engine-flutter-autoroll authored Mar 11, 2024

https://github.com/flutter/engine/compare/210f84eb818b...3b0b59bb224d

2024-03-11 43091780+utzcoz@users.noreply.github.com Bump Robolectric to 4.11.1 (flutter/engine#51310)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

3bb2e594

Roll Flutter Engine from d13999c0ca79 to 210f84eb818b (1 revision) (#144920) · 8e12e133

engine-flutter-autoroll authored Mar 11, 2024

https://github.com/flutter/engine/compare/d13999c0ca79...210f84eb818b

2024-03-11 jiahaog@users.noreply.github.com Disambiguate conditional expressions (flutter/engine#51285)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

8e12e133

Roll Flutter Engine from 7c2a56a44b41 to d13999c0ca79 (1 revision) (#144907) · 087b15ae

engine-flutter-autoroll authored Mar 11, 2024

https://github.com/flutter/engine/compare/7c2a56a44b41...d13999c0ca79

2024-03-11 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from gJ4Wr2FSpnGmoN3ke... to L6_XzizcJqjneCvGA... (flutter/engine#51317)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from gJ4Wr2FSpnGm to L6_XzizcJqjn

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

087b15ae

10 Mar, 2024 3 commits

Rename isAvailableForEnvironment to isForEnvironment (#143176) (#144858) · dbcce277

Ian Hickson authored Mar 10, 2024

This is part 4 of a broken down version of the #140101 refactor.

This PR renames isAvailableForEnvironment to isForEnvironment and replaces a regular expression with a simple function. (The latter will change the behaviour for people with branch names like `mainly_refactors` or `chess_master_experiment` or whatever, but I'm pretty sure the old behaviour was not intended.)

----

This is a reland of https://github.com/flutter/flutter/pull/143176 which was speculatively reverted in https://github.com/flutter/flutter/pull/144855 but turned out not to be the cause of the tree redness.

dbcce277

Roll Flutter Engine from f77664330122 to 7c2a56a44b41 (1 revision) (#144894) · 640d212b

engine-flutter-autoroll authored Mar 10, 2024

https://github.com/flutter/engine/compare/f77664330122...7c2a56a44b41

2024-03-10 skia-flutter-autoroll@skia.org Roll Skia from 8b92038ff67f to e6b884229d2d (1 revision) (flutter/engine#51316)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

640d212b

Roll Flutter Engine from 51fefde43cb3 to f77664330122 (1 revision) (#144891) · 6eb3ce9e

engine-flutter-autoroll authored Mar 10, 2024

https://github.com/flutter/engine/compare/51fefde43cb3...f77664330122

2024-03-09 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from lAV5jgp4796siOZgI... to gJ4Wr2FSpnGmoN3ke... (flutter/engine#51315)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from lAV5jgp4796s to gJ4Wr2FSpnGm

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

6eb3ce9e

09 Mar, 2024 16 commits

Roll Flutter Engine from 49f01510e4e2 to 51fefde43cb3 (1 revision) (#144889) · 98d242a5

engine-flutter-autoroll authored Mar 09, 2024

https://github.com/flutter/engine/compare/49f01510e4e2...51fefde43cb3

2024-03-09 skia-flutter-autoroll@skia.org Roll Skia from 983774f73a16 to 8b92038ff67f (1 revision) (flutter/engine#51313)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

98d242a5

Roll Flutter Engine from 958d7cd560d2 to 49f01510e4e2 (1 revision) (#144887) · cef0a9e9

engine-flutter-autoroll authored Mar 09, 2024

https://github.com/flutter/engine/compare/958d7cd560d2...49f01510e4e2

2024-03-09 zanderso@users.noreply.github.com Roll buildroot to e9df434539745202fa5f9b729fe5f82e5de3f025 (flutter/engine#51306)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

cef0a9e9

Roll Flutter Engine from fc06f5a99377 to 958d7cd560d2 (2 revisions) (#144884) · 7cf29336

engine-flutter-autoroll authored Mar 09, 2024

https://github.com/flutter/engine/compare/fc06f5a99377...958d7cd560d2

2024-03-09 zanderso@users.noreply.github.com Explicitly list Android embedding dependency jars in GN (flutter/engine#51303)
2024-03-09 skia-flutter-autoroll@skia.org Roll Skia from 0da56a6c7446 to 983774f73a16 (1 revision) (flutter/engine#51311)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

7cf29336

Roll Flutter Engine from 6f7fdc533490 to fc06f5a99377 (1 revision) (#144876) · b7b1857c

engine-flutter-autoroll authored Mar 09, 2024

https://github.com/flutter/engine/compare/6f7fdc533490...fc06f5a99377

2024-03-09 skia-flutter-autoroll@skia.org Roll Dart SDK from 02e78997f308 to c3bd630e89bb (1 revision) (flutter/engine#51309)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

b7b1857c

Roll Flutter Engine from 196132ffe2f8 to 6f7fdc533490 (1 revision) (#144875) · ae97ccd4

engine-flutter-autoroll authored Mar 09, 2024

https://github.com/flutter/engine/compare/196132ffe2f8...6f7fdc533490

2024-03-09 skia-flutter-autoroll@skia.org Roll Skia from 8feb4b6a4aa6 to 0da56a6c7446 (1 revision) (flutter/engine#51308)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

ae97ccd4

Fix multiple calls to Slider's onChanged. (#143680) · f733e3a4
yim authored Mar 09, 2024
```
Fixes #143524
```
f733e3a4

Roll Flutter Engine from d4e3d964dc8a to 196132ffe2f8 (1 revision) (#144870) · ff9b1a5c

engine-flutter-autoroll authored Mar 09, 2024

https://github.com/flutter/engine/compare/d4e3d964dc8a...196132ffe2f8

2024-03-09 skia-flutter-autoroll@skia.org Roll Dart SDK from b52b754d5d3e to 02e78997f308 (1 revision) (flutter/engine#51307)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

ff9b1a5c

Roll Flutter Engine from e79a72d362a7 to d4e3d964dc8a (1 revision) (#144866) · b267dc37

engine-flutter-autoroll authored Mar 09, 2024

https://github.com/flutter/engine/compare/e79a72d362a7...d4e3d964dc8a

2024-03-09 skia-flutter-autoroll@skia.org Roll Skia from 3b0b79511469 to 8feb4b6a4aa6 (18 revisions) (flutter/engine#51305)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

b267dc37

Roll Flutter Engine from c3b70321be79 to e79a72d362a7 (1 revision) (#144865) · 0a61e0e9

engine-flutter-autoroll authored Mar 09, 2024

https://github.com/flutter/engine/compare/c3b70321be79...e79a72d362a7

2024-03-09 skia-flutter-autoroll@skia.org Manual roll Dart SDK from 4c64fcc134bf to b52b754d5d3e (6 revisions) (flutter/engine#51304)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

0a61e0e9

Roll Flutter Engine from 79536627661a to c3b70321be79 (1 revision) (#144864) · ebb180e4

engine-flutter-autoroll authored Mar 09, 2024

https://github.com/flutter/engine/compare/79536627661a...c3b70321be79

2024-03-09 skia-flutter-autoroll@skia.org Roll Skia from a4fb847f47d9 to 3b0b79511469 (1 revision) (flutter/engine#51289)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

ebb180e4

Roll Flutter Engine from 7541e902f1b4 to 79536627661a (2 revisions) (#144863) · e070cbc2

engine-flutter-autoroll authored Mar 09, 2024

https://github.com/flutter/engine/compare/7541e902f1b4...79536627661a

2024-03-09 chinmaygarde@google.com [Impeller] Use the AHB prefix for utils that work with Android Hardware Buffers. (flutter/engine#51298)
2024-03-09 chinmaygarde@google.com [Impeller] Make DeviceHolder follow convention for backend specific utilities. (flutter/engine#51300)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

e070cbc2

Roll Flutter Engine from 953927eae78b to 7541e902f1b4 (7 revisions) (#144862) · 6fab1fe6

engine-flutter-autoroll authored Mar 09, 2024

https://github.com/flutter/engine/compare/953927eae78b...7541e902f1b4

2024-03-08 30870216+gaaclarke@users.noreply.github.com [Impeller] implement mask blur for textures (flutter/engine#51183)
2024-03-08 zanderso@users.noreply.github.com Don't rely on dart binary on PATH in run_test.py (flutter/engine#51302)
2024-03-08 tugorez@users.noreply.github.com Mark the Flutter Views as focusable by setting a tabindex value. (flutter/engine#50876)
2024-03-08 chinmaygarde@google.com Update the instructions for updating licenses. (flutter/engine#51297)
2024-03-08 1961493+harryterkelsen@users.noreply.github.com Optimize overlays in CanvasKit (flutter/engine#47317)
2024-03-08 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 5Ra_AjCji-uR1GaX7... to lAV5jgp4796siOZgI... (flutter/engine#51296)
2024-03-08 chinmaygarde@google.com [Impeller] Add the KHR prefix to existing swapchain utilities. (flutter/engine#51295)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from 5Ra_AjCji-uR to lAV5jgp4796s

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

6fab1fe6

Upgrade vm_service. (#144845) · a04fe316
Polina Cherkasova authored Mar 09, 2024

a04fe316

Replace dead links (#144827) · cab4a0fb

Percival authored Mar 09, 2024

I have found that some Apple-related links are no longer accessible, and they have been replaced

cab4a0fb

Roll Flutter Engine from e099277ce061 to 953927eae78b (2 revisions) (#144849) · c0006488

engine-flutter-autoroll authored Mar 09, 2024

https://github.com/flutter/engine/compare/e099277ce061...953927eae78b

2024-03-08 zanderso@users.noreply.github.com Revert test if changes to golden tests (flutter/engine#51291)
2024-03-08 jmccandless@google.com iPad keyboard cut/copy/paste buttons (flutter/engine#50923)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

c0006488

Mark Mac_arm64_ios module_test_ios bringup: true (#144861) · 7bf84d0c
Zachary Anderson authored Mar 09, 2024
```
For https://github.com/flutter/flutter/issues/144860
```
7bf84d0c

08 Mar, 2024 5 commits

Reverts "Rename isAvailableForEnvironment to isForEnvironment (#143176)" (#144855) · 0432a694

auto-submit[bot] authored Mar 08, 2024

Reverts: flutter/flutter#143176
Initiated by: QuncCccccc
Reason for reverting: made tree red.
Original PR Author: Hixie

Reviewed By: {Piinks}

This change reverts the following previous change:
This is part 4 of a broken down version of the #140101 refactor.

This PR renames isAvailableForEnvironment to isForEnvironment and replaces a regular expression with a simple function. (The latter will change the behaviour for people with branch names like `mainly_refactors` or `chess_master_experiment` or whatever, but I'm pretty sure the old behaviour was not intended.)

0432a694

Roll Flutter Engine from 05fdf947f81b to e099277ce061 (1 revision) (#144844) · 0a40291f

engine-flutter-autoroll authored Mar 08, 2024

https://github.com/flutter/engine/compare/05fdf947f81b...e099277ce061

2024-03-08 dnfield@google.com Use `io.flutter.Build.API_LEVELS` rather than `android.os.Build.VERSION_CODES` (flutter/engine#51171)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

0a40291f

Rename isAvailableForEnvironment to isForEnvironment (#143176) · 5bd34ef5

Ian Hickson authored Mar 08, 2024

This is part 4 of a broken down version of the #140101 refactor.

This PR renames isAvailableForEnvironment to isForEnvironment and replaces a regular expression with a simple function. (The latter will change the behaviour for people with branch names like `mainly_refactors` or `chess_master_experiment` or whatever, but I'm pretty sure the old behaviour was not intended.)

5bd34ef5

Roll Flutter Engine from bc4abcda6357 to 05fdf947f81b (9 revisions) (#144839) · fde345a6

engine-flutter-autoroll authored Mar 08, 2024

https://github.com/flutter/engine/compare/bc4abcda6357...05fdf947f81b

2024-03-08 jonahwilliams@google.com [Impeller] More efficient usage of transient onscreen attachments. (flutter/engine#51206)
2024-03-08 68449066+zijiehe-google-com@users.noreply.github.com [Fuchsia] Providing FUCHSIA_SDK_PATH env var for fuchsia lsc (flutter/engine#51234)
2024-03-08 chris@bracken.jp Migrate vulkan_memory_allocator to flutter/third_party (flutter/engine#51275)
2024-03-08 jason-simmons@users.noreply.github.com Update CI scripts to use either src/flutter/third_party/dart or src/third_party/dart (flutter/engine#51276)
2024-03-08 kustermann@google.com Add fuchsia_gn_sdk GN variable pointing to //flutter/tools/fuchsia/gn-sdk (flutter/engine#51287)
2024-03-08 skia-flutter-autoroll@skia.org Roll Skia from 993a88a663c8 to a4fb847f47d9 (1 revision) (flutter/engine#51283)
2024-03-08 skia-flutter-autoroll@skia.org Roll Skia from 15f8d03a9594 to 993a88a663c8 (1 revision) (flutter/engine#51282)
2024-03-08 skia-flutter-autoroll@skia.org Roll Skia from 093994f8f078 to 15f8d03a9594 (1 revision) (flutter/engine#51280)
2024-03-08 skia-flutter-autoroll@skia.org Roll Skia from bf3f9c5f0edb to 093994f8f078 (1 revision) (flutter/engine#51278)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

fde345a6

Fixes the transition builder changing the Cupertino transition on Android. (#134790) · 2be5084b

Mitchell Goodwin authored Mar 08, 2024

Fixes #124850.

Changes the fallback for the builder on Android. Before the error was from the platform being changed mid Cupertino transition to iOS. If a default builder wasn't set for iOS (which a developer developing only for Android might not), then it defaulted to the Zoom transition. Which changing the transition while on the fly caused issues.

2be5084b