- 02 Nov, 2023 1 commit
-
-
Jasper van Riet authored
Fixes #128419, removes the duplicate padding that exists around the header and footer on `CupertinoFormSection`. This PR takes the implementation in #129065 and adds tests. I added the ones suggested in the PR review, as well as one more to test that `margin` is passed correctly from `CupertinoFormSection` to `CupertinoListSection`. Note: I can't quite figure out if this is also a fix to #121543. Potential review questions: - Is the use of `offsetMoreOrLessEquals` here correct? I used it because of the vertical positioning. The horizontal positioning is always exact. ### Screenshots <details> <summary>Before</summary> ![image](https://github.com/flutter/flutter/assets/5138348/1bce10c9-706a-40c8-a581-2dcb574ed937) </details> <details> <summary>After</summary> ![image](https://github.com/flutter/flutter/assets/5138348/cd1d529b-7be5-45df-af31-0f7760dc3fe9) </details>
-
- 20 Sep, 2023 1 commit
-
-
Greg Spencer authored
## Description This removes all of the comments that are of the form "so-and-so (must not be null|can ?not be null|must be non-null)" from the cases where those values are defines as non-nullable values. This PR removes them from the animation, cupertino, foundation, gestures, semantics, and services libraries. Each of them only had a few, so I lumped them together. This was done by hand, since it really didn't lend itself to scripting, so it needs to be more than just spot-checked, I think. I was careful to leave any comment that referred to parameters that were nullable, but I may have missed some. In addition to being no longer relevant after null safety has been made the default, these comments were largely fragile, in that it was easy for them to get out of date, and not be accurate anymore anyhow. This did create a number of constructor comments which basically say "Creates a [Foo].", but I don't really know how to avoid that in a large scale change, since there's not much you can really say in a lot of cases. I think we might consider some leniency for constructors to the "Comment must be meaningful" style guidance (which we de facto have already, since there are a bunch of these). ## Related PRs - https://github.com/flutter/flutter/pull/134991 - https://github.com/flutter/flutter/pull/134992 - https://github.com/flutter/flutter/pull/134993 - https://github.com/flutter/flutter/pull/134994 ## Tests - Documentation only change.
-
- 19 Jul, 2022 1 commit
-
-
Marcel Čampa authored
-
- 14 Apr, 2022 1 commit
-
-
Michael Goderbauer authored
-
- 18 Feb, 2022 1 commit
-
-
Taha Tesser authored
-
- 02 Jun, 2021 1 commit
-
-
Anis Alibegić authored
-
- 14 May, 2021 1 commit
-
-
Abhishek Ghaskata authored
-
- 30 Mar, 2021 1 commit
-
-
Alexandre Ardhuin authored
-
- 12 Jan, 2021 1 commit
-
-
Sam Rawlins authored
-
- 10 Dec, 2020 1 commit
-
-
Daniel Edrisian authored
-
- 04 Dec, 2020 1 commit
-
-
Daniel Edrisian authored
-
- 01 Dec, 2020 2 commits
-
-
Jonah Williams authored
Revert "Added CupertinoFormSection, CupertinoSplitFormRow, and CupertinoTextFormField (#70676)" (#71490) This reverts commit e2447247.
-
Daniel Edrisian authored
-