- 23 Jul, 2020 20 commits
-
-
Greg Spencer authored
This changes FocusNode.descendantsAreFocusable so that it doesn't allow the enclosing scope to re-focus a node that is a descendant of the node with descendantsAreFocusable set to false. Because of the order in which the internal state for descendantsAreFocusable was being set, setting it to false was causing a sibling node to be focused when descendantsAreFocusable of the parent was set to false, even though it shouldn't have been focusable, because the enclosing scope would search for a candidate to be focused before the internal state was set to false. Instead of looping over the children and telling them all to unfocus (and select the previously focused node), this unfocuses the node that has descendantsAreFocusable set to false, with the disposition UnfocusDisposition.previouslyFocusedChild, so that its enclosing scope will look for a previously focused child that isn't part of the subtree being excluded. This affects how the ExcludeFocus widget behaves when turning on exclude.
-
Emmanuel Garcia authored
-
Abdur Rafay Saleem authored
-
chunhtai authored
-
Jonah Williams authored
Allows generating a per-library coverage summary like https://gist.github.com/jonahwilliams/f298381c3fb9f472b2dfe54b82a20a88
-
Jonah Williams authored
Clean even more, in case the plugin dependency update logic is wrong-o.
-
Chris Yang authored
-
Greg Spencer authored
-
Pragya authored
-
Ming Lyu (CareF) authored
-
Todd Volkert authored
-
Todd Volkert authored
The boolean value as to whether the action was found and enabled is less useful than just returning the result of invoking the action itself.
-
Pierre-Louis authored
-
David Martos authored
-
huangchaoyang authored
-
✒ 💙 Yazeed Al-Khalaf authored*
🐛 Fix Spelling Issues in Main README.md *🐛 Fix spelling issues in dev README.md *🐛 Fix spelling issues in complex_layout README.md *🐛 Fix spelling issues in macrobenchmarks README.md *🐛 Fix spelling issues in platform_views_layout README.md *🐛 Fix spelling issues in test_Apps/stocks README.md *🐛 Fix spelling issues in bots README.md *✒ Spell Check dev/ci README.md *✒ Spell Check dev/ci/docker_linux README.md *✒ Spell Check dev/devicelab README.md *✒ Spell Check dev/docs README.md *✒ Spell Check dev/snippets README.md *✒ Spell Check dev/snippets/config/templates README.md *✒ Spell Check dev/tools/gen_keycodes README.md *✒ Spell Check dev/tools/vitool README.md *✒ Spell Check examples/catalog README.md *✒ Spell Check examples/flutter_view README.md *✒ Spell Check examples/image_list README.md *✒ Spell Check examples/layers README.md *✒ Spell Check examples/platform_channel README.md *✒ Spell Check examples/platform_channel_swift README.md *✒ Spell Check examples/platform_view README.md *✒ Spell Check packages/_flutter_web_build_script README.md *✒ Spell Check packages/flutter_localizations README.md *✒ Spell Check packages/flutter_tools README.md *✒ Spell Check CODE_OF_CONDUCT.md *✒ Spell Check dev/integration_test/android_splash_screens/splash_Screen_load_rotate README.md *✒ Spell Check dev/integration_test/android_views README.md *✒ Spell Check dev/integration_tests/flutter_driver_screenshot_test README.md *✒ Spell Check dev/integration_tests/flutter_gallery README.md *✒ Spell Check dev/integration_tests/gradle_deprecated_settings README.md *✒ Spell Check dev/integration_tests/ios_add2app_life_cycle README.md *✒ Spell Check dev/integration_tests/ios_host_app README.md *✒ Spell Check dev/integration_tests/ios_platform_view_tests README.md *✒ Spell Check dev/automated_tests/flutter_test README.md *✒ Spell Check .github/PULL_REQUEST_TEMPLATE.md *✒ Spell Check .hithub/ISSUE_TEMPLATE/ACTIVATION.md *✒ Spell Check .github/ISSUE_TEMPLATE/BUG.md *✒ Spell Check .github/ISSUE_TEMPLATE/feature_request.md *✒ Spell Check .github/ISSUE_TEMPLATE/performance_others.md *✒ Spell Check .github/ISSUE_TEMPLATE/performance_speed.md *✒ Spell Check packages/flutter_tools/doc/daemon.md *✒ Spell Check packages/flutter_tools/fuchsia_enrtypoint_shim/README.md *✒ Minimize line to 80 columns *✒ Minimize line to 80 columns *✒ Fix Typo *✒ Chnaged numbers to 1 for testing purposes *✒ Changed numbers to 1 for testing purposes *❌ Remove 'a' which is a typo *✒ Change a sentence to be better *✒ Remove 'a' which is a typo *✒ Fix small issue *✒ Fix small typo *✒ Fix some typos *❌ Remove trailing space *❌ Remove trailing space *🐛 Fix small typo *✒ Fix Typo *🐛 Fix small bug -
Jonah Williams authored
-
Christopher Fujino authored
-
Jenn Magder authored
-
Jenn Magder authored
-
- 22 Jul, 2020 1 commit
-
-
Emmanuel Garcia authored
This reverts commit d9252f95.
-
- 21 Jul, 2020 14 commits
-
-
engine-flutter-autoroll authored
-
Ming Lyu (CareF) authored
-
Pierre-Louis authored
-
Ming Lyu (CareF) authored
-
includecmath authored
-
Jonah Williams authored
-
Otokaze authored
-
Jason Simmons authored
-
Alexandre Ardhuin authored
-
xubaolin authored
-
Darren Austin authored
- 20 Jul, 2020 5 commits
-
-
Ming Lyu (CareF) authored
This reverts commit aa4b4d35.
-
Jonah Williams authored
To support #61407 , the tool needs to check if a single widget reload is feasible, and then conditionally perform a fast reassemble. To accomplish this, the FlutterDevice class will have a WidgetCache injected. This will eventually contain the logic for parsing the invalidated dart script. Concurrent with the devFS update, the widget cache will be updated/checked if a single widget reload is feasible. If so, an expression evaluation with the target type is performed and the success is communicated through the devFS result. An integration test which demonstrates that this works is already present in https://github.com/flutter/flutter/blob/master/packages/flutter_tools/test/integration.shard/hot_reload_test.dart#L86 Finally, when actually performing the reassemble the tool simply checks if this flag has been set and calls the alternative reassemble method. Cleanups: Remove modules, as this is unused now.
-
Ming Lyu (CareF) authored