1. 12 Oct, 2020 1 commit
  2. 05 Oct, 2020 1 commit
  3. 08 Sep, 2020 1 commit
    • Jonah Williams's avatar
      [framework] make hit slop based on device pointer kind for drag/pan/scale gestures (#64267) · 29898812
      Jonah Williams authored
      Currently the framework uses fairly large "hit slop" values to disambiguate taps from drags/pans. This makes sense on touch devices where the interaction is not very precise, on mice however it can feel as if the UI is lagging. This is immediately noticeable on our infra dashboard, where it takes almost half of a grid square of drag before the actual drag kicks in.
      
      One potential solution is to always use smaller constants depending on whether the interaction is mouse or touch based. The only reasonable choice is to use the pointer device kind and not target platform - same platform can have different input sources. This requires exposing the pointer device kind in a few new places in several of the gesture detectors, and using the enum to compute the correct hit slop from an expanded set of constants.
      
      This almost works, however there are a few places (notably ListViews) which uses the touch hit slop as a default value in scroll physics. It does not seem like it will be easy to disambiguate a user provided scroll physics constant from the default and/or adjust it somehow - this might require significant changes to scroll physics which I have left out of this PR.
      
      This PR does not adjust:
      
      kTouchSlop used in scroll_physics.dart's minFlingDistance
      kTouchSlop used in PrimaryPointerGestureRecognizer/LongPressGestureRecognizer
      29898812
  4. 24 Aug, 2020 1 commit
  5. 11 Jun, 2020 1 commit
  6. 16 Dec, 2019 1 commit
  7. 27 Nov, 2019 1 commit
    • Ian Hickson's avatar
      License update (#45373) · 449f4a66
      Ian Hickson authored
      * Update project.pbxproj files to say Flutter rather than Chromium
      
      Also, the templates now have an empty organization so that we don't cause people to give their apps a Flutter copyright.
      
      * Update the copyright notice checker to require a standard notice on all files
      
      * Update copyrights on Dart files. (This was a mechanical commit.)
      
      * Fix weird license headers on Dart files that deviate from our conventions; relicense Shrine.
      
      Some were already marked "The Flutter Authors", not clear why. Their
      dates have been normalized. Some were missing the blank line after the
      license. Some were randomly different in trivial ways for no apparent
      reason (e.g. missing the trailing period).
      
      * Clean up the copyrights in non-Dart files. (Manual edits.)
      
      Also, make sure templates don't have copyrights.
      
      * Fix some more ORGANIZATIONNAMEs
      449f4a66
  8. 26 Sep, 2019 1 commit
    • Kristin Ho's avatar
      Prevent PointerEnter[or Exit]Event from erasing event.down value (#40637) (#41332) · 034358e3
      Kristin Ho authored
      * MouseRegion documentation claimed that onEnter and onExit
        would track entry and exit regardless of whether the pointer was
        down or up
      * It did such, but when grabbing the value of `event.down` from
        the passed event, the value was always `false`
      * PointerEnterEvent and PointerExitEvent were overriding the value
        passed from PointerEvent in constructors, even if the value was true
        e.g. in invocations of .fromMouseEvent((PointerMoveEvent...))
      * This change now passes the value along to PointerEnter/ExitEvents
        while providing it a default of false, and updates documentation
      
      Fixes #40637
      034358e3
  9. 31 May, 2019 1 commit
  10. 20 May, 2019 1 commit
  11. 03 May, 2019 1 commit
  12. 01 May, 2019 1 commit
  13. 30 Apr, 2019 1 commit
    • Tong Mu's avatar
      Redo: Add buttons to gestures (#31819) · fea2c7d6
      Tong Mu authored
      * Revert "Revert "Add buttons to gestures (#30339)" (#31801)"
      
      This reverts commit 8fd7fa49.
      
      * Synthesise kPrimaryButton for unknown devices
      
      * Change TestPointer to a better API
      fea2c7d6
  14. 29 Apr, 2019 2 commits
  15. 22 Apr, 2019 1 commit
  16. 09 Dec, 2016 1 commit
  17. 27 Jun, 2016 1 commit