Commits · c65ab4d513da99419c44efa6172a978631706dec · abdullh.alsoleman / Front-End

31 Jan, 2024 11 commits

Roll Flutter Engine from 2d2d88068a23 to 8e7df85f7d11 (2 revisions) (#142583) · c65ab4d5

engine-flutter-autoroll authored Jan 31, 2024

https://github.com/flutter/engine/compare/2d2d88068a23...8e7df85f7d11

2024-01-31 skia-flutter-autoroll@skia.org Roll Skia from bf27636582c7 to 1fbb575f968d (1 revision) (flutter/engine#50190)
2024-01-31 kustermann@google.com More correctly name methods regarding event loop that are currently named microtask (flutter/engine#50138)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

c65ab4d5

Add `DropdownMenu.focusNode` (#142516) · 16e014e8

Ian Hickson authored Jan 31, 2024

fixes [`DropdownMenu` doesn't have a focusNode](https://github.com/flutter/flutter/issues/142384)

### Code sample

<details>
<summary>expand to view the code sample</summary> 

```dart
import 'package:flutter/material.dart';

enum TShirtSize {
  s('S'),
  m('M'),
  l('L'),
  xl('XL'),
  xxl('XXL'),
  ;

  const TShirtSize(this.label);
  final String label;
}

void main() => runApp(const MyApp());

class MyApp extends StatefulWidget {
  const MyApp({super.key});

  @override
  State<MyApp> createState() => _MyAppState();
}

class _MyAppState extends State<MyApp> {
  final FocusNode _focusNode = FocusNode();

  @override
  void dispose() {
    _focusNode.dispose();
    super.dispose();
  }

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      debugShowCheckedModeBanner: false,
      home: Scaffold(
        appBar: AppBar(
          title: const Text('DropdownMenu Sample'),
        ),
        body: Center(
          child: DropdownMenu<TShirtSize>(
            focusNode: _focusNode,
            initialSelection: TShirtSize.m,
            label: const Text('T-Shirt Size'),
            dropdownMenuEntries: TShirtSize.values.map((e) {
              return DropdownMenuEntry<TShirtSize>(
                value: e,
                label: e.label,
              );
            }).toList(),
          ),
        ),
        floatingActionButton: FloatingActionButton.extended(
          onPressed: () {
            _focusNode.requestFocus();
          },
          label: const Text('Request Focus on DropdownMenu'),
        ),
      ),
    );
  }
}
```

</details>

16e014e8

Marks Windows_android native_assets_android to be unflaky (#140042) · 4af2051f

Flutter GitHub Bot authored Jan 31, 2024

<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Windows_android native_assets_android"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Windows_android%20native_assets_android%22).
This test can be marked as unflaky.

4af2051f

Marks Linux_pixel_7pro... · 3a442ab4

Flutter GitHub Bot authored Jan 31, 2024

Marks Linux_pixel_7pro complex_layout_scroll_perf_impeller_gles__timeline_summary to be unflaky (#140039)

<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Linux_pixel_7pro complex_layout_scroll_perf_impeller_gles__timeline_summary"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Linux_pixel_7pro%20complex_layout_scroll_perf_impeller_gles__timeline_summary%22).
This test can be marked as unflaky.

3a442ab4

Marks Linux_android native_assets_android to be unflaky (#140040) · 19aa1ed9

Flutter GitHub Bot authored Jan 31, 2024

<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Linux_android native_assets_android"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Linux_android%20native_assets_android%22).
This test can be marked as unflaky.

19aa1ed9

Marks Mac_android native_assets_android to be unflaky (#140041) · ae49afa4

Flutter GitHub Bot authored Jan 31, 2024

<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Mac_android native_assets_android"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Mac_android%20native_assets_android%22).
This test can be marked as unflaky.

ae49afa4

Marks Mac flavors_test_macos to be unflaky (#140647) · 6379378c

Flutter GitHub Bot authored Jan 31, 2024

<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Mac flavors_test_macos"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Mac%20flavors_test_macos%22).
This test can be marked as unflaky.

6379378c

Roll Flutter Engine from 588f06b02664 to 2d2d88068a23 (1 revision) (#142569) · daf8d5fe

engine-flutter-autoroll authored Jan 31, 2024

https://github.com/flutter/engine/compare/588f06b02664...2d2d88068a23

2024-01-31 skia-flutter-autoroll@skia.org Roll Skia from 76da7ec3e106 to bf27636582c7 (1 revision) (flutter/engine#50187)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

daf8d5fe

Roll Flutter Engine from e6e1d6b3d035 to 588f06b02664 (1 revision) (#142566) · 1e8c7519

engine-flutter-autoroll authored Jan 31, 2024

https://github.com/flutter/engine/compare/e6e1d6b3d035...588f06b02664

2024-01-30 skia-flutter-autoroll@skia.org Roll Skia from 62cab132c9ad to 76da7ec3e106 (1 revision) (flutter/engine#50186)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

1e8c7519

M3 - Fix Chip icon and label colors (#140573) · 20dc5cbc
David Martos authored Jan 31, 2024

20dc5cbc

Roll Flutter Engine from d20ed240ace9 to e6e1d6b3d035 (3 revisions) (#142564) · 1f573e02

engine-flutter-autoroll authored Jan 31, 2024

https://github.com/flutter/engine/compare/d20ed240ace9...e6e1d6b3d035

2024-01-30 skia-flutter-autoroll@skia.org Roll Dart SDK from 734aae9604e8 to 488e33cd39de (1 revision) (flutter/engine#50185)
2024-01-30 jonahwilliams@google.com [Impeller] Reland: add interface for submitting multiple command buffers at once. (flutter/engine#50180)
2024-01-30 iinozemtsev@google.com Support running sound null safe kernels from flutter_jit_runner (flutter/engine#50002)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

1f573e02

30 Jan, 2024 24 commits

Be less verbose in CI for customer_testing, and revert old timeout hack (#139611) · cd444534

Ian Hickson authored Jan 30, 2024

This PR does two things. First, it reduces the verbosity in the customer_testing shard. We want to be less verbose because it's nigh on impossible to find anything when there's a failure in the verbose logs. Also, some additional comments are added to make following the breadcrumbs easier for the next person.

Second, it reverts a timeout that had been set to 90 minutes a while ago. It's no longer needed.

Fixes https://github.com/flutter/flutter/issues/120901.

cd444534

use PDI to end the isolated scope for RLI (#141345) · 9ed650ae

Kohei Seino authored Jan 30, 2024

will fix https://github.com/flutter/flutter/issues/141344

https://unicode.org/reports/tr9/#Explicit_Directional_Isolates
https://api.flutter.dev/flutter/foundation/Unicode/RLI-constant.html

9ed650ae

Style correctness improvements for toStrings and related fixes (#142485) · abebd340

Ian Hickson authored Jan 30, 2024

Children should be omitted from debugFillProperties (if they really need to be included they should be in debugDescribeChildren, but in general for widgets we don't bother including them since they are eventually included anyway).

toStrings should not contain newlines (or, ideally, should use Diagnosticable).

Also some minor tweaks to match grammar and style guide conventions.

abebd340

Roll Flutter Engine from 500ae6c4d947 to d20ed240ace9 (1 revision) (#142554) · 176b439d

engine-flutter-autoroll authored Jan 30, 2024

https://github.com/flutter/engine/compare/500ae6c4d947...d20ed240ace9

2024-01-30 skia-flutter-autoroll@skia.org Roll Skia from 739b66191c66 to 62cab132c9ad (2 revisions) (flutter/engine#50181)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

176b439d

Bump codecov/codecov-action from 3.1.5 to 3.1.6 (#142553) · c40acdad

dependabot[bot] authored Jan 30, 2024

Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 3.1.5 to 3.1.6.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/codecov/codecov-action/releases">codecov/codecov-action's releases</a>.</em></p>
<blockquote>
<h2>v3.1.6</h2>
<p><strong>Full Changelog</strong>: <a href="https://github.com/codecov/codecov-action/compare/v3.1.5...v3.1.6">https://github.com/codecov/codecov-action/compare/v3.1.5...v3.1.6</a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/codecov/codecov-action/commit/ab904c41d6ece82784817410c45d8b8c02684457"><code>ab904c4</code></a> chore(release): bump to 3.1.6</li>
<li><a href="https://github.com/codecov/codecov-action/commit/a8c374ae465f56cbb2da206950e903ad74b01bff"><code>a8c374a</code></a> Revert &quot;action.yml: Update to Node.js 20 (<a href="https://redirect.github.com/codecov/codecov-action/issues/1228">#1228</a>)&quot;</li>
<li>See full diff in <a href="https://github.com/codecov/codecov-action/compare/4fe8c5f003fae66aa5ebb77cfd3e7bfbbda0b6b0...ab904c41d6ece82784817410c45d8b8c02684457">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=codecov/codecov-action&package-manager=github_actions&previous-version=3.1.5&new-version=3.1.6)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

c40acdad

Roll Flutter Engine from cd12316a0883 to 500ae6c4d947 (1 revision) (#142551) · d35c08e9

engine-flutter-autoroll authored Jan 30, 2024

https://github.com/flutter/engine/compare/cd12316a0883...500ae6c4d947

2024-01-30 35989475+MeandNi@users.noreply.github.com Revert "Close connection on keyboard close (#41500)" (flutter/engine#49366)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

d35c08e9

Roll Flutter Engine from 0e4342c5a1f2 to cd12316a0883 (6 revisions) (#142548) · b23b3da9

engine-flutter-autoroll authored Jan 30, 2024

https://github.com/flutter/engine/compare/0e4342c5a1f2...cd12316a0883

2024-01-30 skia-flutter-autoroll@skia.org Roll Dart SDK from 10bbb376de7e to 734aae9604e8 (1 revision) (flutter/engine#50179)
2024-01-30 30870216+gaaclarke@users.noreply.github.com [Impeller] added mipmaps to subpasses directly on a draw call (flutter/engine#50157)
2024-01-30 skia-flutter-autoroll@skia.org Manual roll Dart SDK from d0b48a008559 to 10bbb376de7e (8 revisions) (flutter/engine#50172)
2024-01-30 skia-flutter-autoroll@skia.org Roll Skia from 7df4d35e11cf to 739b66191c66 (1 revision) (flutter/engine#50175)
2024-01-30 jonahwilliams@google.com [Android] Reland: recycle hardware buffer textures. (flutter/engine#50122)
2024-01-30 mk12360@gmail.com Roll buildroot to 52689fe8955a9a4916a38f0b8ae5ea3e217037f4 (flutter/engine#50160)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

b23b3da9

Roll Flutter Engine from 438e9b4d7d4e to 0e4342c5a1f2 (11 revisions) (#142543) · 4b110de9

engine-flutter-autoroll authored Jan 30, 2024

https://github.com/flutter/engine/compare/438e9b4d7d4e...0e4342c5a1f2

2024-01-30 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] Add interface for submitting multiple command buffers at once." (flutter/engine#50174)
2024-01-30 skia-flutter-autoroll@skia.org Roll Skia from a3d46fac53be to 7df4d35e11cf (3 revisions) (flutter/engine#50173)
2024-01-30 skia-flutter-autoroll@skia.org Roll Skia from c2fada52fdc4 to a3d46fac53be (2 revisions) (flutter/engine#50171)
2024-01-30 skia-flutter-autoroll@skia.org Roll Skia from 7dc9ba2e8c90 to c2fada52fdc4 (1 revision) (flutter/engine#50170)
2024-01-30 skia-flutter-autoroll@skia.org Roll Skia from 1c0eae94fc09 to 7dc9ba2e8c90 (1 revision) (flutter/engine#50169)
2024-01-30 skia-flutter-autoroll@skia.org Roll Skia from 4e992fb3a9db to 1c0eae94fc09 (3 revisions) (flutter/engine#50167)
2024-01-30 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from Hqi_x_A9lYsY58VSn... to Z-xFM2ILZJw22eU8q... (flutter/engine#50166)
2024-01-30 jonahwilliams@google.com [Impeller] Add interface for submitting multiple command buffers at once. (flutter/engine#50139)
2024-01-30 49699333+dependabot[bot]@users.noreply.github.com Bump actions/upload-artifact from 4.1.0 to 4.3.0 (flutter/engine#50165)
2024-01-30 skia-flutter-autoroll@skia.org Roll Skia from 083c1a4d9767 to 4e992fb3a9db (1 revision) (flutter/engine#50164)
2024-01-30 mbrase@google.com Use structured logging on Fuchsia (flutter/engine#49918)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from Hqi_x_A9lYsY to Z-xFM2ILZJw2

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

4b110de9

Fix: selection handles do not inherit color from local `Theme` widget (#142476) · 1daac1b8

Renzo Olivares authored Jan 30, 2024

This change uses `CapturedTheme`s to capture the themes from the context the selection handles were built in and wraps the handles with them so they can correctly inherit `Theme`s from local `Theme` widgets.

`CapturedTheme`s only captures `InheritedTheme`s, so this change also makes `_InheritedCupertinoTheme` an `InheritedTheme`. This is so we can capture themes declared under a `CupertinoTheme`, for example `primaryColor` is used as the selection handle color.

Fixes #74890

1daac1b8

Marks Windows_arm64 plugin_test_windows to be unflaky (#137675) · bd715036

Flutter GitHub Bot authored Jan 30, 2024

<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Windows_arm64 plugin_test_windows"
}
-->
The issue https://github.com/flutter/flutter/issues/134083 has been closed, and the test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Windows_arm64%20plugin_test_windows%22).
This test can be marked as unflaky.

bd715036

Revert "Roll Flutter Engine from 0e586d1c28c8 to f02a4a80a77e (3 revisions)" (#142533) · 75b3c8ec
Jonah Williams authored Jan 30, 2024
```
Reverts flutter/flutter#142528
```
75b3c8ec

Reset framesEnabled to default value at the end of each test (#141844) · 75a2e5b4

Aizat Azhar authored Jan 30, 2024

Reset `framesEnabled` to `true` at the end of each test as otherwise subsequent tests may fail when pumping a widget

Fixes #141835

75a2e5b4

Fix SliverMainAxisGroup geometry cacheExtent (#142482) · e8cb0295

Kate Lovett authored Jan 30, 2024

Fixes https://github.com/flutter/flutter/issues/142183

This fixes a bug in the SliverGeometry of SliverMainAxisGroup. The cacheExtent represents how many pixels the sliver has consumed in the SliverConstraints.remainingCacheExtent. Since it was not set, slivers that came after a SliverMainAxisGroup that filled the whole screen did not properly lay out their own children, in some cases making lazy sliver more eager than they should be.

e8cb0295

Roll Flutter Engine from 0e586d1c28c8 to f02a4a80a77e (3 revisions) (#142528) · 5bb4fa35

engine-flutter-autoroll authored Jan 30, 2024

https://github.com/flutter/engine/compare/0e586d1c28c8...f02a4a80a77e

2024-01-30 skia-flutter-autoroll@skia.org Roll Skia from 1c0eae94fc09 to 7dc9ba2e8c90 (1 revision) (flutter/engine#50169)
2024-01-30 skia-flutter-autoroll@skia.org Roll Skia from 4e992fb3a9db to 1c0eae94fc09 (3 revisions) (flutter/engine#50167)
2024-01-30 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from Hqi_x_A9lYsY58VSn... to Z-xFM2ILZJw22eU8q... (flutter/engine#50166)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from Hqi_x_A9lYsY to Z-xFM2ILZJw2

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

5bb4fa35

Roll Packages from 516648afb6be to 25abb5d1e0de (6 revisions) (#142527) · 461f0bfb

engine-flutter-autoroll authored Jan 30, 2024

https://github.com/flutter/packages/compare/516648afb6be...25abb5d1e0de

2024-01-30 tessertaha@gmail.com [rfw] Add `OverflowBar` widget and Update `ButtonBar` widget implementation (flutter/packages#5807)
2024-01-30 stuartmorgan@google.com [ci] Reduce tasks slightly (flutter/packages#6011)
2024-01-29 stuartmorgan@google.com Clarify issue requirement (flutter/packages#6010)
2024-01-29 stuartmorgan@google.com [various] Disambiguate TestDefaultBinaryMessengerBinding (flutter/packages#6009)
2024-01-29 engine-flutter-autoroll@skia.org Manual roll Flutter from a8efa771 to 2f6fdf26 (23 revisions) (flutter/packages#6008)
2024-01-29 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.23.1 to 3.23.2 (flutter/packages#5987)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

461f0bfb

Roll Flutter Engine from 438e9b4d7d4e to 0e586d1c28c8 (4 revisions) (#142515) · 72dc162f

engine-flutter-autoroll authored Jan 30, 2024

https://github.com/flutter/engine/compare/438e9b4d7d4e...0e586d1c28c8

2024-01-30 jonahwilliams@google.com [Impeller] Add interface for submitting multiple command buffers at once. (flutter/engine#50139)
2024-01-30 49699333+dependabot[bot]@users.noreply.github.com Bump actions/upload-artifact from 4.1.0 to 4.3.0 (flutter/engine#50165)
2024-01-30 skia-flutter-autoroll@skia.org Roll Skia from 083c1a4d9767 to 4e992fb3a9db (1 revision) (flutter/engine#50164)
2024-01-30 mbrase@google.com Use structured logging on Fuchsia (flutter/engine#49918)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

72dc162f

Using `initExpensiveAndroidView` for Android Hybrid Composition Mode (#142399) · ccb2b443

Rulong Chen（陈汝龙） authored Jan 30, 2024

After https://github.com/flutter/flutter/pull/100990, we should use `initExpensiveAndroidView` for Android Hybrid Composition mode instead of `initSurfaceAndroidView`. 

`initSurfaceAndroidView` attempts to use `TLHC` when possible. In cases where that is not supported, it falls back to using Hybrid Composition.

https://github.com/flutter/engine/pull/49414

ccb2b443

Roll Flutter Engine from ed73d40a8c93 to 438e9b4d7d4e (1 revision) (#142508) · 40ecbc81

engine-flutter-autoroll authored Jan 30, 2024

https://github.com/flutter/engine/compare/ed73d40a8c93...438e9b4d7d4e

2024-01-30 mbrase@google.com Fix incorrect FML_VLOG() severity usage (flutter/engine#50118)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

40ecbc81

Organize leak tracking TODOs. (#142460) · 6dff3da3
Polina Cherkasova authored Jan 30, 2024

6dff3da3

Roll Flutter Engine from 5584a78a439b to ed73d40a8c93 (1 revision) (#142504) · 5c64d037

engine-flutter-autoroll authored Jan 30, 2024

https://github.com/flutter/engine/compare/5584a78a439b...ed73d40a8c93

2024-01-30 skia-flutter-autoroll@skia.org Roll Skia from 09379d00b455 to 083c1a4d9767 (1 revision) (flutter/engine#50162)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

5c64d037

Roll Flutter Engine from df5f1afd4991 to 5584a78a439b (2 revisions) (#142503) · bce0a84b

engine-flutter-autoroll authored Jan 30, 2024

https://github.com/flutter/engine/compare/df5f1afd4991...5584a78a439b

2024-01-30 matanlurey@users.noreply.github.com Revert: "Change how OpenGL textures are flipped in the Android embedder" (flutter/engine#50158)
2024-01-30 john@johnmccutchan.com Re-Re-land Manually revert TLHC optimizations (flutter/engine#50155)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

bce0a84b

Roll Flutter Engine from 65bf8b1db4d1 to df5f1afd4991 (1 revision) (#142501) · 4c62abd6

engine-flutter-autoroll authored Jan 30, 2024

https://github.com/flutter/engine/compare/65bf8b1db4d1...df5f1afd4991

2024-01-29 johnoneil@users.noreply.github.com Enable `_Float16` "half-float" Functionality Only When Available. (flutter/engine#49851)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

4c62abd6

Roll Flutter Engine from c9268c7db03c to 65bf8b1db4d1 (1 revision) (#142496) · d5b189c3

engine-flutter-autoroll authored Jan 30, 2024

https://github.com/flutter/engine/compare/c9268c7db03c...65bf8b1db4d1

2024-01-29 skia-flutter-autoroll@skia.org Roll Skia from c1899b2586da to 09379d00b455 (3 revisions) (flutter/engine#50156)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

d5b189c3

Roll Flutter Engine from e21208583956 to c9268c7db03c (1 revision) (#142492) · 9c166535

engine-flutter-autoroll authored Jan 30, 2024

https://github.com/flutter/engine/compare/e21208583956...c9268c7db03c

2024-01-29 skia-flutter-autoroll@skia.org Roll Skia from 0327d5b319fc to c1899b2586da (3 revisions) (flutter/engine#50152)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

9c166535

29 Jan, 2024 5 commits

Roll Flutter Engine from bedafa8794b6 to e21208583956 (1 revision) (#142483) · 8d14d319

engine-flutter-autoroll authored Jan 29, 2024

https://github.com/flutter/engine/compare/bedafa8794b6...e21208583956

2024-01-29 skia-flutter-autoroll@skia.org Roll Skia from 3680286e6bf4 to 0327d5b319fc (1 revision) (flutter/engine#50150)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

8d14d319

Revert "Reland: "Fix how Gradle resolves Android plugin" (#137115)" (#142464) · 995e3fad

Camille Simon authored Jan 29, 2024

This reverts commit f5ac225c, i.e. https://github.com/flutter/flutter/pull/137115.

This is a continuation of https://github.com/flutter/flutter/pull/142266 that was redone based on feedback to make this easier to revert in the future. The exact steps I took to create this revert:

1. Revert commit noted above
2. Fix merge conflicts, that notably involved reverting some changes in https://github.com/flutter/flutter/pull/140744 ~and https://github.com/flutter/flutter/pull/141417~ (fixed my merge to avoid the second PR from being affected)
3. Delete `packages/flutter_tools/test/integration.shard/android_plugin_skip_unsupported_test.dart` as this was added in the commit noted above

cc @Gustl22 since I couldn't tag as a reviewer

995e3fad

Marks Mac_pixel_7pro native_assets_android to be unflaky (#141675) · 9207b85d

Flutter GitHub Bot authored Jan 29, 2024

<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Mac_pixel_7pro native_assets_android"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Mac_pixel_7pro%20native_assets_android%22).
This test can be marked as unflaky.

9207b85d

Roll Flutter Engine from 9c3ebf67b5da to bedafa8794b6 (4 revisions) (#142478) · ace91811

engine-flutter-autoroll authored Jan 29, 2024

https://github.com/flutter/engine/compare/9c3ebf67b5da...bedafa8794b6

2024-01-29 skia-flutter-autoroll@skia.org Roll Skia from f3b9e80d262a to 3680286e6bf4 (2 revisions) (flutter/engine#50149)
2024-01-29 jason-simmons@users.noreply.github.com Handle construction/destruction of GObject private data containing C++ objects in Linux embedder tests (flutter/engine#50022)
2024-01-29 aam@google.com Include dart vm internal sources into flutter distro. (flutter/engine#50116)
2024-01-29 matanlurey@users.noreply.github.com Manually revert TLHC optimizations, holding on to width/height changes. (flutter/engine#50144)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

ace91811

onNavigationNotification for *App.router (#142190) · ade8af27

Justin McCandless authored Jan 29, 2024

onNavigationNotification was not being passed through when using the router in MaterialApp and CupertinoApp. I believe this was just an oversight on my part when I wrote https://github.com/flutter/flutter/pull/120385. This PR passes them through.

Fixes https://github.com/flutter/flutter/issues/139903

@maRci0002 Would this totally fix your issue https://github.com/flutter/flutter/issues/139903?

ade8af27