1. 21 Apr, 2017 1 commit
    • Ian Hickson's avatar
      Reorganise the drag related gesture files. (#9487) · a591628c
      Ian Hickson authored
      Move the Drag*Details classes into drag_details.dart.
      Move the one-gesture drag recognizers into monodrag.dart.
      Move Drag into drag.dart.
      
      Adjust the comments to claim that Drag is used by other things than
      MultiDragGestureRecognizer. (Right now this is a lie but it will
      hopefully be true soon.)
      a591628c
  2. 12 Apr, 2017 1 commit
    • Ian Hickson's avatar
      Move Point to Offset (#9277) · bf017b79
      Ian Hickson authored
      * Manually fix every use of Point.x and Point.y
      
      Some of these were moved to dx/dy, but not all.
      
      * Manually convert uses of the old gradient API
      
      * Remove old reference to Point.
      
      * Mechanical changes
      
      I applied the following at the root of the Flutter repository:
      
      git ls-files -z | xargs -0 sed -i 's/\bPoint[.]origin\b/Offset.zero/g'
      git ls-files -z | xargs -0 sed -i 's/\bPoint[.]lerp\b/Offset.lerp/g'
      git ls-files -z | xargs -0 sed -i 's/\bnew Point\b/new Offset/g'
      git ls-files -z | xargs -0 sed -i 's/\bconst Point\b/const Offset/g'
      git ls-files -z | xargs -0 sed -i 's/\bstatic Point /static Offset /g'
      git ls-files -z | xargs -0 sed -i 's/\bfinal Point /final Offset /g'
      git ls-files -z | xargs -0 sed -i 's/^\( *\)Point /\1Offset /g'
      git ls-files -z | xargs -0 sed -i 's/ui[.]Point\b/ui.Offset/g'
      git ls-files -z | xargs -0 sed -i 's/(Point\b/(Offset/g'
      git ls-files -z | xargs -0 sed -i 's/\([[{,]\) Point\b/\1 Offset/g'
      git ls-files -z | xargs -0 sed -i 's/@required Point\b/@required Offset/g'
      git ls-files -z | xargs -0 sed -i 's/<Point>/<Offset>/g'
      git ls-files -z | xargs -0 sed -i 's/[.]toOffset()//g'
      git ls-files -z | xargs -0 sed -i 's/[.]toPoint()//g'
      git ls-files -z | xargs -0 sed -i 's/\bshow Point, /show /g'
      git ls-files -z | xargs -0 sed -i 's/\bshow Point;/show Offset;/g'
      
      * Mechanical changes - dartdocs
      
      I applied the following at the root of the Flutter repository:
      
      git ls-files -z | xargs -0 sed -i 's/\ba \[Point\]/an [Offset]/g'
      git ls-files -z | xargs -0 sed -i 's/\[Point\]/[Offset]/g'
      
      * Further improvements and a test
      
      * Fix minor errors from rebasing...
      
      * Roll engine
      bf017b79
  3. 29 Mar, 2017 1 commit
  4. 21 Mar, 2017 1 commit
  5. 08 Mar, 2017 1 commit
  6. 04 Mar, 2017 1 commit
  7. 23 Feb, 2017 1 commit
  8. 22 Jan, 2017 1 commit
  9. 06 Jan, 2017 1 commit
    • Ian Hickson's avatar
      Changes to the drag gesture detectors and the velocity tracker (#7363) · 11d1d54c
      Ian Hickson authored
      - more dartdocs for the drag typedefs
      
      - more toStrings to aid debugging
      
      - require the position for DragUpdateDetails since we were omitting it
        in some places
      
      - add the primaryVelocity to DragEndDetails so that consumers don't
        have to themselves track the axis in question
      
      - fix the velocity tracker so that it doesn't walk the null data.
        Previously, near time t=0 (which pretty much only matters in tests,
        but it does matter there) we would walk the velocity data and then
        also walk missing data, treating it as Point.zero with t=0.
      
      - simplify some of the velocity tracker; e.g. instead of trying (and
        failing?) to clear the velocity tracker when the pointer stalls,
        just drop the data before a stall during the velocity estimation
        (where we redundantly had another bigger horizon anyway).
      11d1d54c
  10. 16 Nov, 2016 1 commit
  11. 15 Nov, 2016 1 commit
  12. 28 Oct, 2016 1 commit
  13. 09 Sep, 2016 1 commit
  14. 02 Aug, 2016 1 commit
  15. 01 Jul, 2016 1 commit
  16. 07 Jun, 2016 2 commits
  17. 03 Jun, 2016 2 commits
    • Adam Barth's avatar
      Fix DragUpdateDetails docs (#4350) · daa0e7fa
      Adam Barth authored
      I changed the behavior late in the code review but didn't update this dartdoc.
      daa0e7fa
    • Adam Barth's avatar
      Convert drag gestures to use details objects (#4343) · 2d4acb80
      Adam Barth authored
      Previously we supplied individual parameters to the various drag and pan
      callbacks. However, that approach isn't extensible because each new
      parameter is a breaking change to the API.
      
      This patch makes a one-time breaking change to the API to provide a
      "details" object that we can extend over time as we need to expose more
      information. The first planned extension is adding enough information to
      accurately produce an overscroll glow on Android.
      2d4acb80
  18. 18 May, 2016 1 commit
  19. 17 May, 2016 2 commits
  20. 26 Apr, 2016 1 commit
    • Adam Barth's avatar
      Delay win-by-default in gesture arena (#3552) · 51b1550d
      Adam Barth authored
      Wait until the end of the microtask to tell gesture recognizers that
      they've won in the gesture arena. This lets recognizers dispose reject
      themselves at arbitrary times without triggering gestures in awkward
      call stacks.
      
      Fixes #3183
      51b1550d
  21. 22 Mar, 2016 1 commit
  22. 15 Mar, 2016 1 commit
    • Adam Barth's avatar
      Tapping drawer during animation causes it to stick · a710676d
      Adam Barth authored
      The problem was we were using a tap gesture to stop the motion of the
      drawer and a drag gesture to settle it. That can cause a broken
      lifecycle. Now we use a single drag recognizer to drive the whole
      lifecycle.
      
      Fixes #775
      Fixes #1276
      a710676d
  23. 14 Mar, 2016 1 commit
  24. 25 Feb, 2016 2 commits
    • Adam Barth's avatar
      Remove PointerRouter and GestureArena arguments · 4b1a9ff1
      Adam Barth authored
      There's no reason to make clients supply a PointerRounter and a
      GestureArena when constructing gesture recognizers. These objects are
      statics and the gesture recognizers can just grab them directly.
      
      Also, remove the callback constructor arguments. Almost no code used
      them. Instead, people seem to prefer using the `..` operator to set
      callbacks on the recognizers. Removing the arguments removes a bunch of
      boilerplate.
      4b1a9ff1
    • Hixie's avatar
      Just-in-time mutations of GestureDetector · 0df3730d
      Hixie authored
      This allows us to adjust exactly which gestures we're listening for
      during layout, which I'll use to kill a SizeObserver.
      0df3730d
  25. 14 Feb, 2016 1 commit
    • Adam Barth's avatar
      Add a Velocity class to be explicit about units · 4fb47600
      Adam Barth authored
      We were using an Offset, which represented pixels/second, but it wasn't
      clear to clients whether that was pixels/ms. Now we use a Velocity class
      that is explict about the units.
      
      Fixes #1510
      Fixes #785
      4fb47600
  26. 14 Dec, 2015 1 commit
  27. 09 Dec, 2015 1 commit
  28. 05 Dec, 2015 2 commits
    • Ian Hickson's avatar
      Cleanup for the Pointer changes. · 2965dcb6
      Ian Hickson authored
      2965dcb6
    • Ian Hickson's avatar
      PointerInput refactor · f1625556
      Ian Hickson authored
      Instead of PointerInputEvent having a "type" field, we now have a
      different class for each pointer type.
      
      This has ripple effects throughout the system.
      
      I also did code cleanup in affected files while I was there.
      f1625556
  29. 04 Nov, 2015 1 commit
    • Hixie's avatar
      Gesture class hierarchy tune-up · ba3f60f8
      Hixie authored
      Make all the *GestureRecognizer classes inherit from a class called
      GestureRecognizer. Give the old GestureRecognizer a name that is more
      precise about its purpose. Remove the members of GestureArenaMember that
      aren't used by GestureArenas.
      ba3f60f8
  30. 02 Nov, 2015 1 commit
  31. 27 Oct, 2015 1 commit
  32. 23 Oct, 2015 1 commit
  33. 13 Oct, 2015 1 commit
  34. 10 Oct, 2015 2 commits