1. 09 Mar, 2018 1 commit
  2. 21 Feb, 2018 1 commit
    • amirh's avatar
      Initial implementation of BottomAppBar (#14713) · 7996d7fb
      amirh authored
      * add a FAB NotchMaker to ScaffoldGeometry
      
      * add a notchMaker to FloatingActionButton
      
      * Initial implementation of BottomAppBar
      
      Mainly includes the notch making logic.
      Not yet tested as currently there is no way to make the FAB and the BAB
      overlap, once #14368 to lands we could add unit tests to the
      BottomAppBar as well.
      
      * use a closeable for clearing the FAB notchmaker
      7996d7fb
  3. 14 Feb, 2018 1 commit
  4. 13 Feb, 2018 1 commit
    • amirh's avatar
      ScaffoldGeometry plumbing. (#14580) · f802cf6d
      amirh authored
      Adds a ScaffoldGeometry class and ValueNotifier for it.
      A scaffold's ScaffoldGeometry notifier is held in the _ScaffoldState, and is passed to _ScaffoldScope.
      New ScaffoldGemometry objects are built and published to the notifier.
      f802cf6d
  5. 07 Feb, 2018 1 commit
  6. 02 Feb, 2018 1 commit
  7. 01 Feb, 2018 1 commit
    • Chris Bracken's avatar
      Position bottom bar widgets relative to window (#14406) · b0e17949
      Chris Bracken authored
      Note: also fixes a bug wherein bottom media padding was applied even in the
      presence of persistent footer buttons.
      
      The material spec states that the keyboard should be positioned on top
      of any bottom navigation bar or persistent footer buttons widget(s).
      
      We no longer inset the bottom of bottom navigation bars / persistent
      footer buttons by the bottom viewInset.
      
      Body content bottom (and the bottom of bottom sheets) is now determined
      by the greater of:
        1. bottom view inset (the keyboard height)
        2. bottom elements (nav bar, footer buttons)
      relative to the window max-Y.
      b0e17949
  8. 11 Jan, 2018 1 commit
  9. 08 Dec, 2017 1 commit
    • Chris Bracken's avatar
      Scaffold resizeToAvoidBottomPadding uses view insets (#13437) · 6ff844a9
      Chris Bracken authored
      Now that keyboard height is modelled as a (bottom) view inset, migrate
      scaffold bottom resizing to use view insets instead of bottom padding,
      which, after an engine roll, will only be used for safe areas.
      
      Until the aforementioned engine roll, the keyboard height is still
      included in both bottom padding and view insets. As such
      resizeToAvoidBottomPadding still drives bottom padding removal until
      that roll lands.
      
      Renames _ScaffoldLayout.bottomPadding to bottomViewInset
      6ff844a9
  10. 07 Dec, 2017 2 commits
    • Chris Bracken's avatar
      Update scaffold test bottom bar height (#13429) · 38c82ea8
      Chris Bracken authored
      This patch contains no framework changes.
      
      This change adjusts a test bottom navigation bar height to be greater
      than the media bottom padding.
      
      This change is pre-factoring to clarify diffs in an upcoming change that
      will expose bottom padding to the bottom navigation bar in order to
      allow it to visually adapt its appearance in the presence of bottom
      padding such as thatexposed for the iPhone X home screen indicator.
      Since the bottom padding was previously greater than the height of the
      bottom navigation bar, the height of insideBottomNavigation bar was
      driven to 0 when padding is exposed.
      38c82ea8
    • Chris Bracken's avatar
      Use greater of viewInsets, padding for Scaffold bottom padding (#13423) · 71021b47
      Chris Bracken authored
      Scaffold bottom padding now applies the maximum of window
      viewInsets.bottom (typically used for iOS safe areas) and padding.bottom
      (typically used for keyboard height).
      71021b47
  11. 02 Nov, 2017 2 commits
  12. 03 Oct, 2017 1 commit
    • Michael Goderbauer's avatar
      Drop invisible SemanticsNodes from tree (#12358) · 49499457
      Michael Goderbauer authored
      * Drop invisible SemanticsNodes from tree
      
      A node is invisible if it is outside of the bounds of the screen and if it is not merged into its (partially) visible parent.
      
      Also in this PR: only set `wasAffectedByClip` to true if the nodes has actually been clipped.
      
      * Fix other failing tests
      
      * renaming
      
      * review feedback
      
      * more doc
      49499457
  13. 29 Sep, 2017 1 commit
  14. 31 Aug, 2017 1 commit
  15. 30 Aug, 2017 1 commit
  16. 06 Jul, 2017 1 commit
  17. 03 Jun, 2017 1 commit
  18. 27 Apr, 2017 2 commits
  19. 23 Apr, 2017 1 commit
  20. 21 Apr, 2017 1 commit
  21. 13 Apr, 2017 1 commit
  22. 12 Apr, 2017 1 commit
    • Ian Hickson's avatar
      Move Point to Offset (#9277) · bf017b79
      Ian Hickson authored
      * Manually fix every use of Point.x and Point.y
      
      Some of these were moved to dx/dy, but not all.
      
      * Manually convert uses of the old gradient API
      
      * Remove old reference to Point.
      
      * Mechanical changes
      
      I applied the following at the root of the Flutter repository:
      
      git ls-files -z | xargs -0 sed -i 's/\bPoint[.]origin\b/Offset.zero/g'
      git ls-files -z | xargs -0 sed -i 's/\bPoint[.]lerp\b/Offset.lerp/g'
      git ls-files -z | xargs -0 sed -i 's/\bnew Point\b/new Offset/g'
      git ls-files -z | xargs -0 sed -i 's/\bconst Point\b/const Offset/g'
      git ls-files -z | xargs -0 sed -i 's/\bstatic Point /static Offset /g'
      git ls-files -z | xargs -0 sed -i 's/\bfinal Point /final Offset /g'
      git ls-files -z | xargs -0 sed -i 's/^\( *\)Point /\1Offset /g'
      git ls-files -z | xargs -0 sed -i 's/ui[.]Point\b/ui.Offset/g'
      git ls-files -z | xargs -0 sed -i 's/(Point\b/(Offset/g'
      git ls-files -z | xargs -0 sed -i 's/\([[{,]\) Point\b/\1 Offset/g'
      git ls-files -z | xargs -0 sed -i 's/@required Point\b/@required Offset/g'
      git ls-files -z | xargs -0 sed -i 's/<Point>/<Offset>/g'
      git ls-files -z | xargs -0 sed -i 's/[.]toOffset()//g'
      git ls-files -z | xargs -0 sed -i 's/[.]toPoint()//g'
      git ls-files -z | xargs -0 sed -i 's/\bshow Point, /show /g'
      git ls-files -z | xargs -0 sed -i 's/\bshow Point;/show Offset;/g'
      
      * Mechanical changes - dartdocs
      
      I applied the following at the root of the Flutter repository:
      
      git ls-files -z | xargs -0 sed -i 's/\ba \[Point\]/an [Offset]/g'
      git ls-files -z | xargs -0 sed -i 's/\[Point\]/[Offset]/g'
      
      * Further improvements and a test
      
      * Fix minor errors from rebasing...
      
      * Roll engine
      bf017b79
  23. 10 Apr, 2017 2 commits
  24. 07 Apr, 2017 1 commit
  25. 14 Mar, 2017 1 commit
  26. 13 Mar, 2017 1 commit
  27. 08 Mar, 2017 1 commit
  28. 04 Mar, 2017 1 commit
  29. 01 Mar, 2017 1 commit
  30. 26 Feb, 2017 1 commit
  31. 24 Feb, 2017 1 commit
    • Adam Barth's avatar
      Add a `color` argument to `Container`. (#8396) · f20c3d10
      Adam Barth authored
      It's common to just want a simple colored box. Simple thing should be simple,
      so this patch adds a convenience argument to Continer for creating a box
      decoration that is just a color.
      
      Fixes #5555
      f20c3d10
  32. 17 Feb, 2017 2 commits
    • Adam Barth's avatar
      Two becomes one (#8253) · e0b12ca1
      Adam Barth authored
      Rename all the "2" classes related to scrolling to remove the "2". Now that the
      old scrolling code is gone, we don't need to use the suffix.
      e0b12ca1
    • Adam Barth's avatar
      Remove Scrollable1 (#8225) · 90574b04
      Adam Barth authored
      All the clients have migrated to Scrollable2.
      90574b04
  33. 09 Feb, 2017 2 commits
  34. 01 Feb, 2017 1 commit
    • Adam Barth's avatar
      Remove extraneous uses of scrollableKey from tests (#7775) · 3a43fc88
      Adam Barth authored
      This patch removes unnecessary uses of scrollableKey from tests.
      Scrollable2 will likely use a different mechanism for identifying
      itself, so we want to focus on the uses of scrollableKey that will need
      to be addressed in the new implementation.
      3a43fc88