1. 13 Feb, 2024 1 commit
  2. 12 Feb, 2024 1 commit
  3. 09 Feb, 2024 1 commit
  4. 08 Feb, 2024 2 commits
    • Gray Mackall's avatar
      [Re-land] Enforce a policy on supported Gradle, Java, AGP, and KGP versions (#143132) · 4b0abc77
      Gray Mackall authored
      Re land of https://github.com/flutter/flutter/pull/142000. 
      Differences:
      1. Fixed the test that was failing in postsubmit. The reason was that the Flutter Gradle Plugin was being applied after KGP in that test, so we couldn't find the KGP version. This caused a log, and the test expects no logs. I moved FGP to after KGP
      2. Added to the logs for when we can't find AGP. Change is from
      >  "Warning: unable to detect project AGP version. Skipping version checking."
      
      to 
      > ~"Warning: unable to detect project AGP version. Skipping version checking. \nThis may be because you have applied the Flutter Gradle Plugin after AGP."~
      
      update: the above is wrong, changed to 
      > "Warning: unable to detect project KGP version. Skipping version checking. \nThis may be because you have applied AGP after the Flutter Gradle Plugin."
      
      3. Added a note to the app-level build.gradle templates that FGP must go last
      > // The Flutter Gradle Plugin must be applied after the Android and Kotlin Gradle plugin.
      4b0abc77
    • Bartek Pacia's avatar
      Reland "Update gradle lockfiles template (#140115)" (#143081) · deaa6002
      Bartek Pacia authored
      Trying to reland #140115 which I had to revert in #142889 because [it broke the tree](https://github.com/flutter/flutter/pull/140115#issuecomment-1925774719).
      
      In this PR I fixed the post-submit following tests:
      deaa6002
  5. 07 Feb, 2024 2 commits
    • Gray Mackall's avatar
      Restore log dumps for gradle OOM crashes, and set a value for `MaxMetaspaceSize` (#143085) · 120a01cc
      Gray Mackall authored
      Re-sets two jvmargs that were getting cleared because we set a value for `-Xmx`. Could help with https://github.com/flutter/flutter/issues/142957. Copied from comment here https://github.com/flutter/flutter/issues/142957:
      >Two random things I ran into while looking into this that might help:
      >
      >1. Gradle has defaults for a couple of the jvmargs, and setting any one of them clears those defaults for the others (bug here https://github.com/gradle/gradle/issues/19750). This can cause the "Gradle daemon to consume more and more native memory until it crashes", though the bug typically has a different associated error. It seems worth it to re-set those defaults.
      >2. There is a property we can set that will give us a heap dump on OOM ([-XX:HeapDumpOnOutOfMemoryError](https://docs.oracle.com/javase/8/docs/technotes/guides/troubleshoot/clopts001.html))
      
      Mostly just a find and replace from `find . -name gradle.properties -exec sed -i '' 's/\-Xmx4G/-Xmx4G\ \-XX:MaxMetaspaceSize=2G\ \-XX:+HeapDumpOnOutOfMemoryError/g' {} \;`, with the templates and the one test that writes from a string replaced by hand. I didn't set a value for `MaxMetaspaceSize` in the template files because I want to make sure this value doesn't cause problems in ci first (changes to the templates are essentially un-revertable for those who `flutter create` while the changes exist).
      120a01cc
    • Chris Bracken's avatar
      [Windows] Fix signed/unsigned int comparison (#142341) · 9f8fe3f0
      Chris Bracken authored
      Previously, we were comparing the signed int `target_length` (returned by WideCharToMultiByte) to a size_t string length, resulting in a signed/unsigned comparison warning as follows:
      
      ```
      windows\runner\utils.cpp(54,43): warning C4018:  '>': signed/unsigned mismatch
      ```
      
      WideCharToMultiByte returns:
      * 0 on error
      * the number of bytes written to the buffer pointed to by its fifth parameter, lpMultiByteStr, on success.
      
      As a result it's safe to store the return value in an unsigned int, which eliminates the warning.
      
      No changes to tests since this is dependent on end-user project settings/modifications and does not trigger a warning with default project settings.
      
      Fixes: https://github.com/flutter/flutter/issues/134227
      9f8fe3f0
  6. 04 Feb, 2024 2 commits
  7. 01 Feb, 2024 1 commit
  8. 24 Jan, 2024 1 commit
  9. 19 Jan, 2024 1 commit
  10. 12 Jan, 2024 2 commits
  11. 09 Jan, 2024 1 commit
  12. 05 Jan, 2024 1 commit
  13. 04 Jan, 2024 1 commit
  14. 03 Jan, 2024 2 commits
  15. 02 Jan, 2024 3 commits
  16. 20 Dec, 2023 1 commit
  17. 19 Dec, 2023 2 commits
  18. 15 Dec, 2023 3 commits
  19. 06 Dec, 2023 1 commit
  20. 05 Dec, 2023 1 commit
  21. 16 Nov, 2023 1 commit
  22. 15 Nov, 2023 1 commit
    • Srujan Gaddam's avatar
      Pin package:web 0.4.0 (#138428) · d8ffc739
      Srujan Gaddam authored
      This version is needed so that dart:js_interop can move to extension
      types. Also adds some code to handle some breaking changes:
      
      - Body -> Response. Body was an IDL interface mixin type we exposed in
      dart:html. Going forward, users should either use Request or Response.
      - Casts to JSAny. These are temporary until we move package:web types to
      extension types. Currently, package:web types can't implement JSObject
      as JSObject will move to be an extension type itself.
      Co-authored-by: 's avatarKevin Moore <kevmoo@users.noreply.github.com>
      d8ffc739
  23. 13 Nov, 2023 1 commit
  24. 09 Nov, 2023 1 commit
  25. 03 Nov, 2023 2 commits
  26. 02 Nov, 2023 1 commit
  27. 01 Nov, 2023 1 commit
  28. 31 Oct, 2023 1 commit
  29. 25 Oct, 2023 1 commit