- 01 Nov, 2023 1 commit
-
-
Dan Field authored
Fixes https://github.com/flutter/flutter/issues/137696 This will get the tree green again. The problem is that `CustomSemanticsAction` has static state in it, and todays test seed order makes things unhappy.
-
- 27 Oct, 2023 1 commit
-
-
LongCatIsLooong authored
Fixes https://github.com/flutter/flutter/issues/54665
-
- 20 Sep, 2023 1 commit
-
-
Greg Spencer authored
## Description This removes all of the comments that are of the form "so-and-so (must not be null|can ?not be null|must be non-null)" from the cases where those values are defines as non-nullable values. This PR removes them from the animation, cupertino, foundation, gestures, semantics, and services libraries. Each of them only had a few, so I lumped them together. This was done by hand, since it really didn't lend itself to scripting, so it needs to be more than just spot-checked, I think. I was careful to leave any comment that referred to parameters that were nullable, but I may have missed some. In addition to being no longer relevant after null safety has been made the default, these comments were largely fragile, in that it was easy for them to get out of date, and not be accurate anymore anyhow. This did create a number of constructor comments which basically say "Creates a [Foo].", but I don't really know how to avoid that in a large scale change, since there's not much you can really say in a lot of cases. I think we might consider some leniency for constructors to the "Comment must be meaningful" style guidance (which we de facto have already, since there are a bunch of these). ## Related PRs - https://github.com/flutter/flutter/pull/134991 - https://github.com/flutter/flutter/pull/134992 - https://github.com/flutter/flutter/pull/134993 - https://github.com/flutter/flutter/pull/134994 ## Tests - Documentation only change.
-
- 31 Jul, 2023 1 commit
-
-
Qun Cheng authored
-
- 17 Jul, 2023 1 commit
-
-
Greg Price authored
These methods and/or their docs were recently copied (in #128467 and #128973) from their classes' former shared base class AbstractNode. Their wording was fittingly abstract there, but that abstraction is a bit puzzling for a reader finding them on these more concrete classes and not aware of the AbstractNode history. So make them more concrete, in similar terms to the other methods around them. Also copy some useful points between corresponding methods on different classes (like that the parent of the root is null), and try to clean up the prose on [RenderObject.depth]. We focus on the more outward-facing parts of the API, letting methods like `redepthChildren` continue to talk generically about "nodes".
-
- 14 Jul, 2023 1 commit
-
-
Michael Goderbauer authored
Small clean up. A file probably doesn't need multiple way to refer to dart:ui concepts.
-
- 14 Jun, 2023 1 commit
-
-
Michael Goderbauer authored
-
- 09 Jun, 2023 1 commit
-
-
chunhtai authored
fixes https://github.com/flutter/flutter/issues/35112
-
- 12 Apr, 2023 1 commit
-
-
Bernardo Ferrari authored
`SemanticsFlag`/`SemanticsAction` cleanup (part 4)
-
- 07 Apr, 2023 1 commit
-
-
chunhtai authored
Fixes IgnorePointer and AbsorbPointer to only block user interactionsâ¦
-
- 31 Mar, 2023 1 commit
-
-
Bernardo Ferrari authored
`SemanticsFlag`/`SemanticsAction` enum migration (part 2)
-
- 23 Mar, 2023 1 commit
-
-
Jacob MacDonald authored
implement Iterator and Comparable instead of extending them
-
- 22 Mar, 2023 1 commit
-
-
Michael Goderbauer authored
Remove 1745 decorative breaks
-
- 01 Mar, 2023 1 commit
-
- 28 Feb, 2023 1 commit
-
-
Michael Goderbauer authored
showOnScreen does not crash if target node doesn't exist anymore
-
- 27 Feb, 2023 1 commit
-
- 24 Feb, 2023 1 commit
-
-
Michael Goderbauer authored
Move semantic-related bindings to SemanticsBinding
-
- 23 Feb, 2023 1 commit
-
-
chunhtai authored
* Fix text.rich to merge widget span * migrate to new API * update * addressing comment * addressing comments * update * addressing comment * Update
-
- 21 Jan, 2023 1 commit
-
-
Michael Goderbauer authored
* Remove unnecessary null checks in flutter/animation * Remove unnecessary null checks in flutter/semantics * Remove unnecessary null checks in flutter/scheduler
-
- 16 Dec, 2022 1 commit
-
- 11 Dec, 2022 2 commits
-
-
Ian Hickson authored
-
Casey Hillers authored
Revert "Adds API in semanticsconfiguration to decide how to merge child semanticsConfigurations (#110730)" (#116839) This reverts commit 352ad3a9.
-
- 07 Dec, 2022 1 commit
-
-
chunhtai authored
* Adds semantics merger API and fix input decorator * addressing comments * abstractnode to object * feature complete * addressing comments * fix comments * conditionally add sort order * fix bool * fix test * more fix * fix tests
-
- 17 Nov, 2022 1 commit
-
-
Ahmed Ashour authored
Fixes #115468
-
- 26 Oct, 2022 1 commit
-
-
Alex Wallen authored
-
- 10 Oct, 2022 1 commit
-
-
Jonah Williams authored
-
- 08 Sep, 2022 1 commit
-
-
yaakovschectman authored
* Introduce tests for tristate checkboxes * Initial * Use tristate changes in engine * Flutter_test matchers test update * Comments, tests * Update packages/flutter/lib/src/semantics/semantics.dart Co-authored-by: Chris Bracken <chris@bracken.jp> * Assert mutual exclusivity * Assert valid state before updating state * Update packages/flutter/lib/src/semantics/semantics.dart Typo fix in comment Co-authored-by: Loïc Sharma <737941+loic-sharma@users.noreply.github.com> Co-authored-by: Chris Bracken <chris@bracken.jp> Co-authored-by: Loïc Sharma <737941+loic-sharma@users.noreply.github.com>
-
- 01 Aug, 2022 1 commit
-
-
pdblasi-google authored
-
- 18 Jul, 2022 1 commit
-
-
Alexandre Ardhuin authored
-
- 24 Jun, 2022 1 commit
-
-
Alexandre Ardhuin authored
-
- 15 Jun, 2022 1 commit
-
-
J-P Nurmi authored
-
- 08 Jun, 2022 1 commit
-
-
Alexandre Ardhuin authored
-
- 25 May, 2022 1 commit
-
-
Pierre-Louis authored
-
- 12 May, 2022 1 commit
-
-
Michael Goderbauer authored
-
- 21 Apr, 2022 1 commit
-
-
chunhtai authored
-
- 14 Apr, 2022 1 commit
-
-
Michael Goderbauer authored
-
- 14 Mar, 2022 1 commit
-
-
Jonathan Joelson authored
-
- 04 Mar, 2022 1 commit
-
-
Michael Goderbauer authored
-
- 01 Mar, 2022 1 commit
-
-
Viren Khatri authored
* migrates lib/foundation and lib/widgets * migrates lib/painting and lib/material * migrates lib/cupertino, lib/gestures, lib/services, lib/semantics and lib/rendering * fixes failing tests * migrates test/ * improves hashing of lists
-
- 22 Feb, 2022 1 commit
-
-
Tomasz Gucio authored
-