1. 01 Nov, 2023 1 commit
  2. 27 Oct, 2023 1 commit
  3. 20 Sep, 2023 1 commit
    • Greg Spencer's avatar
      Remove 'must not be null' comments from various libraries. (#134984) · 8cda3bea
      Greg Spencer authored
      ## Description
      
      This removes all of the comments that are of the form "so-and-so (must not be null|can ?not be null|must be non-null)" from the cases where those values are defines as non-nullable values.
      
      This PR removes them from the animation, cupertino, foundation, gestures, semantics, and services libraries.  Each of them only had a few, so I lumped them together.
      
      This was done by hand, since it really didn't lend itself to scripting, so it needs to be more than just spot-checked, I think. I was careful to leave any comment that referred to parameters that were nullable, but I may have missed some.
      
      In addition to being no longer relevant after null safety has been made the default, these comments were largely fragile, in that it was easy for them to get out of date, and not be accurate anymore anyhow.
      
      This did create a number of constructor comments which basically say "Creates a [Foo].", but I don't really know how to avoid that in a large scale change, since there's not much you can really say in a lot of cases.  I think we might consider some leniency for constructors to the "Comment must be meaningful" style guidance (which we de facto have already, since there are a bunch of these).
      
      ## Related PRs
      - https://github.com/flutter/flutter/pull/134991
      - https://github.com/flutter/flutter/pull/134992
      - https://github.com/flutter/flutter/pull/134993
      - https://github.com/flutter/flutter/pull/134994
      
      ## Tests
       - Documentation only change.
      8cda3bea
  4. 31 Jul, 2023 1 commit
  5. 17 Jul, 2023 1 commit
    • Greg Price's avatar
      Make AbstractNode-derived docs more specific on RenderObject et al. (#130689) · 1937ae65
      Greg Price authored
      These methods and/or their docs were recently copied (in #128467 and #128973) from their classes' former shared base class AbstractNode. Their wording was fittingly abstract there, but that abstraction is a bit puzzling for a reader finding them on these more concrete classes and not aware of the AbstractNode history.  So make them more concrete, in similar terms to the other methods around them.
      
      Also copy some useful points between corresponding methods on different classes (like that the parent of the root is null), and try to clean up the prose on [RenderObject.depth].
      
      We focus on the more outward-facing parts of the API, letting methods like `redepthChildren` continue to talk generically about "nodes".
      1937ae65
  6. 14 Jul, 2023 1 commit
  7. 14 Jun, 2023 1 commit
  8. 09 Jun, 2023 1 commit
  9. 12 Apr, 2023 1 commit
  10. 07 Apr, 2023 1 commit
  11. 31 Mar, 2023 1 commit
  12. 23 Mar, 2023 1 commit
  13. 22 Mar, 2023 1 commit
  14. 01 Mar, 2023 1 commit
    • chunhtai's avatar
      Issues/111931 reland (#121576) · 978d9b55
      chunhtai authored
      * Revert "Revert "Fix text.rich to merge widget span (#113461)" (#121562)"
      
      This reverts commit c8d80163.
      
      * Fixes tag to not pollute cached semantics configuration in rendering object
      978d9b55
  15. 28 Feb, 2023 1 commit
  16. 27 Feb, 2023 1 commit
  17. 24 Feb, 2023 1 commit
  18. 23 Feb, 2023 1 commit
  19. 21 Jan, 2023 1 commit
  20. 16 Dec, 2022 1 commit
  21. 11 Dec, 2022 2 commits
  22. 07 Dec, 2022 1 commit
  23. 17 Nov, 2022 1 commit
  24. 26 Oct, 2022 1 commit
  25. 10 Oct, 2022 1 commit
  26. 08 Sep, 2022 1 commit
  27. 01 Aug, 2022 1 commit
  28. 18 Jul, 2022 1 commit
  29. 24 Jun, 2022 1 commit
  30. 15 Jun, 2022 1 commit
  31. 08 Jun, 2022 1 commit
  32. 25 May, 2022 1 commit
  33. 12 May, 2022 1 commit
  34. 21 Apr, 2022 1 commit
  35. 14 Apr, 2022 1 commit
  36. 14 Mar, 2022 1 commit
  37. 04 Mar, 2022 1 commit
  38. 01 Mar, 2022 1 commit
  39. 22 Feb, 2022 1 commit