- 28 Oct, 2019 1 commit
-
-
Albertus Angga Raharja authored
* Add structured errors in Animations, TabView, ChangeNotifier * Add structured error on MaterialPageRoute, BoxBorder, DecorationImagePainter, TextSpan * Add structured errors in Debug * Fix test errors * Add structured errors in Scaffold and Stepper * Add structured errors in part of Rendering Layer * Fix failing test due to FloatingPoint precision * Fix failing tests due to precision error and not using final * Fix failing test due to floating precision error with RegEx instead * Add structured error in CustomLayout and increase test coverage * Add structured error & its test in ListBody * Add structured error in ProxyBox and increase test coverage * Add structured error message in Viewport * Fix styles and add more assertions on ErrorHint and DiagnosticProperty * Add structured error in scheduler/binding and scheduler/ticker Signed-off-by:
Albertus Angga Raharja <albertusangga@google.com> * Add structured error in AssetBundle and TextInput Signed-off-by:
Albertus Angga Raharja <albertusangga@google.com> * Add structured errors in several widgets #1 Signed-off-by:
Albertus Angga Raharja <albertusangga@google.com> * Remove unused import Signed-off-by:
Albertus Angga Raharja <albertusangga@google.com> * Add assertions on hint messages Signed-off-by:
Albertus Angga Raharja <albertusangga@google.com> * Fix catch spacing Signed-off-by:
Albertus Angga Raharja <albertusangga@google.com> * Add structured error in several widgets part 2 and increase code coverage Signed-off-by:
Albertus Angga Raharja <albertusangga@google.com> * Add structured error in flutter_test/widget_tester * Fix floating precision accuracy by using RegExp Signed-off-by:
Albertus Angga Raharja <albertusangga@google.com> * Remove todo to add tests in Scaffold showBottomSheet Signed-off-by:
Albertus Angga Raharja <albertusangga@google.com> * Fix reviews by indenting lines and fixing the assertion orders Signed-off-by:
Albertus Angga Raharja <albertusangga@google.com> * Fix failing tests due to renaming class Signed-off-by:
Albertus Angga Raharja <albertusangga@google.com> * Try skipping the NetworkBundleTest Signed-off-by:
Albertus Angga Raharja <albertusangga@google.com> * Remove leading space in material/debug error hint Signed-off-by:
Albertus Angga Raharja <albertusangga@google.com>
-
- 10 Sep, 2019 1 commit
-
-
Peter Lee authored
-
- 03 Sep, 2019 1 commit
-
-
Tom Robinson authored
-
- 16 Aug, 2019 1 commit
-
-
Tom Robinson authored
* Take growth direction into account when computing value for getOffsetForReveal in AxisDirection.right and .up conditions. * Add alignment 1.0 test to left - reverse growth * Add Reverse List showOnScreen test * Formatting fix.
-
- 09 May, 2019 1 commit
-
-
Michael Goderbauer authored
-
- 01 Mar, 2019 1 commit
-
-
Alexandre Ardhuin authored
* add trailing commas on list/map/parameters * add trailing commas on Invocation with nb of arg>1 * add commas for widget containing widgets * add trailing commas if instantiation contains trailing comma * revert bad change
-
- 21 Feb, 2019 1 commit
-
-
Alexandre Ardhuin authored
-
- 29 Jan, 2019 1 commit
-
-
Alexandre Ardhuin authored
-
- 17 Jan, 2019 1 commit
-
-
Michael Goderbauer authored
Fixes #20893, the most-upvoted bug for framework. A detailed analysis explaining the cause of the bug has been posted at #20893 (comment).
-
- 09 Jan, 2019 1 commit
-
-
matthew-carroll authored
-
- 18 Dec, 2018 1 commit
-
-
Alexandre Ardhuin authored
-
- 07 Nov, 2018 1 commit
-
-
Hans Muller authored
-
- 25 Sep, 2018 1 commit
-
-
Hans Muller authored
MaterialPageRoute transitions are now defined by the Theme. Added (optional) support for Android P style page transitions.
-
- 12 Sep, 2018 1 commit
-
-
Alexandre Ardhuin authored
* enable lint unnecessary_new * fix tests * fix tests * fix tests
-
- 02 Aug, 2018 1 commit
-
-
Alexandre Ardhuin authored
-
- 30 Jul, 2018 1 commit
-
-
Michael Goderbauer authored
Fixes #19523
-
- 27 Jul, 2018 1 commit
-
-
Todd Volkert authored
It was causing problems rolling Flutter into Fuchsia
-
- 23 Jul, 2018 1 commit
-
-
Alexandre Ardhuin authored
* re-enable lint unnecessary_const * remove trailling whitespaces * remove unnecessary const (after merge)
-
- 16 Jul, 2018 2 commits
-
-
Ian Hickson authored
This reverts commit cc1cf13e.
-
Alexandre Ardhuin authored
-
- 07 Jun, 2018 1 commit
-
-
Michael Goderbauer authored
-
- 05 Jun, 2018 1 commit
-
-
Alexandre Ardhuin authored
-
- 21 May, 2018 1 commit
-
-
Michael Goderbauer authored
-
- 18 May, 2018 1 commit
-
-
Greg Spencer authored
Our style guide says the k's are not necessary, and it seems like a good idea to make all the code be consistent on this. Only naming changes to private vars: no logic changes.
-
- 04 May, 2018 1 commit
-
-
Michael Goderbauer authored
-
- 20 Mar, 2018 1 commit
-
-
Alexandre Ardhuin authored
-
- 07 Mar, 2018 1 commit
-
-
Josh Soref authored
* spelling: accommodate * spelling: allotted * spelling: anonymous * spelling: artificial * spelling: associated * spelling: asset * spelling: button * spelling: canvas * spelling: compatibility * spelling: coverage * spelling: condition * spelling: decoration * spelling: deferring * spelling: diameter * spelling: direction * spelling: displacement * spelling: dropdown * spelling: needing * spelling: environment * spelling: exited * spelling: expansion * spelling: explore * spelling: families * spelling: horizontal * spelling: increment * spelling: indices * spelling: internationalization * spelling: labrador * spelling: localizations * spelling: midflight * spelling: milliseconds * spelling: minimum * spelling: multiple * spelling: multiplication * spelling: navigator * spelling: overridden * spelling: package * spelling: performance * spelling: platform * spelling: porsche * spelling: position * spelling: preceded * spelling: precede * spelling: precedence * spelling: print * spelling: property * spelling: readily * spelling: reproducibility * spelling: rounded * spelling: scroll * spelling: separate * spelling: separator * spelling: services * spelling: specific * spelling: specify * spelling: synchronously * spelling: through * spelling: timeout * spelling: triangle * spelling: trivial * spelling: unusual * spelling: then * spelling: vertically * spelling: visible * spelling: visited * spelling: voice
-
- 09 Jan, 2018 1 commit
-
-
Michael Goderbauer authored
`RenderSemanticsGestureHandler` is no longer a semantics boundary, which allows us to correctly mark disabled buttons as disabled without having their semantics size and semantics node id change unexpectedly. Fixes https://github.com/flutter/flutter/issues/12589. Fixes https://github.com/flutter/flutter/issues/11991. See also https://github.com/flutter/flutter/issues/11993. This change also required some refactoring to how we deal with `twoPaneSemantics` scrolling as it previously relied on `RenderSemanticsGestureHandler` being a semantics boundary. This should also make the underlying logic easier to understand. In addition, the following minor changes are included in this PR: * Removal of orphaned and unused `SemanticsConfiguration.isMergingDescendantsIntoOneNode`. * Logic optimizations for `markNeedsSemanticsUpdate` . * Fix for edge case where `MergeSemantics` failed to merge semantics. * Use of emojis to better indicate leaf merging in the printed semantics tree. * Better assert message for adding invisible child semantics nodes. * Make some semantics tests robuster by not relying on creation order of SemanticsNode ids across test boundaries. Fixes https://github.com/flutter/flutter/issues/13943.
-
- 17 Nov, 2017 1 commit
-
-
Greg Spencer authored
I got tired of drive-by spelling fixes, so I figured I'd just take care of them all at once. This only corrects errors in the dartdocs, not regular comments, and I skipped any sample code in the dartdocs. It doesn't touch any identifiers in the dartdocs either. No code changes, just comments.
-
- 03 Nov, 2017 1 commit
-
-
amirh authored
-
- 31 Oct, 2017 1 commit
-
-
Yegor authored
* fix miscellaneous typos in dartdocs * moar typos
-
- 18 Oct, 2017 1 commit
-
-
Michael Goderbauer authored
* Oct 12 10:12am * implicit_semantics_test.dart passes * refactoring * works in nice * minor rename * more doc comments * to be explicit check better * fix test * ++ * ++ * semantics_9_test (BlockSemantics) and implicit_semantics_test are passing * doc updates * tiny refactor * fix static errors in tests * fix gesture detector * ++ * ++ * geometry * ++ * remove noGeometry * revert test * + * all tests but scrolling/clipping pass * clipping works * scrolling halfway * sliver tests pass * ALL TESTS PASS * SemanticsNode changed * docs and tiny fixes * card test * more doc comments * remove missed print * more tests * make test pass on Linux * remove changes to intellij proj file * review comments
-
- 21 Sep, 2017 1 commit
-
-
Alexandre Ardhuin authored
-
- 05 Sep, 2017 2 commits
-
-
Michael Goderbauer authored
* getOffsetToReveal deals with pinned slivers If a Sliver can potentially be pinned at the edge of a viewport, getOffsetToReveal will take that into account and scroll further up/down to ensure that the object to reveal doesn't end up covered by a pinned sliver. This is important for accessibility scrolling with app bars. Since how much a pinned sliver is covering is dynamic (it can change with scroll offset, etc), getOffsetToReveal deals with the worst case and tries to ensure that the object to uncover is visible when the pinned slivers are at their max pinned extent. * name fixes * review feedback * typos * renaming * fix analyzer * fix test * analyzer fixes
-
Adam Barth authored
Fixes #11855
-
- 30 Aug, 2017 1 commit
-
-
Michael Goderbauer authored
* ensureVisible works with viewports that have a center child * review feedback
-
- 29 Aug, 2017 1 commit
-
-
Michael Goderbauer authored
* Exclude SemanticNodes that are fully covered by an overlapping sliver * simplification * formatting * nits * add test for center widget
-
- 28 Aug, 2017 1 commit
-
-
Michael Goderbauer authored
* Semantic hit test order for Slivers * ++ * fix double space * refactoring * fix test * comment fix * tests * remove accidental debugDumpSemanticsTree * review comments * fix button
-
- 26 Aug, 2017 1 commit
-
-
Michael Goderbauer authored
* refactor to ensureAction + some related doc fixes * Update docs for markNeedsSemanticsUpdate * rewording * rewording * ensureAction test * ensureAction test * ensureAction test * more tests * refactor to allways reset node * tiny fixes * more test * doc fixes * one more test * review comments
-
- 23 Aug, 2017 1 commit
-
-
Michael Goderbauer authored
* refactor to assembleSemanticNode * ++ * cleanup * fix test * add note * review comments * review feedback * import fix * another import fix * refactor to ensure tag * tests, tests, tests * analyzer fixes * review comments
-