- 20 Sep, 2023 1 commit
-
-
Greg Spencer authored
## Description This removes all of the comments that are of the form "so-and-so (must not be null|can ?not be null|must be non-null)" from the cases where those values are defines as non-nullable values. This PR removes them from the painting and rendering libraries. This was done by hand, since it really didn't lend itself to scripting, so it needs to be more than just spot-checked, I think. I was careful to leave any comment that referred to parameters that were nullable, but I may have missed some. In addition to being no longer relevant after null safety has been made the default, these comments were largely fragile, in that it was easy for them to get out of date, and not be accurate anymore anyhow. This did create a number of constructor comments which basically say "Creates a [Foo].", but I don't really know how to avoid that in a large scale change, since there's not much you can really say in a lot of cases. I think we might consider some leniency for constructors to the "Comment must be meaningful" style guidance (which we de facto have already, since there are a bunch of these). ## Related PRs - https://github.com/flutter/flutter/pull/134984 - https://github.com/flutter/flutter/pull/134991 - https://github.com/flutter/flutter/pull/134992 - https://github.com/flutter/flutter/pull/134994 ## Tests - Documentation only change.
-
- 08 Sep, 2023 1 commit
-
-
Greg Spencer authored
## Description Now that we are using Doxygen for building docs for the embedders, this updates the links to point to the correct URLs. ## Related Issues - https://github.com/flutter/flutter/issues/124833 ## Related PRs - https://github.com/flutter/engine/pull/45561
-
- 19 Jul, 2023 1 commit
-
-
Greg Price authored
Fixes #115525. On [AbstractNode.detach] and its two progeny [RenderNode.detach] and [Layer.detach], the docs said both to call the inherited method before detaching children, and to end by doing so. The former advice is what's enforced by an assertion in the base implementation, so cut out the other. The corresponding [attach] methods redundantly said twice to call the inherited method first, so cut the redundancy. Leave in place the version more recently added (in #76021), because that PR shows the old version must have been easy to overlook.
-
- 17 Jul, 2023 2 commits
-
-
Greg Price authored
These methods and/or their docs were recently copied (in #128467 and #128973) from their classes' former shared base class AbstractNode. Their wording was fittingly abstract there, but that abstraction is a bit puzzling for a reader finding them on these more concrete classes and not aware of the AbstractNode history. So make them more concrete, in similar terms to the other methods around them. Also copy some useful points between corresponding methods on different classes (like that the parent of the root is null), and try to clean up the prose on [RenderObject.depth]. We focus on the more outward-facing parts of the API, letting methods like `redepthChildren` continue to talk generically about "nodes".
-
Jason Simmons authored
This was showing up as a hot spot in some benchmarks and profiles. This function is called frequently during frame builds and often has an empty map. There may be significant overhead from obtaining the values iterator and cloning it into a list. See https://github.com/flutter/flutter/issues/130339
-
- 14 Jun, 2023 1 commit
-
-
Michael Goderbauer authored
-
- 15 May, 2023 1 commit
-
-
Tomasz Gucio authored
-
- 02 May, 2023 1 commit
-
-
Jonah Williams authored
Engine PR: https://github.com/flutter/engine/pull/41593 This must land first We should remove these, as they've been deprecated for a while. On the engine side of things, the physical model layer is the only one which requires the device pixel ratio, so deleting it will allow us to simplify the layer tree code in https://github.com/flutter/engine/pull/41559
-
- 22 Mar, 2023 1 commit
-
-
Ian Hickson authored
Documentation improvements
-
- 31 Jan, 2023 1 commit
-
-
LongCatIsLooong authored
* PostFrameCallbacks -> compositionCallbacks * review * review
-
- 21 Jan, 2023 1 commit
-
-
Michael Goderbauer authored
-
- 11 Dec, 2022 1 commit
-
-
Ian Hickson authored
-
- 23 Nov, 2022 1 commit
-
-
Jim Graham authored
Use the new pushImageFilter offset parameter to fix the transform of the children (#113673) (#115884)
-
- 22 Nov, 2022 2 commits
-
-
Jonah Williams authored
Revert "Use the new pushImageFilter offset parameter to fix the transform of the children (#113673)" (#115861) This reverts commit 91aeda7b.
-
Jim Graham authored
-
- 01 Nov, 2022 2 commits
- 28 Sep, 2022 1 commit
-
-
Greg Spencer authored
This implements a MenuBar widget that can render a Material menu bar, and a MenuAnchor widget used to create a cascading menu in a region. The menus are drawn in the overlay, while the menu bar itself is in the regular widget tree. Keyboard traversal works between the two. This implementation of the MenuBar uses MenuAnchor to create a cascading menu that contains widgets representing the menu items. These menu items can be any kind of widget, but are typically SubmenuButtons that host submenus, or MenuItemButtons that have shortcut hints (but don't actually activate the shortcuts) and don't host submenus. Cascading menus can be created outside of a MenuBar by using a MenuAnchor. They can be either given a specific location to appear (a coordinate), or they can be located by the MenuAnchor region that wraps the control that opens them. The developer may also create a MenuController to pass to the various menu primitives (MenuBar or MenuAnchor) to associate menus so that they can be traversed together and closed together. Creating a controller is not required.
-
- 20 Sep, 2022 1 commit
-
-
Polina Cherkasova authored
-
- 20 Aug, 2022 1 commit
-
-
Jonah Williams authored
-
- 22 Jul, 2022 1 commit
-
-
Jonah Williams authored
-
- 25 May, 2022 1 commit
-
-
Pierre-Louis authored
* Use `curly_braces_in_flow_control_structures` for `rendering` * fix comments * fix dangling
-
- 20 May, 2022 1 commit
-
-
Dan Field authored
-
- 17 May, 2022 1 commit
-
-
Dan Field authored
-
- 12 May, 2022 1 commit
-
-
Michael Goderbauer authored
-
- 26 Apr, 2022 1 commit
-
-
Jonah Williams authored
-
- 14 Apr, 2022 1 commit
-
-
Michael Goderbauer authored
-
- 11 Apr, 2022 1 commit
-
-
wangying authored
-
- 25 Mar, 2022 1 commit
-
-
fzyzcjy authored
Fix `FollowerLayer` (`CompositedTransformFollower`) has null pointer error when using with some kinds of `Layer`s (#100672)
-
- 18 Mar, 2022 1 commit
-
-
fzyzcjy authored
-
- 03 Feb, 2022 1 commit
-
-
Ian Hickson authored
-
- 24 Jan, 2022 1 commit
-
-
chunhtai authored
-
- 12 Jan, 2022 1 commit
-
-
Michael Goderbauer authored
-
- 08 Jan, 2022 2 commits
-
-
chunhtai authored
-
Michael Goderbauer authored
-
- 07 Jan, 2022 1 commit
-
-
Dan Field authored
-
- 12 Dec, 2021 1 commit
-
-
Dan Field authored
-
- 06 Dec, 2021 1 commit
-
- 04 Dec, 2021 1 commit
-
-
Jason C.H authored
-
- 28 Oct, 2021 1 commit
-
-
Michael Goderbauer authored
-