- 05 Apr, 2019 1 commit
-
-
Tim Sneath authored
-
- 11 Oct, 2018 1 commit
-
-
Greg Spencer authored
This attempts to re-land #22656. There are two changes from the original: I turned off wrapping completely when not sending output to a terminal. Previously I had defaulted to wrapping at and arbitrary 100 chars in that case, just to keep long messages from being too long, but that turns out the be a bad idea because there are tests that are relying on the specific form of the output. It's also pretty arbitrary, and mostly people sending output to a non-terminal will want unwrapped text. I found a better way to terminate ANSI color/bold sequences, so that they can be embedded within each other without needed quite as complex a dance with removing redundant sequences. As part of these changes, I removed the Logger.supportsColor setter so that the one source of truth for color support is in AnsiTerminal.supportsColor. * Turn on line wrapping again in usage and status messages, adds ANSI color to doctor and analysis messages. (#22656) This turns on text wrapping for usage messages and status messages. When on a terminal, wraps to the width of the terminal. When writing to a non-terminal, wrap lines at a default column width (currently defined to be 100 chars). If --no-wrap is specified, then no wrapping occurs. If --wrap-column is specified, wraps to that column (if --wrap is on). Adds ANSI color to the doctor and analysis output on terminals. This is in this PR with the wrapping, since wrapping needs to know how to count visible characters in the presence of ANSI sequences. (This is just one more step towards re-implementing all of Curses for Flutter. :-)) Will not print ANSI sequences when sent to a non-terminal, or of --no-color is specified. Fixes ANSI color and bold sequences so that they can be combined (bold, colored text), and a small bug in indentation calculation for wrapping. Since wrapping is now turned on, also removed many redundant '\n's in the code.
-
- 06 Oct, 2018 2 commits
-
-
Greg Spencer authored
Revert "Turn on line wrapping in usage and status messages, adds ANSI color to doctor and analysis messages. (#22656)" (#22759) This reverts commit e4386321 because it breaks 160 benchmarks, and several devicelab tests, due to changing the format of the output.
-
Greg Spencer authored
Turn on line wrapping in usage and status messages, adds ANSI color to doctor and analysis messages. (#22656) This turns on text wrapping for usage messages and status messages. When on a terminal, wraps to the width of the terminal. When writing to a non-terminal, wrap lines at a default column width (currently defined to be 100 chars). If --no-wrap is specified, then no wrapping occurs. If --wrap-column is specified, wraps to that column (if --wrap is on). Adds ANSI color to the doctor and analysis output on terminals. This is in this PR with the wrapping, since wrapping needs to know how to count visible characters in the presence of ANSI sequences. (This is just one more step towards re-implementing all of Curses for Flutter. :-)) Will not print ANSI sequences when sent to a non-terminal, or of --no-color is specified. Fixes ANSI color and bold sequences so that they can be combined (bold, colored text), and a small bug in indentation calculation for wrapping. Since wrapping is now turned on, also removed many redundant '\n's in the code.
-
- 05 Oct, 2018 1 commit
-
-
Alexandre Ardhuin authored
-
- 09 May, 2018 1 commit
-
-
Danny Tuppeny authored
-
- 02 Feb, 2018 1 commit
-
-
Alexandre Ardhuin authored
-
- 07 Dec, 2017 1 commit
-
-
Devon Carew authored
* route device issue diagnostics to flutter doctor * review comments * review comments
-
- 22 Oct, 2017 1 commit
-
-
Alexandre Ardhuin authored
-
- 26 Apr, 2017 1 commit
-
-
Todd Volkert authored
`adb` can sometimes hang, which will in turn hang the Dart isolate if we're using `Process.runSync()`. This changes many of the `Device` methods to return `Future<T>` in order to allow them to use the async process methods. A future change will add timeouts to the associated calls so that we can properly alert the user to the hung `adb` process. This is work towards #7102, #9567
-
- 04 Mar, 2017 1 commit
-
-
Chris Bracken authored
-
- 29 Nov, 2016 1 commit
-
-
John McCutchan authored
-
- 14 Nov, 2016 1 commit
-
-
Dan Rubel authored
* Remove the workaround that pinned args to v0.13.6 This reverts most of the changes in commit 6331b6c8 * throw exception if exit code is not an integer * rework command infrastructure to throw ToolExit when non-zero exitCode * convert commands to return Future<Null> * cleanup remaining commands to use throwToolExit for non-zero exit code * remove isUnusual exception message * add type annotations for updated args package
-
- 11 Nov, 2016 1 commit
-
-
Dan Rubel authored
* convert flutter commands to use ToolExit for non-zero exit code * add convenience method throwToolExit * print ToolExit message iff not null
-
- 16 Sep, 2016 1 commit
-
-
Dan Rubel authored
* refactor _run to runCmd * replace requiresProjectRoot getter with call to commandValidator * replace requiresDevice getter with call to findTargetDevice * trace command requires a debug connection, not a device * inline androidOnly getter * rename command methods to verifyTheRunCmd and runCmd * move common verification into BuildSubCommand * rename deviceForCommand to device * rename methods to verifyThenRunCommand and runCommand
-
- 23 May, 2016 1 commit
-
-
Devon Carew authored
-
- 25 Apr, 2016 1 commit
-
-
Devon Carew authored
* improve text for devices * nit * tweak text
-
- 14 Mar, 2016 2 commits
-
-
Hixie authored
-
Devon Carew authored
-
- 11 Mar, 2016 1 commit
-
-
Devon Carew authored
-
- 02 Mar, 2016 1 commit
-
-
Devon Carew authored
-
- 22 Feb, 2016 3 commits
-
-
Devon Carew authored
-
Chinmay Garde authored
-
Chinmay Garde authored
-
- 20 Feb, 2016 1 commit
-
-
Chinmay Garde authored
-
- 17 Feb, 2016 2 commits
-
-
Devon Carew authored
-
Devon Carew authored
-
- 14 Feb, 2016 1 commit
-
-
Devon Carew authored
-
- 10 Feb, 2016 1 commit
-
-
Devon Carew authored
-
- 28 Jan, 2016 1 commit
-
-
Devon Carew authored
rename to printTrace(), printStatus(), and printError()
-
- 27 Jan, 2016 1 commit
-
-
Devon Carew authored
-
- 22 Jan, 2016 2 commits
-
-
Eric Seidel authored
Turns out linux does have an ideviceinstaller package however it doesn't contain idevice_id or any of the other tools we use. Furthermore we don't have xcrun or the rest of xcode on linux so we can't manipulate simulators either. No sense in printing out a warning that ios isn't supported every time on linux, so I wrapped that block in osx only. @chinmaygarde @devoncarew
-
Devon Carew authored
remove device type specific checks
-
- 21 Jan, 2016 1 commit
-
-
Devon Carew authored
-
- 20 Jan, 2016 1 commit
-
-
Devon Carew authored
-
- 29 Nov, 2015 1 commit
-
-
Adam Barth authored
1) Moved basic utility code into base/ directory to make it clear which code doesn't depend on Flutter-specific knowldge. 2) Move the CommandRunner subclasses into a runner/ directory because these aren't commands themselves.
-
- 10 Nov, 2015 1 commit
-
-
Adam Barth authored
-
- 29 Oct, 2015 1 commit
-
-
Devon Carew authored
remove an unused import review comments rename st --> stack
-
- 17 Oct, 2015 1 commit
-
-
Devon Carew authored
-
- 12 Oct, 2015 1 commit
-
-
Adam Barth authored
This patch makes `flutter start` work without a clone of the engine git repository. Making this work pulled a relatively large refactor of how the commands interact with application packages and devices. Now commands that want to interact with application packages or devices inherit from a common base class that holds stores of those objects as members. In production, the commands download and connect to devices based on the build configuration stored on the FlutterCommandRunner. In testing, these fields are used to mock out the real application package and devices.
-