- 06 Nov, 2023 18 commits
-
-
Kostia Sokolovskyi authored
-
Kostia Sokolovskyi authored
-
Kostia Sokolovskyi authored
-
flutter-pub-roller-bot authored
This PR was generated by `flutter update-packages --force-upgrade`.
-
Elias Yishak authored
Related to tracker issue: - https://github.com/flutter/flutter/issues/128251 For this migration, the `HotEvent` was being referenced in 2 additional files outside of `lib/src/reporting/events.dart`, shown below in the screenshot <img width="257" alt="image" src="https://github.com/flutter/flutter/assets/42216813/97986f89-2253-4db1-9deb-bbced6321a16">
-
Jonah Williams authored
Partial repaint is too effective, and we'd like to be able to measure performance without carefully structuring the benchmarks. For example, right now partial repaint is culling any blurs in the multibackdrop case, which we should be using to track https://github.com/flutter/flutter/issues/132735
-
Greg Spencer authored
## Description This checks API doc strings for malformed links to examples. It prevents errors in capitalization, spacing, number of asterisks, etc. It won't catch all errors, because it needs to have a minimally indicative string to know that it even is trying to be a link to an example. At a minimum, the line needs to look like (literally, not as a regexp) `///*seecode.*` in order to be seen as a link to an example. Separately, I'm going to add a check to the snippets tool that checks to make sure that an `{@tool}` block includes either a link to a sample file or a dart code block. ## Tests - Added a test to make sure it catches some malformed links.
-
Ivan Inozemtsev authored
`jsonDecode` decodes lists as `List<Object?>`, so the cast to `List<Object>` fails at runtime in sound null safety mode.
-
auto-submit[bot] authored
Reverts flutter/flutter#136624 Initiated by: HansMuller This change reverts the following previous change: Original Description: This PR updates `BottomNavigationBar` unit tests for M3 migration. More info in https://github.com/flutter/flutter/issues/127064 It was somewhat complex because existing tests relied on a lot of magic numbers.
-
engine-flutter-autoroll authored
https://github.com/flutter/packages/compare/cccf5d24d703...49eac1fec6c7 2023-11-03 katelovett@google.com [two_dimensional_scrollables] Add borderRadius support to TableSpanDecoration (flutter/packages#5184) 2023-11-03 47866232+chunhtai@users.noreply.github.com [go_router] Adds an ability to add a custom codec for serializing/des⦠(flutter/packages#5288) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Bruno Leroux authored
This PR updates `BottomNavigationBar` unit tests for M3 migration. More info in https://github.com/flutter/flutter/issues/127064 It was somewhat complex because existing tests relied on a lot of magic numbers.
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/4f6ed31bd8bd...bdfa8aa8f81f 2023-11-06 skia-flutter-autoroll@skia.org Roll Dart SDK from 96664852accc to 9211fc6406bb (1 revision) (flutter/engine#47706) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/b9b3269b0b2c...4f6ed31bd8bd 2023-11-06 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from V3diHxFGlypUQKNH_... to HQfFSkurc6-jKM2jh... (flutter/engine#47705) 2023-11-06 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from kCyxKT7e5lMvkD3Yt... to _vGlgDiKOrtlKrZAP... (flutter/engine#47704) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from kCyxKT7e5lMv to _vGlgDiKOrtl fuchsia/sdk/core/mac-amd64 from V3diHxFGlypU to HQfFSkurc6-j If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Taha Tesser authored
Provide a helpful error message when `ColorScheme.brightness` doesn't match `ThemeData.brightness` (#137611) fixes [Unexpected behaviour with ColorScheme.fromSeed and Brightness.dark](https://github.com/flutter/flutter/issues/127523)
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/555ffa17b55c...b9b3269b0b2c 2023-11-06 kustermann@google.com Fix FFI-based tonic layer to use proper C++ static_cast<>()s (flutter/engine#47644) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Andrew Kolos authored
Fix tool exit message shown when user provides a non-list to "assets" for a deferred component (#137837) Fixes #136163
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/0d8c7ceacc01...555ffa17b55c 2023-11-05 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from IH6mGM_PvyJB5x7SM... to V3diHxFGlypUQKNH_... (flutter/engine#47696) Also rolling transitive DEPS: fuchsia/sdk/core/mac-amd64 from IH6mGM_PvyJB to V3diHxFGlypU If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/11d66db97d3f...0d8c7ceacc01 2023-11-05 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from qGNZvKP4q2a4jm2Ce... to kCyxKT7e5lMvkD3Yt... (flutter/engine#47697) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from qGNZvKP4q2a4 to kCyxKT7e5lMv If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
- 05 Nov, 2023 3 commits
-
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/a7592e42464c...11d66db97d3f 2023-11-05 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 3dRrKiwZsFq8U8vSM... to qGNZvKP4q2a4jm2Ce... (flutter/engine#47694) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from 3dRrKiwZsFq8 to qGNZvKP4q2a4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/1c6bd97e2288...a7592e42464c 2023-11-05 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from sZ51VV1mNynI39WtT... to IH6mGM_PvyJB5x7SM... (flutter/engine#47693) Also rolling transitive DEPS: fuchsia/sdk/core/mac-amd64 from sZ51VV1mNynI to IH6mGM_PvyJB If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/daf18fe46b72...1c6bd97e2288 2023-11-05 skia-flutter-autoroll@skia.org Roll Dart SDK from b9ae53ac4663 to 96664852accc (1 revision) (flutter/engine#47692) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
- 04 Nov, 2023 8 commits
-
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/a45e679828e6...daf18fe46b72 2023-11-04 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from SmJ_8HFjjm55T4ijL... to 3dRrKiwZsFq8U8vSM... (flutter/engine#47690) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from SmJ_8HFjjm55 to 3dRrKiwZsFq8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/fb2a9c20141e...a45e679828e6 2023-11-04 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from ftLug7WGUYrtgHyy6... to sZ51VV1mNynI39WtT... (flutter/engine#47689) Also rolling transitive DEPS: fuchsia/sdk/core/mac-amd64 from ftLug7WGUYrt to sZ51VV1mNynI If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/576833873c15...fb2a9c20141e 2023-11-04 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Dart SDK from b9ae53ac4663 to 96664852accc (1 revision)" (flutter/engine#47687) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/25f5e285f874...576833873c15 2023-11-04 godofredoc@google.com Fix symbols upload (flutter/engine#47669) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/7282a5d94ab6...25f5e285f874 2023-11-04 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 8tJt8KJzTzbwwQlUE... to SmJ_8HFjjm55T4ijL... (flutter/engine#47682) 2023-11-04 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from 5GLArzquQ4eL56vdy... to ftLug7WGUYrtgHyy6... (flutter/engine#47681) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from 8tJt8KJzTzbw to SmJ_8HFjjm55 fuchsia/sdk/core/mac-amd64 from 5GLArzquQ4eL to ftLug7WGUYrt If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/b66a87626300...7282a5d94ab6 2023-11-04 skia-flutter-autoroll@skia.org Roll Dart SDK from b9ae53ac4663 to 96664852accc (1 revision) (flutter/engine#47679) 2023-11-04 skia-flutter-autoroll@skia.org Roll Dart SDK from c52fb4fe2d86 to b9ae53ac4663 (1 revision) (flutter/engine#47674) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Kostia Sokolovskyi authored
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/ec20731de6ff...b66a87626300 2023-11-03 kustermann@google.com Fix incorrect C++ return value of PictureRecorder::endRecording() (flutter/engine#47645) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
- 03 Nov, 2023 11 commits
-
-
Alex Isaienko authored
Call the `dependency.removeDependent(this)` instead of `dependency._dependents.remove(this)` inside the `Element.deactivate()`. This allows `InheritedElements` to know when they can release resources associated with a given dependent `Element`. Fixes #129207
-
Michael Goderbauer authored
Fixes https://github.com/flutter/flutter/issues/137424. The generic type argument was unused.
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/035740c1f90e...ec20731de6ff 2023-11-03 skia-flutter-autoroll@skia.org Roll Dart SDK from 529fcd5bdffc to c52fb4fe2d86 (1 revision) (flutter/engine#47668) 2023-11-03 jacksongardner@google.com Bundle flutter.js via esbuild (flutter/engine#47573) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Daco Harkes authored
Pin the dependencies from dart-lang/native to a specific version during testing (rather than having them auto-upgrade during pub resolution). This will prevent tests using the template to start failing if a bad version is published to pub. Closes: https://github.com/flutter/flutter/issues/137418 Also bumps dep in flutter_tools.
-
Chris Bracken authored
Background: In the framework, the position of the caret rect is updated on each cursor position change such that if the user initiates composing input, the current cursor position can be used for the first character until the composing rect can be sent. Previously, no update was sent on selection changes, on the assumption that the most recent cursor position will remain the correct position for the duration of the selection. While this is the case for forward selections, it is an incorrect assumption for reversed selections, where selection.base > selection.extent. We now update the cursor position during selection changes such that the cursor position sent to the embedder is always the position at which next text input would occur. This is the start position of the selection or min(selection.baseOffset, selection.extentOffset). Issue: https://github.com/flutter/flutter/issues/137677
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/677040f10f65...035740c1f90e 2023-11-03 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from ho9FqsUD0hxh0b8to... to 8tJt8KJzTzbwwQlUE... (flutter/engine#47666) 2023-11-03 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from y-hqwYkPPVT6RwmAS... to 5GLArzquQ4eL56vdy... (flutter/engine#47667) 2023-11-03 skia-flutter-autoroll@skia.org Roll Skia from c0ca9f2fd828 to 77aeee3b81a5 (1 revision) (flutter/engine#47663) 2023-11-03 flar@google.com [Impeller] Remove Rect field accesses from aiks subdirectory (flutter/engine#47628) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from ho9FqsUD0hxh to 8tJt8KJzTzbw fuchsia/sdk/core/mac-amd64 from y-hqwYkPPVT6 to 5GLArzquQ4eL If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Chris Bobbe authored
As discussed at https://github.com/flutter/flutter/pull/133007#issuecomment-1743916183, this is a docs change meant to help people in the absence of a fix for #133006, which is being closed as WONTFIX.
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/f363a6e5e093...677040f10f65 2023-11-03 skia-flutter-autoroll@skia.org Roll Skia from ee6dbb4e2592 to c0ca9f2fd828 (1 revision) (flutter/engine#47660) 2023-11-03 zanderso@users.noreply.github.com Move //third_party/benchmark to //flutter/third_party/benchmark (flutter/engine#47652) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
auto-submit[bot] authored
Reverts flutter/flutter#137191 Initiated by: camsim99 This change reverts the following previous change: Original Description: Adds support for Android 34 in the following ways: - Bumps integration tests compile SDK versions 33 --> 34 - Bumps template compile SDK version 33 --> 34 - Also changes deprecated `compileSdkVersion` to `compileSdk` Part of https://github.com/flutter/flutter/issues/134220
-
Kostia Sokolovskyi authored
-
Kostia Sokolovskyi authored
-