Commits · c0778318f9c9ec4f470cd268d1c3974d3f3f7348 · abdullh.alsoleman / Front-End

15 Feb, 2024 3 commits

Roll Packages from a8642544730a to ef349bec8ee9 (9 revisions) (#143521) · c0778318

engine-flutter-autoroll authored Feb 15, 2024

https://github.com/flutter/packages/compare/a8642544730a...ef349bec8ee9

2024-02-15 stuartmorgan@google.com [url_launcher] Replace deprecated RouteInformation APIs (flutter/packages#6127)
2024-02-15 stuartmorgan@google.com [rfw] Replace deprecated `textScaleFactor` (flutter/packages#6130)
2024-02-15 stuartmorgan@google.com [flutter_adaptive_scaffold] Replace deprecated APIs (flutter/packages#6129)
2024-02-14 engine-flutter-autoroll@skia.org Roll Flutter from eb5d0a43 to a628814e (72 revisions) (flutter/packages#6118)
2024-02-14 stuartmorgan@google.com [flutter_migrate] Replace deprecated APIs (flutter/packages#6128)
2024-02-14 stuartmorgan@google.com [flutter_image] Replace deprecated APIs (flutter/packages#6126)
2024-02-14 stuartmorgan@google.com [tools] Ignore analysis options files in .symlinks (flutter/packages#6119)
2024-02-14 stuartmorgan@google.com [various] Clean up `deprecated_member_use` ignores (flutter/packages#6123)
2024-02-14 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.24.0 to 3.24.1 (flutter/packages#6121)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

c0778318

Modify `plugin_ffi` and `package_ffi` template (#143376) · 97ab92ee

Hossein Yousefi authored Feb 15, 2024

* Use `dart run` instead of `flutter pub run` in the documentation as it is now deprecated.
* Use `int64_t` instead of `intptr_t` for `sum` examples.

97ab92ee

Remove certs installation from win_arm builds. (#143487) · dde76f49

godofredoc authored Feb 15, 2024

The certs dependency was added in 2020 as a workaround for missing certificates in win 10 images. These dependency is not required for windows arm64 builds because they are running on win 11.

dde76f49

14 Feb, 2024 22 commits

Reverts "[a11y] Add isEnabled semantics flag to text field (#143334)" (#143494) · 0fac13b4

auto-submit[bot] authored Feb 14, 2024

Reverts flutter/flutter#143334

Initiated by: hangyujin

Reason for reverting: broke g3 tests

Original PR Author: hangyujin

Reviewed By: {LongCatIsLooong}

This change reverts the following previous change:
Original Description:
Add a semantics flag to   text field to fix https://github.com/flutter/flutter/issues/143337 (in IOS the disabled text field is not read `dimmed`)

internal: b/322345393

0fac13b4

Reverts "[a11y] Fix date picker cannot focus on the edit field (#143117)" (#143493) · eae0c6a3

auto-submit[bot] authored Feb 14, 2024

Reverts flutter/flutter#143117

Initiated by: dnfield

Reason for reverting: made the tree red.

Original PR Author: hangyujin

Reviewed By: {QuncCccccc}

This change reverts the following previous change:
Original Description:
fixes: https://github.com/flutter/flutter/issues/143116
fixes: https://github.com/flutter/flutter/issues/141992

https://b.corp.google.com/issues/322173632

eae0c6a3

[a11y] Fix date picker cannot focus on the edit field (#143117) · 846719ec

hangyu authored Feb 14, 2024

fixes: [DatePicker edit field](https://github.com/flutter/flutter/issues/143116) 

https://b.corp.google.com/issues/322173632

846719ec

cleanup now-irrelevant ignores for `deprecated_member_use` (#143403) · 3f09b233
Michael Goderbauer authored Feb 14, 2024
```
Follow-up to https://github.com/flutter/flutter/pull/143347.
```
3f09b233

Fix and test SemanticsController.simulatedAccessibilityTraversal (#143386) · f190d625

Kate Lovett authored Feb 14, 2024

Fixes https://github.com/flutter/flutter/issues/143173

The `start` and `end` parameters of `SemanticsController.simulatedAccessibilityTraversal` were deprecated in https://github.com/flutter/flutter/issues/112413, but no tests were added that verified the new API. ð³

This change
- fixes a typo in an error message
- fixes the new `startNode` and `endNode` not being accounted for in setting the traversal range
- adds dart fixes for the deprecations
- adds tests for the new API that is meant to replace the deprecated one.
  - Filed https://github.com/flutter/flutter/issues/143405 to follow up on the new API not working in multiple views.

f190d625

Disable deprecation warnings for mega_gallery (#143466) · 1b8b430e

Michael Goderbauer authored Feb 14, 2024

Follow-up to https://github.com/flutter/flutter/pull/143347.

As https://github.com/flutter/flutter/pull/143403 uncovered, deprecation warnings were still enabled for the mega_gallery because it doesn't use the analysis_options.yaml file from the flutter root. This change injects a analysis_options.yaml file for the mega_gallery that disables those warnings.

Submitting this separately from https://github.com/flutter/flutter/pull/143403 in case it affects the mega_gallery benchmark to get a clean new baseline before removing all the `deprecated_member_use` ignores.

1b8b430e

The initial/selected item on popup menu should always be visible (#143118) · 9bc83932

Qun Cheng authored Feb 14, 2024

Fixes #142895

With the change of #143121, this PR is to add auto scroll to `PopupMenuButton` so when we open the menu, it will automatically scroll to the selected item.

https://github.com/flutter/flutter/assets/36861262/c2bc0395-0641-4e7a-a54d-57a8e62ee26f

9bc83932

Roll native_assets_builder to 0.5.0 (#143472) · db83bc6e

Daco Harkes authored Feb 14, 2024

Roll of https://github.com/dart-lang/native/pull/964, which separates the `KernelAsset`s (the asset information embedded in the Dart kernel snapshot) from `Asset`s (the assets in the `build.dart` protocol). See the linked issue for why they ought to be different instead of shared.

This PR does not change any functionality in Flutter.

(Now that https://github.com/flutter/flutter/pull/143055 has landed, we can land breaking changes.)

For reference, the same roll in the Dart SDK: https://dart-review.googlesource.com/c/sdk/+/352642

db83bc6e

InputDecorator M3 test migration step2 (#143369) · 5b005e47

Bruno Leroux authored Feb 14, 2024

## Description

This PR is the second step for the M3 test migration for `InputDecorator` (step 1 was https://github.com/flutter/flutter/pull/142981).

This PR migrate the two first tests of the M2 section. Those were big tests. I splitted them in several testsn organized in groups, and I narrowed their scope when possible.

@justinmc  I did not move yet the M2 tests to a separate file (I move them to a group) because it would mean we loss the line history which is useful during the migration. In the next step, I will focus on moving out some tests that are in the 'Material2' group (the ones that are ok with both M2 and M3).

## Related Issue

Related to https://github.com/flutter/flutter/issues/139076

## Tests

Adds several tests for M3.

5b005e47

Add more documentation for TextEditingController default constructor (#143452) · 5c88fbf0

Bruno Leroux authored Feb 14, 2024

## Description

This PR adds more documentation for `TextEditingController(String text)` constructor and it adds one example.

https://github.com/flutter/flutter/pull/96245 was a first improvement to the documentation.
https://github.com/flutter/flutter/issues/79495 tried to hide the cursor when an invalid selection is set but it was reverted.
https://github.com/flutter/flutter/pull/123777 mitigated the issue of having a default invalid selection: it takes care of setting a proper selection when a text field is focused and its controller selection is not initialized.

I will try changing the initial selection in another PR, but It will probably break several existing tests.

## Related Issue

Fixes https://github.com/flutter/flutter/issues/95978

## Tests

Adds 1 test for the new example.

5c88fbf0

Format all kotlin according to ktlint (#143390) · c61dc2a5

Gray Mackall authored Feb 14, 2024

Entire pr generated with [ktlint](https://github.com/pinterest/ktlint) --format. First step before enabling linting as part of presubmit for kotlin changes.

c61dc2a5

Marks Linux_pixel_7pro integration_ui_keyboard_resize to be unflaky (#143440) · dc1f9f18

Flutter GitHub Bot authored Feb 14, 2024

<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Linux_pixel_7pro integration_ui_keyboard_resize"
}
-->
The issue https://github.com/flutter/flutter/issues/140645 has been closed, and the test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Linux_pixel_7pro%20integration_ui_keyboard_resize%22).
This test can be marked as unflaky.

dc1f9f18

Roll Packages from 9385bbb3cf46 to a8642544730a (6 revisions) (#143454) · ee638480

engine-flutter-autoroll authored Feb 14, 2024

https://github.com/flutter/packages/compare/9385bbb3cf46...a8642544730a

2024-02-14 matanlurey@users.noreply.github.com Allow deprecated members from the Dart SDK/Flutter Framework to roll in (flutter/packages#6111)
2024-02-14 43054281+camsim99@users.noreply.github.com [google_maps_flutter][iOS 12] Skip `testTakeSnapshot` (flutter/packages#6120)
2024-02-13 stuartmorgan@google.com [ci] Allow dependencies on local_auth_ios (flutter/packages#6116)
2024-02-13 40719830+Alex-Usmanov@users.noreply.github.com [url_launcher] Add `InAppBrowserConfiguration` parameter in implementations (flutter/packages#5759)
2024-02-13 16229121+leiatfly@users.noreply.github.com [flutter_markdown] Use Text.rich to replace RichText in Flutter Markdown (flutter/packages#6062)
2024-02-13 97943118+GavrielRosendorn74@users.noreply.github.com [google_maps_flutter][iOS 17] takeSnapshot FIX (flutter/packages#5823)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

ee638480

[tools] Add column header for emulators information (#142853) · ca03beda

Anas authored Feb 14, 2024

Add column information as table header for `flutter emulators` command.

**Before:**

```
2 available emulators:

Pixel_3_API_30   â¢ Pixel 3 API 30   â¢ Google â¢ android
Resizable_API_33 â¢ Resizable API 33 â¢ Google â¢ android

To run an emulator, run 'flutter emulators --launch <emulator id>'.
To create a new emulator, run 'flutter emulators --create [--name xyz]'.

You can find more information on managing emulators at the links below:
  https://developer.android.com/studio/run/managing-avds
  https://developer.android.com/studio/command-line/avdmanager
```

**After:**

```
2 available emulators:

Id               â¢ Name             â¢ Manufacturer â¢ Platform

Pixel_3_API_30   â¢ Pixel 3 API 30   â¢ Google       â¢ android
Resizable_API_33 â¢ Resizable API 33 â¢ Google       â¢ android

To run an emulator, run 'flutter emulators --launch <emulator id>'.
To create a new emulator, run 'flutter emulators --create [--name xyz]'.

You can find more information on managing emulators at the links below:
  https://developer.android.com/studio/run/managing-avds
  https://developer.android.com/studio/command-line/avdmanager
```

fixes #140656

ca03beda

Use `dart compile wasm` for wasm compilations (#143298) · abadf9ff

Martin Kustermann authored Feb 14, 2024

* Flags to `dart compile wasm`

Some options are not relevant to a standalone user of `dart compile
wasm` (e.g. specyfing dart-sdk, platform file etc). => Those aren't
offered by the `dart compile wasm` tool directly. => We use the
`--extra-compiler-option=` instead which passes through arbitrary
options to the dart2wasm compiler. => We don't maintain compatibility of
those options, if we update them we'll ensure to also update flutter
tools

* Binaryen optimization passes

This change will mean we use the binaryen flags from Dart SDK which are
slightly different from the ones in flutter.

* Optimization configuration

This change will also start using the more standardized `-O` flag for
determining optimization levels. The meaning of those flags have been
mostly aligned with dart2js (with some differences remaining).

* Minimization

Using the new optimization flags, namely `-O4` for `--wasm-opt=full`,
will automatically enable the new `--minify` support. Minification is
Dart semantics preserving but changes the `<obj>.runtimeType.toString()`
to use minified names (just as in dart2js).

* Code size changes

  Overall this change will reduce wonderous code size by around 10%.

Issue https://github.com/dart-lang/sdk/issues/54675

abadf9ff

[devicelab] retain first frame data in certain integration tests. (#143419) · 295eeaf1

Jonah Williams authored Feb 14, 2024

Part of https://github.com/flutter/flutter/issues/143404

We currently drop the first N frames of all benchmarks. For the app based benchmarks (not microbenchmarks) this is harmful as we miss first time initialization costs in our CI.

Still need to do this with flutter/gallery, but that lives in a different repo.

295eeaf1

Roll Flutter Engine from 0849250a1419 to 3af336bfb2df (2 revisions) (#143427) · e2567f49

engine-flutter-autoroll authored Feb 14, 2024

https://github.com/flutter/engine/compare/0849250a1419...3af336bfb2df

2024-02-14 jason-simmons@users.noreply.github.com In run_tests, use the regular path to the Vulkan library if lib.unstripped does not exist (flutter/engine#50629)
2024-02-14 skia-flutter-autoroll@skia.org Roll Dart SDK from a8303c0bf1b4 to 032323fa534b (1 revision) (flutter/engine#50631)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

e2567f49

Roll Flutter Engine from 215d55f4f82d to 0849250a1419 (2 revisions) (#143425) · 7e69720b

engine-flutter-autoroll authored Feb 14, 2024

https://github.com/flutter/engine/compare/215d55f4f82d...0849250a1419

2024-02-14 30870216+gaaclarke@users.noreply.github.com [Impeller] replaces golden file count with a golden diff file (flutter/engine#50621)
2024-02-14 bdero@google.com [Impeller] Migrate all ColorSourceContents to use a shared rendering routine. (flutter/engine#50261)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

7e69720b

Roll Flutter Engine from c0607a0313a3 to 215d55f4f82d (2 revisions) (#143422) · b8ce11e7

engine-flutter-autoroll authored Feb 14, 2024

https://github.com/flutter/engine/compare/c0607a0313a3...215d55f4f82d

2024-02-14 matanlurey@users.noreply.github.com Run Skia and Impeller OpenGLES on APIv28. (flutter/engine#50583)
2024-02-14 34871572+gmackall@users.noreply.github.com Make Android Studio depend on the android_embedding_dependencies (flutter/engine#50612)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

b8ce11e7

Roll Flutter Engine from abb51c48e261 to c0607a0313a3 (2 revisions) (#143417) · 79cab0e9

engine-flutter-autoroll authored Feb 14, 2024

https://github.com/flutter/engine/compare/abb51c48e261...c0607a0313a3

2024-02-14 31859944+LongCatIsLooong@users.noreply.github.com Temporarily change canvaskit kitchensink test to unblock the skia roll (flutter/engine#50617)
2024-02-13 flar@google.com [Impeller] add benchmarks for the stroke geometry entity code (flutter/engine#50616)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

79cab0e9

Roll Flutter Engine from 9b183870ff6c to abb51c48e261 (3 revisions) (#143411) · 14657bd0

engine-flutter-autoroll authored Feb 14, 2024

https://github.com/flutter/engine/compare/9b183870ff6c...abb51c48e261

2024-02-13 737941+loic-sharma@users.noreply.github.com [Windows] Refactor window destroyed app lifecycle event (flutter/engine#50565)
2024-02-13 jonahwilliams@google.com [Impeller] fix cmd buffer recycling bug in test. (flutter/engine#50615)
2024-02-13 skia-flutter-autoroll@skia.org Roll Dart SDK from 04caefbfa60f to a8303c0bf1b4 (1 revision) (flutter/engine#50614)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

14657bd0

Fix `AssetsEntry::equals` (#143355) · 14bcc694

Andrew Kolos authored Feb 14, 2024

In service of https://github.com/flutter/flutter/issues/143348.

**Issue.** The `equals` implementation of `AssetsEntry` is incorrect. It compares `flavors` lists using reference equality. This PR addresses this.

This also adds a test to make sure valid asset `flavors` declarations are parsed correctly.

While we are here, this PR also includes a couple of refactorings:
  * `flutter_manifest_test.dart` is a bit large. To better match our style guide, I've factored out some related tests into their own file.
  *  A couple of changes to the `_validateListType` function in `flutter_manifest.dart`:
      * The function now returns a list of errors instead of accepting a list to append onto. This is more readable and also allows callers to know which errors were found by the call.
      * The function is renamed to `_validateList` and now accepts an `Object?` instead of an `YamlList`. If the argument is null, an appropriate error message is contained in the output. This saves callers that are only interested in validation from having to write their own null-check, which they all did before.
      * Some error strings were tweaked for increased readability and/or grammatical correctness.

14bcc694

13 Feb, 2024 15 commits

Roll Flutter Engine from 0091a4914dc6 to 9b183870ff6c (1 revision) (#143402) · 4280d295

engine-flutter-autoroll authored Feb 13, 2024

https://github.com/flutter/engine/compare/0091a4914dc6...9b183870ff6c

2024-02-13 30870216+gaaclarke@users.noreply.github.com [Impeller] Turn on golden tests that use the ImGui widgets functions (flutter/engine#50606)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

4280d295

Have `FocusManager` respond to app lifecycle state changes (#142930) · f01ce9f4

Nate authored Feb 13, 2024

fixes #87061

It doesn't matter whether I'm using Google Chrome, VS Code, Discord, or a Terminal window: any time a text cursor is blinking, it means that the characters I type will show up there.

And this isn't limited to text fields: if I repeatedly press `Tab` to navigate through a website, there's a visual indicator that goes away if I click away from the window, and it comes back if I click or `Alt+Tab` back into it.

<details open>
<summary>Example (Chrome):</summary>

![focus node](https://github.com/flutter/flutter/assets/10457200/bef42cd9-28e5-4214-b071-b7ef56b26609)

</details>

<details open>
<summary>This PR adds the same functionality to Flutter apps:</summary>

![Flutter demo](https://github.com/flutter/flutter/assets/10457200/6eb34c44-5fb0-4b27-aa10-6606a1eb187e)

</details>

f01ce9f4

Rename `external_ui` to `external_textures`. (#143406) · 56387c01

Matan Lurey authored Feb 13, 2024

My understanding is I can do this safely because the task is marked `bringup: true`?

Next PR will remove `bringup` and take down the old tasks.

Partial work towards https://github.com/flutter/flutter/issues/142178.

56387c01

Improve some scrollbar error messages (#143279) · b4270f7b
Loïc Sharma authored Feb 13, 2024
```
Adds some missing spaces, rewords some errors, and splits some errors into more lines.
```
b4270f7b

[a11y] Add isEnabled semantics flag to text field (#143334) · 14bce28f

hangyu authored Feb 13, 2024

Add a semantics flag to   text field to fix https://github.com/flutter/flutter/issues/143337 (in IOS the disabled text field is not read `dimmed`)

internal: b/322345393

14bce28f

Bump github/codeql-action from 3.24.0 to 3.24.1 (#143395) · 50256811

dependabot[bot] authored Feb 13, 2024

Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.24.0 to 3.24.1.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/github/codeql-action/blob/main/CHANGELOG.md">github/codeql-action's changelog</a>.</em></p>
<blockquote>
<h1>CodeQL Action Changelog</h1>
<p>See the <a href="https://github.com/github/codeql-action/releases">releases page</a> for the relevant changes to the CodeQL CLI and language packs.</p>
<p>Note that the only difference between <code>v2</code> and <code>v3</code> of the CodeQL Action is the node version they support, with <code>v3</code> running on node 20 while we continue to release <code>v2</code> to support running on node 16. For example <code>3.22.11</code> was the first <code>v3</code> release and is functionally identical to <code>2.22.11</code>. This approach ensures an easy way to track exactly which features are included in different versions, indicated by the minor and patch version numbers.</p>
<h2>[UNRELEASED]</h2>
<p>No user facing changes.</p>
<h2>3.24.1 - 13 Feb 2024</h2>
<ul>
<li>Update default CodeQL bundle version to 2.16.2. <a href="https://redirect.github.com/github/codeql-action/pull/2124">#2124</a></li>
<li>The CodeQL action no longer fails if it can't write to the telemetry api endpoint. <a href="https://redirect.github.com/github/codeql-action/pull/2121">#2121</a></li>
</ul>
<h2>3.24.0 - 02 Feb 2024</h2>
<ul>
<li>CodeQL Python analysis will no longer install dependencies on GitHub Enterprise Server, as is already the case for GitHub.com. See <a href="https://github.com/github/codeql-action/blob/main/#3230---08-jan-2024">release notes for 3.23.0</a> for more details. <a href="https://redirect.github.com/github/codeql-action/pull/2106">#2106</a></li>
</ul>
<h2>3.23.2 - 26 Jan 2024</h2>
<ul>
<li>On Linux, the maximum possible value for the <code>--threads</code> option now respects the CPU count as specified in <code>cgroup</code> files to more accurately reflect the number of available cores when running in containers. <a href="https://redirect.github.com/github/codeql-action/pull/2083">#2083</a></li>
<li>Update default CodeQL bundle version to 2.16.1. <a href="https://redirect.github.com/github/codeql-action/pull/2096">#2096</a></li>
</ul>
<h2>3.23.1 - 17 Jan 2024</h2>
<ul>
<li>Update default CodeQL bundle version to 2.16.0. <a href="https://redirect.github.com/github/codeql-action/pull/2073">#2073</a></li>
<li>Change the retention period for uploaded debug artifacts to 7 days. Previously, this was whatever the repository default was. <a href="https://redirect.github.com/github/codeql-action/pull/2079">#2079</a></li>
</ul>
<h2>3.23.0 - 08 Jan 2024</h2>
<ul>
<li>We are rolling out a feature in January 2024 that will disable Python dependency installation by default for all users. This improves the speed of analysis while having only a very minor impact on results. You can override this behavior by setting <code>CODEQL_ACTION_DISABLE_PYTHON_DEPENDENCY_INSTALLATION=false</code> in your workflow, however we plan to remove this ability in future versions of the CodeQL Action. <a href="https://redirect.github.com/github/codeql-action/pull/2031">#2031</a></li>
<li>The CodeQL Action now requires CodeQL version 2.11.6 or later. For more information, see <a href="https://github.com/github/codeql-action/blob/main/#2227---16-nov-2023">the corresponding changelog entry for CodeQL Action version 2.22.7</a>. <a href="https://redirect.github.com/github/codeql-action/pull/2009">#2009</a></li>
</ul>
<h2>3.22.12 - 22 Dec 2023</h2>
<ul>
<li>Update default CodeQL bundle version to 2.15.5. <a href="https://redirect.github.com/github/codeql-action/pull/2047">#2047</a></li>
</ul>
<h2>3.22.11 - 13 Dec 2023</h2>
<ul>
<li>[v3+ only] The CodeQL Action now runs on Node.js v20. <a href="https://redirect.github.com/github/codeql-action/pull/2006">#2006</a></li>
</ul>
<h2>2.22.10 - 12 Dec 2023</h2>
<ul>
<li>Update default CodeQL bundle version to 2.15.4. <a href="https://redirect.github.com/github/codeql-action/pull/2016">#2016</a></li>
</ul>
<h2>2.22.9 - 07 Dec 2023</h2>
<p>No user facing changes.</p>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/github/codeql-action/commit/e675ced7a7522a761fc9c8eb26682c8b27c42b2b"><code>e675ced</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2131">#2131</a> from github/update-v3.24.1-c79c360e0</li>
<li><a href="https://github.com/github/codeql-action/commit/41154da3e48398d8a02f386fd33e8b80195dc47b"><code>41154da</code></a> Update changelog for v3.24.1</li>
<li><a href="https://github.com/github/codeql-action/commit/c79c360e02b1d0dbe91a088f7cf6de2c9f8c85b9"><code>c79c360</code></a> Bump the npm group with 3 updates (<a href="https://redirect.github.com/github/codeql-action/issues/2128">#2128</a>)</li>
<li><a href="https://github.com/github/codeql-action/commit/4075abfb065d705660b25161b8db80d9181f0f9a"><code>4075abf</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2121">#2121</a> from jsoref/status-reports-are-not-critical</li>
<li><a href="https://github.com/github/codeql-action/commit/5a6da1d85da5ff27ffe21409b2f231452aca7f37"><code>5a6da1d</code></a> Treat status reports as non-critical</li>
<li><a href="https://github.com/github/codeql-action/commit/43a8916cbe785c7fa6b2bf8805fbcdaddda6093b"><code>43a8916</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2124">#2124</a> from github/update-bundle/codeql-bundle-v2.16.2</li>
<li><a href="https://github.com/github/codeql-action/commit/b0346e4adb1d5f99f3acdd0c0f8cf161f3df924b"><code>b0346e4</code></a> Merge branch 'main' into update-bundle/codeql-bundle-v2.16.2</li>
<li><a href="https://github.com/github/codeql-action/commit/3ab1d29793a7b28e33903fc553786c9ebdb816a3"><code>3ab1d29</code></a> Stop running debug artifacts checks on MacOS (<a href="https://redirect.github.com/github/codeql-action/issues/2123">#2123</a>)</li>
<li><a href="https://github.com/github/codeql-action/commit/9a734dafa18de81f414b2837120067625bf77c1d"><code>9a734da</code></a> Add changelog note</li>
<li><a href="https://github.com/github/codeql-action/commit/8fae32eb183816404b81b714c0dc84a12427cb26"><code>8fae32e</code></a> Update default bundle to codeql-bundle-v2.16.2</li>
<li>Additional commits viewable in <a href="https://github.com/github/codeql-action/compare/e8893c57a1f3a2b659b6b55564fdfdbbd2982911...e675ced7a7522a761fc9c8eb26682c8b27c42b2b">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=github/codeql-action&package-manager=github_actions&previous-version=3.24.0&new-version=3.24.1)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

50256811

Roll Flutter Engine from 8742f1c61a4c to 0091a4914dc6 (7 revisions) (#143393) · 96b0a6b2

engine-flutter-autoroll authored Feb 13, 2024

https://github.com/flutter/engine/compare/8742f1c61a4c...0091a4914dc6

2024-02-13 jonahwilliams@google.com [Impeller] remove denylist entry. (flutter/engine#50605)
2024-02-13 zanderso@users.noreply.github.com [engine_build_configs] Use dart:ffi Abi to determine the host cpu (flutter/engine#50604)
2024-02-13 jason-simmons@users.noreply.github.com Update embedder support for Impeller/OpenGL to load some missing shaders and configure a depth attachment (flutter/engine#50416)
2024-02-13 skia-flutter-autoroll@skia.org Roll Skia from 30bba7419898 to f7e3a5395fe1 (1 revision) (flutter/engine#50603)
2024-02-13 30870216+gaaclarke@users.noreply.github.com [Impeller] replaced playground macros with functions (flutter/engine#50602)
2024-02-13 matanlurey@users.noreply.github.com Allow deprecated members from the Dart SDK to roll in. (flutter/engine#50575)
2024-02-13 68449066+zijiehe-google-com@users.noreply.github.com [Fuchsia] Run tests with test arguments (flutter/engine#50478)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

96b0a6b2

Introduce `avatarBoxConstraints` & `deleteIconBoxConstraints` for the chips (#143302) · ccf42dde

Taha Tesser authored Feb 13, 2024

fixes [Chip widget's avatar padding changing if label text is more than 1 line](https://github.com/flutter/flutter/issues/136892)

### Code sample

<details>
<summary>expand to view the code sample</summary> 

```dart
import 'package:flutter/material.dart';

List<String> strings = [
  'hello good morning',
  'hello good morning hello good morning',
  'hello good morning hello good morning hello good morning'
];

void main() => runApp(const MyApp());

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      debugShowCheckedModeBanner: false,
      home: Scaffold(
        body: Center(
          child: Row(
            mainAxisAlignment: MainAxisAlignment.spaceEvenly,
            children: [
              Column(
                mainAxisSize: MainAxisSize.min,
                crossAxisAlignment: CrossAxisAlignment.center,
                children: [
                  const Text(
                      'avatarBoxConstraints: null \ndeleteIconBoxConstraints: null',
                      textAlign: TextAlign.center),
                  for (String string in strings)
                    Padding(
                      padding: const EdgeInsets.all(8.0),
                      child: RawChip(
                        label: Container(
                          width: 150,
                          color: Colors.amber,
                          child: Text(
                            string,
                            maxLines: 3,
                            overflow: TextOverflow.ellipsis,
                          ),
                        ),
                        avatar: const Icon(Icons.settings),
                        onDeleted: () {},
                      ),
                    ),
                ],
              ),
              Column(
                mainAxisSize: MainAxisSize.min,
                crossAxisAlignment: CrossAxisAlignment.center,
                children: [
                  const Text(
                      'avatarBoxConstraints: BoxConstraints.tightForFinite() \ndeleteIconBoxConstraints: BoxConstraints.tightForFinite()',
                      textAlign: TextAlign.center),
                  for (String string in strings)
                    Padding(
                      padding: const EdgeInsets.all(8.0),
                      child: RawChip(
                        avatarBoxConstraints:
                            const BoxConstraints.tightForFinite(),
                        deleteIconBoxConstraints:
                            const BoxConstraints.tightForFinite(),
                        label: Container(
                          width: 150,
                          color: Colors.amber,
                          child: Text(
                            string,
                            maxLines: 3,
                            overflow: TextOverflow.ellipsis,
                          ),
                        ),
                        avatar: const Icon(Icons.settings),
                        onDeleted: () {},
                      ),
                    ),
                ],
              ),
            ],
          ),
        ),
      ),
    );
  }
}

```

</details>

### Preview
![Screenshot 2024-02-12 at 14 58 35](https://github.com/flutter/flutter/assets/48603081/5724bd07-7ac7-4987-b992-fa3ab8488273)

# Example previews
![Screenshot 2024-02-12 at 22 15 14](https://github.com/flutter/flutter/assets/48603081/33af472d-3561-47d4-8d0d-e1628de1e0aa)
![Screenshot 2024-02-12 at 22 15 46](https://github.com/flutter/flutter/assets/48603081/3de78b59-5cb6-4fd8-879b-8e204aacb069)

ccf42dde

Update dependencies in integration test (#143111) · a8e9f209

Reid Baker authored Feb 13, 2024

Update dependencies to latest versions
Related to #142618 
Fixes #143219

- [ x I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].

a8e9f209

Dual compile reland (#143262) · 5a9fa1e7

Jackson Gardner authored Feb 13, 2024

This is an attempt at a reland of https://github.com/flutter/flutter/pull/141396

The main changes here that are different than the original PR is fixes to wire up the `flutter test` command properly with the web renderer.

5a9fa1e7

Roll Flutter Engine from 920874bf2c1a to 8742f1c61a4c (2 revisions) (#143385) · 4f1fc5a8

engine-flutter-autoroll authored Feb 13, 2024

https://github.com/flutter/engine/compare/920874bf2c1a...8742f1c61a4c

2024-02-13 skia-flutter-autoroll@skia.org Roll Dart SDK from 105312b80125 to 04caefbfa60f (1 revision) (flutter/engine#50600)
2024-02-13 skia-flutter-autoroll@skia.org Roll Skia from aaed347b2dbb to 30bba7419898 (7 revisions) (flutter/engine#50599)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

4f1fc5a8

refactor: remove implicit globals dependencies in `writeBundle` (#143343) · e8a75aa0

Andrew Kolos authored Feb 13, 2024

This is in service of https://github.com/flutter/flutter/pull/141194

This will make it easier to get the `flutter run -d <browser>` and `flutter build fuschia` cases easier to get under test.

e8a75aa0

Remove message about `pub cache` that is not actionable (#143357) · 66367dd8

Matan Lurey authored Feb 13, 2024

... and neither the pub nor tools team think it's important.

Fixes https://github.com/flutter/flutter/issues/140628.

66367dd8

Fix chips constructor docs for callbacks (#143361) · 2adbc2b8

Taha Tesser authored Feb 13, 2024

fixes [ActionChip constructor documentation does not match class documentation](https://github.com/flutter/flutter/issues/137964)

2adbc2b8

Implementing `switch` expressions in `widgets/` (#143293) · 8eea4f17

Nate authored Feb 13, 2024

This PR is the 7áµÊ° step in the journey to solve issue #136139 and make the entire Flutter repo more readable.

(previous pull requests: #139048, #139882, #141591, #142279, #142634, #142793)

This pull request covers everything in `packages/flutter/lib/src/widgets/`. Most of it should be really straightforward, but there was some refactoring in the `getOffsetToReveal()` function in `two_dimensional_viewport.dart`. I'll add some comments to describe those changes.

8eea4f17