1. 24 Feb, 2016 1 commit
    • Adam Barth's avatar
      Improve TextSpan · fb4dbf45
      Adam Barth authored
      Now we just have one TextSpan class that handles both simple strings, trees of
      children, and styling both. This approach simplifies the interface for most
      clients.
      
      This patch also removes StyledText, which was weakly typed and tricky to use
      correctly. The replacement is RichText, which is strongly typed and uses
      TextSpan.
      fb4dbf45
  2. 18 Jan, 2016 1 commit
    • Ian Hickson's avatar
      Fix some intrinsic constraints contract violations. · 60d9ab7e
      Ian Hickson authored
      RenderBlock wasn't constraining the results.
      RenderPadding wasn't constraining the results (which matters
      especially when the constraints can't fit the padding in the first
      place).
      RenderViewport wasn't constraining the results.
      
      Add a test for the block case.
      
      To catch this kind of thing in the future, add some asserts to
      debugDoesMeetConstraints() that all four intrinsic functions return
      values that are within the constraints.
      
      RenderBlockViewport doesn't support returning intrinsics, so turn off
      the "no intrinsic support" asserts (and return zero) when we're doing
      this new assert.
      
      This new assert screwed up the custom layout classes' tests, so adjust
      those tests to ignore the callbacks invoked from these asserts.
      
      Add to the _debugReportException() method a short summary of the
      descendants of this node. It's important to have this information when
      debugging errors like these intrinsic constraints contract violations
      because often nodes just pass the values through to their child so you
      have to go several steps down to find the actual problem.
      
      Fixes https://github.com/flutter/flutter/issues/1210
      60d9ab7e
  3. 02 Jan, 2016 1 commit
    • Adam Barth's avatar
      ScrollbarPainter exception when scrolling MaterialList · 94843700
      Adam Barth authored
      When assigning a new overlayPainter, we were detaching the old overlay
      painter even if the render object itself wasn't attached. Now we only
      twiddle the attach/detach state of the overlay painter when we're
      attached ourselves.
      
      Fixes #1047
      94843700