- 30 May, 2019 1 commit
-
-
Jonah Williams authored
-
- 23 May, 2019 1 commit
-
-
Todd Volkert authored
I forgot to add `onChunk` to them in #33092
-
- 21 May, 2019 2 commits
-
-
Todd Volkert authored
This is another step towards supporting image loading progress notification at the widgets layer. This adds an `ImageChunkEvent` class along with associated `ImageChunkListener` callback signature and an `onChunk` property to `ImageStreamListener`. The events serve to notify registered listeners when byte chunks are received while loading an image. https://github.com/flutter/flutter/issues/32374
-
Todd Volkert authored
The current API was broken in that you registered multiple callbacks at once, but when you removed listeners, only the primary listener was used to determine what was removed. This led to unintuitive cases where the caller could get unexpected behavior. This updates the API to add and remove listeners using a newly introduced [ImageStreamListener] object, a value object that has references to the individual callbacks that may fire. flutter/flutter#24722 flutter/flutter#32374 flutter/flutter#32935
-
- 16 May, 2019 1 commit
-
-
Alexandre Ardhuin authored
* use null aware operators * rollback changes about null-aware operator * disable lint prefer_is_not_empty
-
- 01 May, 2019 1 commit
-
-
Jacob Richman authored
Make FlutterError objects more structured so they can be displayed better in debugging tools such as Dart DevTools.
-
- 02 Apr, 2019 1 commit
-
-
Amir Hardon authored
There were 2 possible scenarios in which _handleAppFrame is added more than once as a frame callback. When this happens it is possible that the second invocation will try to access _nextFrame.image when _nextFrame is null and crash. The 2 scenarios are: Scenario 1 A GIF frame is decoded and a Flutter frame is executed before it's time to show the next GIF frame. The timer that's waiting for enough time to elapse is invoked, and schedules a callback for the next Flutter frame(here). Before the next Flutter frame is executed, MultiFrameImageStreamCompleter#removeListener is called followed by ``MultiFrameImageStreamCompleter#addListenerthat is invoking_decodeNextFrameAndSchedule` which is adding `_handleAppFrame` again as a next frame callback. Scenario 2 removeListener and addListener are called multiple times in succession, every call to addListener can result in another registration of _handleAppFrame to the next Flutter frame callbacks list. This patch fixes the issue by guarding against a second registration of _handleAppFrame.
-
- 01 Mar, 2019 1 commit
-
-
Alexandre Ardhuin authored
* add trailing commas on list/map/parameters * add trailing commas on Invocation with nb of arg>1 * add commas for widget containing widgets * add trailing commas if instantiation contains trailing comma * revert bad change
-
- 28 Feb, 2019 1 commit
-
-
Greg Spencer authored
Fix the spelling errors in the dartdocs for the framework. There are no functionality changes here, just documentation fixes.
-
- 31 Jan, 2019 1 commit
-
-
Ian Hickson authored
* Remove stray extra space * Add ImageStreamCompleter.hasListeners (and cleanup) This is mostly just some cleanup of stuff I ran into, but it makes `hasListeners` protected on `ImageStreamCompleter`, because otherwise there's no way to track if listeners are registered or not. * Address review comments
-
- 29 Jan, 2019 1 commit
-
-
Alexandre Ardhuin authored
-
- 04 Jan, 2019 1 commit
-
-
xster authored
-
- 16 Oct, 2018 1 commit
-
-
Alexandre Ardhuin authored
* Future<void> main * Future<void>.delayed * prefer_void_to_Null * address review comments
-
- 14 Sep, 2018 1 commit
-
-
Alexandre Ardhuin authored
-
- 12 Sep, 2018 1 commit
-
-
Alexandre Ardhuin authored
* enable lint unnecessary_new * fix tests * fix tests * fix tests
-
- 15 Aug, 2018 1 commit
-
-
xster authored
-
- 31 Jul, 2018 1 commit
-
-
xster authored
-
- 13 Jun, 2018 1 commit
-
-
Chris Bracken authored
fuchsia_tester.dart still assumes Dart 1. Previously, it ran tests directly from source, flutter_platform.dart automatically runs a kernel compile when operating in Dart 2 mode, but this assumes a functional Dart SDK is available in the artifacts directly, and fuchsia_tester.dart mocks out the artifacts directory with an empty temp dir. Remaining work is: 1. Get the frontend server building as a dependency on Fuchsia. 2. Patch fuchsia_tester.dart to use a valid Dart SDK and frontend server. This also reverts migration to Dart 2 typedef syntax. This reverts commit 6c56bb24. (#18362) This reverts commit 3daebd05. (#18316)
-
- 11 Jun, 2018 1 commit
-
-
Greg Spencer authored
Now that Dart 1 is turned off, reapplying my change to turn on the prefer_generic_function_type_aliases analysis option, and fix all the typedefs to Dart 2 preferred syntax. Also eliminated the unused analysis_options_repo.yaml file and turned on public_member_api_docs in analysys_options.yaml. No logic changes, just changing the typedef syntax for all typedefs, and updating analysis options.
-
- 05 Jun, 2018 1 commit
-
-
Alexandre Ardhuin authored
-
- 30 May, 2018 2 commits
-
-
Greg Spencer authored
Revert "Update typedef syntax to use Function notation and turn on lint for old notation. (#18035)" (#18041) This reverts commit 32586020.
-
Greg Spencer authored
Fixes #18028 Just changes typedef declarations, no logic changes.
-
- 24 Jan, 2018 1 commit
-
-
Vyacheslav Egorov authored
-
- 10 Jan, 2018 1 commit
-
-
Ian Hickson authored
Fixes https://github.com/flutter/flutter/issues/12553 The root cause of https://github.com/flutter/flutter/issues/12553 was that when the refresh indicator went away, which happened after the avatars had started their image loads but before the avatars had loaded, the DecoratedBoxes, along with the rest of the list, got GlobalKey-reparented, which caused the RenderDecoratedBox objects to unregister from the DecorationImagePainters, but they never re-registered since the whole subtree was in a RepaintBoundary and was therefore not explicitly repainted when the tree got reattached. This fixes the bug by explicitly requiring any RenderDecoratedBox to repaint when it's reattached. This is probably a little more aggressive than required; we could probably expose a flag on Decoration that says whether or not the onChanged handler will ever be invoked, and only call markNeedsPaint if that's true, but we'll do that if it turns out that there's a performance issue here. (This patch also introduces a bunch of improved debugging information that I used to track down the bug.)
-
- 07 Dec, 2017 1 commit
-
-
Ian Hickson authored
This allows the scheduler library to depend on the services library and the painting library to depend on the scheduler library without the services library having to depend on the scheduler library. While I was at it I also cleaned up some of the binding logic: the licenses logic can now be overridden (and the test library does so), and the image cache can now be overridden as well.
-
- 22 Nov, 2017 1 commit
-
-
amirh authored
This is a bug in my previous CL: instead of cancelling the timer if there are no more listeners, I canceled it if there were listeners (I can claim I just missed a not :) ). Not cancelling the timer when removing the last listener was not that bad, as the timer callback is guarded by a check to see if there are listeners. So the animation will not continue. But in the case there were multiple listeners on the same stream, and one of them is removed, this bug will stop the animation for all other listeners. I added a test case for this scenario.
-
- 17 Nov, 2017 2 commits
- 16 Nov, 2017 2 commits
-
-
amirh authored
-
Ian Hickson authored
Previously, ExpansionPanel would do weird things if interacted with when it was already animating. This is fixed and there's now a test. Also: * Minor fixes to make the gallery work in RTL, not that there's any way to see that without hard-coding the framework to RTL. But at least I'll be less annoyed when doing that. * Some trivial code and documentation cleanup.
-
- 10 Nov, 2017 1 commit
-
-
amirh authored
* Implement MultiFrameImageStreamCompleter * only decode frames while there are active listeners * review comments followup * multiply animation frame timer duration by time dilation * lint
-
- 28 Sep, 2017 1 commit
-
-
Ian Hickson authored
-
- 12 Sep, 2017 1 commit
-
-
Jacob Richman authored
Diagnostics object is.
-
- 03 Aug, 2017 1 commit
-
-
Jacob Richman authored
Add Diagnosticable base class and documentation
-
- 28 Jul, 2017 1 commit
-
-
Ian Hickson authored
-
- 23 Jun, 2017 1 commit
-
-
Ian Hickson authored
...and make one of the comments accurate by fixing the code. Turns out I forgot to add the 'silent' argument when I changed that comment.
-
- 06 Jun, 2017 1 commit
-
-
Ian Hickson authored
-
- 05 Jun, 2017 1 commit
-
-
Alexandre Ardhuin authored
-
- 10 May, 2017 1 commit
-
-
Chris Bracken authored
Also includes minor doc fixes.
-
- 06 May, 2017 1 commit
-
-
Ian Hickson authored
-