- 15 Mar, 2015 1 commit
-
-
Rafael Weinstein authored
This patch removes the mutable API to event handling (Nodes no longer have a events object with which to add listeners). Instead, a new (non-Render) Node is introduced: EventTarget. This node represents a location in the Effen tree which can handle events as they bubble. Note that this also changes the implementation to use event delegation (one set of listeners at the sky.document level) rather than direct listeners on leaf nodes. R=abarth@chromium.org Review URL: https://codereview.chromium.org/1019633004
-
- 18 Mar, 2015 5 commits
-
-
Adam Barth authored
We're now doing all of the elements of the popup menu entrance animation from the material design spec, but our timing and curves might not be exactly right yet. I haven't started on the exit animation. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/1017193004
-
Eric Seidel authored
R=abarth@chromium.org Review URL: https://codereview.chromium.org/1022613002
-
Eric Seidel authored
Before this change Sky would hit 404s when trying to load examples from domokit.github.io. I also added a separate sky_home and updated the default url to point to sky_home instead of home. R=abarth@chromium.org Review URL: https://codereview.chromium.org/1016143002
-
Adam Barth authored
This CL also refactors how animations work, particularly for the Drawer. I've renamed DrawerAnimation to DrawerController and switched it from being an Animation to having an Animation. I've also renamed Animation to AnimatedValue to capture the idea that the class actually presents the value being animated. Finally, I've factored AnimatedValueListener out of Drawer so that it can be used by PopupMenuItem as well. Finally, I've added a scheduleBuild convienence function to Component instead of having to call setState(() {}), which has come up a couple times. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/1016093002
-
Adam Barth authored
We should probably move this menu into a view for an individual stock, but for now add it to the main stock screen. R=ojan@chromium.org, eseidel@chromium.org Review URL: https://codereview.chromium.org/1008003007
-
- 17 Mar, 2015 6 commits
-
-
Adam Barth authored
1) Add a pubspec.yaml. 2) Move all the code into a 'lib' directory. 3) Move the stock widgets out of the app's library. TBR=eseidel@chromium.org Review URL: https://codereview.chromium.org/1011023003
-
Viet-Trung Luu authored
Ditto for terminal_client.mojom, previously in examples/echo_terminal. Fix the sky terminal example. R=erg@chromium.org Review URL: https://codereview.chromium.org/1013313002
-
Adam Barth authored
Currently this widget is demoed in widgets-fn, but I'll move it into stocks-fn soon. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/1017873002
-
Eric Seidel authored
The packages produced from this CL were deployed as v0.0.1: https://pub.dartlang.org/packages/sky https://pub.dartlang.org/packages/mojo There is still no tool included with the sky package due to pub's inability to run anything other than Dart: https://code.google.com/p/dart/issues/detail?id=22877 I'm likely just going to write a dart version of my "sky" script. :( R=ojan@chromium.org, abarth@chromium.org Review URL: https://codereview.chromium.org/1015833002
-
Adam Barth authored
This CL is a warmup for using a more sophisticated gesture disambiguation. 1) Use gesturetap instead of click. We should probably remove click events because folks should use gesturetap to integrate with the gesture system. 2) Handle the case where you swipe the drawer during an animation. Previously we had an assert which triggered in some multitouch scenarios. We'll eventually move this over to gestureswipe. 3) Remove an extra container for ink splashes. There's no need to group all the ink splashes in a container. They can all just be children of the Material component itself. This structure is left over from when Material was a base class. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/1013713005
-
Adam Barth authored
This CL adds typography information to the Sky theme. The values are from the Material Design spec. I've also applied these values to the stocks app and the various components. We're not geting precisely the right typography in some cases because of https://github.com/domokit/mojo/issues/65. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/1006363004
-
- 16 Mar, 2015 2 commits
-
-
Adam Barth authored
The left edge of the title should be on the 72px vertical keyline according to the Material Design spec. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/1010443005
-
Adam Barth authored
This naming matches the naming in Material Design. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/1010913002
-
- 13 Mar, 2015 5 commits
-
-
Rafael Weinstein authored
R=abarth@chromium.org Review URL: https://codereview.chromium.org/1006053002
-
Adam Barth authored
This CL cleans up the sky/framework/animation as follows: 1) I've moved code that's used only by the custom elements framework into sky/framework/elements/animation. This code is based on AnimationDelegates rather than Streams. 2) Rename ScrollCurve to ScrollBehavior because it encapsulates more behavior than just a curve. 3) Make the Generator interface explicit and mark subclasses as actual subclasses. 4) Move Simulation into generators.dart because it implements the Generator interface. 5) Move Animation out of generators.dart because it does not implement the Generator interface. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/1001373002
-
Rafael Weinstein authored
-
Rafael Weinstein authored
-
Rafael Weinstein authored
-
- 12 Mar, 2015 3 commits
-
-
Adam Barth authored
When using OverscrollCurve, we continue to scroll beyond the top of the scrollable area but the scroll delta is reduced by 2x. A future CL will add an animation at gesturescrollend to relax back to scroll position 0.0. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/1002953003
-
Adam Barth authored
Intead of hard-coding the notion of bounded scrolling into Scrollable, this CL factors out a ScrollCurve class that applies the bounds. In the future, we'll refine this mechanism to implement overflow scrolling. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/1005633002
-
Adam Barth authored
R=eseidel@chromium.org Review URL: https://codereview.chromium.org/1000863002
-
- 11 Mar, 2015 9 commits
-
-
Viet-Trung Luu authored
Also: * Fix consecutive spaces (don't collapse them). * Add support for ^L. Still doesn't work: * Totally blank lines. (I know why, but I don't know why I can't seem to fix it.) R=erg@chromium.org Review URL: https://codereview.chromium.org/997873004
-
Viet-Trung Luu authored
D'oh. TBR=erg@chromium.org Review URL: https://codereview.chromium.org/998103002
-
Viet-Trung Luu authored
(Together with an app that echoes stuff from the terminal.) R=erg@chromium.org Review URL: https://codereview.chromium.org/999193002
-
Adam Barth authored
To accomplish this, I made the following changes: 1) Material is now in charge of drawing the material shadows. 2) In order to mix in the style for the shadow, Element now takes a list of Styles instead of a single style. 3) Update all clients of Element#style to understand that we now have a list. 4) Update components that drawer shadows to have Material do that work instead. a) One exception: FloatingActionButton draws its own shadow because of its crazy clip requirements. We'll probably want to find a better way for FloatingActionButton to clip in the future. I've also added a widgets-fn example to demo the fn material widgets. This CL introduces a bug into Drawer whereby you can get ink splashes everywhere in the drawer. In the future, we'll need to separate out the different material aspects to get non-splashable materials. R=rafaelw@chromium.org Review URL: https://codereview.chromium.org/1003553002
-
Eric Seidel authored
We're not actively developing these at the moment. I could also just delete them, not sure if we're ready for that yet. TBR=abarth@chromium.org Review URL: https://codereview.chromium.org/999873002
-
Adam Barth authored
We don't yet reset the scroll offset, so sometimes you can't see your search results properly. R=rafaelw@chromium.org Review URL: https://codereview.chromium.org/1002453003
-
Adam Barth authored
R=rafaelw@chromium.org Review URL: https://codereview.chromium.org/996213004
-
Adam Barth authored
Instead of MaterialComponent being a base class, components that want material behavior simply create a MaterialComponent during their render function. This approach gives the component more flexibility as to its structure and gives MaterialComponent more flexibility has to how the components it generates are related to the existing children. Also, I've improved some of the event delegation code. There's no reason to attach event handlers to the root component you emit during |render| because the framework already delegates events from your root component to you. R=rafaelw@chromium.org Review URL: https://codereview.chromium.org/983903003
-
Adam Barth authored
The search field doesn't do anything, but it's there. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/998803002
-
- 10 Mar, 2015 7 commits
-
-
Adam Barth authored
Moving these files into sky/framework will make them easier to use from the SDK. Also, this CL also splits up the giant "widgets" library into smaller libraries, one per component. TBR=eseidel@chromium.org Review URL: https://codereview.chromium.org/993033003
-
Adam Barth authored
The implementation details are in sky/framework/editing. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/983213005
-
Adam Barth authored
We don't yet have a focus controller, which means once this control becomes focused there's no way for it to lose focus. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/999553002
-
Eric Seidel authored
http://www.google.com/design/spec/components/lists.html#lists-behavior R=abarth@chromium.org Review URL: https://codereview.chromium.org/993093004
-
Eric Seidel authored
54px on small screens: http://www.google.com/design/spec/layout/metrics-keylines.html#metrics-keylines-keylines-spacing TBR=abarth@chromium.org Review URL: https://codereview.chromium.org/995133002
-
Adam Barth authored
This CL factors EditableString out of EditableText and implements more of the InputConnection functions. As a result, EditableText now basically works. This CL also paves the way to make EditableText stateless by using EditableString as its state object. However, there's still a bit more work to do to make that a reality (e.g., factoring out the cursor blink timer and the connection to the keyboard). R=eseidel@chromium.org Review URL: https://codereview.chromium.org/995073002
-
Rafael Weinstein authored
This patch allows for an initial delay before an animation begins and also adds an Animation class which encapsulates a value which is long-lived, can be explicitly set and also animated from its current value to another value. BUG= R=abarth@chromium.org Review URL: https://codereview.chromium.org/994143002
-
- 09 Mar, 2015 2 commits
-
-
Adam Barth authored
This CL introduces a new keyboard service that understands Android IME and starts work on a Input component that interacts with this service to provide an editing control. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/995613002
-
Rafael Weinstein authored
"Render" is misleading. "Build" may not be the best word either, it's closer to what's actually happening. R=ojan@chromium.org TBR=abarth BUG= Review URL: https://codereview.chromium.org/992033002
-