Commits · bd1bb675b3dff2f782952e5681ea9542fad7733d · abdullh.alsoleman / Front-End

10 Aug, 2023 12 commits

Remove bringup from Windows build_tests shards (#132306) · bd1bb675
Zachary Anderson authored Aug 10, 2023
```
Context:
https://github.com/flutter/flutter/commit/aff8ef13d428395725ce8f836ca771b8bf2d87db
```
bd1bb675

Fix `PopupMenuItem` & `CheckedPopupMenuItem` has redundant `ListTile` padding... · 96e02c61

Taha Tesser authored Aug 10, 2023

Fix `PopupMenuItem` & `CheckedPopupMenuItem` has redundant `ListTile` padding and update default horizontal padding for Material 3 (#131609)

fixes [`PopupMenuItem` adds redundant padding when using `ListItem`](https://github.com/flutter/flutter/issues/128553)

### Description

- Fixed redundant `ListTile` padding when using `CheckedPopupMenuItem` or  `PopupMenuItem`  with the `ListTile` child for complex popup menu items as suggested in the docs.
- Updated default horizontal padding for popup menu items.

### Code sample

<details> 
<summary>expand to view the code sample</summary> 

```dart
import 'package:flutter/material.dart';

/// Flutter code sample for [PopupMenuButton].

// This is the type used by the popup menu below.
enum SampleItem { itemOne, itemTwo, itemThree }

void main() => runApp(const PopupMenuApp());

class PopupMenuApp extends StatelessWidget {
  const PopupMenuApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      theme: ThemeData(useMaterial3: true),
      home: const PopupMenuExample(),
    );
  }
}

class PopupMenuExample extends StatefulWidget {
  const PopupMenuExample({super.key});

  @override
  State<PopupMenuExample> createState() => _PopupMenuExampleState();
}

class _PopupMenuExampleState extends State<PopupMenuExample> {
  SampleItem? selectedMenu;

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(title: const Text('PopupMenuButton')),
      body: Center(
        child: SizedBox(
          width: 150,
          height: 100,
          child: Align(
            alignment: Alignment.topLeft,
            child: PopupMenuButton<SampleItem>(
              initialValue: selectedMenu,
              // Callback that sets the selected popup menu item.
              onSelected: (SampleItem item) {
                setState(() {
                  selectedMenu = item;
                });
              },
              itemBuilder: (BuildContext context) =>
                  <PopupMenuEntry<SampleItem>>[
                const PopupMenuItem<SampleItem>(
                  value: SampleItem.itemOne,
                  child: Text('PopupMenuItem'),
                ),
                const CheckedPopupMenuItem<SampleItem>(
                  checked: true,
                  value: SampleItem.itemTwo,
                  child: Text('CheckedPopupMenuItem'),
                ),
                const PopupMenuItem<SampleItem>(
                  value: SampleItem.itemOne,
                  child: ListTile(
                    leading: Icon(Icons.cloud),
                    title: Text('ListTile'),
                    contentPadding: EdgeInsets.zero,
                    trailing: Icon(Icons.arrow_right_rounded),
                  ),
                ),
              ],
            ),
          ),
        ),
      ),
    );
  }
}
``` 
	
</details>

### Before

![image](https://github.com/flutter/flutter/assets/48603081/aad15ffb-ca11-4997-81d1-b46288161a4e)

- Default horizontal padding is the same as M2 (16.0), while the specs use a smaller value (12.0)
- `ListTile` nested by default in `CheckedPopupMenuItem` has redundant padding
- `PopupMenuItem` using `ListTile` as a child for complex menu items contains redundant padding.

![Screenshot 2023-07-31 at 17 17 08](https://github.com/flutter/flutter/assets/48603081/75ad1fe5-e051-42ba-badf-e20c799dee96)

### After 

- Default horizontal padding is updated for Material 3.
- `PopupMenuItem` & `CheckedPopupMenuItem` override `ListTile` padding (similar to how `ExpansionTile` overrides `ListTile` text and icon color.

![Screenshot 2023-07-31 at 17 17 25](https://github.com/flutter/flutter/assets/48603081/288cf892-5b51-4365-9855-5ef0ed2928e9)

96e02c61

Roll Flutter Engine from 2fe84892b90a to 3359d6696da4 (1 revision) (#132305) · c428d915

engine-flutter-autoroll authored Aug 10, 2023

https://github.com/flutter/engine/compare/2fe84892b90a...3359d6696da4

2023-08-10 skia-flutter-autoroll@skia.org Roll Skia from a3975f2a9e79 to 7a1fec6b197f (1 revision) (flutter/engine#44580)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

c428d915

Roll Flutter Engine from 02ac5e84097b to 2fe84892b90a (2 revisions) (#132294) · 7c59dfeb

engine-flutter-autoroll authored Aug 10, 2023

https://github.com/flutter/engine/compare/02ac5e84097b...2fe84892b90a

2023-08-10 skia-flutter-autoroll@skia.org Roll Skia from d9e9b7073171 to a3975f2a9e79 (2 revisions) (flutter/engine#44577)
2023-08-10 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from zoCGnScKZWbm5s9Hy... to SoKcmsZ5H8uHJXV1S... (flutter/engine#44576)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from zoCGnScKZWbm to SoKcmsZ5H8uH

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

7c59dfeb

Fix `DropdownButtonFormField` input border clipping (#131481) · bb6b72d6

Taha Tesser authored Aug 10, 2023

fixes [BUG: DropdownButtonFormField input decorator focus/hover is not clipped
](https://github.com/flutter/flutter/issues/131282)

### Description

This fixes an issue where `DropdownButtonFormField`'s input border isn't used for clipping with `InkWell`.

### Before
![Screenshot 2023-07-28 at 17 06 20](https://github.com/flutter/flutter/assets/48603081/8fe1ee1f-5cea-4297-b4f6-e672d74bb583)

### After
![Screenshot 2023-07-28 at 17 06 38](https://github.com/flutter/flutter/assets/48603081/a0091459-67dc-45ca-96b1-95d7093d475f)

bb6b72d6

Roll Flutter Engine from 9117ff27d9c9 to 02ac5e84097b (2 revisions) (#132288) · 35a3ef7e

engine-flutter-autoroll authored Aug 10, 2023

https://github.com/flutter/engine/compare/9117ff27d9c9...02ac5e84097b

2023-08-10 skia-flutter-autoroll@skia.org Roll Skia from 7c5f6b17a998 to d9e9b7073171 (1 revision) (flutter/engine#44573)
2023-08-10 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from ZCP8LDbKF4LTBFz_W... to 961_tJawsbLMdy5i0... (flutter/engine#44572)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from ZCP8LDbKF4LT to 961_tJawsbLM

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

35a3ef7e

Roll Flutter Engine from b5b41ff66dae to 9117ff27d9c9 (16 revisions) (#132284) · a50776e5

engine-flutter-autoroll authored Aug 10, 2023

https://github.com/flutter/engine/compare/b5b41ff66dae...9117ff27d9c9

2023-08-10 zanderso@users.noreply.github.com Revert "Android a11y bridge sets importantness" (flutter/engine#44569)
2023-08-10 skia-flutter-autoroll@skia.org Roll Skia from 491f67637e6e to 7c5f6b17a998 (2 revisions) (flutter/engine#44568)
2023-08-10 matanlurey@users.noreply.github.com [Impeller] Replace Vulkan rotation checks with polling (flutter/engine#44361)
2023-08-10 31859944+LongCatIsLooong@users.noreply.github.com Disable text rounding hack by default (flutter/engine#44544)
2023-08-09 skia-flutter-autoroll@skia.org Roll Skia from 3d5a6138b7e5 to 491f67637e6e (4 revisions) (flutter/engine#44563)
2023-08-09 skia-flutter-autoroll@skia.org Manual roll Dart SDK from f664f4b9c50d to d89e4ead966d (11 revisions) (flutter/engine#44560)
2023-08-09 58529443+srujzs@users.noreply.github.com Make toJS'd function use JS types (flutter/engine#44469)
2023-08-09 xty50337@hotmail.com [web] Fix rendering of gradients in html mode (flutter/engine#40345)
2023-08-09 55360120+Matt2D@users.noreply.github.com Flutter iOS Interactive Keyboard: Fixing Animation Issue (flutter/engine#44514)
2023-08-09 skia-flutter-autoroll@skia.org Roll Skia from 8c9a8d3e073c to 3d5a6138b7e5 (4 revisions) (flutter/engine#44557)
2023-08-09 skia-flutter-autoroll@skia.org Roll Skia from d210bab77137 to 8c9a8d3e073c (1 revision) (flutter/engine#44555)
2023-08-09 skia-flutter-autoroll@skia.org Roll Skia from 25aedb939915 to d210bab77137 (2 revisions) (flutter/engine#44550)
2023-08-09 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from e7bMhkfY-RPMrSMhB... to zoCGnScKZWbm5s9Hy... (flutter/engine#44548)
2023-08-09 skia-flutter-autoroll@skia.org Roll Skia from 17ba2122707b to 25aedb939915 (3 revisions) (flutter/engine#44547)
2023-08-09 47866232+chunhtai@users.noreply.github.com Android a11y bridge sets importantness (flutter/engine#44452)
2023-08-09 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from tO6r8iQqnmsYkLcvZ... to ZCP8LDbKF4LTBFz_W... (flutter/engine#44545)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from tO6r8iQqnmsY to ZCP8LDbKF4LT
fuchsia/sdk/core/mac-amd64 from e7bMhkfY-RPM to zoCGnScKZWbm

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

a50776e5

Keep alive support for 2D scrolling (#131641) · 0c80ed6d

Kate Lovett authored Aug 10, 2023

Fixes https://github.com/flutter/flutter/issues/126297

This adds support for keep alive to the 2D scrolling foundation. The TwoDimensionalChildBuilderDelegate and TwoDimensionalChildListDelegate will both add automatic keep alives to their children, matching the convention from SliverChildDelegates. The TwoDimensionalViewportParentData now incorporates keep alive and which is managed by the RenderTwoDimensionalViewport.

0c80ed6d

Add missing `ignore: deprecated_member_use` to unblock the engine roller (#132280) · 9156f6b5

LongCatIsLooong authored Aug 10, 2023

## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat

9156f6b5

Pin leak_tracker. (#132261) · 2efda23a
Polina Cherkasova authored Aug 10, 2023

2efda23a

Fix prefer_null_aware_operators violation (#132242) · 9a32f24a

Sam Rawlins authored Aug 10, 2023

Use a null-aware `?.` operator instead of a conditional operator. This complies with the `prefer_null_aware_operators` rule. Fixes https://github.com/flutter/flutter/issues/132241

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

9a32f24a

Making TextPainter rounding hack disabled by default (#132094) · 3f831b69

LongCatIsLooong authored Aug 10, 2023

Migrate tests in flutter/flutter. Once the tests here and in `*_customer_testing` are migrated, the default value of the migration flag will be changed from false to true, making the rounding hack disabled by default.

3f831b69

09 Aug, 2023 20 commits

Allows adding a storage 'realm' to the storage base URL (#131951) · 118c2df7

Zachary Anderson authored Aug 09, 2023

Context: https://github.com/flutter/flutter/issues/131862

This PR injects a "realm" component to the storage base URL when the contents of the file `bin/internal/engine.realm` is non-empty.

As documented in the PR, when the realm is `flutter_archives_v2`, and `bin/internal/engine.version` contains the commit hash for a commit in a `flutter/engine` PR, then the artifacts pulled by the tool will be the artifacts built by the presubmit checks for the PR.

This works for everything but the following two cases:
1. Fuchsia artifacts are not uploaded to CIPD by the Fuchsia presubmit builds.
2. Web artifacts are not uploaded to gstatic by the web engine presubmit builds.

For (1), the flutter/flutter presubmit `fuchsia_precache` is driven by a shell script outside of the repo. It will fail when the `engine.version` and `engine.realm` don't point to a post-submit engine commit.

For (2), the flutter/flutter web presubmit tests that refer to artifacts in gstatic hang when the artifacts aren't found, so this PR skips them.

118c2df7

Sample code for ImageProvider (#131952) · 9c8f3950

Ian Hickson authored Aug 09, 2023

Also:
- minor improvements to documentation
- wrap one of our test error messages in a manner more consistent with other messages

9c8f3950

Remove shrinkWrap from flexible_space_bar_test.dart (#132173) · 702b78c6
Tae Hyung Kim authored Aug 09, 2023
```
See title.
```
702b78c6
Deprecate `describeEnum`. (#125016) · 6da6fbf5
Bernardo Ferrari authored Aug 09, 2023
```
Final part of https://github.com/flutter/flutter/issues/123346.
```
6da6fbf5

Handle hasStrings on web (#132093) · f5ceaf98

Justin McCandless authored Aug 09, 2023

By default, Flutter web uses the browser's built-in context menu.

<img width="200" src="https://github.com/flutter/flutter/assets/389558/990f99cb-bc38-40f1-9e88-8839bc342da5" />

As of [recently](https://github.com/flutter/engine/pull/38682), it's possible to use a Flutter-rendered context menu like the other platforms.

```dart
void main() {
  runApp(const MyApp());
  BrowserContextMenu.disableContextMenu();
}
```

But there is a bug (https://github.com/flutter/flutter/issues/129692) that the Paste button is missing and never shows up.

<img width="284" alt="Screenshot 2023-08-07 at 2 39 03 PM" src="https://github.com/flutter/flutter/assets/389558/f632be25-28b1-4e2e-98f7-3bb443f077df">

The reason why it's missing is that Flutter first checks if there is any pasteable text on the clipboard before deciding to show the Paste button using the `hasStrings` platform channel method, but that was never implemented for web ([original hasStrings PR](https://github.com/flutter/flutter/pull/87678)).

So let's just implement hasStrings for web?  No, because Chrome shows a permissions prompt when the clipboard is accessed, and there is [no browser clipboard API](https://developer.mozilla.org/en-US/docs/Web/API/Clipboard_API) to avoid it.  The prompt will show immediately when the EditableText is built, not just when the Paste button is pressed.

<img width="200" src="https://github.com/flutter/flutter/assets/389558/5abdb160-1b13-4f1a-87e1-4653ca19d73e" />

### This PR's solution

Instead, before implementing hasStrings for web, this PR disables the hasStrings check for web.  The result is that users will always see a paste button, even in the (unlikely) case that they have nothing pasteable on the clipboard.  However, they will not see a permissions dialog until they actually click the Paste button.  Subsequent pastes don't show the permission dialog.

<details>

<summary>Video of final behavior with this PR</summary>

https://github.com/flutter/flutter/assets/389558/ed16c925-8111-44a7-99e8-35a09d682748

</details>

I think this will be the desired behavior for the vast majority of app developers.  Those that want different behavior can use hasStrings themselves, which will be implemented in https://github.com/flutter/engine/pull/43360.

### References

Fixes https://github.com/flutter/flutter/issues/129692
Engine PR to be merged after this: https://github.com/flutter/engine/pull/43360

f5ceaf98

Add an example for `TapAndPanGestureRecognizer` (#131873) · 6ac161f9

Renzo Olivares authored Aug 09, 2023

This adds an example for `TapAndPanGestureRecognizer` that demonstrates how to scale a widget using a double tap + vertical drag gesture.

https://github.com/flutter/flutter/assets/948037/4c6c5467-2157-4b6a-bc52-264a3b6303de

6ac161f9

Reland "[web] Migrate framework to fully use package:web (#128901)" (#132092) · 632681da

Mouad Debbar authored Aug 09, 2023

Relanding https://github.com/flutter/flutter/pull/128901

Part of https://github.com/flutter/flutter/issues/113402
Part of https://github.com/flutter/flutter/issues/127030

632681da

New tooling for iOS 17 physical devices (#131865) · d631b262

Victoria Ashworth authored Aug 09, 2023

This PR includes the following changes. These changes only apply to iOS 17 physical devices.

| Command | Change Description  | Changes to User Experience |
| ------------- | ------------- | ------------- |
| `flutter run --release` | Uses `devicectl` to install and launch application in release mode.  | No change.  |
| `flutter run`  | Uses Xcode via automation scripting to run application in debug and profile mode. | Xcode will be opened in the background. Errors/crashes may be caught in Xcode and therefore may not show in terminal. |
| `flutter run --use-application-binary=xxxx` | Creates temporary empty Xcode project and use Xcode to run via automation scripting in debug and profile. | Xcode will be opened in the background. Errors/crashes may be caught in Xcode and therefore may not show in terminal.  |
| `flutter install` | Uses `devicectl` to check installed apps, install app, uninstall app.  | No change.  |
| `flutter screenshot` | Will return error.  | Will return error.  |

Other changes include:
* Using `devicectl` to get information about the device
* Using `idevicesyslog` and Dart VM logging for device logs

Note:
Xcode automation scripting (used in `flutter run` for debug and profile) does not work in a headless (without a UI) interface. No known workaround.

Fixes https://github.com/flutter/flutter/issues/128827, https://github.com/flutter/flutter/issues/128531.

d631b262

Roll Flutter Engine from 30e7780efacc to b5b41ff66dae (2 revisions) (#132238) · 88ed9bd9

engine-flutter-autoroll authored Aug 09, 2023

https://github.com/flutter/engine/compare/30e7780efacc...b5b41ff66dae

2023-08-09 ftsui@google.com Request GLES version 2 interface. (flutter/engine#44504)
2023-08-09 jonahwilliams@google.com [Impeller] Don't perform final layout transition on worker thread. (flutter/engine#44510)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

88ed9bd9

[Impeller] Adds advanced blend benchmark (#131893) · 1ff82af5

gaaclarke authored Aug 09, 2023

issue: https://github.com/flutter/flutter/issues/131784

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat

1ff82af5

Roll Packages from ac4137624a13 to 881c1f552d0f (3 revisions) (#132234) · c4954968

engine-flutter-autoroll authored Aug 09, 2023

https://github.com/flutter/packages/compare/ac4137624a13...881c1f552d0f

2023-08-09 engine-flutter-autoroll@skia.org Roll Flutter from 436df69a to f4c25bbb (28 revisions) (flutter/packages#4666)
2023-08-09 reidbaker@google.com [url_launcher] Android API 34 support (flutter/packages#4660)
2023-08-08 67326251+Franreno@users.noreply.github.com Migrating styleFrom API to new version. (flutter/packages#4540)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

c4954968

Roll Flutter Engine from 3d3fb4faed02 to 30e7780efacc (8 revisions) (#132233) · 26a9c6e9

engine-flutter-autoroll authored Aug 09, 2023

https://github.com/flutter/engine/compare/3d3fb4faed02...30e7780efacc

2023-08-09 skia-flutter-autoroll@skia.org Roll Skia from 3e85749702f4 to 17ba2122707b (2 revisions) (flutter/engine#44540)
2023-08-09 skia-flutter-autoroll@skia.org Roll Skia from e892c300a7c4 to 3e85749702f4 (1 revision) (flutter/engine#44539)
2023-08-09 skia-flutter-autoroll@skia.org Roll Skia from ff6d82573f69 to e892c300a7c4 (1 revision) (flutter/engine#44538)
2023-08-09 skia-flutter-autoroll@skia.org Roll Skia from e2885a01f134 to ff6d82573f69 (3 revisions) (flutter/engine#44536)
2023-08-09 10456171+caroqliu@users.noreply.github.com Remove GFX and Scenic dependencies from Fuchsia integration tests (flutter/engine#44498)
2023-08-09 skia-flutter-autoroll@skia.org Roll Skia from ac2b25fec6eb to e2885a01f134 (1 revision) (flutter/engine#44534)
2023-08-09 skia-flutter-autoroll@skia.org Roll Skia from d097852dc928 to ac2b25fec6eb (3 revisions) (flutter/engine#44533)
2023-08-09 leroux_bruno@yahoo.fr [Windows] Return keyboard pressed state (flutter/engine#43998)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

26a9c6e9

Update material and cupertino localizations (#131212) · fa88170a

Tae Hyung Kim authored Aug 09, 2023

See title.

Fixes https://github.com/flutter/flutter/issues/130874.

---------
Co-authored-by: Xilai Zhang <xilaizhang@google.com>

fa88170a

Revert "Handle breaking changes in leak_tracker." (#132223) · f4c25bbb
Zachary Anderson authored Aug 09, 2023
```
Reverts flutter/flutter#131998

Reverting for https://github.com/flutter/flutter/issues/132222
```
f4c25bbb

Roll Flutter Engine from 8ec575168d44 to 3d3fb4faed02 (3 revisions) (#132193) · d78b3ac0

engine-flutter-autoroll authored Aug 09, 2023

https://github.com/flutter/engine/compare/8ec575168d44...3d3fb4faed02

2023-08-09 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from c18Y3Ga7cvdrmy8FQ... to e7bMhkfY-RPMrSMhB... (flutter/engine#44531)
2023-08-09 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 9Pl8nd13UI8rrS3JD... to tO6r8iQqnmsYkLcvZ... (flutter/engine#44529)
2023-08-09 skia-flutter-autoroll@skia.org Roll Skia from e904a9f2010e to d097852dc928 (1 revision) (flutter/engine#44525)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from 9Pl8nd13UI8r to tO6r8iQqnmsY
fuchsia/sdk/core/mac-amd64 from c18Y3Ga7cvdr to e7bMhkfY-RPM

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

d78b3ac0

Use pattern matching to avoid strange type annotations (#131964) · aac01897
LongCatIsLooong authored Aug 09, 2023
```
Addresses https://github.com/flutter/flutter/pull/131640#discussion_r1284861384
```
aac01897

Roll Flutter Engine from 6839b88283b6 to 8ec575168d44 (1 revision) (#132182) · d7877d1f

engine-flutter-autoroll authored Aug 09, 2023

https://github.com/flutter/engine/compare/6839b88283b6...8ec575168d44

2023-08-09 matanlurey@users.noreply.github.com [Impeller] Plumb Paint.enableDithering to backend (flutter/engine#44522)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

d7877d1f

Roll Flutter Engine from 29b117aa4192 to 6839b88283b6 (1 revision) (#132181) · 886d676a

engine-flutter-autoroll authored Aug 09, 2023

https://github.com/flutter/engine/compare/29b117aa4192...6839b88283b6

2023-08-08 skia-flutter-autoroll@skia.org Roll Skia from 1fbe521b2c56 to e904a9f2010e (3 revisions) (flutter/engine#44520)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

886d676a

Roll Flutter Engine from 82292b8390cb to 29b117aa4192 (5 revisions) (#132179) · bf729dcd

engine-flutter-autoroll authored Aug 09, 2023

https://github.com/flutter/engine/compare/82292b8390cb...29b117aa4192

2023-08-08 matanlurey@users.noreply.github.com [Impeller] Add gradient dithering for Radial/Sweep/Conical gradients (flutter/engine#44331)
2023-08-08 skia-flutter-autoroll@skia.org Roll Skia from 68b80f663be6 to 1fbe521b2c56 (2 revisions) (flutter/engine#44518)
2023-08-08 chris@bracken.jp [macOS] Improve engine retain cycle testing (flutter/engine#44509)
2023-08-08 34871572+gmackall@users.noreply.github.com Fix name in description of 'create_cipd_packages.sh' (flutter/engine#44513)
2023-08-08 30870216+gaaclarke@users.noreply.github.com [Impeller] started std::moving `Command`s instead of copying (flutter/engine#44508)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

bf729dcd

Add more info to `OverlayState.insert` error messages (#129363) · 5de6684b

LongCatIsLooong authored Aug 09, 2023

I was debugging an Overlay issue and felt I could have identified the problem faster if the existing assertions provided more information about the current state of the OverlayEntry and Overlay.

5de6684b

08 Aug, 2023 8 commits

Add `textCapitalization` property for `SearchBar` and `SearchAnchor` (#131459) · 0bc5a2bc
Qun Cheng authored Aug 08, 2023
```
This is to add `textCapitalization` property for `SearchBar` and `SearchAnchor`.
Fixes: #131260
```
0bc5a2bc

Roll Flutter Engine from 934ebb005d02 to 82292b8390cb (3 revisions) (#132166) · 40a3e481

engine-flutter-autoroll authored Aug 08, 2023

https://github.com/flutter/engine/compare/934ebb005d02...82292b8390cb

2023-08-08 skia-flutter-autoroll@skia.org Roll Skia from 9fa8ebdfdbb8 to 68b80f663be6 (1 revision) (flutter/engine#44511)
2023-08-08 31859944+LongCatIsLooong@users.noreply.github.com Disable HTML renderer paragraph input width flooring (flutter/engine#44478)
2023-08-08 skia-flutter-autoroll@skia.org Roll Skia from 5c8c7faf9131 to 9fa8ebdfdbb8 (2 revisions) (flutter/engine#44507)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

40a3e481

Bump github/codeql-action from 2.21.2 to 2.21.3 (#132165) · 9b261a77

dependabot[bot] authored Aug 08, 2023

Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.21.2 to 2.21.3.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/github/codeql-action/blob/main/CHANGELOG.md">github/codeql-action's changelog</a>.</em></p>
<blockquote>
<h1>CodeQL Action Changelog</h1>
<p>See the <a href="https://github.com/github/codeql-action/releases">releases page</a> for the relevant changes to the CodeQL CLI and language packs.</p>
<h2>[UNRELEASED]</h2>
<p>No user facing changes.</p>
<h2>2.21.3 - 08 Aug 2023</h2>
<ul>
<li>We are rolling out a feature in August 2023 that will improve multi-threaded performance on larger runners. <a href="https://redirect.github.com/github/codeql-action/pull/1817">#1817</a></li>
<li>We are rolling out a feature in August 2023 that adds beta support for <a href="https://projectlombok.org/">Project Lombok</a> when analyzing Java. <a href="https://redirect.github.com/github/codeql-action/pull/1809">#1809</a></li>
<li>Reduce disk space usage when downloading the CodeQL bundle. <a href="https://redirect.github.com/github/codeql-action/pull/1820">#1820</a></li>
</ul>
<h2>2.21.2 - 28 Jul 2023</h2>
<ul>
<li>Update default CodeQL bundle version to 2.14.1. <a href="https://redirect.github.com/github/codeql-action/pull/1797">#1797</a></li>
<li>Avoid duplicating the analysis summary within the logs. <a href="https://redirect.github.com/github/codeql-action/pull/1811">#1811</a></li>
</ul>
<h2>2.21.1 - 26 Jul 2023</h2>
<ul>
<li>Improve the handling of fatal errors from the CodeQL CLI. <a href="https://redirect.github.com/github/codeql-action/pull/1795">#1795</a></li>
<li>Add the <code>sarif-output</code> output to the analyze action that contains the path to the directory of the generated SARIF. <a href="https://redirect.github.com/github/codeql-action/pull/1799">#1799</a></li>
</ul>
<h2>2.21.0 - 19 Jul 2023</h2>
<ul>
<li>CodeQL Action now requires CodeQL CLI 2.9.4 or later. For more information, see the corresponding changelog entry for CodeQL Action version 2.20.4. <a href="https://redirect.github.com/github/codeql-action/pull/1724">#1724</a></li>
</ul>
<h2>2.20.4 - 14 Jul 2023</h2>
<ul>
<li>This is the last release of the Action that supports CodeQL CLI versions 2.8.5 to 2.9.3. These versions of the CodeQL CLI were deprecated on June 20, 2023 alongside GitHub Enterprise Server 3.5 and will not be supported by the next release of the CodeQL Action (2.21.0).
<ul>
<li>If you are using one of these versions, please update to CodeQL CLI version 2.9.4 or later. For instance, if you have specified a custom version of the CLI using the 'tools' input to the 'init' Action, you can remove this input to use the default version.</li>
<li>Alternatively, if you want to continue using a version of the CodeQL CLI between 2.8.5 and 2.9.3, you can replace 'github/codeql-action/<em><a href="https://github.com/v2"><code>@âv2</code></a>' by 'github/codeql-action/</em><a href="https://github.com/v2"><code>@âv2</code></a>.20.4' in your code scanning workflow to ensure you continue using this version of the CodeQL Action.</li>
</ul>
</li>
<li>We are rolling out a feature in July 2023 that will slightly reduce the default amount of RAM used for query execution, in proportion to the runner's total memory. This will help to avoid out-of-memory failures on larger runners. <a href="https://redirect.github.com/github/codeql-action/pull/1760">#1760</a></li>
<li>Update default CodeQL bundle version to 2.14.0. <a href="https://redirect.github.com/github/codeql-action/pull/1762">#1762</a></li>
</ul>
<h2>2.20.3 - 06 Jul 2023</h2>
<ul>
<li>Update default CodeQL bundle version to 2.13.5. <a href="https://redirect.github.com/github/codeql-action/pull/1743">#1743</a></li>
</ul>
<h2>2.20.2 - 03 Jul 2023</h2>
<p>No user facing changes.</p>
<h2>2.20.1 - 21 Jun 2023</h2>
<ul>
<li>Update default CodeQL bundle version to 2.13.4. <a href="https://redirect.github.com/github/codeql-action/pull/1721">#1721</a></li>
<li>Experimental: add a new <code>resolve-environment</code> action which attempts to infer a configuration for the build environment that is required to build a given project. Do not use this in production as it is part of an internal experiment and subject to change at any time.</li>
</ul>
<h2>2.20.0 - 13 Jun 2023</h2>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/github/codeql-action/commit/5b6282e01c62d02e720b81eb8a51204f527c3624"><code>5b6282e</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/1829">#1829</a> from github/update-v2.21.3-f9a7c6738</li>
<li><a href="https://github.com/github/codeql-action/commit/f0f7a35b85fdfbe2a22f71f07357d50c3b42a03b"><code>f0f7a35</code></a> Add changenote for Lombok rollout</li>
<li><a href="https://github.com/github/codeql-action/commit/dda4ed3db43be29c67d79c0cb9820615c945bef9"><code>dda4ed3</code></a> Update changelog for v2.21.3</li>
<li><a href="https://github.com/github/codeql-action/commit/f9a7c6738f28efb36e31d49c53a201a9c5d6a476"><code>f9a7c67</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/1827">#1827</a> from github/dependabot/npm_and_yarn/npm-5103036bd1</li>
<li><a href="https://github.com/github/codeql-action/commit/31b9dd18d42cacc20225c8e17681df56ecc9b962"><code>31b9dd1</code></a> Update checked-in dependencies</li>
<li><a href="https://github.com/github/codeql-action/commit/7e2f56aae343fe3734d1841385b67742654aa94c"><code>7e2f56a</code></a> Bump the npm group with 3 updates</li>
<li><a href="https://github.com/github/codeql-action/commit/878ae4a749eff2fd2a5789cd23ef5c39a4903cd1"><code>878ae4a</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/1823">#1823</a> from github/henrymercer/setup-swift-more-consistent</li>
<li><a href="https://github.com/github/codeql-action/commit/63602c0f72ecd7fac834d5ca1d52ec1500bc8152"><code>63602c0</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/1824">#1824</a> from github/henrymercer/cli-notifications-fix</li>
<li><a href="https://github.com/github/codeql-action/commit/66dc883276a9bc95275668a69c26e7f55e4013d8"><code>66dc883</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/1826">#1826</a> from github/henrymercer/increase-reserved-scaling-fa...</li>
<li><a href="https://github.com/github/codeql-action/commit/2203178090782fe408dd0bee3925a959edaedf22"><code>2203178</code></a> Increase scaling factor for reserved RAM to 5%</li>
<li>Additional commits viewable in <a href="https://github.com/github/codeql-action/compare/0ba4244466797eb048eb91a6cd43d5c03ca8bd05...5b6282e01c62d02e720b81eb8a51204f527c3624">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=github/codeql-action&package-manager=github_actions&previous-version=2.21.2&new-version=2.21.3)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

9b261a77

Revert of #120385 (#132167) · 2728ba0f

Jesús S Guerrero authored Aug 08, 2023

Breaking google testing 
revert of: https://github.com/flutter/flutter/pull/120385
b/295065534

2728ba0f

Add `PopupMenuButton.iconColor`, `PopupMenuTheme.iconSize` and fix button icon... · b77b149d

Taha Tesser authored Aug 08, 2023

Add `PopupMenuButton.iconColor`, `PopupMenuTheme.iconSize` and fix button icon using unexpected color propert (#132054)

fixes [PopupMenuButton uses color property for icon color](https://github.com/flutter/flutter/issues/127802) 
fixes [`popup_menu_test.dart` lacks default icon color tests.](https://github.com/flutter/flutter/issues/132050) 

### Description
- Add  `PopupMenuButton..iconColor` and fix the PopupMenu button icon using an unexpected color property.
- Add the missing `PopupMenuTheme.iconSize`.
- Clean up some tests and minor improvements.

### Code sample

<details> 
<summary>expand to view the code sample</summary> 

```dart
import 'package:flutter/material.dart';

/// Flutter code sample for [PopupMenuButton].

// This is the type used by the popup menu below.
enum SampleItem { itemOne, itemTwo, itemThree }

void main() => runApp(const PopupMenuApp());

class PopupMenuApp extends StatelessWidget {
  const PopupMenuApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      theme: ThemeData(
        popupMenuTheme: PopupMenuThemeData(
          // iconSize: 75,
          // iconColor: Colors.amber,
          color: Colors.deepPurple[100],
        ),
      ),
      home: const PopupMenuExample(),
    );
  }
}

class PopupMenuExample extends StatefulWidget {
  const PopupMenuExample({super.key});

  @override
  State<PopupMenuExample> createState() => _PopupMenuExampleState();
}

class _PopupMenuExampleState extends State<PopupMenuExample> {
  SampleItem? selectedMenu;

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(title: const Text('PopupMenuButton')),
      body: Center(
        child: PopupMenuButton<SampleItem>(
          iconSize: 75,
          // iconColor: Colors.amber,
          color: Colors.deepPurple[100],
          initialValue: selectedMenu,
          // Callback that sets the selected popup menu item.
          onSelected: (SampleItem item) {
            setState(() {
              selectedMenu = item;
            });
          },
          itemBuilder: (BuildContext context) => <PopupMenuEntry<SampleItem>>[
            const PopupMenuItem<SampleItem>(
              value: SampleItem.itemOne,
              child: Text('Item 1'),
            ),
            const PopupMenuItem<SampleItem>(
              value: SampleItem.itemTwo,
              child: Text('Item 2'),
            ),
            const PopupMenuDivider(),
            const CheckedPopupMenuItem<SampleItem>(
              value: SampleItem.itemThree,
              checked: true,
              child: Text('Item 3'),
            ),
          ],
        ),
      ),
    );
  }
}

``` 
	
</details>

![Group 2](https://github.com/flutter/flutter/assets/48603081/eb5404ae-2a07-4374-9821-66a0bbea041e)

![Group 1](https://github.com/flutter/flutter/assets/48603081/464e3957-1afb-4118-abcc-aad12591dc51)

b77b149d

More PageStorage clarity in the documentation (#131954) · e65c37ee
Ian Hickson authored Aug 08, 2023
```
Fixes https://github.com/flutter/flutter/issues/10867
```
e65c37ee
Document that missed_frame_build_budget_count is misleading (#132137) · b29069ec
Ian Hickson authored Aug 08, 2023
```
Fixes https://github.com/flutter/flutter/issues/109745
```
b29069ec
Locate the template directory using a TemplatePathProvider. (#132156) · d5a0fcd5
Lau Ching Jun authored Aug 08, 2023
```
So that the paths can be overridden.
```
d5a0fcd5