1. 09 May, 2019 1 commit
  2. 22 Mar, 2019 1 commit
  3. 01 Mar, 2019 1 commit
    • Alexandre Ardhuin's avatar
      Add missing trailing commas (#28673) · 387f8854
      Alexandre Ardhuin authored
      * add trailing commas on list/map/parameters
      
      * add trailing commas on Invocation with nb of arg>1
      
      * add commas for widget containing widgets
      
      * add trailing commas if instantiation contains trailing comma
      
      * revert bad change
      387f8854
  4. 18 Dec, 2018 1 commit
  5. 26 Oct, 2018 1 commit
    • Ian Hickson's avatar
      Fix bugs in RenderSizedOverflowBox and RenderFractionallySizedOverflowBox (#23492) · 53308465
      Ian Hickson authored
      Bug #1: These didn't work with directional alignments, due to an error
      in the types of the constructor arguments.
      
      Bug #2: Pretty sure RenderSizedOverflowBox never worked at all. As
      soon as I wrote a test for it, the test showed that there was a
      fundamental bug in its performLayout method: it didn't set
      parentUsesSize, but it immediately tried to use the child's size.
      53308465
  6. 12 Sep, 2018 1 commit
  7. 18 Aug, 2018 1 commit
    • Ian Hickson's avatar
      Fixes resulting from audit of issues links (#20772) · 8c79f40d
      Ian Hickson authored
      * Fixes resulting from audit of issues links
      
      I looked at every link to GitHub in our repo. For cases where we had a TODO that was waiting for a bug to be fixed, and the bug has now been fixed, I applied the pending change. For cases where the link was out of date, I updated the link.
      
      * Update run_test.dart
      
      skip this test again since it failed on linux and macos bots
      8c79f40d
  8. 10 Aug, 2018 1 commit
  9. 05 Jun, 2018 1 commit
  10. 31 May, 2018 1 commit
  11. 03 May, 2018 1 commit
  12. 23 Apr, 2018 1 commit
  13. 22 Mar, 2018 1 commit
    • Greg Spencer's avatar
      Creating chips custom renderer, updating visual look. (#15596) · 4141946c
      Greg Spencer authored
      This updates the visual look of the Chip class, so that it scales properly in the face of text scale (and label widget size) changes, and bases its height off of the label widget's height, constraining the other widgets it contains to be the same height.
      
      To do this properly, I had to implement a custom render object that will measure the height of the label, so the guts of this class are basically rewritten.
      
      In addition, to allow the circle avatar to increase in size when the chip does, I added minRadius and maxRadius arguments to it, and I updated its color handling to use the light/dark primary colors of the theme in a smart way instead of just using black and white.
      
      Updated and added tests.
      4141946c
  14. 20 Mar, 2018 1 commit
  15. 12 Mar, 2018 1 commit
  16. 02 Feb, 2018 1 commit
  17. 17 Nov, 2017 1 commit
    • Greg Spencer's avatar
      Fix spelling errors in all the dartdocs. (#13061) · 0259be90
      Greg Spencer authored
      I got tired of drive-by spelling fixes, so I figured I'd just take care of them all at once.
      
      This only corrects errors in the dartdocs, not regular comments, and I skipped any sample code in the dartdocs. It doesn't touch any identifiers in the dartdocs either. No code changes, just comments.
      0259be90
  18. 16 Nov, 2017 1 commit
    • Ian Hickson's avatar
      ExpansionPanel animation fixes (#13032) · c97fc206
      Ian Hickson authored
      Previously, ExpansionPanel would do weird things if interacted with
      when it was already animating. This is fixed and there's now a test.
      
      Also:
      
       * Minor fixes to make the gallery work in RTL, not that there's
         any way to see that without hard-coding the framework to RTL.
         But at least I'll be less annoyed when doing that.
      
       * Some trivial code and documentation cleanup.
      c97fc206
  19. 15 Nov, 2017 1 commit
    • Greg Spencer's avatar
      Adding accomodations to ListTile for scaleTextFactor. (#12973) · c15c021e
      Greg Spencer authored
      This makes ListTile expand vertically when text is scaled, or really when whatever is placed inside it is larger than the available space.
      
      In order for UnconstrainedBox to be useful here, I needed for it to only unconstrain the child Row in one dimension, so I added a "constrainedAxis" parameter to the UnconstrainedBox.
      
      Also, changed one enum test to use a switch instead.
      
      I modified the ListTile test to be more representative of the intention of the spec: we were testing with text in the leading and trailing sections, and the design wants icons there. Because there was leading text, and the dense mode only changes the font size on the text lines, the leading text was propping up the minimum size of the tile, making so that the test wasn't really testing any changes in dense mode.
      c15c021e
  20. 09 Nov, 2017 1 commit
    • Greg Spencer's avatar
      Add an UnconstrainedBox and factor out debug overflow indicator. (#12856) · 3541ad0a
      Greg Spencer authored
      UnconstrainedBox will allow its child to size itself as if it had no constraints, and then attempt to fit around that object, until its own constraints are exceeded, in which case it will clip and display an overflow warning.
      
      I also factored out DebugOverflowIndicator, which will draw overflow indicators on containers which overflow but aren't expected to.
      3541ad0a
  21. 23 Oct, 2017 1 commit
  22. 02 Oct, 2017 1 commit
    • Adam Barth's avatar
      Add Alignment, which will replace FractionalOffset (#12342) · 2b126bcd
      Adam Barth authored
      Unlike FractionalOffset, Alignment uses the center as the zero of the
      coordinate system, which makes the RTL math work out much cleaner.
      
      Also, make FractionalOffset into a subclass of Alignment so that clients
      can continue to use FractionalOffset.
      2b126bcd
  23. 24 Sep, 2017 1 commit
  24. 21 Sep, 2017 1 commit
  25. 31 Aug, 2017 1 commit
  26. 28 Aug, 2017 1 commit
    • Ian Hickson's avatar
      RTL: Padding, Flex (#11709) · f235a2c1
      Ian Hickson authored
      * Introduce a Directionality inherited widget which sets the ambient LTR vs RTL mode (defaulting to null, which means you cannot use directionality-influenced values).
      
      * Make it possible to configure Padding (including Container.padding and Container.margin) using a directionality-agnostic EdgeInsets variant.
      
      * Provide textDirection and verticalDirection controls on Row and Column to make them RTL-aware.
      
      * Introduce a variant of FractionalOffset based on the EdgeInsets variant. Not yet actually used.
      
      * Fix all the tests that depended on Row defaulting to LTR.
      f235a2c1
  27. 23 Aug, 2017 1 commit
  28. 03 Aug, 2017 1 commit
  29. 25 Jul, 2017 1 commit
  30. 05 Jun, 2017 1 commit
  31. 12 Apr, 2017 1 commit
    • Ian Hickson's avatar
      Move Point to Offset (#9277) · bf017b79
      Ian Hickson authored
      * Manually fix every use of Point.x and Point.y
      
      Some of these were moved to dx/dy, but not all.
      
      * Manually convert uses of the old gradient API
      
      * Remove old reference to Point.
      
      * Mechanical changes
      
      I applied the following at the root of the Flutter repository:
      
      git ls-files -z | xargs -0 sed -i 's/\bPoint[.]origin\b/Offset.zero/g'
      git ls-files -z | xargs -0 sed -i 's/\bPoint[.]lerp\b/Offset.lerp/g'
      git ls-files -z | xargs -0 sed -i 's/\bnew Point\b/new Offset/g'
      git ls-files -z | xargs -0 sed -i 's/\bconst Point\b/const Offset/g'
      git ls-files -z | xargs -0 sed -i 's/\bstatic Point /static Offset /g'
      git ls-files -z | xargs -0 sed -i 's/\bfinal Point /final Offset /g'
      git ls-files -z | xargs -0 sed -i 's/^\( *\)Point /\1Offset /g'
      git ls-files -z | xargs -0 sed -i 's/ui[.]Point\b/ui.Offset/g'
      git ls-files -z | xargs -0 sed -i 's/(Point\b/(Offset/g'
      git ls-files -z | xargs -0 sed -i 's/\([[{,]\) Point\b/\1 Offset/g'
      git ls-files -z | xargs -0 sed -i 's/@required Point\b/@required Offset/g'
      git ls-files -z | xargs -0 sed -i 's/<Point>/<Offset>/g'
      git ls-files -z | xargs -0 sed -i 's/[.]toOffset()//g'
      git ls-files -z | xargs -0 sed -i 's/[.]toPoint()//g'
      git ls-files -z | xargs -0 sed -i 's/\bshow Point, /show /g'
      git ls-files -z | xargs -0 sed -i 's/\bshow Point;/show Offset;/g'
      
      * Mechanical changes - dartdocs
      
      I applied the following at the root of the Flutter repository:
      
      git ls-files -z | xargs -0 sed -i 's/\ba \[Point\]/an [Offset]/g'
      git ls-files -z | xargs -0 sed -i 's/\[Point\]/[Offset]/g'
      
      * Further improvements and a test
      
      * Fix minor errors from rebasing...
      
      * Roll engine
      bf017b79
  32. 31 Mar, 2017 1 commit
  33. 10 Mar, 2017 2 commits
  34. 04 Mar, 2017 1 commit
  35. 01 Mar, 2017 1 commit
  36. 23 Feb, 2017 1 commit
  37. 21 Feb, 2017 1 commit
  38. 30 Jan, 2017 1 commit
  39. 28 Jan, 2017 1 commit