Skip to content

F
Front-End
Switch branch/tag
  1. 15 Feb, 2023 7 commits
    • LongCatIsLooong's avatar
      Remove deprecated AppBar.color & AppBar.backwardsCompatibility (#120618) · ba46cb8d
      LongCatIsLooong authored
      ba46cb8d
    • Viren Khatri's avatar
      added MaterialStateColor support to TabBarTheme.labelColor (#109541) · 378668db
      Viren Khatri authored
      378668db
    • Ian Hickson's avatar
      Improve network resources doctor check (#120417) · d29668dd
      Ian Hickson authored 
      ...and various other minor cleanup:

* Moved "FLUTTER_STORAGE_BASE_URL" into a constant throughout the code. There are other strings that we should do that to but this one was relevant to the code I was changing.

* Fixed the logger's handling of slow warnings. Previously it deleted too much text. Fixed the test for that to actually verify it entirely, too.

* Made the logger delete the slow warning when it's finished.

* Fixed 'Please choose one (To quit, press "q/Q")' message to be the cleaner 'Please choose one (or "q" to quit)'.

* Added a debug toString to ValidationResult for debugging purposes (not used).

* In http_host_validator:

  - Shortened constant names to be clearer (e.g. kPubDevHttpHost -> kPubDev).
  - Added GitHub as a tested host since when you run `flutter` we hit that immediately.
  - Renamed the check "Network resources".
  - Updated the `slowWarning` of the check to say which hosts are pending.
  - Removed all timeout logic. Timeouts violate our style guide.
  - Removed `int.parse(... ?? '10')`; passing a constant to `int.parse` is inefficient.
  - Replaced the `_HostValidationResult` class with `String?` for simplicity.
  - Improved the error messages to be more detailed.
  - Removed all checks that dependened on the stringification of exceptions. That's very brittle.
  - Added a warning specifically for HandshakeException that talks about the implications (MITM attacks).
  - Replaced exception-message-parsing logic with just calling `Uri.tryParse` and validating the result.
  - Replaced a lot of list-filtering logic with just a single for loop to check the results.
  - Replaced code that added a constant to a known-empty list with just returning a constant list.
  - Revamped the logic for deciding which hosts to check to just use a single chain of if/else blocks instead of getters, lists literals with `if` expressions, `??`, functions, etc spread over multiple places in the code.
      d29668dd
    • godofredoc's avatar
      Move linux-x64-flutter-gtk.zip to linux-x64-debug location. (#120658) · 9d94a51b
      godofredoc authored 
      * Move linux-x64-flutter-gtk.zip to linux-x64-debug location.

linux-x64-flutter-gtk.zip is being uploaded twice to linux-x64-debug
and linux-x64 as part of making a soft transition to use linux-x64-debug
location. This PR starts using the copy inside linux-x64-debug to later
remove the duplicated upload.

* Also move arm64.

* Do not override output dir.
      9d94a51b
    • engine-flutter-autoroll's avatar
      d86089252 Roll Fuchsia Mac SDK from OeUljRQOmJwgDhNOo... to... · fd2fd94e
      engine-flutter-autoroll authored 
      d86089252 Roll Fuchsia Mac SDK from OeUljRQOmJwgDhNOo... to EFcCpAxOuQllDqP0F... (flutter/engine#39621) (#120702)
      fd2fd94e
    • Loïc Sharma's avatar
      Force Mac plugin_test to run on x64 bots (#120714) · 2cfca820
      Loïc Sharma authored
      2cfca820
    • fzyzcjy's avatar
      Fix error when resetting configurations in tear down phase (#114468) · 577ad2ee
      fzyzcjy authored 
      * move _verifyInvariants

* fix

* fix (mimic import test_api.dart)

* fix

* Update binding.dart

* add tests

* try to move

* Revert "try to move"

This reverts commit d3c466d226cc1abe195af83a2630c70f08e25d7d.

* Update binding.dart
      577ad2ee
  3. 14 Feb, 2023 10 commits
  5. 13 Feb, 2023 23 commits

HIAST - GitLab