1. 20 Jan, 2016 1 commit
  2. 19 Jan, 2016 1 commit
  3. 18 Jan, 2016 2 commits
    • Ian Hickson's avatar
      Fix some intrinsic constraints contract violations. · 60d9ab7e
      Ian Hickson authored
      RenderBlock wasn't constraining the results.
      RenderPadding wasn't constraining the results (which matters
      especially when the constraints can't fit the padding in the first
      place).
      RenderViewport wasn't constraining the results.
      
      Add a test for the block case.
      
      To catch this kind of thing in the future, add some asserts to
      debugDoesMeetConstraints() that all four intrinsic functions return
      values that are within the constraints.
      
      RenderBlockViewport doesn't support returning intrinsics, so turn off
      the "no intrinsic support" asserts (and return zero) when we're doing
      this new assert.
      
      This new assert screwed up the custom layout classes' tests, so adjust
      those tests to ignore the callbacks invoked from these asserts.
      
      Add to the _debugReportException() method a short summary of the
      descendants of this node. It's important to have this information when
      debugging errors like these intrinsic constraints contract violations
      because often nodes just pass the values through to their child so you
      have to go several steps down to find the actual problem.
      
      Fixes https://github.com/flutter/flutter/issues/1210
      60d9ab7e
    • Ian Hickson's avatar
      More elaborate RenderBox example · 51566aef
      Ian Hickson authored
      Also, some trivial fixes for things that I found while playing with
      the rendering library directly.
      51566aef
  4. 16 Jan, 2016 1 commit
  5. 15 Jan, 2016 1 commit
  6. 14 Jan, 2016 1 commit
    • Hixie's avatar
      Tooltips · 24cab899
      Hixie authored
      Introduces a new Tooltip class.
      Adds support for tooltips to IconButton and Scaffold.
      Adds some tooltips to various demos.
      
      Also some tweaks to stack.dart that I made before I decided not to go
      down a "CustomPositioned" route.
      24cab899
  7. 13 Jan, 2016 1 commit
    • Adam Barth's avatar
      Handle degenerate transforms better · 192c6e24
      Adam Barth authored
      No you can't hit things inside degenerate transforms. Tranforming from global
      coordaintes to degenerate local coordinates gives you Point.origin. Also,
      upgrade vector_math to get a better invert constructor.
      
      Fixes #1161
      Fixes #1224
      192c6e24
  8. 12 Jan, 2016 5 commits
  9. 11 Jan, 2016 7 commits
    • Adam Barth's avatar
      RenderPerformanceOverlay needs alwaysNeedsCompositing · 00359a4f
      Adam Barth authored
      The performance overlay is always drawn using the compositor. We should tell
      the rest of the system that it's going to make a composited layer.
      
      Fixes #1177
      00359a4f
    • Adam Barth's avatar
      Rename ScrollDirection to Axis · b2cef9f2
      Adam Barth authored
      We use the ScrollDirection for more than just scrolling.
      
      Fixes #151
      b2cef9f2
    • Adam Barth's avatar
      Always using OpacityLayer for blending · 635168d9
      Adam Barth authored
      We don't know how to accuately compute paint bounds in the render tree.
      Instead, we can rely on the compositor to compute the paint bounds for
      us if we use OpacityLayer to do our opacity blends.
      
      Fixes the shadow when closing the menu in the stocks app.
      635168d9
    • Adam Barth's avatar
      Rename RenderObject.hasLayer to isRepaintBoundary · 0b775984
      Adam Barth authored
      Also, introduce alwaysNeedsCompositing to force the "needs compositing"
      bit to true without necessarily introducing a ContainerLayer into the
      layer tree. A future patch will make use of alwaysNeedsCompositing to
      optimize opacity layers.
      0b775984
    • Ian Hickson's avatar
      88c43c3f
    • Ian Hickson's avatar
      Add more debugging options to the stocks app. · 48e1350e
      Ian Hickson authored
      - Add an option to enable debugPaintSizeEnabled.
      - Add an option to enable the StatisticsOverlay.
      - Add support for the StatisticsOverlay in MaterialApp.
      - Change the layout behaviour of RenderStatisticsBox:
         - Give it a zero intrinsic width.
         - Give it an accurate intrinsic height that depends on the flags
           set. (Also, move the enum to the rendering/ layer from the
           widgets/ layer to enable this.)
         - Make the box automatically size itself full-width and the correct
           height, so that you can actually embed it (though most of the
           time you'd just put it in a Stack so this doesn't matter as
           much, really).
      - Some style nit fixes in statistics_box.dart.
      48e1350e
    • Ian Hickson's avatar
      tightenWidth(), tightenHeight() => tighten(width:, height:) · c21b565f
      Ian Hickson authored
      This makes it more consistent with tightFor(), and also makes it
      easier to tighten both directions at once when you're not sure you
      will always do so (e.g. if you have a height and width that might be
      null, and want to tighten whichever ones aren't null).
      c21b565f
  10. 09 Jan, 2016 1 commit
  11. 08 Jan, 2016 2 commits
    • Ian Hickson's avatar
    • Adam Barth's avatar
      Optimize repainting in Scaffold · ee88a685
      Adam Barth authored
      Previously, we triggered a layout (and hence a repaint) when sliding the
      draw because we gave the draw loose constraints. The drawer uses an
      Align to move itself to the proper side of the screen, so it can have
      tight constraints, which makes it a layout boundary.
      
      Also, don't trigger a layout just because the Scaffold rebuilds. There
      isn't any state in the scaffold custom layout, so it doesn't need to
      repaint just because we created a new instance of the delegate.
      
      Finally, add the debugging infrastructure I used to find these issues.
      ee88a685
  12. 07 Jan, 2016 3 commits
  13. 06 Jan, 2016 2 commits
    • Adam Barth's avatar
      Switch PageableList over to using RenderList · e64d93a5
      Adam Barth authored
      This patch moves PageableList off HomogeneousViewport and onto RenderList and
      friends, making it match the new ScrollableList.
      e64d93a5
    • Adam Barth's avatar
      Switch clients of ScrollableList to ScrollableList2 · b1f9138f
      Adam Barth authored
      This patch also changed ScrollableList2 to use an Iterable instead of an
      List for its children. This change lets clients map their underlying
      data lazily. If the clients actually have a concrete list, we skip the
      extra copy and grab the child list directly.
      b1f9138f
  14. 05 Jan, 2016 3 commits
    • Adam Barth's avatar
      Complete features of ScrollableList2 · 37106ea6
      Adam Barth authored
      This patch implements the remaining missing features of ScrollableList2.
      It should now be nearly a drop-in replacement for ScrollableList. The
      next patch will switch callers over to the new machinery.
      37106ea6
    • Adam Barth's avatar
      Remove ScrollDirection.both · 7aa575b0
      Adam Barth authored
      Almost none of the clients of ScrollDirection can handle scrolling in both
      directions.
      
      Fixes #151
      7aa575b0
    • Adam Barth's avatar
      Introduce ScrollableList2 · 99bca282
      Adam Barth authored
      ScrollableList2 uses the same pattern as ScrollableGrid, which requires the
      client to allocate widgets for every list item but doesn't inflate them unless
      they're actually needed for the view. It improves on the original
      ScrollableList by not requiring a rebuild of the whole visible portion of the
      list when scrolling. In fact, small scrolls can often be handled entirely by
      repainting.
      99bca282
  15. 04 Jan, 2016 1 commit
    • Adam Barth's avatar
      Add support for scrollable grids · 6106fa9d
      Adam Barth authored
      We now support (vertically) scrollable grids with viewporting. If the
      scroll doesn't reveal any new rows, we execute the scroll with a repaint
      (i.e., no layout). If the scroll reveals a new row, we trigger a layout
      to change the set of materialized children in the viewport.
      6106fa9d
  16. 02 Jan, 2016 3 commits
    • Adam Barth's avatar
      Generalize grid layout · 46a178dc
      Adam Barth authored
      This patch make grid layout much more flexible. The behavior is factored
      out into a GridDelegate that's modeled after the custom layout
      delegates. The patch includes a MaxTileWidthGridDelegate that implements
      the old behavior and a FixedColumnCountGridDelegate that implements a
      grid layout with a fixed number of columns.
      
      Fixes #1048
      46a178dc
    • Adam Barth's avatar
      RenderBox should use Offset for child offset · e9ac6d30
      Adam Barth authored
      Previously we used Position, which makes it harder to accumulate offsets
      when walking the render tree.
      e9ac6d30
    • Adam Barth's avatar
      ScrollbarPainter exception when scrolling MaterialList · 94843700
      Adam Barth authored
      When assigning a new overlayPainter, we were detaching the old overlay
      painter even if the render object itself wasn't attached. Now we only
      twiddle the attach/detach state of the overlay painter when we're
      attached ourselves.
      
      Fixes #1047
      94843700
  17. 24 Dec, 2015 1 commit
    • Ian Hickson's avatar
      RenderFractionalTranslation · 9bad312a
      Ian Hickson authored
      - Add RenderFractionalTranslation, a render box that does a
        translation based on a FractionalOffset.
      
      - Make FractionalOffset more like Offset
        - dx/dy instead of x/y
        - add /, ~/, %
        - add .zero
      
      - Add alongOffset and alongSize to FractionalOffset so that you can
        easily apply FractionalOffset to Offsets and Sizes. (Better name
        suggestions welcome.)
      
      - Add transformHitTests boolean to RenderTransform (also on
        RenderFractionalTranslation), and to classes based on it.
      
      - Remove the fade from Dismissable. We can add it back using the
        builder-with-child pattern like Draggable if we need it. See #1003
        for tha feature request.
      
      - Rename a bunch of variables in dismissable.dart.
      
      - Change the test for dismissable to not handle leftwards dismisses
        one pixel different from rightwards dismisses, and cleaned up the
        resulting effect on the test (mostly making sure we had the right
        number of pumps, with comments explaining what each one was).
      
      Fixes #174.
      9bad312a
  18. 20 Dec, 2015 1 commit
  19. 17 Dec, 2015 1 commit
    • Hixie's avatar
      Less tree walking for compositing bits updates. · ab01c7bf
      Hixie authored
      Use the same technique for updating compositing bits as layout and
      painting. This avoids walking the entire rendering tree when all you
      need to update is a small subtree.
      ab01c7bf
  20. 16 Dec, 2015 2 commits