1. 20 Mar, 2019 1 commit
    • Alexandre Ardhuin's avatar
      some spaces formatting (#29452) · a6af4228
      Alexandre Ardhuin authored
      * some space formattings
      
      * always use blocks in if-else if a block is used
      
      * format spaces in for and while
      
      * allow multiline if conditions
      
      * fix missing space
      a6af4228
  2. 01 Mar, 2019 1 commit
    • Alexandre Ardhuin's avatar
      Add missing trailing commas (#28673) · 387f8854
      Alexandre Ardhuin authored
      * add trailing commas on list/map/parameters
      
      * add trailing commas on Invocation with nb of arg>1
      
      * add commas for widget containing widgets
      
      * add trailing commas if instantiation contains trailing comma
      
      * revert bad change
      387f8854
  3. 28 Feb, 2019 1 commit
    • Greg Spencer's avatar
      Fix spelling errors. (#28657) · ccdd5057
      Greg Spencer authored
      Fix the spelling errors in the dartdocs for the framework.
      
      There are no functionality changes here, just documentation fixes.
      ccdd5057
  4. 25 Feb, 2019 1 commit
    • jslavitz's avatar
      Breaks the moveBy call from drag and dragFrom into two separate calls and... · 47724f97
      jslavitz authored
      Breaks the moveBy call from drag and dragFrom into two separate calls and changes the default behavior of DragStartBehavior to DragStartBehavior.start (#26438)
      
      * Breaking change which sets the default DragStartBehavior to DragStartBehavior.start and changes WidgetTester.drag and WidgetTester.dragFrom by breaking the moveBy function call into multiple pieces.
      47724f97
  5. 21 Feb, 2019 1 commit
  6. 15 Feb, 2019 2 commits
    • Hans Muller's avatar
    • Greg Spencer's avatar
      Remove remaining "## Sample code" segments, and fix the snippet generator. (#27793) · 262f12b4
      Greg Spencer authored
      This converts all remaining "## Sample code" segments into snippets, and fixes
      the snippet generator to handle multiple snippets in the same dartdoc block
      properly.
      
      I also generated, compiled, and ran each of the existing application samples,
      and fixed them up to be more useful and/or just run without errors.
      
      This PR fixes these problems with examples:
      
      1. Switching tabs in a snippet now works if there is more than one snippet in
         a single dartdoc block.
      2. Generation of snippet code now works if there is more than one snippet.
      3. Contrast of text and links in the code sample block has been improved to
         recommended levels.
      4. Added five new snippet templates, including a "freeform" template to make
         it possible to show examples that need to change the app instantiation.
      5. Fixed several examples to run properly, a couple by adding the "Scaffold"
         widget to the template, a couple by just fixing their code.
      6. Fixed visual look of some of the samples when they run by placing many
         samples inside of a Scaffold.
      7. In order to make it easier to run locally, changed the sample analyzer to
         remove the contents of the supplied temp directory before running, since
         having files that hang around is problematic (only a problem when running
         locally with the `--temp` argument).
      8. Added a `SampleCheckerException` class, and handle sample checking
         exceptions more gracefully.
      9. Deprecated the old "## Sample code" designation, and added enforcement for
         the deprecation.
      10. Removed unnecessary `new` from templates (although they never appeared in
         the samples thanks to dartfmt, but still).
      
      Fixes #26398
      Fixes #27411
      262f12b4
  7. 18 Jan, 2019 1 commit
  8. 17 Jan, 2019 1 commit
  9. 16 Jan, 2019 2 commits
  10. 15 Jan, 2019 1 commit
  11. 09 Jan, 2019 1 commit
  12. 08 Jan, 2019 1 commit
  13. 07 Jan, 2019 1 commit
  14. 04 Jan, 2019 1 commit
  15. 24 Dec, 2018 1 commit
  16. 18 Dec, 2018 1 commit
  17. 12 Nov, 2018 1 commit
  18. 08 Nov, 2018 1 commit
  19. 31 Oct, 2018 1 commit
  20. 16 Oct, 2018 1 commit
  21. 10 Oct, 2018 1 commit
  22. 08 Oct, 2018 1 commit
  23. 04 Oct, 2018 1 commit
  24. 23 Sep, 2018 1 commit
  25. 22 Sep, 2018 1 commit
    • Ian Hickson's avatar
      [H] Cleanup (#21542) · 989cf18b
      Ian Hickson authored
      * Improve documentation and clean up code.
      
      * Remove "Note that".
      
      The phrase "note that" is basically meaningless as a prefix to an
      otherwise fine sentence.
      989cf18b
  26. 12 Sep, 2018 1 commit
  27. 07 Sep, 2018 1 commit
  28. 08 Aug, 2018 1 commit
  29. 07 Aug, 2018 1 commit
  30. 01 Aug, 2018 1 commit
    • jslavitz's avatar
      Drawer fix (#20015) · d2ab29d2
      jslavitz authored
      * Drawer fix
      
      * fixed nits
      
      * fixed nits
      
      * fixed nits
      
      * final change
      
      * Drawer fix final
      d2ab29d2
  31. 24 Jul, 2018 1 commit
    • Jonah Williams's avatar
      Semantics framework updates (#18758) · 810a29d6
      Jonah Williams authored
      Changes:
      
      - Move the SemanticsConfiguration update from RenderToggleable to each subclass, so that Switch can use toggled.
      - Add image, liveRegion, toggled properties to Semantics, SemanticsConfiguration, SemanticsNode
      - Added semanticsLabel and excludeFromSemantics to Image (the latter so that we avoid creating a semantics node)
      - Added onDismiss semantics action which maps to the modal escape on iOS and dismiss action on Android.
      - Added dismiss and liveRegion to snackbar widget
      - Updated custom painter semantics to handle image, liveRegion, toggle
      - Updated relevant tests to use correct flag/action
      810a29d6
  32. 21 Jun, 2018 1 commit
    • amirh's avatar
      Move the notch computation from the FAB to the BAB. (#18372) · c39f2f26
      amirh authored
      Move the notch computation from the FAB to the BAB.
      
      The notch in the BAB (bottom action bar) for the FAB (floating action button) was previously kept as part of the FAB's implementation. This was done to keep the shape of the FAB and the shape of the notch coupled.
      That approach resulted in a somewhat complex and 'non Fluttery' mechanism for propagating the notch computation from the FAB to the BAB.
      
      This CL uncouples the FAB and the notch computation.
      With the new API the BAB computes its overall shape including the notch using a NotchedShape delegate.
      
      This includes multiple breaking changes:
        * Scaffold.setFloatingActionButtonNotchFor is deleted.
        * The ComputeNotch type is deleted.
        * The hasNotch property of BottomAppBar is deleted.
        * The notchMargin property of FloatingActionButton is deleted.
      
      Quick migration guide from the previous API:
      
      | Previous API | New API |
      | ------------------|-------------|
      | BottomAppBar(hasNotch: false) | BottomAppBar() |
      | Using a FloatingActionButton with: BottomAppBar() / BottomAppBar(hasNotch: true) | BottomAppBar(shape: CircularNotchedRectangle()) |
      | Scaffold.setFloatingActionButtonNotchFor(..) | No longer supported |
      c39f2f26
  33. 13 Jun, 2018 1 commit
    • Chris Bracken's avatar
      Revert elimination of Dart 1 (#18460) · 2ae48845
      Chris Bracken authored
      fuchsia_tester.dart still assumes Dart 1. Previously, it ran tests directly
      from source, flutter_platform.dart automatically runs a kernel compile when
      operating in Dart 2 mode, but this assumes a functional Dart SDK is available
      in the artifacts directly, and fuchsia_tester.dart mocks out the artifacts
      directory with an empty temp dir.
      
      Remaining work is:
      1. Get the frontend server building as a dependency on Fuchsia.
      2. Patch fuchsia_tester.dart to use a valid Dart SDK and frontend server.
      
      This also reverts migration to Dart 2 typedef syntax.
      
      This reverts commit 6c56bb24. (#18362)
      This reverts commit 3daebd05. (#18316)
      2ae48845
  34. 12 Jun, 2018 1 commit
  35. 11 Jun, 2018 1 commit
    • Greg Spencer's avatar
      Update typedef syntax to use Function notation and turn on lint for old notation. (#18362) · 6c56bb24
      Greg Spencer authored
      Now that Dart 1 is turned off, reapplying my change to turn on the prefer_generic_function_type_aliases analysis option, and fix all the typedefs to Dart 2 preferred syntax.
      
      Also eliminated the unused analysis_options_repo.yaml file and turned on public_member_api_docs in analysys_options.yaml.
      
      No logic changes, just changing the typedef syntax for all typedefs, and updating analysis options.
      6c56bb24
  36. 05 Jun, 2018 1 commit
  37. 30 May, 2018 2 commits