- 13 Nov, 2015 5 commits
-
-
Adam Barth authored
Parent data not updated when reparenting using global keys
-
Adam Barth authored
When we reactivate a subtree that had a global key, we weren't updating the parent data because: 1) The child wasn't in the tree when we updated the parent data element. 2) The activated child didn't go through mount (just through update). This patch moves the parent data update work to when we attach the render object, which we do both during mount and when reactivating a child. Fixes #345
-
Hans Muller authored
Fix Dialog and PopupMenu completion logic It's now (just) in TransitionRoute. Added smoke tests for showMenu() and showDialog(). Fixes #337
-
Hans Muller authored
-
Devon Carew authored
add a flutter.yaml file for the widgets project
-
- 12 Nov, 2015 27 commits
-
-
Ian Hickson authored
Make the analyzer actually work.
-
Hixie authored
Turns out that ignoring all error lines that match the empty string is a poor way to go. Also, we have to update all the example packages now too, since we analyze them. So just have travis use our update script. Also, remove flutter_tools' old travis stuff. It's now part of a bigger repo. Also, make travis use the dev Dart SDK, since we need the new analyzer. Stable is way too out of date, e.g. it still complains about libraries not having names and mixins using 'super', and the strong mode hints are even more aggressive than on dev.
-
Ian Hickson authored
Delete analyzer temporary directories
-
Devon Carew authored
-
Hixie authored
-
Ian Hickson authored
Remove constructor tear-offs
-
Hixie authored
Some of our workflows have no way to silence analyzer warnings, and the analyzer doesn't yet support constructor tear-offs, so pretend that we can't use them for now.
-
Ian Hickson authored
flutter analyze command
-
Adam Barth authored
ItemBuilder should also get the index of the item
-
Hixie authored
Other changes in this patch: - Make the 'flutter' tool say "Updating flutter tool..." when it calls pub get, to avoid confusion about what the pub get output is about. - Make the bash flutter tool call pub get when the revision has changed. (This was already happening on Windows.) - Fix a raft of bugs found by the analyzer. - Fix some style nits in various bits of code that happened to be near things the analyzer noticed. - Remove the logic in "flutter test" that would run "pub get", since upon further reflexion it was determined it didn't work anyway. We'll probably have to add better diagnostics here and say to run the updater script. - Remove the native velocity tracker script, since it was testing code that has since been removed. Notes on ignored warnings: - We ignore warnings in any packages that are not in the Flutter repo or in the author's current directory. - We ignore various irrelevant Strong Mode warnings. We still enable strong mode because even though it's not really relevant to our needs, it does (more or less accidentally) catch a few things that are helpful to us. - We allow CONSTANTS_LIKE_THIS, since we get some of those from other platforms that we are copying for sanity and consistency. - We allow one-member abstract classes since we have a number of them where it's perfectly reasonable. - We unfortunately still ignore warnings in mojom.dart autogenerated files. We should really fix those but that's a separate patch. - We verify the actual source file when we see the 'Name non-constant identifiers using lowerCamelCase.' lint, to allow one-letter variables that use capital letters (e.g. for physics expressions) and to allow multiple-underscore variable names. - We ignore all errors on lines that contain the following magic incantation and a "#" character: // analyzer doesn't like constructor tear-offs - For all remaining errors, if the line contains a comment of the form // analyzer says "..." ...then we ignore any errors that have that "..." string in them.
-
Adam Barth authored
This seems useful for numbering the entries in the list, for example. Fixes #328
-
Adam Barth authored
Update to a newer sky_engine and sky_services
-
Adam Barth authored
-
Adam Barth authored
Add a `flutter upgrade` command
-
Adam Barth authored
This command upgrades the version of flutter that you're using and runs `pub upgrade` to update the transitive dependencies.
-
Hans Muller authored
showSnackBar() returns a Future, clears its placeholder The returned Future completes after the snack bar has been dismissed. Revised BottomSheet to ensure that its Future only runs after the bottom sheet has been dismissed.
-
Hans Muller authored
TransitionRoute completer is now optional.
-
Devon Carew authored
also listen for flutter in the adb logs
-
Devon Carew authored
update double tap reference
-
Devon Carew authored
-
Devon Carew authored
-
Adam Barth authored
service_registry.dart should use the service registry handle instead of shell handle
-
Adam Barth authored
Fixes assert connecting to Activity service under Linux
-
Ian Hickson authored
Update the interactive_flex example for the new event handlers
-
Jason Simmons authored
-
Alhaad Gokhale authored
shell handle. R=@abarth,@tonygentilcore
-
Jim Beveridge authored
Fixes #313.
-
- 11 Nov, 2015 8 commits
-
-
Hans Muller authored
Add a persistent bottom sheet to the stocks demo
-
Eric Seidel authored
Move data out of Github and into Firebase
-
Hans Muller authored
-
Eric Seidel authored
@abarth @collinjackson
-
Devon Carew authored
Fix adb parse
-
Devon Carew authored
-
Ian Hickson authored
Update to match Hixie's changed bash script
-