Skip to content

F
Front-End
Switch branch/tag
  1. 28 Sep, 2023 25 commits
  3. 27 Sep, 2023 12 commits
  5. 26 Sep, 2023 3 commits
    • Christopher Fujino's avatar
      [flutter_tools] fix tests with no native assets running native asset build (#135474) · 851497ff
      Christopher Fujino authored 
      Fixes https://github.com/flutter/flutter/issues/135461
      851497ff
    • Kate Lovett's avatar
      Allow multiple ParentDataWidgets to write to ParentData (#133581) · 67d4a831
      Kate Lovett authored 
      Fixes https://github.com/flutter/flutter/issues/133089

This allows more than one ParentDataWidget to write to the ParentData of a child render object. Previously only one was allowed. There are some rules though:
1. Only one of a given type of `ParentDataWidget` can write to the `ParentData` of a given child.
  a. For example, 2 `Positioned` widgets wrapping a child of a `Stack` would not be allowed, as only one of type `Positioned` can contribute data.

2. The type of `ParentData` **must** be compatible with all of the `ParentDataWidget`s that want to contribute data.
  a. For example, `TwoDimensionalViewportParentData` mixes in the `KeepAliveParentDataMixin`. So the `ParentData` of a given child would be compatible with the `KeepAlive` `ParentDataWidget`, as well as another `ParentDataWidget` that writes `TwoDimensionalViewportParentData` (or a subclass of `TwoDimensionalViewportParentData` - This was the motivation for this change, where a `ParentDataWidget` is being used in `TableView` with the parent data type being a subclass of `TwoDimensionalViewportParentData`.)
      67d4a831
    • Renzo Olivares's avatar
      SelectionArea long press selection overlay behavior should match native (#133967) · d81c8aa8
      Renzo Olivares authored 
      During a long press, on native iOS the context menu does not show until the long press has ended. The handles are shown immediately when the long press begins. This is true for static and editable text.

For static text on Android, the context menu appears when the long press is initiated, but the handles do not appear until the long press has ended. For editable text on Android, the context menu does not appear until the long press ended, and the handles also do not appear until the end.

For both platforms in editable/static contexts the context menu does not show while doing a long press drag.

I think the behavior where the context menu is not shown until the long press ends makes the most sense even though Android varies in this depending on the context. The user is not able to react to the context menu until the long press has ended.

Other details:
On a windows touch screen device the context menu does not show up until the long press ends in editable/static text contexts. On a long press hold it selects the word on drag start as well as popping up the selection handles (static text).
      d81c8aa8

HIAST - GitLab