Commits · b51859ec330317c1468a78cb098d8920094089e3 · abdullh.alsoleman / Front-End

31 Aug, 2023 26 commits

Add benchmark for scrolling very long pictures (#133434) · b51859ec

Jim Graham authored Aug 31, 2023

This benchmark will track the performance of the RTree implementation to cull very large pictures down to just the portion visible on the screen.

b51859ec

Roll Flutter Engine from e8de3dd63d47 to 51090e3cfe79 (2 revisions) (#133784) · 82ded603

engine-flutter-autoroll authored Aug 31, 2023

https://github.com/flutter/engine/compare/e8de3dd63d47...51090e3cfe79

2023-08-31 skia-flutter-autoroll@skia.org Roll Skia from a295ff96782a to d113402de2ce (1 revision) (flutter/engine#45324)
2023-08-31 skia-flutter-autoroll@skia.org Roll Skia from a13a9d6efbbc to a295ff96782a (2 revisions) (flutter/engine#45321)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

82ded603

Test cover more tests with leak tracking. (#133712) · 127b90e1
Polina Cherkasova authored Aug 31, 2023

127b90e1
_FocusTraversalGroupNode should communicate creation in constructor. (#133717) · c1256d53
Polina Cherkasova authored Aug 31, 2023

c1256d53
_ResetNotifier should communicate creation in constructor. (#133716) · 54402ae3
Polina Cherkasova authored Aug 31, 2023

54402ae3

Tweaking CSS to make object docs more legible. (#133711) · a14989b3

yusuf-goog authored Aug 31, 2023

Bug:None

*Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.*

*List which issues are fixed by this PR. You must list at least one issue.*

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

a14989b3

Revert "Cover some test/widgets tests with leak tracking" (#133779) · c57e4e79
Victoria Ashworth authored Aug 31, 2023
```
Reverts flutter/flutter#133767

Causing failures to Mac framework_tests_widgets and Linux framework_tests_widgets
```
c57e4e79

[Windows] Add target architecture to build path (#131843) · 792e26df

Pierrick Bouvier authored Aug 31, 2023

To implement windows-arm64 support, it is needed to add architecture as a subdirectory (https://github.com/flutter/flutter/issues/129805).

In short, when performing a flutter windows build, we have:
- Before: build/windows/runner/Release/gallery.exe
- After: build/windows/x64/runner/Release/gallery.exe

This convention follows what flutter linux build does.

Addresses: https://github.com/flutter/flutter/issues/129805
Addresses: https://github.com/flutter/flutter/issues/116196

Design doc: [flutter.dev/go/windows-arm64](https://flutter.dev/go/windows-arm64)

792e26df

Cover some test/widgets tests with leak tracking (#133767) · be06151e
Kostia Sokolovskyi authored Aug 31, 2023

be06151e
ScrollController creation dispatching for memory leaks tracking (#133759) · 414bff14
Kostia Sokolovskyi authored Aug 31, 2023

414bff14

Roll Flutter Engine from 1809b05a37a3 to e8de3dd63d47 (1 revision) (#133766) · 7fe4571a

engine-flutter-autoroll authored Aug 31, 2023

https://github.com/flutter/engine/compare/1809b05a37a3...e8de3dd63d47

2023-08-31 skia-flutter-autoroll@skia.org Roll Skia from 47a7d27ceb93 to a13a9d6efbbc (2 revisions) (flutter/engine#45319)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

7fe4571a

Roll Packages from 64af59e00bb7 to e7d812cefce0 (6 revisions) (#133765) · 28ec737d

engine-flutter-autoroll authored Aug 31, 2023

https://github.com/flutter/packages/compare/64af59e00bb7...e7d812cefce0

2023-08-30 50271102+talhakhan1297@users.noreply.github.com [path_provider] Fix93198: Added getDownloadsDirectory() for Android (flutter/packages#4708)
2023-08-30 stuartmorgan@google.com [in_app_purchase] Minor lint cleanup (flutter/packages#4818)
2023-08-30 tarrinneal@gmail.com [local_auth] Update to pigeon 11 and remove enum wrappers (flutter/packages#4809)
2023-08-30 vital@hey.com [image_picker] Fix link in README file. (flutter/packages#4775)
2023-08-30 mouad.debbar@gmail.com [web] Use new APIs from `dart:ui_web` (flutter/packages#4168)
2023-08-30 engine-flutter-autoroll@skia.org Roll Flutter from 6c957373 to 1fe24956 (24 revisions) (flutter/packages#4817)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

28ec737d

Roll Flutter Engine from 772d5e996af8 to 1809b05a37a3 (1 revision) (#133762) · 5a2b8dc4

engine-flutter-autoroll authored Aug 31, 2023

https://github.com/flutter/engine/compare/772d5e996af8...1809b05a37a3

2023-08-31 skia-flutter-autoroll@skia.org Roll Skia from 1fae612aee7d to 47a7d27ceb93 (1 revision) (flutter/engine#45318)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

5a2b8dc4

Ignore macOS Cocoapods linting failure on DT_TOOLCHAIN_DIR error (#133588) · c175cf87

Victoria Ashworth authored Aug 31, 2023

Xcode 15 introduced an [error](https://github.com/flutter/flutter/issues/132755) into Cocoapods when building macOS apps. 

When `pod lib lint` runs, it under the covers is building the app with `xcodebuild`, which is why this error occurs when linting.

A fix has been made in Cocoapods, but is not in an official release so we can't upgrade Cocoapods yet. This is to temporarily ignore lint failure due to that error.

Fixes https://github.com/flutter/flutter/issues/132980.

Tracking issue to upgrade Cocoapods when fix is in a release: https://github.com/flutter/flutter/issues/133584

Since Xcode 15 isn't in CI, I tested it in a one-off led test:
* [Pre-fix failure](https://chromium-swarm.appspot.com/task?id=6431f228ecf98e10)
* [Post-fix success](https://chromium-swarm.appspot.com/task?id=645ba7ebdab97210)

c175cf87

`InputDecorationTheme.isCollapsed` doesn't work if... · dd1ee24f

Delwin Mathew authored Aug 31, 2023

`InputDecorationTheme.isCollapsed` doesn't work if `InputDecoration.isCollapsed` is not provided. (#133189)

`appleDefault` method didn't include setting values for non-null (here `isCollapsed`) parameters initially, which has been updated and documented in this commit.

Existing and new tests are passing.

Fixes #133144

dd1ee24f

Roll Flutter Engine from 5156c03344eb to 772d5e996af8 (1 revision) (#133752) · 9e9aa810

engine-flutter-autoroll authored Aug 31, 2023

https://github.com/flutter/engine/compare/5156c03344eb...772d5e996af8

2023-08-31 skia-flutter-autoroll@skia.org Roll Skia from 5f17219305ff to 1fae612aee7d (1 revision) (flutter/engine#45317)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

9e9aa810

Roll Flutter Engine from 1917fa95ea55 to 5156c03344eb (2 revisions) (#133745) · 5e16d2ca

engine-flutter-autoroll authored Aug 31, 2023

https://github.com/flutter/engine/compare/1917fa95ea55...5156c03344eb

2023-08-31 skia-flutter-autoroll@skia.org Roll Skia from 676a16152834 to 5f17219305ff (1 revision) (flutter/engine#45316)
2023-08-31 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from gWpPuUyuR_hmz9Xmg... to 7sFO_YvenNXCm6TdK... (flutter/engine#45315)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from gWpPuUyuR_hm to 7sFO_YvenNXC

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

5e16d2ca

Roll Flutter Engine from 1f1071d3f5ba to 1917fa95ea55 (2 revisions) (#133739) · 0700801e

engine-flutter-autoroll authored Aug 31, 2023

https://github.com/flutter/engine/compare/1f1071d3f5ba...1917fa95ea55

2023-08-31 skia-flutter-autoroll@skia.org Roll Skia from adaad6716b2c to 676a16152834 (1 revision) (flutter/engine#45314)
2023-08-31 matej.knopp@gmail.com [macOS] Implement unobstructed platform views (flutter/engine#42960)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

0700801e

Roll Flutter Engine from e88b21b6d4e8 to 1f1071d3f5ba (1 revision) (#133737) · 5603935d

engine-flutter-autoroll authored Aug 31, 2023

https://github.com/flutter/engine/compare/e88b21b6d4e8...1f1071d3f5ba

2023-08-31 skia-flutter-autoroll@skia.org Roll Skia from af7fb958e7f7 to adaad6716b2c (1 revision) (flutter/engine#45312)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

5603935d

Roll Flutter Engine from 0559a733c888 to e88b21b6d4e8 (1 revision) (#133735) · dd51bf09

engine-flutter-autoroll authored Aug 31, 2023

https://github.com/flutter/engine/compare/0559a733c888...e88b21b6d4e8

2023-08-31 skia-flutter-autoroll@skia.org Roll Skia from 5f3ef5363dbd to af7fb958e7f7 (1 revision) (flutter/engine#45311)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

dd51bf09

Roll Flutter Engine from 3b75e3de7ef3 to 0559a733c888 (1 revision) (#133734) · cfdb91bf

engine-flutter-autoroll authored Aug 31, 2023

https://github.com/flutter/engine/compare/3b75e3de7ef3...0559a733c888

2023-08-31 jonahwilliams@google.com [Impeller] CoverGeometry transforms its bounds. (flutter/engine#45308)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

cfdb91bf

[framework] use ImageFilter for stretch overscroll. (#133613) · a0862f1c

Jonah Williams authored Aug 31, 2023

Rather than changing the size of the child elements (relaying out text
and potentially changing glyph shape and position due to pixel
snapping), apply the stretch effect as a compositing effect - render the
children to a texture and stretch the texture. If we end up using an
image shader to apply an custom shader we'll need to do this anyway.

Fixes https://github.com/flutter/flutter/issues/129528

### Before


https://github.com/flutter/flutter/assets/8975114/16e9eb57-f864-4093-b4a4-461082b89b43

### After


https://github.com/flutter/flutter/assets/8975114/14cf0167-8922-4876-a325-e3bc154b084f

a0862f1c

Roll Flutter Engine from 73e86369614d to 3b75e3de7ef3 (2 revisions) (#133724) · 5296f846

engine-flutter-autoroll authored Aug 31, 2023

https://github.com/flutter/engine/compare/73e86369614d...3b75e3de7ef3

2023-08-31 dnfield@google.com [Impeller] Reland DlAiksCanvas
(flutter/engine#45232)
2023-08-31 matanlurey@users.noreply.github.com Add a
build_bucket_golden_scraper tool. (flutter/engine#45243)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the
revert to ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

5296f846

Roll Flutter Engine from 8f1b77b1ac69 to 73e86369614d (1 revision) (#133720) · 2434a9d9

engine-flutter-autoroll authored Aug 31, 2023

https://github.com/flutter/engine/compare/8f1b77b1ac69...73e86369614d

2023-08-30 matanlurey@users.noreply.github.com Add a `DlStopwatchVisualizer` and conditionally use it for Impeller (flutter/engine#45259)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

2434a9d9

Roll Flutter Engine from d37cef84d40d to 8f1b77b1ac69 (1 revision) (#133714) · 4b0bbe90

engine-flutter-autoroll authored Aug 31, 2023

https://github.com/flutter/engine/compare/d37cef84d40d...8f1b77b1ac69

2023-08-30 skia-flutter-autoroll@skia.org Roll Skia from 185fbe1a264d to 5f3ef5363dbd (9 revisions) (flutter/engine#45305)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

4b0bbe90

Mark leak in _DraggableScrollableSheetState. (#133693) · be3e64ab
Polina Cherkasova authored Aug 31, 2023

be3e64ab

30 Aug, 2023 14 commits

Mark routing test as leaking. (#133697) · 2bc4c7a8
Polina Cherkasova authored Aug 30, 2023

2bc4c7a8

Roll Flutter Engine from b63eee2e31cc to d37cef84d40d (3 revisions) (#133706) · 784629c9

engine-flutter-autoroll authored Aug 30, 2023

https://github.com/flutter/engine/compare/b63eee2e31cc...d37cef84d40d

2023-08-30 jacksongardner@google.com [web] Roll to most recent fallback font data (flutter/engine#45301)
2023-08-30 matanlurey@users.noreply.github.com Increase maximum length of function names from 30 to 60. (flutter/engine#45296)
2023-08-30 jacksongardner@google.com Add an API in `ui_web` to create a `ui.Image` from an `ImageBitmap` (flutter/engine#45256)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

784629c9

_RawAutocompleteState should dispose _highlightedOptionIndex. (#133700) · 95e197ba
Polina Cherkasova authored Aug 30, 2023

95e197ba

Forward-fix a test that will break with an engine roll. (#133619) · 31600c82

Matan Lurey authored Aug 30, 2023

See https://github.com/flutter/engine/pull/44705 where it fails a framework smoke test.

Partial work towards https://github.com/flutter/flutter/issues/112498.

31600c82

Fix `cancelButtonStyle` & `confirmButtonStyle` properties from... · d7a3a682

Taha Tesser authored Aug 30, 2023

Fix `cancelButtonStyle` & `confirmButtonStyle` properties  from `TimePickerTheme`  aren't working (#132843)

fixes [`TimePickerThemeData` action buttons styles aren't working](https://github.com/flutter/flutter/issues/132760)

### Code sample

<details> 
<summary>expand to view the code sample</summary> 

```dart
import 'package:flutter/material.dart';

void main() => runApp(const MyApp());

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      debugShowCheckedModeBanner: false,
      theme: ThemeData(
        useMaterial3: true,
        timePickerTheme: TimePickerThemeData(
          cancelButtonStyle: TextButton.styleFrom(
            shape: const RoundedRectangleBorder(
              borderRadius: BorderRadius.all(Radius.circular(4)),
              side: BorderSide(color: Colors.red),
            ),
            backgroundColor: Colors.white,
            foregroundColor: Colors.red,
            elevation: 3,
            shadowColor: Colors.red,
          ),
          confirmButtonStyle: TextButton.styleFrom(
            shape: const RoundedRectangleBorder(
              borderRadius: BorderRadius.all(Radius.circular(4)),
            ),
            backgroundColor: Colors.green[700],
            foregroundColor: Colors.white,
            elevation: 3,
            shadowColor: Colors.green[700],
          ),
        ),
      ),
      home: const Example(),
    );
  }
}

class Example extends StatelessWidget {
  const Example({super.key});

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      body: Center(
        child: TimePickerDialog(initialTime: TimeOfDay.now()),
      ),
    );
  }
}

``` 

</details>

### Before (action buttons don't use the style from the `TimePickerTheme`)

![Screenshot 2023-08-18 at 14 57 37](https://github.com/flutter/flutter/assets/48603081/c95160e2-76a2-4bb5-84e0-3731fce19c0b)

### After (action buttons use the style from the `TimePickerTheme`)

![Screenshot 2023-08-18 at 14 57 18](https://github.com/flutter/flutter/assets/48603081/422d348a-bee2-4696-8d9a-5fce56191aaa)

d7a3a682

Updated DropdownMenu example and added a test (#133592) · 336d60d2
Hans Muller authored Aug 30, 2023

336d60d2

Add `cancelButtonStyle` & `confirmButtonStyle` to the `DatePickerThemeData` (#132847) · 1e770c38

Taha Tesser authored Aug 30, 2023

fixes [Unable to adjust the color for "Cancel" and "Ok" button in datePicker dialog](https://github.com/flutter/flutter/issues/127739)

### Code sample

<details> 
<summary>expand to view the code sample</summary> 

```dart
import 'package:flutter/material.dart';

void main() => runApp(const MyApp());

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      debugShowCheckedModeBanner: false,
      theme: ThemeData(
        useMaterial3: true,
        datePickerTheme: DatePickerThemeData(
          cancelButtonStyle: TextButton.styleFrom(
            shape: const RoundedRectangleBorder(
              borderRadius: BorderRadius.all(Radius.circular(16)),
              side: BorderSide(color: Colors.red),
            ),
            backgroundColor: Colors.white,
            foregroundColor: Colors.red,
            elevation: 3,
            shadowColor: Colors.red,
          ),
          confirmButtonStyle: TextButton.styleFrom(
            shape: const RoundedRectangleBorder(
              borderRadius: BorderRadius.all(Radius.circular(16)),
            ),
            backgroundColor: Colors.green[700],
            foregroundColor: Colors.white,
            elevation: 3,
            shadowColor: Colors.green[700],
          ),
        ),
      ),
      home: const Example(),
    );
  }
}

class Example extends StatelessWidget {
  const Example({super.key});

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      body: Center(
        child: DatePickerDialog(
          initialDate: DateTime.now(),
          firstDate: DateTime(2020),
          lastDate: DateTime(2030),
        ),
      ),
    );
  }
}
``` 

</details>

### Before 

Not possible to customize action buttons from the `DatePickerThemeData`.

### After 

![Screenshot 2023-08-18 at 16 42 00](https://github.com/flutter/flutter/assets/48603081/4ec01e93-c661-491d-9253-d687da8b76f3)

1e770c38

Roll Flutter Engine from 31d5662dcb53 to b63eee2e31cc (1 revision) (#133692) · 2f2a10d5

engine-flutter-autoroll authored Aug 30, 2023

https://github.com/flutter/engine/compare/31d5662dcb53...b63eee2e31cc

2023-08-30 jason-simmons@users.noreply.github.com [Impeller] Reorganize the glyph atlas to improve efficiency when looking up runs of glyphs in the same font (flutter/engine#45191)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

2f2a10d5

Fixing memory leak in EditableTextState (#131377) · 4b89fce1
Renzo Olivares authored Aug 30, 2023

4b89fce1

Roll Flutter Engine from 69f04bdfe952 to 31d5662dcb53 (14 revisions) (#133683) · d1410a11

engine-flutter-autoroll authored Aug 30, 2023

https://github.com/flutter/engine/compare/69f04bdfe952...31d5662dcb53

2023-08-30 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from Y2xfuZM0ec5GQfHV8... to gWpPuUyuR_hmz9Xmg... (flutter/engine#45287)
2023-08-30 skia-flutter-autoroll@skia.org Roll Skia from 7a246c9eb086 to 185fbe1a264d (3 revisions) (flutter/engine#45289)
2023-08-30 30870216+gaaclarke@users.noreply.github.com Revert "Roll Dart SDK from 0cea73a8d3c3 to 96d3a79547fc" (flutter/engine#45285)
2023-08-30 skia-flutter-autoroll@skia.org Roll Skia from 3489b6d1d613 to 7a246c9eb086 (4 revisions) (flutter/engine#45286)
2023-08-30 skia-flutter-autoroll@skia.org Roll Skia from a58ccf8ae398 to 3489b6d1d613 (2 revisions) (flutter/engine#45283)
2023-08-30 skia-flutter-autoroll@skia.org Roll Skia from 6f4fd97d2f7e to a58ccf8ae398 (1 revision) (flutter/engine#45280)
2023-08-30 skia-flutter-autoroll@skia.org Roll Skia from a2728a7ad2a3 to 6f4fd97d2f7e (2 revisions) (flutter/engine#45278)
2023-08-30 skia-flutter-autoroll@skia.org Roll Skia from 7492e29ad235 to a2728a7ad2a3 (1 revision) (flutter/engine#45273)
2023-08-30 skia-flutter-autoroll@skia.org Roll Skia from 80f4d2f303d0 to 7492e29ad235 (1 revision) (flutter/engine#45272)
2023-08-30 skia-flutter-autoroll@skia.org Roll Skia from 03289b20b5d3 to 80f4d2f303d0 (1 revision) (flutter/engine#45270)
2023-08-30 skia-flutter-autoroll@skia.org Roll Dart SDK from 96d3a79547fc to 4352efd8497d (1 revision) (flutter/engine#45267)
2023-08-30 skia-flutter-autoroll@skia.org Roll Skia from fde9fe141863 to 03289b20b5d3 (1 revision) (flutter/engine#45268)
2023-08-30 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from QKekosWnIY_ObKstn... to Y2xfuZM0ec5GQfHV8... (flutter/engine#45265)
2023-08-30 skia-flutter-autoroll@skia.org Roll Dart SDK from 0cea73a8d3c3 to 96d3a79547fc (1 revision) (flutter/engine#45262)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from QKekosWnIY_O to gWpPuUyuR_hm

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

d1410a11

Expose barrierDismissible in PageRoute constructor (#133659) · b2310527

Bruno Leroux authored Aug 30, 2023

## Description

This PR exposes `barrierDismissible` in `PageRoute`, `MaterialPageRoute` and `CupertinoPageRoute` constructors.
Setting this property to true will enable the escape key binding.

## Related Issue

Fixes https://github.com/flutter/flutter/issues/132138.

## Tests

Adds one test.

b2310527

Update the infrastructure issue template (#133519) · 15048a6b

Ricardo Amador authored Aug 30, 2023

*Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.*

*List which issues are fixed by this PR. You must list at least one issue.*

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

15048a6b

Reland "Remove ImageProvider.load, DecoderCallback and... · 7f3abea3

LongCatIsLooong authored Aug 30, 2023

Reland "Remove ImageProvider.load, DecoderCallback and `PaintingBinding.instantiateImageCodec` (#132679) (reverted in #133482) (#133605)

Relanding the commit per
https://github.com/flutter/flutter/pull/133482#issuecomment-1698030976

## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat

7f3abea3

Roll Packages from d7d3150e5966 to 64af59e00bb7 (4 revisions) (#133675) · d49eb4af

engine-flutter-autoroll authored Aug 30, 2023

https://github.com/flutter/packages/compare/d7d3150e5966...64af59e00bb7

2023-08-30 katelovett@google.com [two_dimensional_scrollables] Fix repaint boundary override in builder delegate (flutter/packages#4814)
2023-08-29 stuartmorgan@google.com [all] Add topics to pubspecs (flutter/packages#4771)
2023-08-29 engine-flutter-autoroll@skia.org Roll Flutter from ec387a46 to 6c957373 (24 revisions) (flutter/packages#4813)
2023-08-29 panuj330@gmail.com Fixed AlertDialog Height of example in image_picker (flutter/packages#4800)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

d49eb4af