- 20 Feb, 2024 1 commit
-
-
Qun Cheng authored
This PR is to introduce 19 new color roles and deprecate 3 color roles in `ColorScheme`. **Tone-based surface colors** (7 colors): * surfaceBright * surfaceDim * surfaceContainer * surfaceContainerLowest * surfaceContainerLow * surfaceContainerHigh * surfaceContainerHighest **Accent color add-ons** (12 colors): * primary/secondary/tertiary-Fixed * primary/secondary/tertiary-FixedDim * onPrimary/onSecondary/onTertiary-Fixed * onPrimary/onSecondary/onTertiary-FixedVariant **Deprecated colors**: * background -> replaced with surface * onBackground -> replaced with onSurface * surfaceVariant -> replaced with surfaceContainerHighest Please checkout this [design doc](https://docs.google.com/document/d/1ODqivpM_6c490T4j5XIiWCDKo5YqHy78YEFqDm4S8h4/edit?usp=sharing) for more information:) ![Screenshot 2024-01-08 at 4 56 51â¯PM](https://github.com/flutter/flutter/assets/36861262/353cdb4c-6ba9-4435-a518-fd3f67e415f0)
-
- 19 Jan, 2024 1 commit
-
-
Qun Cheng authored
-
- 14 Dec, 2023 1 commit
-
-
hgraceb authored
## Description Similar to #119877, but with more cases that I could find in `packages/flutter`. Although there is already a [proposal](https://github.com/dart-lang/linter/issues/4102), it is uncertain how long it will take to be implemented. ![[image-20200711205959042](https://user-images.githubusercontent.com/72788825/216486897-b56453d2-b309-47ea-885b-b0ec6ed1b648.png)](https://user-images.githubusercontent.com/72788825/216486897-b56453d2-b309-47ea-885b-b0ec6ed1b648.png)
-
- 03 Nov, 2023 1 commit
-
-
Michael Goderbauer authored
Fixes https://github.com/flutter/flutter/issues/137424. The generic type argument was unused.
-
- 09 Oct, 2023 1 commit
-
-
Bruno Leroux authored
This PR updates unit tests from bottom sheet tests for M3 migration. More info in https://github.com/flutter/flutter/issues/127064 It also contains in bottom_sheet.dart where a default value took precedence over a theme attribute.
-
- 07 Oct, 2023 1 commit
-
-
Chris Bobbe authored
As discussed at https://github.com/flutter/flutter/pull/122225#issuecomment-1690729628, this is a docs change meant to help people in the absence of a fix for #121752, which is being closed as WONTFIX.
-
- 20 Sep, 2023 2 commits
-
-
Michael Goderbauer authored
Avoids that dynamic accidentally sneaks in, see https://dart.dev/tools/analysis#enabling-additional-type-checks
-
Greg Spencer authored
## Description This removes all of the comments that are of the form "so-and-so (must not be null|can ?not be null|must be non-null)" from the cases where those values are defines as non-nullable values. This PR removes them from the material library. This was done by hand, since it really didn't lend itself to scripting, so it needs to be more than just spot-checked, I think. I was careful to leave any comment that referred to parameters that were nullable, but I may have missed some. In addition to being no longer relevant after null safety has been made the default, these comments were largely fragile, in that it was easy for them to get out of date, and not be accurate anymore anyhow. This did create a number of constructor comments which basically say "Creates a [Foo].", but I don't really know how to avoid that in a large scale change, since there's not much you can really say in a lot of cases. I think we might consider some leniency for constructors to the "Comment must be meaningful" style guidance (which we de facto have already, since there are a bunch of these). ## Related PRs - https://github.com/flutter/flutter/pull/134984 - https://github.com/flutter/flutter/pull/134992 - https://github.com/flutter/flutter/pull/134993 - https://github.com/flutter/flutter/pull/134994 ## Tests - Documentation only change.
-
- 29 Aug, 2023 1 commit
-
-
Polina Cherkasova authored
-
- 28 Jul, 2023 1 commit
-
-
Taha Tesser authored
Update `BottomSheet.enableDrag` & `BottomSheet.showDragHandle` docs for animation controller (#131484) fixes [`AnimationController` must be provided when `BottomSheet.enableDrag` or `BottomSheet.showDragHandle` is true](https://github.com/flutter/flutter/issues/127093)
-
- 25 Jul, 2023 1 commit
-
-
Alex Li authored
Adding the `scrollControlDisabledMaxHeightRatio` parameter for modal bottom sheet widgets, and using the default value `9.0 / 16.0` to avoid breaking. Resolves #129690.
-
- 09 Jun, 2023 1 commit
-
-
Pierre-Louis authored
## Description This improves defaults generation with logging, stats, and token validation. This PR includes these changes: * introduce `TokenLogger`, with a verbose mode * prints versions and tokens usage to the console * outputs `generated/used_tokens.csv`, a list of all used tokens, for use by Google * find token files in `data` automatically * hide tokens `Map` * tokens can be obtained using existing resolvers (e.g. `color`, `shape`), or directly through `getToken`. * tokens can be checked for existence with `tokenAvailable` * remove version from template, since the tokens are aggregated and multiple versions are possible (as is the case currently), it does not make sense to attribute a single version * improve documentation ## Related Issues - Fixes https://github.com/flutter/flutter/issues/122602 ## Tests - Added tests for `TokenLogger` - Regenerated tokens, no-op except version removal ## Future work A future PR should replace or remove the following invalid tokens usages <img width="578" alt="image" src="https://github.com/flutter/flutter/assets/6655696/b6f9e5a7-523f-4f72-94f9-1b0bf4cc9f00">
-
- 31 May, 2023 1 commit
-
-
Renzo Olivares authored
This fixes an issue where the bottom sheet would rebuild when `enableDrag` is set to true on every tap. This is because `DragGestureRecognizer` would win the arena by default and dispatch the `drag` callbacks (in `acceptGesture`) even though it had not met the drag threshold. This changes keep the default behavior of `DragGestureRecognizer` the same, but adds a parameter `onlyAcceptDragOnThreshold` that a user can use to stop drag callbacks from being fired when the drag threshold has not been met. Fixes #126833
-
- 23 May, 2023 1 commit
-
-
NikolajHarderNota authored
Adds barrierLabel as optional param in showModalBottomSheet Fixes #83180
-
- 22 May, 2023 1 commit
-
-
Daniel Iglesia authored
Support keeping a bottom sheet with a DraggableScrollableSheet from closing on drag/fling to min extent (#127339)
-
- 15 May, 2023 1 commit
-
-
Tomasz Gucio authored
-
- 27 Apr, 2023 1 commit
-
-
Pierre-Louis authored
This PR constrains M3 bottom sheets to 640dp max width by default. `constraints` can be used to provide different `minWidth` and `maxWidth`. This is not a breaking change per the breaking change policy. Part of https://github.com/flutter/flutter/issues/118619 Part of https://github.com/flutter/flutter/issues/111448 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [Features we expect every widget to implement]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat
-
- 28 Mar, 2023 1 commit
-
-
Qun Cheng authored
-
- 19 Mar, 2023 1 commit
-
-
hangyu authored
* M3 bottomsheet * Update bottom_sheet.dart * Update bottom_sheet.dart * Update bottom_sheet.dart * Update bottom_sheet.dart * Update bottom_sheet.dart * Update bottom_sheet.dart * Update bottom_sheet.dart * Update bottom_sheet.dart * Update bottom_sheet.dart * Update bottom_sheet.dart * Update packages/flutter/lib/src/material/bottom_sheet.dart Co-authored-by: Pierre-Louis <6655696+guidezpl@users.noreply.github.com> * Update packages/flutter/lib/src/material/bottom_sheet.dart Co-authored-by: Pierre-Louis <6655696+guidezpl@users.noreply.github.com> * Update packages/flutter/lib/src/material/bottom_sheet.dart Co-authored-by: Pierre-Louis <6655696+guidezpl@users.noreply.github.com> * Update packages/flutter/lib/src/material/bottom_sheet.dart Co-authored-by: Pierre-Louis <6655696+guidezpl@users.noreply.github.com> * Update packages/flutter/lib/src/material/bottom_sheet.dart Co-authored-by: Pierre-Louis <6655696+guidezpl@users.noreply.github.com> * Update packages/flutter/lib/src/material/bottom_sheet.dart Co-authored-by: Pierre-Louis <6655696+guidezpl@users.noreply.github.com> * Update bottom_sheet.dart Update bottom_sheet_test.dart Update bottom_sheet.dart * showDragHandle defaults to false * fix test --------- Co-authored-by: Pierre-Louis <6655696+guidezpl@users.noreply.github.com>
-
- 14 Mar, 2023 1 commit
-
-
Taha Tesser authored
Cleanup M3 token templates for theme lookups
-
- 13 Mar, 2023 1 commit
-
-
Pierre-Louis authored
Update Material tokens to 0.162
-
- 08 Mar, 2023 1 commit
-
-
Chris Bobbe authored
ModalBottomSheetRoute: Remove gap at screen bottom with `useSafeArea: true`
-
- 06 Mar, 2023 1 commit
-
-
Eilidh Southren authored
* add shadowColor property * add to bottom app bar * add test * update m2/m3 diffs * reorder debug test * finalize * remove crswap * update doc comments * add m2 shadow back * add const * update docs * update docs * comment replies * make param non-null * indentation fix * doc fix
-
- 24 Feb, 2023 1 commit
-
-
Bruno Leroux authored
Remove accessibleNavigation reference from BottomSheet
-
- 11 Feb, 2023 1 commit
-
-
Casey Hillers authored
This reverts commit 0a97ef85.
-
- 08 Feb, 2023 1 commit
-
-
Eilidh Southren authored
* remove m3 shadows * fix * fix that test over there
-
- 07 Feb, 2023 1 commit
-
-
Qun Cheng authored
* Update to v0.158 of the token database. * Update checkbox template * Fix DatePickerTheme test --------- Co-authored-by: Qun Cheng <quncheng@google.com>
-
- 24 Jan, 2023 1 commit
-
-
Michael Goderbauer authored
* dart fix --apply * manual fixes
-
- 17 Jan, 2023 1 commit
-
-
Darren Austin authored
-
- 03 Jan, 2023 1 commit
-
-
Darren Austin authored
* Updated to tokens v0.150. * Updated with a reverted list_tile.dart.
-
- 20 Dec, 2022 2 commits
-
-
Ondrej Simek authored
-
harperl-lgtm authored
* Implemented Scrim Focus for BottomSheet so that assistive technology users can focus and tap on the scrim to close the BottomSheet, which they could not do before the change . The Scrim Focus's size changes to avoid overlapping the BottomSheet.
-
- 09 Dec, 2022 1 commit
-
-
Callum Moffat authored
-
- 30 Nov, 2022 1 commit
-
-
Taha Tesser authored
fix title
-
- 28 Nov, 2022 1 commit
-
-
Darren Austin authored
-
- 15 Nov, 2022 1 commit
-
-
Darren Austin authored
-
- 01 Nov, 2022 1 commit
-
-
Darren Austin authored
-
- 24 Oct, 2022 1 commit
-
-
Darren Austin authored
-
- 13 Oct, 2022 1 commit
-
-
Gregor Weber authored
-
- 11 Oct, 2022 1 commit
-
-
hangyu authored
-