- 20 Mar, 2018 1 commit
-
-
Alexandre Ardhuin authored
-
- 09 Mar, 2018 1 commit
-
-
Michael Goderbauer authored
-
- 02 Feb, 2018 1 commit
-
-
Alexandre Ardhuin authored
-
- 09 Jan, 2018 1 commit
-
-
Michael Goderbauer authored
`RenderSemanticsGestureHandler` is no longer a semantics boundary, which allows us to correctly mark disabled buttons as disabled without having their semantics size and semantics node id change unexpectedly. Fixes https://github.com/flutter/flutter/issues/12589. Fixes https://github.com/flutter/flutter/issues/11991. See also https://github.com/flutter/flutter/issues/11993. This change also required some refactoring to how we deal with `twoPaneSemantics` scrolling as it previously relied on `RenderSemanticsGestureHandler` being a semantics boundary. This should also make the underlying logic easier to understand. In addition, the following minor changes are included in this PR: * Removal of orphaned and unused `SemanticsConfiguration.isMergingDescendantsIntoOneNode`. * Logic optimizations for `markNeedsSemanticsUpdate` . * Fix for edge case where `MergeSemantics` failed to merge semantics. * Use of emojis to better indicate leaf merging in the printed semantics tree. * Better assert message for adding invisible child semantics nodes. * Make some semantics tests robuster by not relying on creation order of SemanticsNode ids across test boundaries. Fixes https://github.com/flutter/flutter/issues/13943.
-
- 21 Dec, 2017 1 commit
-
-
Ian Hickson authored
This attempts to apply some of what we learnt from UX studies, namely that people wonder how to add multiple children to widget that take one child.
-
- 13 Oct, 2017 1 commit
-
-
amirh authored
-
- 11 Oct, 2017 1 commit
-
-
Michael Goderbauer authored
* Update Semantics for SingleChildScrollViews * refactor * review feedback * added assert and comments * doc
-
- 28 Sep, 2017 1 commit
-
-
Ian Hickson authored
-
- 27 Sep, 2017 1 commit
-
-
Ian Hickson authored
-
- 21 Sep, 2017 1 commit
-
-
Alexandre Ardhuin authored
-
- 15 Sep, 2017 1 commit
-
-
Ian Hickson authored
* Allow FloatingActionButton to not have a heroTag. * Allow FloatingActionButton to not have a child. * Allow Tooltip to not have a child. * Improve the debug output of the default FloatingActionButton hero tag. * Improve the error message in the Hero clashing-tag case. * Improve the debug output of the Hero widget. * Improve the debug output of gesture-related widgets. * Minor improvements to documentation. * Fix some typos in comments. * Fix some style nits.
-
- 12 Sep, 2017 1 commit
-
-
Jacob Richman authored
Diagnostics object is.
-
- 08 Sep, 2017 1 commit
-
-
Michael Goderbauer authored
* ++ * ++ * ++ * ++ * ++ * dart docs * test fix * undo unintended change * fix test * fix test * review feedback
-
- 08 Aug, 2017 2 commits
-
-
Michael Goderbauer authored
* Make tear-offs cachable for RenderSemanticsGestureHandler Fixes https://github.com/flutter/flutter/issues/11552 * comment fix * refactor
-
Michael Goderbauer authored
* a11y: handle left/right scrolls correctly * fix keep alive test * fix scaffold test
-
- 03 Aug, 2017 1 commit
-
-
Jacob Richman authored
Add Diagnosticable base class and documentation
-
- 28 Jul, 2017 1 commit
-
-
Ian Hickson authored
-
- 27 Jul, 2017 1 commit
-
-
Ian Hickson authored
It was 8.0. It's now arbitrarily 18.0. Changing this required adjusting some tests. Adjusting the tests required debugging the tests. Debugging the tests required some tools to help debugging gesture recognizers and gesture arenas, so I added some. It also required updating some toString() methods which resulted in some changes to the tree diagnostics logic. Also I cleaned up some docs while I was at it.
-
- 25 Jul, 2017 1 commit
-
-
Jacob Richman authored
Refactor RenderObject.toStringDeep and Widget.toStringDeep code to use DiagnosticsNode.
-
- 21 Jul, 2017 1 commit
-
-
Ian Hickson authored
Mainly, this adds documentation to members that were previously lacking documentation. It also adds a big block of documentation about improving performance of widgets. This also removes some references to package:collection and adds global setEquals and listEquals methods in foundation that we can use. (setEquals in particular should be much faster than the package:collection equivalent, though both should be faster as they avoid allocating new objects.) All remaining references now qualify the import so we know what our remaining dependencies are. Also lots of code reordering in Flutter driver to make the code consistent and apply the style guide more thoroughly.
-
- 19 Jul, 2017 1 commit
-
-
Michael Goderbauer authored
* Expose the currently available semantic scroll actions * review comments * add test * refactor to set
-
- 13 Jun, 2017 1 commit
-
-
Ian Hickson authored
-
- 12 Jun, 2017 1 commit
-
-
Ian Hickson authored
-
- 08 Jun, 2017 1 commit
-
-
Ian Hickson authored
-
- 02 Jun, 2017 1 commit
-
-
Alexandre Ardhuin authored
* preview of prefer_asserts_in_initializer_list lint * fix issue
-
- 03 May, 2017 1 commit
-
-
Ian Hickson authored
-
- 02 May, 2017 1 commit
-
-
Ian Hickson authored
Fixes https://github.com/flutter/flutter/issues/8476 More detailed list of changes in this patch: * Replaced the didTouch special logic with more generic logic that uses Activities instead. Now instead when you tap down the Scrollable calls `hold()` which begins a HoldScrollActivity which is a hybrid of DragStartDetails and IdleScrollActivity and can be canceled. When you let go, it gets canceled and that goes ballistic. * Make DragGestureRecognizer more aggressive about grabbing pointers, otherwise a second pointer in a situation with competing horizontal and vertical recognizers always gets taken by the other one. * Fixed the _GestureSemantics widget to call the "down" callbacks so that it follows the same pattern as "real" interactions. * Added tests for the above. * Added a hashCode to ScrollActivity.toString (and subclasses). * Added a toString to ScrollDragController, and include it in DragScrollActivity's toString. * s/coorindator/coordinator/ * Add a comment in DragStartDetails to distinguish it from the otherwise identical DragDownDetails, so we're not tempted to merge them.
-
- 23 Apr, 2017 1 commit
-
-
Alexandre Ardhuin authored
* more widget const constructors * prefer const constructors * address review comments
-
- 21 Apr, 2017 1 commit
-
-
Alexandre Ardhuin authored
* make @immutable const * fix build
-
- 17 Apr, 2017 1 commit
-
-
Hans Muller authored
-
- 11 Apr, 2017 1 commit
-
-
xster authored
Rename State.config to State.widget Rename State.didUpdateConfig to State.didUpdateWidget Renamed all State subclasses' local variables named config to something else
-
- 04 Mar, 2017 1 commit
-
-
Chris Bracken authored
Covers lib/ in package:flutter.
-
- 25 Jan, 2017 1 commit
-
-
Adam Barth authored
This patch introduces ScrollView, which is a convenience widget for using a SliverBlock. This patch also switches a number of tests from Block to ScrollView. Once we support more features of block (e.g., padding and shrinkwrapping), we'll be able to move over more clients.
-
- 22 Jan, 2017 1 commit
-
-
Ian Hickson authored
-
- 11 Jan, 2017 1 commit
-
-
Adam Barth authored
Also, make the exception handling for global key listeners slightly more robust.
-
- 10 Jan, 2017 1 commit
-
-
Ian Hickson authored
-
- 15 Nov, 2016 1 commit
-
-
Ian Hickson authored
See https://github.com/flutter/flutter/pull/6861 This silences all but two of the warnings from https://travis-ci.org/flutter/flutter/builds/176055550 One of the silenced warnings was a genuine code error. Some of the others were correct but there was no way for the analyzer to know, and I worked around them. The remainder are problems with the analyzer, specifically https://github.com/dart-lang/sdk/issues/27827 and https://github.com/dart-lang/sdk/issues/27504.
-
- 03 Nov, 2016 1 commit
-
-
Ian Hickson authored
-
- 01 Nov, 2016 1 commit
-
-
Chris Bracken authored
-
- 04 Oct, 2016 1 commit
-
-
Hans Muller authored
-