- 22 Feb, 2024 16 commits
-
-
Martin Kustermann authored
-
LongCatIsLooong authored
Fixes an issue where if the `TextSpan` doesn't have a text style, the specified strutStyle is not applied. Additionally, adds a migration flag for https://github.com/flutter/engine/pull/50385, for internal golden changes. It's only going to exist for a week.
-
Zachary Anderson authored
https://github.com/flutter/flutter/issues/143915 cc @yusuf-goog
-
Kostia Sokolovskyi authored
Contributes to https://github.com/flutter/flutter/issues/141198 ### Description - Adds `CurvedAnimation` disposals to `material/chip.dart`, `material/input_decorator.dart`, `material/toggleable.dart`, `widgets/animated_switcher.dart`, `widgets/overscroll_indicator.dart`.
-
Andrew authored
Fixes a small documentation typo.
-
Tirth authored
Fixed Small Typo in Emulators Test Name. I filed #140656 and it was fixed in #142853. I noticed this one there and decided to send a fix.
-
Derek Xu authored
This PR implements the functionality described above and hides it behind the `--experimental-faster-testing` flag of `flutter test`. ### The following are some performance measurements from test runs conducted on GitHub Actions run 1 logs: https://github.com/derekxu16/flutter_test_ci/actions/runs/8008029772/attempts/1 run 2 logs: https://github.com/derekxu16/flutter_test_ci/actions/runs/8008029772/attempts/2 run 3 logs: https://github.com/derekxu16/flutter_test_ci/actions/runs/8008029772/attempts/3 **length of `flutter test --reporter=expanded test/animation test/foundation` step** run 1: 54s run 2: 52s run 3: 56s average: 54s **length of `flutter test --experimental-faster-testing --reporter=expanded test/animation test/foundation` step** run 1: 27s run 2: 27s run 3: 29s average: 27.67s (~48.77% shorter than 54s) **length of `flutter test --reporter=expanded test/animation test/foundation test/gestures test/painting test/physics test/rendering test/scheduler test/semantics test/services` step** run 1: 260s run 2: 270s run 3: 305s average: 278.33s **length of `flutter test --experimental-faster-testing --reporter=expanded test/animation test/foundation test/gestures test/painting test/physics test/rendering test/scheduler test/semantics test/services` step** from a clean build (right after deleting the build folder): run 1: 215s run 2: 227s run 3: 245s average: 229s (~17.72% shorter than 278.33s) Note that in reality, `test/material` was not passed to `flutter test` in the trials below. All of the test files under `test/material` except for `test/material/icons_test.dart` were listed out individually **length of `flutter test --reporter=expanded test/material` step** run 1: 408s run 2: 421s run 3: 451s average: 426.67s **length of `flutter test --experimental-faster-testing --reporter=expanded test/material` step** run 1: 382s run 2: 373s run 3: 400s average: 385s (~9.77% shorter than 426.67s) --------- Co-authored-by:
Dan Field <dnfield@google.com>
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/9250bfdb38c5...06448ee8165f 2024-02-22 zanderso@users.noreply.github.com Change "Linux mac_unopt" to "Mac mac_unopt" (flutter/engine#50863) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
auto-submit[bot] authored
Reverts flutter/flutter#143799 Initiated by: goderbauer Reason for reverting: The microbenchmark failed two run two times in a row after this was committed (see https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8755379171959141089/+/u/run_microbenchmarks/stdout). Original PR Author: bernaferrari Reviewed By: {goderbauer} This change reverts the following previous change: Original Description: Re-lands https://github.com/flutter/flutter/pull/143542 (which is part 1 of https://github.com/flutter/flutter/pull/138481) The filename was wrong 🫠
-
engine-flutter-autoroll authored
https://github.com/flutter/packages/compare/48048f6bc779...078c2a304a01 2024-02-22 engine-flutter-autoroll@skia.org Manual roll Flutter from 5129806e to efee280c (47 revisions) (flutter/packages#6180) 2024-02-22 engine-flutter-autoroll@skia.org Manual roll Flutter (stable) from bae5e49bc2a8 to abb292a07e20 (1 revision) (flutter/packages#6179) 2024-02-21 louisehsu@google.com [in_app_purchase] Convert refreshReceipt(), startObservingPaymentQueue(), stopObservingPaymentQueue(), registerPaymentQueueDelegate(), removePaymentQueueDelegate(), showPriceConsentIfNeeded() to Pigeon (flutter/packages#6165) 2024-02-21 43054281+camsim99@users.noreply.github.com [camerax] Modifies initialized camera info to reflect default AF/AE modes and the ability to set focus points for each (flutter/packages#6109) 2024-02-21 43054281+camsim99@users.noreply.github.com [camerax] Implements `setFocusPoint`, `setExposurePoint`, `setExposureOffset` (flutter/packages#6059) 2024-02-21 stuartmorgan@google.com [various] Commit Windows build migrations (flutter/packages#6175) 2024-02-21 kevmoo@users.noreply.github.com [flutter_markdown] Support wasm (flutter/packages#6168) 2024-02-21 737941+loic-sharma@users.noreply.github.com [ci] Run Windows Arm64 build tests post-submit (flutter/packages#6166) 2024-02-21 stuartmorgan@google.com [url_launcher] Remove `renderView` usage (flutter/packages#6137) 2024-02-21 b@sdevaan.nl [camera_android_camerax] Fix typo in readme (flutter/packages#6143) 2024-02-21 stuartmorgan@google.com [local_auth] Switch iOS endorsement to `local_auth_darwin` (flutter/packages#6107) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/7777480eb94d...9250bfdb38c5 2024-02-22 skia-flutter-autoroll@skia.org Roll Skia from 0b55d78d32f9 to b9c16065b76d (1 revision) (flutter/engine#50861) 2024-02-22 skia-flutter-autoroll@skia.org Roll Skia from cbdbcf9bebe6 to 0b55d78d32f9 (1 revision) (flutter/engine#50860) 2024-02-22 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from dLhvv964txwnSlvNw... to j9cJ94K-T1i3u5xGh... (flutter/engine#50858) 2024-02-22 skia-flutter-autoroll@skia.org Roll Skia from ec119f44e6b9 to cbdbcf9bebe6 (2 revisions) (flutter/engine#50857) 2024-02-22 skia-flutter-autoroll@skia.org Roll Skia from 4aa97aca087c to ec119f44e6b9 (1 revision) (flutter/engine#50849) 2024-02-22 bdero@google.com [Impeller] Add StC color source/clip behavior + constexpr flag for enabling StC. (flutter/engine#50817) 2024-02-22 skia-flutter-autoroll@skia.org Roll Skia from 3fd1a5a7c7c1 to 4aa97aca087c (2 revisions) (flutter/engine#50848) 2024-02-22 matanlurey@users.noreply.github.com Minor non-semantic refactors of `ExternalTexturesFlutterActivity` (flutter/engine#50845) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from dLhvv964txwn to j9cJ94K-T1i3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Bernardo Ferrari authored
Re-lands https://github.com/flutter/flutter/pull/143542 (which is part 1 of https://github.com/flutter/flutter/pull/138481) The filename was wrong ð«
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/7eeb697687d5...7777480eb94d 2024-02-22 skia-flutter-autoroll@skia.org Roll Skia from 57490c8d257e to 3fd1a5a7c7c1 (9 revisions) (flutter/engine#50842) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/bf5c003085fd...7eeb697687d5 2024-02-22 tugorez@users.noreply.github.com Add view focus direction detection to flutter web. (flutter/engine#50843) 2024-02-22 matanlurey@users.noreply.github.com Add a similar `runIf` guard to `web_engine` as web framework. (flutter/engine#50846) 2024-02-22 dkwingsmt@users.noreply.github.com Add scheduleWarmUpFrame (flutter/engine#50570) 2024-02-22 matanlurey@users.noreply.github.com Remove/reduce unused or private methods and add tests to `SkiaGoldClient` (flutter/engine#50844) 2024-02-22 matanlurey@users.noreply.github.com Clean up contributing formatting, add a Skia gold callout (flutter/engine#50828) 2024-02-21 34871572+gmackall@users.noreply.github.com Make Android Studio be able to run android embedding unit tests out of the box (flutter/engine#50840) 2024-02-21 zanderso@users.noreply.github.com Shift some deps to //flutter/third_party (flutter/engine#50830) 2024-02-21 tugorez@users.noreply.github.com Make the view focus binding report focus transitions across elements. (flutter/engine#50610) 2024-02-21 chris@bracken.jp [macOS] Wrap FlutterEngineTest in autoreleasepool (flutter/engine#50832) 2024-02-21 jason-simmons@users.noreply.github.com Update the vulkan_glfw sample for the latest roll of vulkan-deps (flutter/engine#50839) 2024-02-21 skia-flutter-autoroll@skia.org Roll Skia from 8fa858855820 to 57490c8d257e (6 revisions) (flutter/engine#50833) 2024-02-21 zanderso@users.noreply.github.com Starts a .ci.yaml parser (flutter/engine#50783) 2024-02-21 skia-flutter-autoroll@skia.org Roll Dart SDK from f344e2266468 to 0f0f7400c38a (6 revisions) (flutter/engine#50837) 2024-02-21 737941+loic-sharma@users.noreply.github.com [Windows] Fix top-level message procedure order (flutter/engine#50797) 2024-02-21 john@johnmccutchan.com Tweak verbose log messages in ImageReaderSurfaceProducer (flutter/engine#50831) 2024-02-21 matanlurey@users.noreply.github.com Add a throw statement for imgtestAdd non 0 exit codes. (flutter/engine#50829) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Kate Lovett authored
I don't know if this is feasible, but figured it was worth seeing. Often times dart fixes are forgotten as part of the code review process. I know some people ignore the PR template, but considered maybe a mention was warranted. I've made the change reflected below:
-
Kate Lovett authored
My RenderSliverMultiBoxAdaptor/RenderSliverFixedExtentList/RenderSliverVariedExtentList yak shave continues. I've been subclassing RenderSliverVariedExtentList for SliverTree and have found some opportunities for clean up. There is a larger clean up I'd like to do, but this week SliverTree comes first. I noticed these methods were getting repeated ð, and I was about to repeat them again ð for the tree, so I figured bumping them up to the base class was better than continuing to copy-paste the same methods.
-
- 21 Feb, 2024 24 commits
-
-
auto-submit[bot] authored
Reverts flutter/flutter#143864 Initiated by: goderbauer Reason for reverting: The test is consistently failing in post-submit, e.g. https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8755443299639610049/+/u/run_test.dart_for_framework_tests_shard_and_subshard_impeller/stdout Original PR Author: jonahwilliams Reviewed By: {matanlurey} This change reverts the following previous change: Original Description: Part of https://github.com/flutter/flutter/issues/143616 Without this these tests only run on postsubmit which means we can't get gold results on PRs.
-
Jonah Williams authored
Part of https://github.com/flutter/flutter/issues/143616 Without this these tests only run on postsubmit which means we can't get gold results on PRs.
-
Jonah Williams authored
This test is still unstable with the debug banner disabled. the Icon in the FAB appears to be shifting.
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/52ffcaadea41...bf5c003085fd 2024-02-21 skia-flutter-autoroll@skia.org Roll Skia from 9d86359b5fe8 to 8fa858855820 (15 revisions) (flutter/engine#50827) 2024-02-21 matanlurey@users.noreply.github.com Add the `scenario_app` `'solid_blue'` golden to the Android test suite (flutter/engine#50801) 2024-02-21 matanlurey@users.noreply.github.com Ignore EOF newline characters and added tests to `dir_contents_diff` tool (flutter/engine#50805) 2024-02-21 jason-simmons@users.noreply.github.com Make the GL context current in EmbedderSurfaceGLImpeller before creating the GPU surface (flutter/engine#50807) 2024-02-21 matanlurey@users.noreply.github.com Fail engine post-submit on skia-gold comparions. (flutter/engine#50826) 2024-02-21 34871572+gmackall@users.noreply.github.com Remove WindowManager reflection in SingleViewPresentation.java (flutter/engine#49996) 2024-02-21 30870216+gaaclarke@users.noreply.github.com [Impeller] applied the lerp hack to blur (roughly 2x speedup?) (flutter/engine#50790) 2024-02-21 jason-simmons@users.noreply.github.com Migrate the Fuchsia embedder to the Dart_RecordTimelineEvent API (flutter/engine#50823) 2024-02-21 john@johnmccutchan.com Hook ImageReaderSurfaceProducer to the onTrimMemory listener interface (flutter/engine#50792) 2024-02-21 matanlurey@users.noreply.github.com Fix the local-only lint errors due to an unexpected `GeneratedPluginRegistrant.java` (flutter/engine#50795) 2024-02-21 jonahwilliams@google.com [Impeller] cache onscreen render targets. (flutter/engine#50751) 2024-02-21 zanderso@users.noreply.github.com Use 'et format' in CI. Check formatting of all files in CI (flutter/engine#50810) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/4128895d79a1...52ffcaadea41 2024-02-21 jonahwilliams@google.com [Impeller] force bootstrap render pass. (flutter/engine#50749) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Kate Lovett authored
Multiple methods in `RenderSliverFixedExtentBoxAdaptor` pass a `double itemExtent` for computing things like what children will be laid out, what the max scroll offset will be, and how the children will be laid out. Since `RenderSliverFixedExtentBoxAdaptor` was further subclassed to support a `itemExtentBuider` in `RenderSliverVariedExtentList`, these itemExtent parameters became useless when using that RenderObject. Reading through `RenderSliverFixedExtentBoxAdaptor.performLayout`, the remaining artifacts of passing around itemExtent make it hard to follow when it is irrelevant. `RenderSliverFixedExtentBoxAdaptor.itemExtent` is available from these methods, so it does not need to pass it. It is redundant API. Plus, if a bogus itemExtent is passed for some reason, errors will ensue and the layout will be incorrect. ð£ ð¥ Deprecating so we can remove these for a cleaner API. Unfortunately this is not supported by dart fix, but the fact that these methods are protected means usage outside of the framework is likely minimal.
-
Reid Baker authored
- **Fix #143778 add aab as alias to appbundle** Fixes #143778
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/e16f43eeaaa4...4128895d79a1 2024-02-21 matanlurey@users.noreply.github.com Disallow files additional named `GeneratedPluginRegistrant.java`. (flutter/engine#50796) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/packages/compare/8bba41b0c046...48048f6bc779 2024-02-20 ditman@gmail.com [google_sign_in_web] Updates package:web dependency to 0.5.0. (flutter/packages#6167) 2024-02-20 kevmoo@users.noreply.github.com [web] Updates package:web dependency to ^0.5.0. (flutter/packages#5791) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Taha Tesser authored
fixes [`hourMinuteTextStyle` Material 3 default doesn't match the specs](https://github.com/flutter/flutter/issues/143748) This updates `hourMinuteTextStyle` defaults to match Material 3 specs. `hourMinuteTextStyle` should use different font style for different entry modes based on the specs. ### Specs   ### Before ```dart return _textTheme.displayMedium!.copyWith(color: _hourMinuteTextColor.resolve(states)); ``` ### After ```dart return entryMode == TimePickerEntryMode.dial ? _textTheme.displayLarge!.copyWith(color: _hourMinuteTextColor.resolve(states)) : _textTheme.displayMedium!.copyWith(color: _hourMinuteTextColor.resolve(states)); ```
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/93063f61943a...e16f43eeaaa4 2024-02-21 bdero@google.com [Impeller] Add GeometryResult enum with StC modes. (flutter/engine#50816) 2024-02-21 bdero@google.com Update impeller-cmake-example (flutter/engine#50808) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/ed49634486e9...93063f61943a 2024-02-21 bdero@google.com [Impeller] Remove non-Flutter fill types from impeller::Path. (flutter/engine#50814) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Taha Tesser authored
fixes [Screen reader is not announcing the selected date as selected on DatePicker](https://github.com/flutter/flutter/issues/143439) ### Descriptions - This fixes an issue where `CalendarDatePicker` doesn't announce selected date on desktop. - Add semantic label to describe the selected date is indeed "Selected". ### Code sample <details> <summary>expand to view the code sample</summary> ```dart import 'package:flutter/material.dart'; void main() { runApp(const MyApp()); } class MyApp extends StatelessWidget { const MyApp({super.key}); @override Widget build(BuildContext context) { return const MaterialApp( home: MyHomePage(title: 'Flutter Demo Home Page'), ); } } class MyHomePage extends StatefulWidget { const MyHomePage({super.key, required this.title}); final String title; @override MyHomePageState createState() => MyHomePageState(); } class MyHomePageState extends State<MyHomePage> { void _showDatePicker() async { await showDatePicker( context: context, initialDate: DateTime.now(), firstDate: DateTime(1900), lastDate: DateTime(2200), ); } @override Widget build(BuildContext context) { return Scaffold( appBar: AppBar( title: Text(widget.title, style: const TextStyle(fontFamily: 'ProductSans')), ), body: const Center( child: Text('Click the button to show date picker.'), ), floatingActionButton: FloatingActionButton( onPressed: _showDatePicker, tooltip: 'Show date picker', child: const Icon(Icons.edit_calendar), ), ); } } // import 'package:flutter/material.dart'; // void main() => runApp(const MyApp()); // class MyApp extends StatelessWidget { // const MyApp({super.key}); // @override // Widget build(BuildContext context) { // return MaterialApp( // debugShowCheckedModeBanner: false, // home: Scaffold( // body: Center( // child: CalendarDatePicker( // initialDate: DateTime.now(), // firstDate: DateTime(2020), // lastDate: DateTime(2050), // onDateChanged: (date) { // print(date); // }, // ), // ), // ), // ); // } // } ``` </details> ### Before https://github.com/flutter/flutter/assets/48603081/c82e1f15-f067-4865-8a5a-1f3c0c8d91da ### After https://github.com/flutter/flutter/assets/48603081/193d9e26-df9e-4d89-97ce-265c3d564607
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/9100d326475a...ed49634486e9 2024-02-21 bdero@google.com [Impeller] Apply Entity depth in filter shaders that may render directly to an EntityPass. (flutter/engine#50742) 2024-02-21 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from gKg6HlBeR52y-cMhu... to dLhvv964txwnSlvNw... (flutter/engine#50813) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from gKg6HlBeR52y to dLhvv964txwn If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Taha Tesser authored
Add `timeSelectorSeparatorColor` and `timeSelectorSeparatorTextStyle` for Material 3 Time Picker (#143739) fixes [`Time selector separator` in TimePicker is not centered vertically](https://github.com/flutter/flutter/issues/143691) Separator currently `hourMinuteTextStyle` to style itself. This introduces `timeSelectorSeparatorColor` and `timeSelectorSeparatorTextStyle` from Material 3 specs to correctly style the separator. This also adds ability to change separator color without changing `hourMinuteTextColor`. ### Specs for the time selector separator https://m3.material.io/components/time-pickers/specs  ### Code sample <details> <summary>expand to view the code sample</summary> ```dart import 'package:flutter/material.dart'; void main() { runApp(const App()); } class App extends StatelessWidget { const App({super.key}); @override Widget build(BuildContext context) { return MaterialApp( theme: ThemeData( // timePickerTheme: TimePickerThemeData( // hourMinuteTextColor: Colors.amber, // ) ), home: Scaffold( body: Center( child: Builder(builder: (context) { return ElevatedButton( onPressed: () async { await showTimePicker( context: context, initialTime: TimeOfDay.now(), ); }, child: const Text('Pick Time'), ); }), ), ), ); } } ``` </details> | Before | After | | --------------- | --------------- | | <img src="https://github.com/flutter/flutter/assets/48603081/20beeba4-5cc2-49ee-bba8-1c552c0d1e44" /> | <img src="https://github.com/flutter/flutter/assets/48603081/24927187-aff7-4191-930c-bceab6a4b4c2" /> |
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/efc69946cb1e...9100d326475a 2024-02-21 leroux_bruno@yahoo.fr [Web] Update modifier state when Meta key is seen as Process key (flutter/engine#50779) 2024-02-21 jason-simmons@users.noreply.github.com Add pub.dev to the hosted package URIs checked by the pub_get_offline script (flutter/engine#50811) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/700250436e3f...efc69946cb1e 2024-02-21 zanderso@users.noreply.github.com Make global builds uniquely named per platform (flutter/engine#50764) 2024-02-21 zanderso@users.noreply.github.com [et] Adds a format command (flutter/engine#50747) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/3557277c575c...700250436e3f 2024-02-21 bdero@google.com [Flutter GPU] Fix symbol export for windows. (flutter/engine#50755) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Jonah Williams authored
Part of https://github.com/flutter/flutter/issues/143616
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/cb12a8cc97a1...3557277c575c 2024-02-21 jonahwilliams@google.com Disable framework smoke tests. (flutter/engine#50800) 2024-02-20 jonahwilliams@google.com [Impeller] more nullchecks in image decoder. (flutter/engine#50787) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Kevin Moore authored
Wasm compilation is now available on `master` and `beta` channels.
-
Simon Friis Vindum authored
This PR fixes #142885. The issue is that in `_RepeatingSimulation` the initial time is calculated as follows: ``` (initialValue / (max - min)) * (period.inMicroseconds / Duration.microsecondsPerSecond) ``` This calculation does not work in general. For instance, if `max` is 300, `min` is 100, and `initialValue` is 100 then `initialValue / (max - min)` is 1/2 when it should be 0 The current tests work by happenstance because the numbers used happen to work. To reveal the bug I've added some more tests similar to the existing ones but with different numbers. A "side-effect" of the incorrect calculation is that if `initialValue` is 0, then the animation will always start from `min` no matter what. For instance, in one of the tests, an `AnimationController` with the value 0 is told to `repeat` between 0.5 and 1.0, and this starts the animation from 0.5. To preserve this behavior, and to more generally handle the case where the initial value is out of bounds, this PR clamps the initial value to be within the lower and upper bounds of the repetition. Just for reference, this calculation was introduced at https://github.com/flutter/flutter/pull/25125.
-
Jonah Williams authored
Fixes some of https://github.com/flutter/flutter/issues/143616 by disabling the debug banner, which does not appear to be a critical part of the golden.
-
auto-submit[bot] authored
Reverts "Changing `TextPainter.getOffsetForCaret` implementation to remove the logarithmic search (#143281)" (#143801) Reverts flutter/flutter#143281 Initiated by: LongCatIsLooong Reason for reverting: https://github.com/flutter/flutter/issues/143797 Original PR Author: LongCatIsLooong Reviewed By: {justinmc, jason-simmons} This change reverts the following previous change: Original Description: The behavior largely remains the same, except: 1. The EOT cursor `(textLength, downstream)` for text ending in the opposite writing direction as the paragraph is now placed at the visual end of the last line. For example, in a LTR paragraph, the EOT cursor for `aA` (lowercase for LTR and uppercase for RTL) is placed to the right of the line: `aA|` (it was `a|A` before). This matches the behavior of most applications that do logical order arrow key navigation instead of visual order navigation. And it makes the navigation order consistent for `aA\naA`: ``` |aA => aA| => aA| => aA => aA => aA aA aA aA |aA aA| aA| (1) (2) (3) (4) (5) (6) ``` This is indeed still pretty confusing as (2) and (3), as well as (5) and (6) are hard to distinguish (when the I beam has a large width they are actually visually distinguishable -- they use the same anchor but one gets painted to the left and the other to the right. I noticed that emacs does the same). But logical order navigation will always be confusing in bidi text, in one way or another. Interestingly there are 3 different behaviors I've observed in chrome: - the chrome download dialog (which I think uses GTK text widgets but not sure which version) gives me 2 cursors when navigating bidi text, and - its HTML fields only show one, and presumably they place the I beam at the **trailing edge** of the character (which makes more sense for backspacing I guess). - On the other hand, its (new) omnibar seems to use visual order arrow navigation Side note: we may need to update the "tap to place the caret here" logic to handle the case where the tap lands outside of the text and the text ends in the opposite writing direction. 2. Removed the logarithmic search. The same could be done using the characters package but when glyphInfo tells you about the baseline location in the future we probably don't need the `getBoxesForRange` call. This should fix https://github.com/flutter/flutter/issues/123424. ## Internal Tests This is going to change the image output of some internal golden tests. I'm planning to merge https://github.com/flutter/flutter/pull/143281 before this to avoid updating the same golden files twice for invalid selections.
-
![auto-submit[bot]'s avatar](https://secure.gravatar.com/avatar/266ceac20512ae5366aafb5e5452ef8b?s=80&d=identicon "auto-submit[bot]")
