- 28 Apr, 2023 12 commits
-
-
Bruno Leroux authored
## Description This PR adds a new channel to query the engine keyboard state. See https://github.com/flutter/flutter/issues/87391#issuecomment-1228975571 for motivation. ## Related Issue Framework side implementation for https://github.com/flutter/flutter/issues/87391. Once approved the framework will try to query the initial keyboard state from the engine. PRs will be needed on the engine side to answer the framework query. ## Tests Adds 1 test.
-
Flutter GitHub Bot authored
This PR was generated by `flutter update-packages --force-upgrade`.
-
Qun Cheng authored
`Checkbox.fillColor` should be applied to checkbox's background color when it is unchecked. (#125643)
-
Zachary Anderson authored
Fixes https://github.com/flutter/flutter/issues/125648
-
Flutter GitHub Bot authored
This PR was generated by `flutter update-packages --force-upgrade`.
-
Phlippie Bosman authored
Fixes a [grocer's apostrophe](https://www.grammar-monster.com/lessons/apostrophe_error_with_plurals.htm). Apostrophes are not used to indicate plurals, and this incorrect usage in the documentation tripped me up, so I figured I could submit a quick correction :)
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/1d25906b4cf0...98b6fabc66bb 2023-04-28 godofredoc@google.com Migrate Linux Arm Host Engine to engine v2. (flutter/engine#41555) 2023-04-28 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from Rk2iPE0_H1vjuGV4e... to kNDuhglIFq_xEt5n3... (flutter/engine#41582) 2023-04-28 bdero@google.com [Impeller] Manage the onscreen stencil in EntityPass (flutter/engine#41563) 2023-04-28 bdero@google.com Revert "Reland: [Impeller] Use a device buffer for SkBitmap allocation, use Linear texture on Metal backend. " (flutter/engine#41567) Also rolling transitive DEPS: fuchsia/sdk/core/mac-amd64 from Rk2iPE0_H1vj to kNDuhglIFq_x If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
fzyzcjy authored
Background: I am adding logging to things like dialogs, bottom sheets and menus. Then I realized that, showMenu does not allow users to provide RouteSettings, while showDialog and showModalBottomSheet both allow. Therefore, IMHO a consistent API design may need to add this to showMenu. I will add tests if this proposal looks OK :)
-
Viren Khatri authored
Fixes https://github.com/flutter/flutter/issues/123218
-
Reid Baker authored
Testing AGP 8.0 is not possible with the existing infra because of the java version on CI machines. See https://github.com/flutter/flutter/issues/125325 for more details. https://github.com/flutter/flutter/issues/125181
-
arvin authored
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/3d61e293cb96...1d25906b4cf0 2023-04-27 skia-flutter-autoroll@skia.org Roll Skia from f7c8a58c2127 to 05d09f28250a (4 revisions) (flutter/engine#41557) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
- 27 Apr, 2023 22 commits
-
-
Jenn Magder authored
Looks like CocoaPods 1.12.1 is incompatible with < Xcode 14 due to https://github.com/CocoaPods/CocoaPods/pull/11828 (see https://github.com/flutter/flutter/issues/123890 for context). Bump the minimum Xcode version allowed by tooling to 14, released September 2022. ``` [!] Xcode - develop for iOS and macOS (Xcode 13.4) â Flutter requires Xcode 14 or higher. Download the latest version or update via the Mac App Store. ``` Fixes https://github.com/flutter/flutter/issues/125286. Previous bump at #97746.
-
gmackall authored
Add migrator to upgrade gradle version when conflict with Android Studio bundled Java version is detected (#124085) This PR adds an android project migrator that checks the version of android studio and the version of gradle for conflicts, and upgrades to 7.4 if a conflict is detected. For more detail about the particular conflict, see https://github.com/flutter/flutter/issues/122376. The PR also upgrades older gradle versions being used in integration testing to 7.4. Fixes/related to: https://github.com/flutter/flutter/issues/122376 and https://github.com/flutter/flutter/issues/123636
-
Janice Collins authored
This PR updates the dartdoc version to v6.2.2. Release notes: https://github.com/dart-lang/dartdoc/releases/tag/v6.2.2 The main impact for Flutter is to update dartdoc to add chips to class and/or mixin pages for class modifiers. See dart-lang/dartdoc#3391, dart-lang/dartdoc#3402. This will also be a cherry-pick candidate for 3.1 if it can land in time. - [ test-exempt ] I added new tests to check the change I am making, or this PR is [test-exempt].
-
Taha Tesser authored
This adds `devicelab` task `slider_perf_android` to `.ci.yaml`, which was added in https://github.com/flutter/flutter/pull/125296
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/883bb7d5cb28...3d61e293cb96 2023-04-27 skia-flutter-autoroll@skia.org Roll Skia from 8441d7a93942 to f7c8a58c2127 (10 revisions) (flutter/engine#41556) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Christopher Fujino authored
Better debugging to investigate: https://github.com/flutter/flutter/issues/125241 When the `test/integration.shard/break_on_framework_exceptions_test.dart` test times out, log out verbose logging to give clues as to why it did not complete. From one local run it looks like the test runner is failing to load a test file (when I checked the path locally, the file was there, and re-running the `flutter test ...` invocation succeeded--in that the app threw an exception): ``` 14:12 +26 -1: breaks when StatefulWidget.build throws [E] Timed out launching `flutter test` package:matcher fail test/integration.shard/break_on_framework_exceptions_test.dart 623:11 _timeoutAfter.<fn> 250s Spawning flutter [test, --disable-service-auth-codes, --machine, --start-paused, test/test.dart] in /tmp/flutter_break_on_framework_exceptions.GUJDAZ 251s <=stdout= {"protocolVersion":"0.1.1","runnerVersion":null,"pid":25763,"type":"start","time":0} <=stdout= {"suite":{"id":0,"platform":"vm","path":"/tmp/flutter_break_on_framework_exceptions.GUJDAZ/test/test.dart"},"type":"suite","time":0} <=stdout= {"test":{"id":1,"name":"loading /tmp/flutter_break_on_framework_exceptions.GUJDAZ/test/test.dart","suiteID":0,"groupIDs":[],"metadata":{"skip":false,"skipReason":null},"line":null,"column":null,"url":null},"type":"testStart","time":0} 258s <=stdout= {"testID":1,"error":"Exception: the Dart compiler exited unexpectedly.","stackTrace":"package:flutter_tools/src/base/common.dart 10:3 throwToolExit\npackage:flutter_tools/src/compile.dart 813:13 DefaultResidentCompiler._compile.<fn>\ndart:async/zone.dart 1391:47 _rootRun\ndart:async/zone.dart 1301:19 _CustomZone.run\ndart:async/zone.dart 1209:7 _CustomZone.runGuarded\ndart:async/stream_impl.dart 392:13 _BufferingStreamSubscription._sendDone.sendDone\ndart:async/stream_impl.dart 402:7 _BufferingStreamSubscription._sendDone\ndart:async/stream_impl.dart 291:7 _BufferingStreamSubscription._close\ndart:async/stream_transformers.dart 87:11 _SinkTransformerStreamSubscription._close\ndart:async/stream_transformers.dart 21:11 _EventSinkWrapper.close\ndart:convert/string_conversion.dart 241:11 _StringAdapterSink.close\ndart:convert/line_splitter.dart 141:11 _LineSplitterSink.close\ndart:async/stream_transformers.dart 132:24 _SinkTransformerStreamSubscription._handleDone\ndart:async/zone.dart 1391:47 _rootRun\ndart:async/zone.dart 1301:19 _CustomZone.run\ndart:async/zone.dart 1209:7 _CustomZone.runGuarded\ndart:async/stream_impl.dart 392:13 _BufferingStreamSubscription._sendDone.sendDone\ndart:async/stream_impl.dart 402:7 _BufferingStreamSubscription._sendDone\ndart:async/stream_impl.dart 291:7 _BufferingStreamSubscription._close\ndart:async/stream_transformers.dart 87:11 _SinkTransformerStreamSubscription._close\ndart:async/stream_transformers.dart 21:11 _EventSinkWrapper.close\ndart:convert/string_conversion.dart 241:11 _StringAdapterSink.close\ndart:convert/string_conversion.dart 295:20 _Utf8ConversionSink.close\ndart:convert/chunked_conversion.dart 78:18 _ConverterStreamEventSink.close\ndart:async/stream_transformers.dart 132:24 _SinkTransformerStreamSubscription._handleDone\ndart:async/zone.dart 1391:47 _rootRun\ndart:async/zone.dart 1301:19 _CustomZone.run\ndart:async/zone.dart 1209:7 _CustomZone.runGuarded\ndart:async/stream_impl.dart 392:13 _BufferingStreamSubscription._sendDone.sendDone\ndart:async/stream_impl.dart 402:7 _BufferingStreamSubscription._sendDone\ndart:async/stream_impl.dart... <=stdout= {"testID":1,"error":"Failed to load \"/tmp/flutter_break_on_framework_exceptions.GUJDAZ/test/test.dart\": Compilation failed for testPath=/tmp/flutter_break_on_framework_exceptions.GUJDAZ/test/test.dart","stackTrace":"","isFailure":false,"type":"error","time":7518} <=stdout= {"testID":1,"result":"error","skipped":false,"hidden":false,"type":"testDone","time":7521} <=stdout= {"count":1,"time":7526,"type":"allSuites"} <=stdout= {"success":false,"type":"done","time":7529} 259s Process exited (1) 371s Expecting test.startedProcess event [+ 95] <=stdout= {"suite":{"id":0,"platform":"vm","path":"/tmp/flutter_break_on_framework_exceptions.GUJDAZ/test/test.dart"},"type":"suite","time":0} [+ 95] <=stdout= {"test":{"id":1,"name":"loading /tmp/flutter_break_on_framework_exceptions.GUJDAZ/test/test.dart","suiteID":0,"groupIDs":[],"metadata":{"skip":false,"skipReason":null},"line":null,"column":null,"url":null},"type":"testStart","time":0} [+ 7600] <=stdout= {"testID":1,"error":"Exception: the Dart compiler exited unexpectedly.","stackTrace":"package:flutter_tools/src/base/common.dart 10:3 throwToolExit\npackage:flutter_tools/src/compile.dart 813:13 DefaultResidentCompiler._compile.<fn>\ndart:async/zone.dart 1391:47 _rootRun\ndart:async/zone.dart 1301:19 _CustomZone.run\ndart:async/zone.dart 1209:7 _CustomZone.runGuarded\ndart:async/stream_impl.dart 392:13 _BufferingStreamSubscription._sendDone.sendDone\ndart:async/stream_impl.dart 402:7 _BufferingStreamSubscription._sendDone\ndart:async/stream_impl.dart 291:7 _BufferingStreamSubscription._close\ndart:async/stream_transformers.dart 87:11 _SinkTransformerStreamSubscription._close\ndart:async/stream_transformers.dart 21:11 _EventSinkWrapper.close\ndart:convert/string_conversion.dart 241:11 _StringAdapterSink.close\ndart:convert/line_splitter.dart 141:11 _LineSplitterSink.close\ndart:async/stream_transformers.dart 132:24 _SinkTransformerStreamSubscription._handleDone\ndart:async/zone.dart 1391:47 _rootRun\ndart:async/zone.dart 1301:19 _CustomZone.run\ndart:async/zone.dart 1209:7 _CustomZone.runGuarded\ndart:async/stream_impl.dart 392:13 _BufferingStreamSubscription._sendDone.sendDone\ndart:async/stream_impl.dart 402:7 _BufferingStreamSubscription._sendDone\ndart:async/stream_impl.dart 291:7 _BufferingStreamSubscription._close\ndart:async/stream_transformers.dart 87:11 _SinkTransformerStreamSubscription._close\ndart:async/stream_transformers.dart 21:11 _EventSinkWrapper.close\ndart:convert/string_conversion.dart 241:11 _StringAdapterSink.close\ndart:convert/string_conversion.dart 295:20 _Utf8ConversionSink.close\ndart:convert/chunked_conversion.dart 78:18 _ConverterStreamEventSink.close\ndart:async/stream_transformers.dart 132:24... Expecting test.startedProcess event is taking longer than usual... ```
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/3d6d915cb74a...883bb7d5cb28 2023-04-27 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.2.11 to 2.3.1 (flutter/engine#41553) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Jenn Magder authored
[Dart workaround](https://dart-review.googlesource.com/c/sdk/+/297821 ) to prevent the flake has rolled into the framework. Mark the tests unflaky so we can detect if it happens again when a fix for the underlying issue lands. https://github.com/flutter/flutter/issues/125425#issuecomment-1522142360 Reverts https://github.com/flutter/flutter/pull/125426
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/381f714972d8...3d6d915cb74a 2023-04-27 103135467+sealesj@users.noreply.github.com Refactor vuln scan into separate yaml (flutter/engine#41528) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Dan Field authored
See https://docs.flutter.dev/reference/supported-platforms I don't expect this to break anything, but if it does we can revert and figure out what else needs to happen first. Without this change, engine changes upstream will get flagged in default flutter created apps.
-
Taha Tesser authored
fixes https://github.com/flutter/flutter/issues/125619 ### Before ![Screenshot 2023-04-27 at 14 08 05](https://user-images.githubusercontent.com/48603081/234853490-0a9c4e18-20aa-40f7-a6b0-efb278f515eb.png) ### After ![Screenshot 2023-04-27 at 14 00 44](https://user-images.githubusercontent.com/48603081/234853470-c69c20d3-124d-438a-9312-2d17492c5606.png)
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/968413585768...381f714972d8 2023-04-27 skia-flutter-autoroll@skia.org Roll Dart SDK from 497a81b1af4f to c7160d4ea0b7 (1 revision) (flutter/engine#41550) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
fzyzcjy authored
Close https://github.com/flutter/flutter/issues/125600
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/79237ad14354...968413585768 2023-04-27 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from Du6g64Nirs3tZVK6i... to Rk2iPE0_H1vjuGV4e... (flutter/engine#41551) Also rolling transitive DEPS: fuchsia/sdk/core/mac-amd64 from Du6g64Nirs3t to Rk2iPE0_H1vj If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Pierre-Louis authored
This PR constrains M3 bottom sheets to 640dp max width by default. `constraints` can be used to provide different `minWidth` and `maxWidth`. This is not a breaking change per the breaking change policy. Part of https://github.com/flutter/flutter/issues/118619 Part of https://github.com/flutter/flutter/issues/111448 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [Features we expect every widget to implement]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/99b7fc1aa5b0...79237ad14354 2023-04-27 jonahwilliams@google.com Reland: [Impeller] Use a device buffer for SkBitmap allocation, use Linear texture on Metal backend. (flutter/engine#41538) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/d9f91aadffd4...99b7fc1aa5b0 2023-04-27 jonahwilliams@google.com [Impeller] allow shader read for root resolve texture (flutter/engine#41543) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/689eb6ee9047...d9f91aadffd4 2023-04-27 skia-flutter-autoroll@skia.org Roll Skia from 3b14dcad64ef to 8441d7a93942 (1 revision) (flutter/engine#41542) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Kevin Moore authored
Internal usage dropped in http://cl/527348621
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/19045bb99c7a...689eb6ee9047 2023-04-27 godofredoc@google.com reland "Migrate mac_host_engine to engine v2 builds." (flutter/engine#41531) 2023-04-27 zanderso@users.noreply.github.com Roll buildroot to 5708f2051772fd02c949e5dc9397e54f8c7a4478 (flutter/engine#41540) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/d4ca5240da52...19045bb99c7a 2023-04-27 skia-flutter-autoroll@skia.org Roll Skia from d315ab065af3 to 3b14dcad64ef (1 revision) (flutter/engine#41539) 2023-04-27 skia-flutter-autoroll@skia.org Roll Dart SDK from 3d444bc30fc4 to 497a81b1af4f (1 revision) (flutter/engine#41537) 2023-04-27 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from rM9DAwmAeMc8pV11x... to Du6g64Nirs3tZVK6i... (flutter/engine#41536) Also rolling transitive DEPS: fuchsia/sdk/core/mac-amd64 from rM9DAwmAeMc8 to Du6g64Nirs3t If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/cf975417ce40...d4ca5240da52 2023-04-27 skia-flutter-autoroll@skia.org Roll Skia from 20a1c61c5597 to d315ab065af3 (5 revisions) (flutter/engine#41535) 2023-04-26 jonahwilliams@google.com Revert "[Impeller] Use a device buffer for SkBitmap allocation, use Linear texture on Metal backend." (flutter/engine#41533) 2023-04-26 xilaizhang@google.com [codesign] Add pinned xcode version as property to mac android aot engine (flutter/engine#41518) 2023-04-26 bdero@google.com [Impeller] Coerce opaque ColorSourceContents to Source (flutter/engine#41525) 2023-04-26 skia-flutter-autoroll@skia.org Roll Skia from 3fea88565a83 to 20a1c61c5597 (3 revisions) (flutter/engine#41530) 2023-04-26 jonahwilliams@google.com [Impeller] partial repaint for Impeller/iOS. (flutter/engine#40959) 2023-04-26 30870216+gaaclarke@users.noreply.github.com Updated todo with github issue link (flutter/engine#41517) 2023-04-26 skia-flutter-autoroll@skia.org Roll Clang from 20d06c833d83 to 5344d8e10bb7 (flutter/engine#41524) 2023-04-26 jonahwilliams@google.com [Impeller] Use a device buffer for SkBitmap allocation, use Linear texture on Metal backend. (flutter/engine#41374) 2023-04-26 zanderso@users.noreply.github.com Manual clang roll to 5344d8e10bb7d8672d4bfae8adb010465470d51b (flutter/engine#41520) 2023-04-26 zanderso@users.noreply.github.com Download and use the goma client from cipd (flutter/engine#41488) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
- 26 Apr, 2023 6 commits
-
-
Jonah Williams authored
Reverts flutter/flutter#125583 Reverting to fix tree breakage caused by https://github.com/flutter/engine/pull/41533/files
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/cf975417ce40...fddd5add8b62 2023-04-26 jonahwilliams@google.com [Impeller] Use a device buffer for SkBitmap allocation, use Linear texture on Metal backend. (flutter/engine#41374) 2023-04-26 zanderso@users.noreply.github.com Manual clang roll to 5344d8e10bb7d8672d4bfae8adb010465470d51b (flutter/engine#41520) 2023-04-26 zanderso@users.noreply.github.com Download and use the goma client from cipd (flutter/engine#41488) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Zachary Anderson authored
This test has been failing for the past >1000 runs, and is wedging a bot for 30 minutes as the failure mode is a timeout. Fixes https://github.com/flutter/flutter/issues/119782
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/f2882afe0ec3...cf975417ce40 2023-04-26 godofredoc@google.com Migrate Windows AOT Engine to Engine V2. (flutter/engine#41515) 2023-04-26 bdero@google.com [Impeller] Store the root stencil on iOS (flutter/engine#41509) 2023-04-26 bdero@google.com [Impeller] iOS/macOS: Only wait for command scheduling prior to present (redux) (flutter/engine#41501) 2023-04-26 30870216+gaaclarke@users.noreply.github.com [Impeller] removed collisions of dead command pools between tests. (flutter/engine#41490) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/40187bb9afac...f2882afe0ec3 2023-04-26 skia-flutter-autoroll@skia.org Roll Skia from a0e3fa5aa947 to 3fea88565a83 (3 revisions) (flutter/engine#41516) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Tae Hyung Kim authored
Refactor "gen-l10n" command to use same code path when "l10n.yaml" is present or not present (#125429) I think this is a long needed change to the `gen-l10n` command. Essentially, the arguments to `flutter gen-l10n` can be provided by two different methods: via command line arguments or via the `l10n.yaml` file. The existence of a `l10n.yaml` file causes the latter approach to take precedence. However, currently, there's several differences in how the two approaches are handled, and most of the default arguments are all over the place, causing unexpected issues such as #120457 or #120023. This PR refactors the command so that * `LocalizationOptions` are more consistent with the actual argument names/yaml options. * All default values are determined in `LocalizationOptions`'s constructor (or in `argParser.addOption(...)` in the case a boolean value needs to be explicitly true). * New `parseLocalizationsOptionsFromCommand` function to parse arguments. * Parse `LocalizationOptions` at the beginning of `runCommand()` and pass it to `generateLocalizations`. Fixes #120023.
-