1. 13 Jun, 2019 1 commit
  2. 30 May, 2019 1 commit
  3. 29 May, 2019 1 commit
    • Todd Volkert's avatar
      Add loading support to Image (#33369) · 68841469
      Todd Volkert authored
      This adds two new builders to the `Image` class:
      
      * `frameBuilder`, which allows callers to control the widget
        created by an [Image].
      * `loadingBuilder`, which allows callers fine-grained control
        over how to display loading progress of an image to the user.
      
      `FadeInImage` can be simplified by migrating to the new API.
      This is done in a follow-on commit.
      
      https://github.com/flutter/flutter/issues/32374
      68841469
  4. 21 May, 2019 1 commit
    • Todd Volkert's avatar
      Add some sanity to the ImageStream listener API (#32936) · 592f81e7
      Todd Volkert authored
      The current API was broken in that you registered multiple
      callbacks at once, but when you removed listeners, only the
      primary listener was used to determine what was removed.
      This led to unintuitive cases where the caller could get
      unexpected behavior.
      
      This updates the API to add and remove listeners using
      a newly introduced [ImageStreamListener] object, a value
      object that has references to the individual callbacks
      that may fire.
      
      flutter/flutter#24722
      flutter/flutter#32374
      flutter/flutter#32935
      592f81e7
  5. 29 Apr, 2019 1 commit
  6. 22 Mar, 2019 1 commit
  7. 01 Mar, 2019 1 commit
    • Alexandre Ardhuin's avatar
      Add missing trailing commas (#28673) · 387f8854
      Alexandre Ardhuin authored
      * add trailing commas on list/map/parameters
      
      * add trailing commas on Invocation with nb of arg>1
      
      * add commas for widget containing widgets
      
      * add trailing commas if instantiation contains trailing comma
      
      * revert bad change
      387f8854
  8. 21 Feb, 2019 1 commit
  9. 29 Jan, 2019 1 commit
  10. 22 Jan, 2019 1 commit
  11. 03 Jan, 2019 1 commit
  12. 16 Oct, 2018 1 commit
  13. 04 Oct, 2018 1 commit
  14. 12 Sep, 2018 1 commit
  15. 15 Aug, 2018 1 commit
  16. 31 Jul, 2018 1 commit
  17. 24 Jul, 2018 1 commit
    • Jonah Williams's avatar
      Semantics framework updates (#18758) · 810a29d6
      Jonah Williams authored
      Changes:
      
      - Move the SemanticsConfiguration update from RenderToggleable to each subclass, so that Switch can use toggled.
      - Add image, liveRegion, toggled properties to Semantics, SemanticsConfiguration, SemanticsNode
      - Added semanticsLabel and excludeFromSemantics to Image (the latter so that we avoid creating a semantics node)
      - Added onDismiss semantics action which maps to the modal escape on iOS and dismiss action on Android.
      - Added dismiss and liveRegion to snackbar widget
      - Updated custom painter semantics to handle image, liveRegion, toggle
      - Updated relevant tests to use correct flag/action
      810a29d6
  18. 12 Jun, 2018 1 commit
  19. 21 Apr, 2018 1 commit
  20. 17 Apr, 2018 3 commits
    • Chinmay Garde's avatar
      Roll engine to 0c09bf03d. (#16668) · e9177ba3
      Chinmay Garde authored
      This roll includes the following engine commits:
      
      * flutter/engine@0c09bf03: In the service protocol, if no view is specified to flush tasks on, pick the first one. (#5028)
      * flutter/engine@ecaefd7a: Roll src/third_party/skia/ 276886160..1cd6098d5 (50 commits) (#5026)
      * flutter/engine@e6545573: Enable 'Speak Screen' and 'Switch Control' for iOS (#5016)
      * flutter/engine@3393c179: Fix Android platform channels (#5025)
      * flutter/engine@1bc0e1bb: On windows, refer to Dart snapshot directly executable. (#5024)
      * flutter/engine@cf6ca32d: Revert "Roll Dart to fe606f890b0a311da802c78b0af414a3c2087a79" (#5023)
      * flutter/engine@4b45a53e: Only make ERROR and FATAL log levels visible by default. (#5022)
      * flutter/engine@98f6c2d5: Fix shell launcher test (dart2 compliant and stop polling) (#5009)
      * flutter/engine@75851f08: Roll Dart to fe606f890b0a311da802c78b0af414a3c2087a79 (#5020)
      * flutter/engine@9495a52d: On iOS, try to use ES3, then fall back to ES2. (#5006)
      * flutter/engine@d6d4eec2: Fix broken Linux build (#5019)
      * flutter/engine@d15dc76e: Fix broken Chromebot build (#5018)
      * flutter/engine@c17a6290: Breadcrumbs to the wiki (#5017)
      * flutter/engine@4eaf2c2f: Return raw (unencoded) bytes in Image.toByteData() (#5008)
      * flutter/engine@d812a617: Roll src/third_party/skia/ e669bdfad..276886160 (9 commits) (#5014)
      * flutter/engine@62aeab72: Call SkSurface::flush instead of getting a backend handle in vulkan_swapchain. (#5012)
      * flutter/engine@f4ebb180: Roll src/third_party/skia/ 3462eb034..e669bdfad (54 commits) (#5007)
      * flutter/engine@0b7d6be9: Re-land "do not pause rendering when android view loses focus" (#5004)
      * flutter/engine@91dee598: If the rasterizer has a valid surface context, use that to create a snapshotting render target. (#4979)
      * flutter/engine@570231b7: Specify the packages file path when running engine dart tests. (#5005)
      * flutter/engine@0b9cef5a: Minor update to README (#5003)
      * flutter/engine@c386418f: Promote line height in text style created from paragraph style (#4995)
      * flutter/engine@4e0fbb6f: If the test specifies a .dill file, dont make the engine interpret is as source. (#5002)
      * flutter/engine@58e84c8b: Re-land "Support multiple shells in a single process. (#4932)" (#4998)
      * flutter/engine@37e5df05: Remove only use of SkPaint::kGenA8FromLCD (#4994)
      * flutter/engine@b7358b33: libtxt: cache font families that are remapped to the default font family (#4990)
      * flutter/engine@a530035b: libtxt: fix leaks in Skia object reference counting (#4988)
      * flutter/engine@0c74fc93: [fuchsia] Fix use-after-free (#4987)
      * flutter/engine@b6d2dde9: [fuchsia] Fix build (#4986)
      * flutter/engine@1dd12649: [async] Adapt to libasync API changes. (#4980)
      e9177ba3
    • Mikkel Nygaard Ravn's avatar
    • Todd Volkert's avatar
      Roll engine to 1bc0e1bb9a8db882a21086096cc2b1e0854312b7 (#16643) · dd32d1b1
      Todd Volkert authored
      * Roll engine to d6d4eec24c38bb06a9b1aef4e70c321d447ba762
      
      Contains the following engine commits:
      
      flutter/engine@1bc0e1b On windows, refer to Dart snapshot directly executable.
      flutter/engine@cf6ca32 Revert "Roll Dart to fe606f890b0a311da802c78b0af414a3c2087a79"
      flutter/engine@4b45a53 Only make ERROR and FATAL log levels visible by default.
      flutter/engine@98f6c2d Fix shell launcher test (dart2 compliant and stop polling)
      flutter/engine@75851f0 Roll Dart to fe606f890b0a311da802c78b0af414a3c2087a79
      flutter/engine@9495a52 On iOS, try to use ES3, then fall back to ES2.
      flutter/engine@d6d4eec Fix broken Linux build
      flutter/engine@d15dc76 Fix broken Chromebot build
      flutter/engine@c17a629 Breadcrumbs to the wiki
      flutter/engine@4eaf2c2 Return raw (unencoded) bytes in Image.toByteData()
      flutter/engine@d812a61 Roll src/third_party/skia/ e669bdfad..276886160 (9 commits)
      flutter/engine@62aeab7 Call SkSurface::flush instead of getting a backend handle in vulkan_swapchain.
      flutter/engine@f4ebb18 Roll src/third_party/skia/ 3462eb034..e669bdfad (54 commits)
      flutter/engine@0b7d6be Re-land "do not pause rendering when android view loses focus"
      flutter/engine@91dee59 If the rasterizer has a valid surface context, use that to create a snapshotting render target.
      flutter/engine@570231b Specify the packages file path when running engine dart tests.
      flutter/engine@0b9cef5 Minor update to README
      flutter/engine@c386418 Promote line height in text style created from paragraph style
      flutter/engine@4e0fbb6 If the test specifies a .dill file, dont make the engine interpret is as source.
      flutter/engine@58e84c8 Re-land "Support multiple shells in a single process.
      flutter/engine@37e5df0 Remove only use of SkPaint::kGenA8FromLCD
      flutter/engine@b7358b3 libtxt: cache font families that are remapped to the default font family
      flutter/engine@a530035 libtxt: fix leaks in Skia object reference counting
      flutter/engine@0c74fc9 [fuchsia] Fix use-after-free
      flutter/engine@b6d2dde [fuchsia] Fix build
      flutter/engine@1dd1264 [async] Adapt to libasync API changes.
      
      * Run test platform finalizers in reverse order to ensure that shell is shutdown before trying to delete any temporary files or directories. This fixes "Access Denied" error on Windows (see #16657).
      dd32d1b1
  21. 06 Apr, 2018 1 commit
  22. 09 Feb, 2018 1 commit
  23. 02 Feb, 2018 1 commit
  24. 16 Jan, 2018 1 commit
    • Dwayne Slater's avatar
      Set _imageInfo to null BEFORE adding listener to new ImageStream (#13825) · 4488f58a
      Dwayne Slater authored
      * Set _imageInfo to null before adding listener to new ImageStream
      
      Fixes an edge case where switching the ImageStream to an already completed ImageStream caused the Image widget to show nothing. ImageStreamCompleter calls the listener during addListener if their image is already loaded.
      
      * Fix whitespace
      
      * Add test to verify correct behavior
      
      * Added test from mravn-google's PR
      4488f58a
  25. 10 Jan, 2018 1 commit
    • Ian Hickson's avatar
      Make DecoratedBox repaint after being reparented (#13927) · 316d8e1c
      Ian Hickson authored
      Fixes https://github.com/flutter/flutter/issues/12553
      
      The root cause of https://github.com/flutter/flutter/issues/12553 was that when the refresh indicator went away, which happened after the avatars had started their image loads but before the avatars had loaded, the DecoratedBoxes, along with the rest of the list, got GlobalKey-reparented, which caused the RenderDecoratedBox objects to unregister from the DecorationImagePainters, but they never re-registered since the whole subtree was in a RepaintBoundary and was therefore not explicitly repainted when the tree got reattached.
      
      This fixes the bug by explicitly requiring any RenderDecoratedBox to repaint when it's reattached. This is probably a little more aggressive than required; we could probably expose a flag on Decoration that says whether or not the onChanged handler will ever be invoked, and only call markNeedsPaint if that's true, but we'll do that if it turns out that there's a performance issue here.
      
      (This patch also introduces a bunch of improved debugging information that I used to track down the bug.)
      316d8e1c
  26. 07 Dec, 2017 1 commit
    • Ian Hickson's avatar
      Move image logic from services/ to painting/. (#13409) · 44e228eb
      Ian Hickson authored
      This allows the scheduler library to depend on the services library
      and the painting library to depend on the scheduler library without
      the services library having to depend on the scheduler library.
      
      While I was at it I also cleaned up some of the binding logic: the
      licenses logic can now be overridden (and the test library does so),
      and the image cache can now be overridden as well.
      44e228eb
  27. 22 Nov, 2017 1 commit
    • amirh's avatar
      Don't keep image stream listeners when TickerMode is disabled. (#13106) · 155a4cab
      amirh authored
      This makes sure that we don't decode frames when we don't need to run
      the animation.
      
      For example, prior to this CL: an animated image in a page that is not
      currently at the top of the page stack (it is covered by another page),
      will keep the the image stream listener, and thus frames will still be
      decoded.
      155a4cab
  28. 28 Aug, 2017 1 commit
    • Ian Hickson's avatar
      RTL: Padding, Flex (#11709) · f235a2c1
      Ian Hickson authored
      * Introduce a Directionality inherited widget which sets the ambient LTR vs RTL mode (defaulting to null, which means you cannot use directionality-influenced values).
      
      * Make it possible to configure Padding (including Container.padding and Container.margin) using a directionality-agnostic EdgeInsets variant.
      
      * Provide textDirection and verticalDirection controls on Row and Column to make them RTL-aware.
      
      * Introduce a variant of FractionalOffset based on the EdgeInsets variant. Not yet actually used.
      
      * Fix all the tests that depended on Row defaulting to LTR.
      f235a2c1
  29. 03 Aug, 2017 1 commit
  30. 02 Aug, 2017 1 commit
  31. 25 Jul, 2017 1 commit
  32. 27 Jun, 2017 1 commit
  33. 21 Jun, 2017 3 commits
  34. 20 Apr, 2017 1 commit
  35. 20 Mar, 2017 1 commit
  36. 04 Mar, 2017 1 commit