Commits · acbfb40f05d28225398f262eb70cd51cf894aa64 · abdullh.alsoleman / Front-End

17 May, 2023 14 commits

Handle null return from WillPopCallback (#127039) · acbfb40f

Michael Goderbauer authored May 17, 2023

Partial revert of https://github.com/flutter/flutter/pull/126647 to work around issue in google3.

See b/283046390

acbfb40f

Roll Flutter Engine from 6048360c1837 to 400a26ad8343 (1 revision) (#127036) · c08b9acc

engine-flutter-autoroll authored May 17, 2023

https://github.com/flutter/engine/compare/6048360c1837...400a26ad8343

2023-05-17 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from dIATtSiPf8KE25MMF... to wNfsef5we4l8hxEII... (flutter/engine#42094)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from dIATtSiPf8KE to wNfsef5we4l8

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

c08b9acc

Remove unused (and untested) parameters from private _MasterDetailFlow (#126935) · 0bd275fe
Michael Goderbauer authored May 17, 2023
```
Follow-up to https://github.com/flutter/flutter/pull/126926.
```
0bd275fe
Autocomplete async examples (#126283) · 9d882983
Justin McCandless authored May 17, 2023
```
Added examples clarifying how to fetch Autocomplete options asynchronously.
```
9d882983
Expose callback that allows focus traversal customization (#120235) · 561169ec
JellyO1 authored May 17, 2023
```
This PR exposes a requestFocusCallback on `FocusTraversalPolicy` and it's inheritors.

Fixes #83175.
```
561169ec

Roll Packages from b9718302b30f to 5c6991400e91 (5 revisions) (#127034) · 1a76859c

engine-flutter-autoroll authored May 17, 2023

https://github.com/flutter/packages/compare/b9718302b30f...5c6991400e91

2023-05-17 49699333+dependabot[bot]@users.noreply.github.com [video_player]: Bump exoplayer_version from 2.18.5 to 2.18.6 in /packages/video_player/video_player_android/android (flutter/packages#3770)
2023-05-17 JeroenWeener@users.noreply.github.com [in_app_purchase] Fully migrate to BillingClient V5 (flutter/packages#3752)
2023-05-17 stuartmorgan@google.com [ci] Re-enable Windows repo tool tests (flutter/packages#4007)
2023-05-16 stuartmorgan@google.com [ci] Allow simctl shutdown to fail (flutter/packages#4024)
2023-05-16 stuartmorgan@google.com [ci] Move Linux repo tool tests to LUCI (flutter/packages#4006)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

1a76859c

Roll Flutter Engine from ea3f27383acc to 6048360c1837 (2 revisions) (#127032) · 05390851

engine-flutter-autoroll authored May 17, 2023

https://github.com/flutter/engine/compare/ea3f27383acc...6048360c1837

2023-05-17 skia-flutter-autoroll@skia.org Roll Skia from 88d7a68694d9 to c3473c32bb35 (2 revisions) (flutter/engine#42093)
2023-05-17 skia-flutter-autoroll@skia.org Roll Dart SDK from 2fc9f4dd9623 to 7f6fabbe9fba (1 revision) (flutter/engine#42090)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

05390851

Add missing `Switch.onFocusChange` test (#126685) · 160618b1
Taha Tesser authored May 17, 2023

160618b1
Remove 'url_launcher' from pubspec.yaml. (#126939) · d021109d
joshualitt authored May 17, 2023

d021109d

Roll Flutter Engine from 4b7c37532ea4 to ea3f27383acc (1 revision) (#126994) · e2aafd45

engine-flutter-autoroll authored May 17, 2023

https://github.com/flutter/engine/compare/4b7c37532ea4...ea3f27383acc

2023-05-17 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
D_EOM3rJ8AMk3-Wex... to YrEDYUB9NKhirgo5s... (flutter/engine#42086)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from D_EOM3rJ8AMk to YrEDYUB9NKhi

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that
a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

e2aafd45

Roll Flutter Engine from 170b45bae571 to 4b7c37532ea4 (1 revision) (#126985) · 45e3039a

engine-flutter-autoroll authored May 17, 2023

https://github.com/flutter/engine/compare/170b45bae571...4b7c37532ea4

2023-05-17 skia-flutter-autoroll@skia.org Roll Dart SDK from dbbb8a6d79a3 to 2fc9f4dd9623 (1 revision) (flutter/engine#42085)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

45e3039a

Roll Flutter Engine from 28b9dc993c30 to 170b45bae571 (1 revision) (#126981) · 4be65314

engine-flutter-autoroll authored May 17, 2023

https://github.com/flutter/engine/compare/28b9dc993c30...170b45bae571

2023-05-17 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from N4LwCRxg0oIevhQ_O... to dIATtSiPf8KE25MMF... (flutter/engine#42084)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from N4LwCRxg0oIe to dIATtSiPf8KE

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

4be65314

Roll Flutter Engine from 87a03e107df7 to 28b9dc993c30 (1 revision) (#126974) · abdf1f46

engine-flutter-autoroll authored May 17, 2023

https://github.com/flutter/engine/compare/87a03e107df7...28b9dc993c30

2023-05-16 skia-flutter-autoroll@skia.org Roll Dart SDK from d2b2ac829842 to dbbb8a6d79a3 (3 revisions) (flutter/engine#42082)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

abdf1f46

Roll Flutter Engine from 1c775e34e2d5 to 87a03e107df7 (3 revisions) (#126968) · 790897c6

engine-flutter-autoroll authored May 17, 2023

https://github.com/flutter/engine/compare/1c775e34e2d5...87a03e107df7

2023-05-16 bdero@google.com [Impeller] Use 32 bit Gaussian function in the 2-pass blur (flutter/engine#42069)
2023-05-16 skia-flutter-autoroll@skia.org Roll Skia from 9b0e912a1cb9 to 88d7a68694d9 (13 revisions) (flutter/engine#42081)
2023-05-16 jacksongardner@google.com Use client ICU data with skwasm. (flutter/engine#42018)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

790897c6

16 May, 2023 25 commits

Fix style issues (#122586) · 788ceb34

Sigurd Meldgaard authored May 16, 2023

Follow-up to https://github.com/flutter/flutter/pull/121802 resolving some style issues.

788ceb34

Manual roll Flutter Engine from fe2476743b59 to 1c775e34e2d5 (10 revisions) (#126961) · 5df903a0

engine-flutter-autoroll authored May 16, 2023

Manual roll requested by zra@google.com

https://github.com/flutter/engine/compare/fe2476743b59...1c775e34e2d5

2023-05-16 zanderso@users.noreply.github.com Revert "[ios_platform_view]
only recycle maskView when the view is applying mutators"
(flutter/engine#42080)
2023-05-16 gspencergoog@users.noreply.github.com [macOS] Wait for
binding to be ready before requesting exits from framework
(flutter/engine#41753)
2023-05-16 gspencergoog@users.noreply.github.com [linux] Wait for
binding to be ready before requesting exits from framework
(flutter/engine#41782)
2023-05-16 jacksongardner@google.com Initial support for images in
Skwasm (flutter/engine#42019)
2023-05-16 jacksongardner@google.com Use new `unresolvedCodePoints` API
from skia. (flutter/engine#41991)
2023-05-16 jason-simmons@users.noreply.github.com Convert public API
NativeFieldWrapper classes to abstract interfaces (flutter/engine#41945)
2023-05-16 737941+loic-sharma@users.noreply.github.com [Windows] Add
force redraw to the C++ client wrapper (flutter/engine#42061)
2023-05-16 godofredoc@google.com Fix drone_dimension
host_engine_builder. (flutter/engine#42068)
2023-05-16 godofredoc@google.com Add linux_clang_tidy builder.
(flutter/engine#41990)
2023-05-16 ychris@google.com [ios_platform_view] only recycle maskView
when the view is applying mutators (flutter/engine#41573)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that
a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

5df903a0

Make SlottedMultiChildRenderObjectWidgetMixin a concrete class (#126108) · 027bb844

Ian Hickson authored May 16, 2023

This is a proof of concept for renaming SlottedMultiChildRenderObjectWidgetMixin to SlottedMultiChildRenderObjectWidget and making it a concrete class.

I also made SlottedContainerRenderObjectMixin generic instead of being specialized to RenderBox.

I don't think this is something we can easily automigrate, but we may not need to, I don't know how common this is...

027bb844

Add ScrollMetrics.extentTotal for completeness (#126607) · 5235a0f0

Ian Hickson authored May 16, 2023

When implementing scrollbars, I found that it would be useful and idiomatic to be able to do `m.extentInside / m.extentTotal` to get the scrollbar thumb size.

5235a0f0

Fix drone_dimensions. (#126953) · 25a9efe9

godofredoc authored May 16, 2023

Use drone_dimensions instead of dimensions for builds running on dart-internal. This is required for those builders to select the correct drone type.

25a9efe9

Add checkmark style to CupertinoRadio (#126480) · 678f40cf

Mitchell Goodwin authored May 16, 2023

Fixes: #102813

Adds a checkmark style to the Cupertino Radio. Also allows the Radio.adaptive and RadioListTile.adaptive widgets to control whether they use the checkmark style for their Cupertino widgets or not.

This is how it looks in action:

https://github.com/flutter/flutter/assets/58190796/b409b270-42dd-404a-9350-d2c3e1d7fa4e

678f40cf

Move `Mac_build_test flutter_gallery__transition_perf_e2e_ios` to prod (#126941) · 3f01c7e0

keyonghan authored May 16, 2023

Target `Mac_build_test flutter_gallery__transition_perf_e2e_ios` was enabled in staging: https://github.com/flutter/flutter/pull/111164, and it has passed more than 50 runs: https://ci.chromium.org/p/flutter/builders/staging/Mac_build_test%20flutter_gallery__transition_perf_e2e_ios?limit=50.

Manually enabling it in prod and removing the old `Mac_ios flutter_gallery__transition_perf_e2e_ios`.

The `Mac_build_test` one does the same thing as `Mac_ios` one, but separating build and test steps in separate targets.

Context: https://github.com/flutter/flutter/issues/103542

3f01c7e0

Fix DataTableThemeData.copyWith handling of dataRowHeight (#126943) · e24c64d8
Jason Simmons authored May 16, 2023
```
Fixes https://github.com/flutter/flutter/issues/126676
```
e24c64d8

Fix copyWith method of ActionIconThemeData (#126763) · 60751ca5

Mushaheed Syed authored May 16, 2023

Fixes copyWith method of ActionIconThemeData, now using blank copyWith on [ActionIconThemeData] object that isn't `const ActionIconThemeData()` returns object with same values.

*List which issues are fixed by this PR.*
Fixes https://github.com/flutter/flutter/issues/126762

60751ca5

Revert "Roll Flutter Engine from fe2476743b59 to 5cf141f7c03c (2 revisions)" (#126954) · 99464341
Zachary Anderson authored May 16, 2023
```
Reverts flutter/flutter#126934

Bad Engine roll.
```
99464341

Roll Flutter Engine from fe2476743b59 to 5cf141f7c03c (2 revisions) (#126934) · d0d1feb6

engine-flutter-autoroll authored May 16, 2023

https://github.com/flutter/engine/compare/fe2476743b59...5cf141f7c03c

2023-05-16 godofredoc@google.com Add linux_clang_tidy builder. (flutter/engine#41990)
2023-05-16 ychris@google.com [ios_platform_view] only recycle maskView when the view is applying mutators (flutter/engine#41573)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

d0d1feb6

Remove outdated comment (#126927) · 1ca183d5
Michael Goderbauer authored May 16, 2023
```
Follow-up to https://github.com/flutter/flutter/pull/126647#discussion_r1195417860.
```
1ca183d5

Alert engine upon registering ServiceBinding (#126075) · 130944e7

yaakovschectman authored May 16, 2023

Send a platform message to the engine when the `ServiceBinding` is
registered. Framework side of
https://github.com/flutter/engine/pull/41733

Addresses https://github.com/flutter/flutter/issues/126033

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat

---------
Co-authored-by: Greg Spencer <gspencergoog@users.noreply.github.com>

130944e7

Roll Flutter Engine from 525a53eb58ed to fe2476743b59 (1 revision) (#126925) · cc44359b

engine-flutter-autoroll authored May 16, 2023

https://github.com/flutter/engine/compare/525a53eb58ed...fe2476743b59

2023-05-16 skia-flutter-autoroll@skia.org Roll Skia from 24bebce2d9a1 to 9b0e912a1cb9 (12 revisions) (flutter/engine#42072)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

cc44359b

Replace rsync when unzipping artifacts on a Mac (#126703) · 2b3cd7f4

Victoria Ashworth authored May 16, 2023

Instead of using rsync, which has caused errors in the past (https://github.com/flutter/flutter/issues/99785), delete the file/directory/link prior to moving it.

Hopefully should let us stop double zipping the FlutterMacOS.framework in the engine: https://github.com/flutter/engine/pull/41306/files

Part of https://github.com/flutter/flutter/issues/126016.

2b3cd7f4

Update SemanticsUpdateBuilderSpy for the conversion of SemanticsUpdateBuilder... · a3b38aa8

Jason Simmons authored May 16, 2023

Update SemanticsUpdateBuilderSpy for the conversion of SemanticsUpdateBuilder into a base class (#126570)

See https://github.com/flutter/flutter/issues/123756

a3b38aa8

expose `CupertinoDatePicker` and `CupertinoTimerPicker` `itemExtent` … (#125852) · 6753a852

st merlhin authored May 16, 2023

â¦property

This PR expose `CupertinoDatePicker` and `CupertinoTimerPicker` `itemExtent` property to allow setting custom one depending on `tMediaQuery.of(context).textScaleFactor`.
Fixes: #125127

6753a852

Roll Flutter Engine from d7a5de672d1e to 525a53eb58ed (1 revision) (#126923) · 856fcc30

engine-flutter-autoroll authored May 16, 2023

https://github.com/flutter/engine/compare/d7a5de672d1e...525a53eb58ed

2023-05-16 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
38Oyy28qgYCdt7fEV... to D_EOM3rJ8AMk3-Wex... (flutter/engine#42071)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from 38Oyy28qgYCd to D_EOM3rJ8AMk

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that
a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

856fcc30

enable no_literal_bool_comparisons lint (#126647) · 5e1ba701
Michael Goderbauer authored May 16, 2023

5e1ba701

Roll Packages from 6608b604b0e7 to b9718302b30f (2 revisions) (#126921) · b45f9b36

engine-flutter-autoroll authored May 16, 2023

https://github.com/flutter/packages/compare/6608b604b0e7...b9718302b30f

2023-05-16 stuartmorgan@google.com [camera] Fix Android lint issues (flutter/packages#3993)
2023-05-15 stuartmorgan@google.com [various] Update min macOS versions (flutter/packages#3987)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

b45f9b36

Updated the `Drawer` API doc to link to `NavigationDrawer` (#126915) · 2f5ed339
Taha Tesser authored May 16, 2023
```
fixes https://github.com/flutter/flutter/issues/124887
```
2f5ed339

Roll Flutter Engine from c4d4b40c6596 to d7a5de672d1e (4 revisions) (#126919) · e62e5c41

engine-flutter-autoroll authored May 16, 2023

https://github.com/flutter/engine/compare/c4d4b40c6596...d7a5de672d1e

2023-05-16 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from
JCoP2Fekj3MBIqskE... to N4LwCRxg0oIevhQ_O... (flutter/engine#42070)
2023-05-16 zhangzhijian.123@bytedance.com [Impeller] Fix issue about
saveLayer ignoring opacity of paint with advanced blend mode
(flutter/engine#41972)
2023-05-16 ychris@google.com [ios_platform_view] Only remove platform
views from flutter view in reset. (flutter/engine#41709)
2023-05-16 godofredoc@google.com Add drone_dimensions as top level
target property. (flutter/engine#42064)

Also rolling transitive DEPS:
  fuchsia/sdk/core/mac-amd64 from JCoP2Fekj3MB to N4LwCRxg0oIe

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that
a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

e62e5c41

Upgrade leak_tracker to 5.0.0 (#126367) · ea5eddb5

Polina Cherkasova authored May 16, 2023

Fixes https://github.com/flutter/flutter/issues/126259

Updated pubspec:
https://github.com/flutter/flutter/blob/345f0bffbfda31fab7d4a740f65b3d1610d20a99/packages/flutter/pubspec.yaml

ea5eddb5

Minor documentation fixes (#126609) · 2919572f
Ian Hickson authored May 16, 2023
```
Fixes for grammar, tone, and clarity.
```
2919572f

Roll Flutter Engine from 027ca797985f to c4d4b40c6596 (6 revisions) (#126894) · 6b6c4bdb

engine-flutter-autoroll authored May 16, 2023

https://github.com/flutter/engine/compare/027ca797985f...c4d4b40c6596

2023-05-15 ychris@google.com Fix upload xcresult script in run_tests.py (flutter/engine#42056)
2023-05-15 jonahwilliams@google.com [Impeller] set stencil attachment descriptor for runtime effect. (flutter/engine#42054)
2023-05-15 skia-flutter-autoroll@skia.org Roll Skia from 4becb53e3c21 to 24bebce2d9a1 (20 revisions) (flutter/engine#42058)
2023-05-15 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from EweLgJoiYUDok2vyU... to 38Oyy28qgYCdt7fEV... (flutter/engine#42057)
2023-05-15 bdero@google.com [Impeller] Remove debug print statement from EntityPass (flutter/engine#42055)
2023-05-15 jacksongardner@google.com Compile skwasm at -Oz. (flutter/engine#42002)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from EweLgJoiYUDo to 38Oyy28qgYCd

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

6b6c4bdb

15 May, 2023 1 commit

Adds drawn image wide gamut test (#126715) · 63800755

gaaclarke authored May 15, 2023

integration test for https://github.com/flutter/engine/pull/41994
issue https://github.com/flutter/flutter/issues/126620

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat

63800755