Commits · acaa97350a70ee5d53171998027892db361c9733 · abdullh.alsoleman / Front-End

29 Aug, 2023 26 commits

Roll Flutter Engine from 01a1579808b5 to 1feb9302050c (1 revision) (#133604) · acaa9735

engine-flutter-autoroll authored Aug 29, 2023

https://github.com/flutter/engine/compare/01a1579808b5...1feb9302050c

2023-08-29 109111084+yaakovschectman@users.noreply.github.com Add callback to Embedder API to respond to new channel listeners, and use for Windows lifecycle (flutter/engine#44827)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

acaa9735

Upgrade packages. (#133593) · 67f9d771
Polina Cherkasova authored Aug 29, 2023

67f9d771
Cover more tests with leak tracking. (#133596) · fb5abe45
Polina Cherkasova authored Aug 29, 2023

fb5abe45

Roll Flutter Engine from 73cc3fb451fd to 01a1579808b5 (3 revisions) (#133591) · fc06fe6a

engine-flutter-autoroll authored Aug 29, 2023

https://github.com/flutter/engine/compare/73cc3fb451fd...01a1579808b5

2023-08-29 skia-flutter-autoroll@skia.org Roll Skia from 15de7f9c3b3b to fb09020ce62d (3 revisions) (flutter/engine#45233)
2023-08-29 matanlurey@users.noreply.github.com Use `runIfNot: ...` to avoid running Fuchsia try-jobs for some changes. (flutter/engine#45134)
2023-08-29 zanderso@users.noreply.github.com Clean up engine repo Dart code (flutter/engine#45203)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

fc06fe6a

Added DropdownMenuEntry.labelWidget (#133491) · 4022864c
Hans Muller authored Aug 29, 2023

4022864c
Use a fake stopwatch to remove flakiness. (#133229) · 89310eda
Ian Hickson authored Aug 29, 2023
```
Fixes https://github.com/flutter/flutter/issues/133215
```
89310eda

Roll Flutter Engine from d1e6eb080f08 to 73cc3fb451fd (3 revisions) (#133580) · bfbfce49

engine-flutter-autoroll authored Aug 29, 2023

https://github.com/flutter/engine/compare/d1e6eb080f08...73cc3fb451fd

2023-08-29 skia-flutter-autoroll@skia.org Roll Skia from b7e826d5324f to 15de7f9c3b3b (3 revisions) (flutter/engine#45231)
2023-08-29 jonahwilliams@google.com [Impeller] its not safe to presentWithTransaction from a background thread. (flutter/engine#45182)
2023-08-29 skia-flutter-autoroll@skia.org Roll Skia from b0c1b2868129 to b7e826d5324f (4 revisions) (flutter/engine#45229)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

bfbfce49

[web] Migrate remaining web-only API usages to `dart:ui_web` (#132248) · 9a9c2826

Mouad Debbar authored Aug 29, 2023

This is the last batch of web-only API migration.

Depends on https://github.com/flutter/engine/pull/44516

Fixes https://github.com/flutter/flutter/issues/52899
Fixes https://github.com/flutter/flutter/issues/126831

9a9c2826

Add doxygen doc generation. (#131356) · ff829fd8
Greg Spencer authored Aug 29, 2023

ff829fd8

Roll Flutter Engine from 50bd80773287 to d1e6eb080f08 (2 revisions) (#133570) · 7ef4290a

engine-flutter-autoroll authored Aug 29, 2023

https://github.com/flutter/engine/compare/50bd80773287...d1e6eb080f08

2023-08-29 skia-flutter-autoroll@skia.org Roll Skia from 4048262b9b21 to b0c1b2868129 (2 revisions) (flutter/engine#45227)
2023-08-29 mdebbar@google.com [web] Make devicePixelRatio ready for multi-view (flutter/engine#44783)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

7ef4290a

ShortcutManager should dispatch creation in constructor. (#133487) · ae64abc6
Polina Cherkasova authored Aug 29, 2023

ae64abc6

Add FAB Additional Color Mappings example (#133453) · d8d7e019

Taha Tesser authored Aug 29, 2023

fixes [Additional color mappings for FAB in Material 3](https://github.com/flutter/flutter/issues/130702)

### Preview
![image](https://github.com/flutter/flutter/assets/48603081/a6f9aef6-af80-41ce-8e59-50f095db047d)

d8d7e019

Roll Flutter Engine from 65438c7bb46a to 50bd80773287 (1 revision) (#133565) · f6c20db6

engine-flutter-autoroll authored Aug 29, 2023

https://github.com/flutter/engine/compare/65438c7bb46a...50bd80773287

2023-08-29 skia-flutter-autoroll@skia.org Roll Skia from 7675f886f884 to 4048262b9b21 (2 revisions) (flutter/engine#45225)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

f6c20db6

Roll Packages from 383bffa3991d to d7d3150e5966 (13 revisions) (#133564) · dcdc4df9

engine-flutter-autoroll authored Aug 29, 2023

https://github.com/flutter/packages/compare/383bffa3991d...d7d3150e5966

2023-08-29 ian@hixie.ch [rfw] Implement /* block comments */ in the text format (flutter/packages#4769)
2023-08-29 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.21.4 to 2.21.5 (flutter/packages#4810)
2023-08-28 engine-flutter-autoroll@skia.org Roll Flutter from cd3aeef3 to ec387a46 (15 revisions) (flutter/packages#4807)
2023-08-28 49699333+dependabot[bot]@users.noreply.github.com [pigeon]: Bump org.jetbrains.kotlin:kotlin-gradle-plugin from 1.9.0 to 1.9.10 in /packages/pigeon/platform_tests/test_plugin/android (flutter/packages#4798)
2023-08-28 jhy03261997@gmail.com Fix popping repeated pages unexpectedly (flutter/packages#4763)
2023-08-28 tarrinneal@gmail.com [pigeon] primitive enums (flutter/packages#4580)
2023-08-27 engine-flutter-autoroll@skia.org Roll Flutter from 229b74d9 to cd3aeef3 (4 revisions) (flutter/packages#4777)
2023-08-26 engine-flutter-autoroll@skia.org Roll Flutter from 61d9f556 to 229b74d9 (13 revisions) (flutter/packages#4776)
2023-08-25 engine-flutter-autoroll@skia.org Roll Flutter from deeb811e to 61d9f556 (25 revisions) (flutter/packages#4774)
2023-08-25 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 3.5.3 to 3.6.0 (flutter/packages#4770)
2023-08-24 praconfi@gmail.com [css_colors] docs: Update deprecated link address (flutter/packages#4537)
2023-08-24 engine-flutter-autoroll@skia.org Roll Flutter (stable) from efbf63d9c66b to e1e47221e862 (3 revisions) (flutter/packages#4767)
2023-08-24 engine-flutter-autoroll@skia.org Roll Flutter from bd836cc6 to deeb811e (17 revisions) (flutter/packages#4766)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

dcdc4df9

Roll Flutter Engine from d84763e04496 to 65438c7bb46a (1 revision) (#133563) · 6c957373

engine-flutter-autoroll authored Aug 29, 2023

https://github.com/flutter/engine/compare/d84763e04496...65438c7bb46a

2023-08-29 skia-flutter-autoroll@skia.org Roll Skia from 85377eca700d to 7675f886f884 (7 revisions) (flutter/engine#45224)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

6c957373

Roll Flutter Engine from 0625049b5ee3 to d84763e04496 (6 revisions) (#133559) · dbe114d8

engine-flutter-autoroll authored Aug 29, 2023

https://github.com/flutter/engine/compare/0625049b5ee3...d84763e04496

2023-08-29 skia-flutter-autoroll@skia.org Roll Dart SDK from 70066300aa83 to a4e0e792ef9a (1 revision) (flutter/engine#45221)
2023-08-29 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from 68DESTl_q6I45UJyb... to QKekosWnIY_ObKstn... (flutter/engine#45217)
2023-08-29 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from Ys38QMyFZToJxnXrF... to z9uQ0mXwjKFQF05Xl... (flutter/engine#45216)
2023-08-29 skia-flutter-autoroll@skia.org Roll Skia from e9e4d0dacc9d to 85377eca700d (1 revision) (flutter/engine#45215)
2023-08-29 skia-flutter-autoroll@skia.org Roll Skia from 5dd678aebdaf to e9e4d0dacc9d (1 revision) (flutter/engine#45214)
2023-08-29 skia-flutter-autoroll@skia.org Roll Dart SDK from f6c11801db41 to 70066300aa83 (1 revision) (flutter/engine#45212)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from Ys38QMyFZToJ to z9uQ0mXwjKFQ
fuchsia/sdk/core/mac-amd64 from 68DESTl_q6I4 to QKekosWnIY_O

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

dbe114d8

Roll Flutter Engine from c2ec683c4ea8 to 0625049b5ee3 (2 revisions) (#133538) · c66e922a

engine-flutter-autoroll authored Aug 29, 2023

https://github.com/flutter/engine/compare/c2ec683c4ea8...0625049b5ee3

2023-08-29 skia-flutter-autoroll@skia.org Roll Skia from 01ee493cc113 to 5dd678aebdaf (1 revision) (flutter/engine#45210)
2023-08-29 skia-flutter-autoroll@skia.org Roll Skia from f576668bfe99 to 01ee493cc113 (1 revision) (flutter/engine#45208)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

c66e922a

Roll Flutter Engine from 3d1faae1bc2f to c2ec683c4ea8 (4 revisions) (#133535) · d58f158a

engine-flutter-autoroll authored Aug 29, 2023

https://github.com/flutter/engine/compare/3d1faae1bc2f...c2ec683c4ea8

2023-08-29 zhongwuzw@qq.com [iOS] Don't call App lifecycle resumed when device is locked (flutter/engine#44947)
2023-08-29 skia-flutter-autoroll@skia.org Roll Dart SDK from 60a3bb84fa6d to f6c11801db41 (1 revision) (flutter/engine#45207)
2023-08-29 skia-flutter-autoroll@skia.org Roll Skia from b27fecd52899 to f576668bfe99 (1 revision) (flutter/engine#45206)
2023-08-29 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 3.5.3 to 3.6.0 (flutter/engine#45205)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

d58f158a

Roll Flutter Engine from c7c61ff9732c to 3d1faae1bc2f (1 revision) (#133530) · d37a8e46

engine-flutter-autoroll authored Aug 29, 2023

https://github.com/flutter/engine/compare/c7c61ff9732c...3d1faae1bc2f

2023-08-29 skia-flutter-autoroll@skia.org Roll Skia from 66e367b12e96 to b27fecd52899 (1 revision) (flutter/engine#45204)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

d37a8e46

Fix bug in setPreferredOrientations example (#133503) · f489256f

Dan Field authored Aug 29, 2023

The `ui.Display` is a simple data class (like `MediaQueryData`), and does not get updated when the display size changes.  The provided sample code does not work as intended, but the update does.

f489256f

Roll Flutter Engine from 9778c2cb1d51 to c7c61ff9732c (2 revisions) (#133527) · 6dae2698

engine-flutter-autoroll authored Aug 29, 2023

https://github.com/flutter/engine/compare/9778c2cb1d51...c7c61ff9732c

2023-08-29 skia-flutter-autoroll@skia.org Roll Dart SDK from 2900ad211f38 to 60a3bb84fa6d (1 revision) (flutter/engine#45201)
2023-08-29 matanlurey@users.noreply.github.com A minimal `engine_tools_lib` to use for local-repo Dart tooling (flutter/engine#45154)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

6dae2698

Roll Flutter Engine from ffda7e3cfc7f to 9778c2cb1d51 (1 revision) (#133526) · 773287b7

engine-flutter-autoroll authored Aug 29, 2023

https://github.com/flutter/engine/compare/ffda7e3cfc7f...9778c2cb1d51

2023-08-29 jacksongardner@google.com Fix scene view canvas/platform view placement. (flutter/engine#45199)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

773287b7

Roll Flutter Engine from 1e821961e96a to ffda7e3cfc7f (2 revisions) (#133523) · 8845c80a

engine-flutter-autoroll authored Aug 29, 2023

https://github.com/flutter/engine/compare/1e821961e96a...ffda7e3cfc7f

2023-08-29 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from u44zzvYd85WSDMpS3... to 68DESTl_q6I45UJyb... (flutter/engine#45197)
2023-08-29 matanlurey@users.noreply.github.com Rename `instrumentation` to `stopwatch` (flutter/engine#45196)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from u44zzvYd85WS to 68DESTl_q6I4

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

8845c80a

Roll Flutter Engine from 45e2b41e5ae5 to 1e821961e96a (2 revisions) (#133520) · e6c7b849

engine-flutter-autoroll authored Aug 29, 2023

https://github.com/flutter/engine/compare/45e2b41e5ae5...1e821961e96a

2023-08-29 jonahwilliams@google.com [Impeller] Sync presentation when rendering into FlutterImageView. (flutter/engine#44881)
2023-08-28 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from AQZddYgKiWrQL8vny... to Ys38QMyFZToJxnXrF... (flutter/engine#45195)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from AQZddYgKiWrQ to Ys38QMyFZToJ

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

e6c7b849

Roll Flutter Engine from bd2132a0814f to 45e2b41e5ae5 (2 revisions) (#133518) · 6cc01ced

engine-flutter-autoroll authored Aug 29, 2023

https://github.com/flutter/engine/compare/bd2132a0814f...45e2b41e5ae5

2023-08-28 jacksongardner@google.com [skwasm] encode PNGs using browser APIs (flutter/engine#45187)
2023-08-28 skia-flutter-autoroll@skia.org Roll Dart SDK from 5d3ab5db5037 to 2900ad211f38 (3 revisions) (flutter/engine#45192)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

6cc01ced

add missing forwards of local-engine-host in benchmark runners (#133517) · 88717b3c

Jim Graham authored Aug 29, 2023

Some places where we are missing a forward of the `--local-engine-host` values in the benchmark code preventing local running of the benchmarks (does not affect CI usages which don't override local engine).

88717b3c

28 Aug, 2023 14 commits

Roll Flutter Engine from a7a4c1c70bad to bd2132a0814f (3 revisions) (#133516) · 42e2f4fb

engine-flutter-autoroll authored Aug 28, 2023

https://github.com/flutter/engine/compare/a7a4c1c70bad...bd2132a0814f

2023-08-28 skia-flutter-autoroll@skia.org Roll Skia from 335f748463db to 66e367b12e96 (1 revision) (flutter/engine#45189)
2023-08-28 jonahwilliams@google.com [Impeller] Cache Skia text bounds computation. (flutter/engine#45150)
2023-08-28 skia-flutter-autoroll@skia.org Roll Skia from 83f6fbad8a38 to 335f748463db (1 revision) (flutter/engine#45186)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

42e2f4fb

FocusNode and FocusManager should dispatch creation in constructor. (#133490) · bd1583f3
Polina Cherkasova authored Aug 28, 2023

bd1583f3
Use flutter pub get instead of dart pub get in create_api_docs.dart (#133493) · 5bd8579b
Greg Spencer authored Aug 28, 2023

5bd8579b
PlatformRouteInformationProvider should dispatch creation in constructor. (#133492) · e8df4349
Polina Cherkasova authored Aug 28, 2023

e8df4349

Roll Flutter Engine from 91522a188bda to a7a4c1c70bad (11 revisions) (#133508) · 2540412b

engine-flutter-autoroll authored Aug 28, 2023

https://github.com/flutter/engine/compare/91522a188bda...a7a4c1c70bad

2023-08-28 matanlurey@users.noreply.github.com Explain how to update the embedder/fixtures golden outputs. (flutter/engine#45184)
2023-08-28 skia-flutter-autoroll@skia.org Roll Skia from ded5d08a9999 to 83f6fbad8a38 (1 revision) (flutter/engine#45183)
2023-08-28 jonahwilliams@google.com [Impeller] Simplify color source + text with new Skia API. (flutter/engine#45090)
2023-08-28 matanlurey@users.noreply.github.com Re-write docs for DlSkCanvas{Adapter|Dispatcher}. (flutter/engine#44961)
2023-08-28 skia-flutter-autoroll@skia.org Roll Skia from 5baa2c74fbc6 to ded5d08a9999 (1 revision) (flutter/engine#45181)
2023-08-28 skia-flutter-autoroll@skia.org Roll Skia from 651ada29fcb0 to 5baa2c74fbc6 (2 revisions) (flutter/engine#45178)
2023-08-28 skia-flutter-autoroll@skia.org Roll Skia from 477659e6f41b to 651ada29fcb0 (3 revisions) (flutter/engine#45176)
2023-08-28 bdero@google.com [Impeller] Only enable captures in debug builds. (flutter/engine#45174)
2023-08-28 skia-flutter-autoroll@skia.org Roll Skia from ce99ad7b587e to 477659e6f41b (1 revision) (flutter/engine#45173)
2023-08-28 jacksongardner@google.com Skwasm platform views (flutter/engine#43011)
2023-08-28 skia-flutter-autoroll@skia.org Roll Skia from df783b542165 to ce99ad7b587e (2 revisions) (flutter/engine#45172)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

2540412b

Revert "Remove `ImageProvider.load`, `DecoderCallback` and `PaintingB… (#133482) · 7772f6b0

Zachary Anderson authored Aug 28, 2023

…inding.instantiateImageCodec` (#132679)"

This reverts commit b4f4ece4.

Trial revert for https://github.com/flutter/flutter/issues/133398Co-authored-by: LongCatIsLooong <31859944+LongCatIsLooong@users.noreply.github.com>

7772f6b0

Fix context menu button color on Android when textButtonTheme is set (#133271) · ca33836b

Renzo Olivares authored Aug 28, 2023

Fixes #133027

When setting a `textButtonTheme` it should not override the native context menu colors.

```dart
  theme: ThemeData(
    textButtonTheme: const TextButtonThemeData(
      style: ButtonStyle(
        backgroundColor: MaterialStatePropertyAll<Color>(
            Color(0xff05164d)), // blue color
      ),
    ),
  ),
```

Before|After
--|--
<img width="341" alt="Screenshot 2023-08-24 at 1 17 25 PM" src="https://github.com/flutter/flutter/assets/948037/30ea0ef8-b41a-4e1f-93a3-50fcd87ab2bf">|<img width="341" alt="Screenshot 2023-08-24 at 1 15 35 PM" src="https://github.com/flutter/flutter/assets/948037/5f59481c-aa5d-4850-aa4b-daa678e54044">

ca33836b

Bump github/codeql-action from 2.21.4 to 2.21.5 (#133504) · c0466274

dependabot[bot] authored Aug 28, 2023

Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.21.4 to 2.21.5.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/github/codeql-action/blob/main/CHANGELOG.md">github/codeql-action's changelog</a>.</em></p>
<blockquote>
<h1>CodeQL Action Changelog</h1>
<p>See the <a href="https://github.com/github/codeql-action/releases">releases page</a> for the relevant changes to the CodeQL CLI and language packs.</p>
<h2>[UNRELEASED]</h2>
<p>No user facing changes.</p>
<h2>2.21.5 - 28 Aug 2023</h2>
<ul>
<li>Update default CodeQL bundle version to 2.14.3. <a href="https://redirect.github.com/github/codeql-action/pull/1845">#1845</a></li>
<li>Fixed a bug in CodeQL Action 2.21.3 onwards that affected beta support for <a href="https://projectlombok.org/">Project Lombok</a> when analyzing Java. The environment variable <code>CODEQL_EXTRACTOR_JAVA_RUN_ANNOTATION_PROCESSORS</code> will now be respected if it was manually configured in the workflow. <a href="https://redirect.github.com/github/codeql-action/pull/1844">#1844</a></li>
<li>Enable support for Kotlin 1.9.20 when running with CodeQL CLI v2.13.4 through v2.14.3. <a href="https://redirect.github.com/github/codeql-action/pull/1853">#1853</a></li>
</ul>
<h2>2.21.4 - 14 Aug 2023</h2>
<ul>
<li>Update default CodeQL bundle version to 2.14.2. <a href="https://redirect.github.com/github/codeql-action/pull/1831">#1831</a></li>
<li>Log a warning if the amount of available disk space runs low during a code scanning run. <a href="https://redirect.github.com/github/codeql-action/pull/1825">#1825</a></li>
<li>When downloading CodeQL bundle version 2.13.4 and later, cache these bundles in the Actions tool cache using a simpler version number. <a href="https://redirect.github.com/github/codeql-action/pull/1832">#1832</a></li>
<li>Fix an issue that first appeared in CodeQL Action v2.21.2 that prevented CodeQL invocations from being logged. <a href="https://redirect.github.com/github/codeql-action/pull/1833">#1833</a></li>
<li>We are rolling out a feature in August 2023 that will improve the quality of file coverage information. <a href="https://redirect.github.com/github/codeql-action/pull/1835">#1835</a></li>
</ul>
<h2>2.21.3 - 08 Aug 2023</h2>
<ul>
<li>We are rolling out a feature in August 2023 that will improve multi-threaded performance on larger runners. <a href="https://redirect.github.com/github/codeql-action/pull/1817">#1817</a></li>
<li>We are rolling out a feature in August 2023 that adds beta support for <a href="https://projectlombok.org/">Project Lombok</a> when analyzing Java. <a href="https://redirect.github.com/github/codeql-action/pull/1809">#1809</a></li>
<li>Reduce disk space usage when downloading the CodeQL bundle. <a href="https://redirect.github.com/github/codeql-action/pull/1820">#1820</a></li>
</ul>
<h2>2.21.2 - 28 Jul 2023</h2>
<ul>
<li>Update default CodeQL bundle version to 2.14.1. <a href="https://redirect.github.com/github/codeql-action/pull/1797">#1797</a></li>
<li>Avoid duplicating the analysis summary within the logs. <a href="https://redirect.github.com/github/codeql-action/pull/1811">#1811</a></li>
</ul>
<h2>2.21.1 - 26 Jul 2023</h2>
<ul>
<li>Improve the handling of fatal errors from the CodeQL CLI. <a href="https://redirect.github.com/github/codeql-action/pull/1795">#1795</a></li>
<li>Add the <code>sarif-output</code> output to the analyze action that contains the path to the directory of the generated SARIF. <a href="https://redirect.github.com/github/codeql-action/pull/1799">#1799</a></li>
</ul>
<h2>2.21.0 - 19 Jul 2023</h2>
<ul>
<li>CodeQL Action now requires CodeQL CLI 2.9.4 or later. For more information, see the corresponding changelog entry for CodeQL Action version 2.20.4. <a href="https://redirect.github.com/github/codeql-action/pull/1724">#1724</a></li>
</ul>
<h2>2.20.4 - 14 Jul 2023</h2>
<ul>
<li>This is the last release of the Action that supports CodeQL CLI versions 2.8.5 to 2.9.3. These versions of the CodeQL CLI were deprecated on June 20, 2023 alongside GitHub Enterprise Server 3.5 and will not be supported by the next release of the CodeQL Action (2.21.0).
<ul>
<li>If you are using one of these versions, please update to CodeQL CLI version 2.9.4 or later. For instance, if you have specified a custom version of the CLI using the 'tools' input to the 'init' Action, you can remove this input to use the default version.</li>
<li>Alternatively, if you want to continue using a version of the CodeQL CLI between 2.8.5 and 2.9.3, you can replace 'github/codeql-action/<em><a href="https://github.com/v2"><code>@âv2</code></a>' by 'github/codeql-action/</em><a href="https://github.com/v2"><code>@âv2</code></a>.20.4' in your code scanning workflow to ensure you continue using this version of the CodeQL Action.</li>
</ul>
</li>
<li>We are rolling out a feature in July 2023 that will slightly reduce the default amount of RAM used for query execution, in proportion to the runner's total memory. This will help to avoid out-of-memory failures on larger runners. <a href="https://redirect.github.com/github/codeql-action/pull/1760">#1760</a></li>
<li>Update default CodeQL bundle version to 2.14.0. <a href="https://redirect.github.com/github/codeql-action/pull/1762">#1762</a></li>
</ul>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/github/codeql-action/commit/00e563ead9f72a8461b24876bee2d0c2e8bd2ee8"><code>00e563e</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/1858">#1858</a> from github/update-v2.21.5-100912429</li>
<li><a href="https://github.com/github/codeql-action/commit/7323c2ac6bb5b909731a79a05be177865803cb35"><code>7323c2a</code></a> Update changelog for v2.21.5</li>
<li><a href="https://github.com/github/codeql-action/commit/100912429fab4cb230e66ffb11e738ac5194e73a"><code>1009124</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/1845">#1845</a> from github/update-bundle/codeql-bundle-v2.14.3</li>
<li><a href="https://github.com/github/codeql-action/commit/a2d14d32b8fe679ae2cd9a1a42b7a1b494ca080e"><code>a2d14d3</code></a> Merge branch 'main' into update-bundle/codeql-bundle-v2.14.3</li>
<li><a href="https://github.com/github/codeql-action/commit/ff9cb435df425a3cb2cd53b09e3947f600b11ef5"><code>ff9cb43</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/1853">#1853</a> from github/igfoo/kot1.9.10</li>
<li><a href="https://github.com/github/codeql-action/commit/2f913c12497b474080784ca08ad349d693b3c172"><code>2f913c1</code></a> npm run build</li>
<li><a href="https://github.com/github/codeql-action/commit/7dab60079ba615275bc07067ee108dfa7ebec60a"><code>7dab600</code></a> Put upper limit on the CodeQL versions for which we override the Kotlin limit</li>
<li><a href="https://github.com/github/codeql-action/commit/862b2cf102c7d450547d5bfb21e408e6cd6813aa"><code>862b2cf</code></a> Add a changelog entry for the Kotlin 1.9.10 support</li>
<li><a href="https://github.com/github/codeql-action/commit/070dd05edd619bee2751a0cc76633f1e8b6ebda9"><code>070dd05</code></a> npm run build</li>
<li><a href="https://github.com/github/codeql-action/commit/ff95d147d6ce5678eee4d906f79bff30f5e182a1"><code>ff95d14</code></a> Kotlin: Fix lint</li>
<li>Additional commits viewable in <a href="https://github.com/github/codeql-action/compare/a09933a12a80f87b87005513f0abb1494c27a716...00e563ead9f72a8461b24876bee2d0c2e8bd2ee8">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=github/codeql-action&package-manager=github_actions&previous-version=2.21.4&new-version=2.21.5)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

c0466274

Fix `DatePickerDialog` & `DateRangePickerDialog` overflow when resized from... · a0943e65

Taha Tesser authored Aug 28, 2023

Fix  `DatePickerDialog` & `DateRangePickerDialog` overflow when resized from landscape to portrait (#133327)

fixes [resize window with a `showDateRangePicker` will make RenderFlex overflowed error](https://github.com/flutter/flutter/issues/131989)

### Description
- This fixes  `DatePickerDialog` & `DateRangePickerDialog` overflow error when resized from landscape to portrait.
- Added tests that check these two widgets from landscape to portrait for no overflow errors.

<details
<summary>expand to view the code sample</summary> 

```dart
import 'package:flutter/material.dart';

void main() {
  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return const MaterialApp(
      debugShowCheckedModeBanner: false,
      home: Example(),
    );
  }
}

class Example extends StatefulWidget {
  const Example({super.key});

  @override
  State<Example> createState() => _ExampleState();
}

class _ExampleState extends State<Example> {
  bool _portait = false;

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: const Text('DatePicker & DateRangePicker'),
      ),
      body: MediaQuery(
        data: MediaQuery.of(context).copyWith(
          size: _portait ? const Size(400, 800) : const Size(800, 400),
        ),
        child: Column(
          mainAxisAlignment: MainAxisAlignment.spaceEvenly,
          children: [
            DatePickerDialog(
              initialDate: DateTime.now(),
              firstDate: DateTime(2020),
              lastDate: DateTime(2030),
              initialEntryMode: DatePickerEntryMode.inputOnly,
            ),
            DateRangePickerDialog(
              currentDate: DateTime.now(),
              firstDate: DateTime(2020),
              lastDate: DateTime(2030),
              initialEntryMode: DatePickerEntryMode.inputOnly,
            ),
          ],
        ),
      ),
      floatingActionButton: FloatingActionButton(
        onPressed: () {
          setState(() {
            _portait = !_portait;
          });
        },
        child: const Icon(Icons.refresh),
      ),
    );
  }
}

```

</details>

### Before

https://github.com/flutter/flutter/assets/48603081/81387cbb-cdcf-42bd-b4f8-b7a08317c955

### After

https://github.com/flutter/flutter/assets/48603081/36d28ea9-cfed-48ad-90f5-0459755e08c0

a0943e65

Empty commit to re-trigger tests (#133495) · e7fc5a6e
Victoria Ashworth authored Aug 28, 2023
```
An empty commit to re-trigger tests for https://github.com/flutter/tests/pull/291
```
e7fc5a6e

Revert "PlatformRouteInformationProvider should dispatch creation in constructor." (#133479) · f1f46ef2

Victoria Ashworth authored Aug 28, 2023

Reverts flutter/flutter#133353

Tree is failing on Mac and Linux customer_testing on this PR.
https://ci.chromium.org/ui/p/flutter/builders/prod/Mac%20customer_testing/14646/overview
https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20customer_testing/14974/overview

f1f46ef2

Revert "FocusNode and FocusManager should dispatch creation in constructor." (#133474) · 76d6d36b

Victoria Ashworth authored Aug 28, 2023

Reverts flutter/flutter#133352

76d6d36b

Revert "ShortcutManager should dispatch creation in constructor." (#133472) · ec387a46

Victoria Ashworth authored Aug 28, 2023

Reverts flutter/flutter#133356

Tree is failing on customer_testing on this PR.
https://ci.chromium.org/ui/p/flutter/builders/prod/Mac%20customer_testing/14646/overview

ec387a46

Roll Flutter Engine from 9ab2603db24f to 91522a188bda (2 revisions) (#133462) · 05259ca9

engine-flutter-autoroll authored Aug 28, 2023

https://github.com/flutter/engine/compare/9ab2603db24f...91522a188bda

2023-08-28 skia-flutter-autoroll@skia.org Roll Skia from fe4f018ef935 to df783b542165 (1 revision) (flutter/engine#45171)
2023-08-28 skia-flutter-autoroll@skia.org Roll Skia from 0d39172f35d2 to fe4f018ef935 (1 revision) (flutter/engine#45169)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

05259ca9